kcov: improve CONFIG_ARCH_HAS_KCOV help text
PATCH 1/1 kcov: improve CONFIG_ARCH_HAS_KCOV help text
The help text for CONFIG_ARCH_HAS_KCOV is stale, and describes the feature as being enabled only for x86_64, when it is now enabled for several architectures, including arm, arm64, powerpc, and s390.
Let's remove that stale help text, and update it along the lines of hat for ARCH_HAS_FORTIFY_SOURCE, better describing when an architecture should select CONFIG_ARCH_HAS_KCOV.
--- lib/Kconfig.debug | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/Kconfig.debug +3 -3
@@ -753,9 +753,9 @@ endmenu # "Memory Debugging" config ARCH_HAS_KCOV bool help - KCOV does not have any arch-specific code, but currently it is enabled - only for x86_64. KCOV requires testing on other archs, and most likely - disabling of instrumentation for some early boot code. + An architecture should select this when it can successfully + build and run with CONFIG_KCOV. This typically requires + disabling instrumentation for some early boot code. config CC_HAS_SANCOV_TRACE_PC def_bool $(cc-option,-fsanitize-coverage=trace-pc)
Signature · 1 line
2.11.0
Quoted 35 lines · Mark Rutland
The help text for
CONFIG_ARCH_HAS_KCOVis stale, and describes the feature as being enabled only forx86_64, when it is now enabled for several architectures, including arm, arm64, powerpc, and s390.Let's remove that stale help text, and update it along the lines of hat for
ARCH_HAS_FORTIFY_SOURCE, better describing when an architecture should selectCONFIG_ARCH_HAS_KCOV.Signed-off-by Mark Rutland <[email protected]>Cc Andrew Morton <[email protected]>Cc Dmitry Vyukov <[email protected]>Cc Kees Cook <[email protected]>--- lib/Kconfig.debug | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)lib/Kconfig.debug +3
-4@@ -753,9 +753,9 @@ endmenu # "Memory Debugging" config ARCH_HAS_KCOV bool help - KCOV does not have any arch-specific code, but currently it is enabled - only for x86_64. KCOV requires testing on other archs, and most likely - disabling of instrumentation for some early boot code. + An architecture should select this when it can successfully + build and run with CONFIG_KCOV. This typically requires + disabling instrumentation for some early boot code. config CC_HAS_SANCOV_TRACE_PC def_bool $(cc-option,-fsanitize-coverage=trace-pc) --
Quoted 1 line
2.11.0
Quoted 33 lines · Dmitry Vyukov
Quoted 32 lines · Mark Rutland
The help text for
CONFIG_ARCH_HAS_KCOVis stale, and describes the feature as being enabled only forx86_64, when it is now enabled for several architectures, including arm, arm64, powerpc, and s390.Let's remove that stale help text, and update it along the lines of hat for
ARCH_HAS_FORTIFY_SOURCE, better describing when an architecture should selectCONFIG_ARCH_HAS_KCOV.Signed-off-by Mark Rutland <[email protected]>Cc Andrew Morton <[email protected]>Cc Dmitry Vyukov <[email protected]>Cc Kees Cook <[email protected]>--- lib/Kconfig.debug | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)lib/Kconfig.debug +3
-3@@ -753,9 +753,9 @@ endmenu # "Memory Debugging" config ARCH_HAS_KCOV bool help - KCOV does not have any arch-specific code, but currently it is enabled - only for x86_64. KCOV requires testing on other archs, and most likely - disabling of instrumentation for some early boot code. + An architecture should select this when it can successfully + build and run with CONFIG_KCOV. This typically requires + disabling instrumentation for some early boot code.
Quoted 7 lines
Quoted 4 lines
lib/Kconfig.debug +0
-1config CC_HAS_SANCOV_TRACE_PC def_bool $(cc-option,-fsanitize-coverage=trace-pc) --2.11.0
Acked-by Dmitry Vyukov <[email protected]>
Thanks!
Andrew, are you happy to pick this up?
Mark.