Skip to contentSkip to conversation

ARM: dts: aspeed: zaius: add Infineon and Intersil regulators

PATCH In review Patrick Venture 2 participants 6 messages Apr 12, 2019 – Apr 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: zaius: add Infineon and Intersil regulators

From: Maxim Sloyko <[email protected]>

Add the nodes for the ir38064 and isl68137 devices on the Zaius board.

---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 65 ++++++++++++++++++++--
 1 file changed, 60 insertions(+), 5 deletions(-)
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +60 -5
index 0c0ea41cbe27..53751adebf17 100644
@@ -301,6 +301,32 @@
 				reg = <0x54>;
 			};
 		};
+
+	};
+
+	vrm@64 {
+		compatible = "intersil,isl68137";
+		reg = <0x64>;
+	};
+
+	vrm@40 {
+		compatible = "intersil,isl68137";
+		reg = <0x40>;
+	};
+
+	vrm@60 {
+		compatible = "intersil,isl68137";
+		reg = <0x60>;
+	};
+
+	vrm@43 {
+		compatible = "infineon,ir38064";
+		reg = <0x43>;
+	};
+
+	vrm@41 {
+		compatible = "intersil,isl68137";
+		reg = <0x41>;
 	};
 
 	/* Master selector PCA9541A @70h (other master: CPU0)
@@ -316,18 +342,47 @@
 	/* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
 	/* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
 	/* CPU0 VR ISL68137 0.8V PMBUS @60h */
-	/* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @41h */
+	/* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @43h */
 	/* CPU0 VR ISL68137 1.2V CH47 PMBUS @41h */
+	/* Master selector PCA9541A @70h (other master: CPU0)
+	 *   LM5066I PMBUS @10h
+	 */
+	/* 12V SMPS Q54SH12050NNDH @61h */
 };
 
 &i2c8 {
 	status = "okay";
 
-	/* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @65h */
-	/* CPU1 VR ISL68137 1.2V CH03 PMBUS @44h */
-	/* CPU1 VR ISL68137 0.8V PMBUS @61h */
+	vrm@64 {
+		compatible = "intersil,isl68137";
+		reg = <0x64>;
+	};
+
+	vrm@40 {
+		compatible = "intersil,isl68137";
+		reg = <0x40>;
+	};
+
+	vrm@41 {
+		compatible = "intersil,isl68137";
+		reg = <0x41>;
+	};
+
+	vrm@42 {
+		compatible = "infineon,ir38064";
+		reg = <0x42>;
+	};
+
+	vrm@60 {
+		compatible = "intersil,isl68137";
+		reg = <0x60>;
+	};
+
+	/* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @64h */
+	/* CPU1 VR ISL68137 1.2V CH03 PMBUS @40h */
+	/* CPU1 VR ISL68137 1.2V CH47 PMBUS @41h */
 	/* CPU1 VR 1.0V IR38064 I2C @12h, PMBUS @42h */
-	/* CPU0 VR ISL68137 1.2V CH47 PMBUS @45h */
+	/* CPU1 VR ISL68137 0.8V PMBUS @60h */
 };
 
 
Signature · 1 line
2.21.0.392.gf8f6787159e-goog
#1 lore raw
Quoted 103 lines · Patrick Venture

From: Maxim Sloyko <[email protected]>

Add the nodes for the ir38064 and isl68137 devices on the Zaius board.

---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 65 ++++++++++++++++++++--
 1 file changed, 60 insertions(+), 5 deletions(-)
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +60 -6
index 0c0ea41cbe27..53751adebf17 100644
@@ -301,6 +301,32 @@
                                reg = <0x54>;
                        };
                };
+
+       };
+
+       vrm@64 {
+               compatible = "intersil,isl68137";
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       vrm@43 {
+               compatible = "infineon,ir38064";
+               reg = <0x43>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
        };
 
        /* Master selector PCA9541A @70h (other master: CPU0)
@@ -316,18 +342,47 @@
        /* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
        /* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
        /* CPU0 VR ISL68137 0.8V PMBUS @60h */
-       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @41h */
+       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @43h */
        /* CPU0 VR ISL68137 1.2V CH47 PMBUS @41h */
+       /* Master selector PCA9541A @70h (other master: CPU0)
+        *   LM5066I PMBUS @10h
+        */
+       /* 12V SMPS Q54SH12050NNDH @61h */
 };
 
 &i2c8 {
        status = "okay";
 
-       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @65h */
-       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @44h */
-       /* CPU1 VR ISL68137 0.8V PMBUS @61h */
+       vrm@64 {
+               compatible = "intersil,isl68137";
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
+       };
+
+       vrm@42 {
+               compatible = "infineon,ir38064";
+               reg = <0x42>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @64h */
+       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @40h */
+       /* CPU1 VR ISL68137 1.2V CH47 PMBUS @41h */
        /* CPU1 VR 1.0V IR38064 I2C @12h, PMBUS @42h */
-       /* CPU0 VR ISL68137 1.2V CH47 PMBUS @45h */
+       /* CPU1 VR ISL68137 0.8V PMBUS @60h */
 };
 
 
--
Quoted 2 lines

2.21.0.392.gf8f6787159e-goog

The bindings for the two drivers are missing still. This will be fixed when the patches are merged into an upstream branch.

#2 lore raw
In reply to Patrick Venture
Quoted 17 lines · Patrick Venture

From: Maxim Sloyko <[email protected]>

Add the nodes for the ir38064 and isl68137 devices on the Zaius board.

---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 65 ++++++++++++++++++++--
 1 file changed, 60 insertions(+), 5 deletions(-)
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +0 -0
index 0c0ea41cbe27..53751adebf17 100644

arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts line 308

Quoted 8 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +5 -0
@@ -301,6 +301,32 @@
                                reg = <0x54>;
                        };
                };
+
+       };
+
+       vrm@64 {
+               compatible = "intersil,isl68137";

s/intersil/isil/g

Quoted 80 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +55 -6
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       vrm@43 {
+               compatible = "infineon,ir38064";
+               reg = <0x43>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
        };
 
        /* Master selector PCA9541A @70h (other master: CPU0)
@@ -316,18 +342,47 @@
        /* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
        /* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
        /* CPU0 VR ISL68137 0.8V PMBUS @60h */
-       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @41h */
+       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @43h */
        /* CPU0 VR ISL68137 1.2V CH47 PMBUS @41h */
+       /* Master selector PCA9541A @70h (other master: CPU0)
+        *   LM5066I PMBUS @10h
+        */
+       /* 12V SMPS Q54SH12050NNDH @61h */
 };
 
 &i2c8 {
        status = "okay";
 
-       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @65h */
-       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @44h */
-       /* CPU1 VR ISL68137 0.8V PMBUS @61h */
+       vrm@64 {
+               compatible = "intersil,isl68137";
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
+       };
+
+       vrm@42 {
+               compatible = "infineon,ir38064";
+               reg = <0x42>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @64h */
+       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @40h */
+       /* CPU1 VR ISL68137 1.2V CH47 PMBUS @41h */
        /* CPU1 VR 1.0V IR38064 I2C @12h, PMBUS @42h */
-       /* CPU0 VR ISL68137 1.2V CH47 PMBUS @45h */
+       /* CPU1 VR ISL68137 0.8V PMBUS @60h */
 };
 
 
--

2.21.0.392.gf8f6787159e-goog

#3 lore raw
Quoted 13 lines · Patrick Venture
Quoted 12 lines · Patrick Venture

From: Maxim Sloyko <[email protected]>

Add the nodes for the ir38064 and isl68137 devices on the Zaius board.

---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 65 ++++++++++++++++++++--
 1 file changed, 60 insertions(+), 5 deletions(-)
Quoted 14 lines

arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts line 308

Quoted 13 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +5 -0
index 0c0ea41cbe27..53751adebf17 100644
@@ -301,6 +301,32 @@
                                reg = <0x54>;
                        };
                };
+
+       };
+
+       vrm@64 {
+               compatible = "intersil,isl68137";

s/intersil/isil/g

Hrm, I didn't see this follow up and applied the patch as is.

Can you send a fix-up if necessary?

Andrew

Quoted 82 lines
Quoted 81 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +55 -6
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       vrm@43 {
+               compatible = "infineon,ir38064";
+               reg = <0x43>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
        };
 
        /* Master selector PCA9541A @70h (other master: CPU0)
@@ -316,18 +342,47 @@
        /* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
        /* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
        /* CPU0 VR ISL68137 0.8V PMBUS @60h */
-       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @41h */
+       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @43h */
        /* CPU0 VR ISL68137 1.2V CH47 PMBUS @41h */
+       /* Master selector PCA9541A @70h (other master: CPU0)
+        *   LM5066I PMBUS @10h
+        */
+       /* 12V SMPS Q54SH12050NNDH @61h */
 };
 
 &i2c8 {
        status = "okay";
 
-       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @65h */
-       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @44h */
-       /* CPU1 VR ISL68137 0.8V PMBUS @61h */
+       vrm@64 {
+               compatible = "intersil,isl68137";
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
+       };
+
+       vrm@42 {
+               compatible = "infineon,ir38064";
+               reg = <0x42>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @64h */
+       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @40h */
+       /* CPU1 VR ISL68137 1.2V CH47 PMBUS @41h */
        /* CPU1 VR 1.0V IR38064 I2C @12h, PMBUS @42h */
-       /* CPU0 VR ISL68137 1.2V CH47 PMBUS @45h */
+       /* CPU1 VR ISL68137 0.8V PMBUS @60h */
 };
 
 
--

2.21.0.392.gf8f6787159e-goog

#4 lore raw
Quoted 32 lines · Andrew Jeffery
Quoted 13 lines · Patrick Venture
Quoted 12 lines · Patrick Venture

From: Maxim Sloyko <[email protected]>

Add the nodes for the ir38064 and isl68137 devices on the Zaius board.

---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 65 ++++++++++++++++++++--
 1 file changed, 60 insertions(+), 5 deletions(-)
Quoted 14 lines

arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts line 308

Quoted 13 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +5 -0
index 0c0ea41cbe27..53751adebf17 100644
@@ -301,6 +301,32 @@
                                reg = <0x54>;
                        };
                };
+
+       };
+
+       vrm@64 {
+               compatible = "intersil,isl68137";

s/intersil/isil/g

Quoted 3 lines

Hrm, I didn't see this follow up and applied the patch as is.

Can you send a fix-up if necessary?

Yeah, I can send a fixup. The fixed up patch was sent out for review to Joel's staging repo the other day. In this case, should I send a fixup here or just wait until this patchset is dropped when the next rebase occurs?

Quoted 85 lines

Andrew

Quoted 82 lines
Quoted 81 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +55 -6
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       vrm@43 {
+               compatible = "infineon,ir38064";
+               reg = <0x43>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
        };
 
        /* Master selector PCA9541A @70h (other master: CPU0)
@@ -316,18 +342,47 @@
        /* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
        /* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
        /* CPU0 VR ISL68137 0.8V PMBUS @60h */
-       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @41h */
+       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @43h */
        /* CPU0 VR ISL68137 1.2V CH47 PMBUS @41h */
+       /* Master selector PCA9541A @70h (other master: CPU0)
+        *   LM5066I PMBUS @10h
+        */
+       /* 12V SMPS Q54SH12050NNDH @61h */
 };
 
 &i2c8 {
        status = "okay";
 
-       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @65h */
-       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @44h */
-       /* CPU1 VR ISL68137 0.8V PMBUS @61h */
+       vrm@64 {
+               compatible = "intersil,isl68137";
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
+       };
+
+       vrm@42 {
+               compatible = "infineon,ir38064";
+               reg = <0x42>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @64h */
+       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @40h */
+       /* CPU1 VR ISL68137 1.2V CH47 PMBUS @41h */
        /* CPU1 VR 1.0V IR38064 I2C @12h, PMBUS @42h */
-       /* CPU0 VR ISL68137 1.2V CH47 PMBUS @45h */
+       /* CPU1 VR ISL68137 0.8V PMBUS @60h */
 };
 
 
--

2.21.0.392.gf8f6787159e-goog

#5 lore raw
Quoted 34 lines · Patrick Venture
Quoted 32 lines · Andrew Jeffery
Quoted 27 lines · Patrick Venture
Quoted 17 lines · Patrick Venture

From: Maxim Sloyko <[email protected]>

Add the nodes for the ir38064 and isl68137 devices on the Zaius board.

---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 65 ++++++++++++++++++++--
 1 file changed, 60 insertions(+), 5 deletions(-)
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +0 -0
index 0c0ea41cbe27..53751adebf17 100644

arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts line 308

Quoted 8 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +5 -0
@@ -301,6 +301,32 @@
                                reg = <0x54>;
                        };
                };
+
+       };
+
+       vrm@64 {
+               compatible = "intersil,isl68137";

s/intersil/isil/g

Quoted 8 lines
Quoted 3 lines

Hrm, I didn't see this follow up and applied the patch as is.

Can you send a fix-up if necessary?

Yeah, I can send a fixup. The fixed up patch was sent out for review to Joel's staging repo the other day. In this case, should I send a fixup here or just wait until this patchset is dropped when the next rebase occurs?

Just decided to send a fixup. I'll send a fixup for the isl driver as well.

Quoted 86 lines
Quoted 86 lines

Andrew

Quoted 82 lines
Quoted 81 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +55 -6
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       vrm@43 {
+               compatible = "infineon,ir38064";
+               reg = <0x43>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
        };
 
        /* Master selector PCA9541A @70h (other master: CPU0)
@@ -316,18 +342,47 @@
        /* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
        /* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
        /* CPU0 VR ISL68137 0.8V PMBUS @60h */
-       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @41h */
+       /* CPU0 VR 1.0V IR38064 I2C @11h, PMBUS @43h */
        /* CPU0 VR ISL68137 1.2V CH47 PMBUS @41h */
+       /* Master selector PCA9541A @70h (other master: CPU0)
+        *   LM5066I PMBUS @10h
+        */
+       /* 12V SMPS Q54SH12050NNDH @61h */
 };
 
 &i2c8 {
        status = "okay";
 
-       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @65h */
-       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @44h */
-       /* CPU1 VR ISL68137 0.8V PMBUS @61h */
+       vrm@64 {
+               compatible = "intersil,isl68137";
+               reg = <0x64>;
+       };
+
+       vrm@40 {
+               compatible = "intersil,isl68137";
+               reg = <0x40>;
+       };
+
+       vrm@41 {
+               compatible = "intersil,isl68137";
+               reg = <0x41>;
+       };
+
+       vrm@42 {
+               compatible = "infineon,ir38064";
+               reg = <0x42>;
+       };
+
+       vrm@60 {
+               compatible = "intersil,isl68137";
+               reg = <0x60>;
+       };
+
+       /* CPU1 VR ISL68137 0.7V, 0.96V PMBUS @64h */
+       /* CPU1 VR ISL68137 1.2V CH03 PMBUS @40h */
+       /* CPU1 VR ISL68137 1.2V CH47 PMBUS @41h */
        /* CPU1 VR 1.0V IR38064 I2C @12h, PMBUS @42h */
-       /* CPU0 VR ISL68137 1.2V CH47 PMBUS @45h */
+       /* CPU1 VR ISL68137 0.8V PMBUS @60h */
 };
 
 
--

2.21.0.392.gf8f6787159e-goog