Skip to contentSkip to conversation

Add support for the MT41K128M16JT125K memory modules

PATCH New Martyn Welch 3 participants 7 messages Feb 25, 2019 – Apr 12, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/3 Add support for the MT41K128M16JT125K memory modules

From: Sjoerd Simons <[email protected]>

Add configuration for the MT41K128M16JT125K memory modules as used on the Bosch Guardian device.

Based on a patch by:
Govindaraji Sivanantham <[email protected]>

[checkpatch.pl cleanup by Martyn Welch]

---

Changes in v3: None
Changes in v2: None

 arch/arm/include/asm/arch-am33xx/ddr_defs.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm/include/asm/arch-am33xx/ddr_defs.h +16 -0
index d8ddecc0bd..15a5b641ff 100644
@@ -84,6 +84,22 @@
 #define MT41K128MJT187E_PHY_FIFO_WE		0x100
 #define MT41K128MJT187E_IOCTRL_VALUE		0x18B
 
+/* Micron MT41K128M16JT-125 IT:K (256 MB) at 400MHz */
+#define MT41K128M16JT125K_EMIF_READ_LATENCY     0x07
+#define MT41K128M16JT125K_EMIF_TIM1             0x0AAAD4DB
+#define MT41K128M16JT125K_EMIF_TIM2             0x2A437FDA
+#define MT41K128M16JT125K_EMIF_TIM3             0x501F83FF
+#define MT41K128M16JT125K_EMIF_SDCFG            0x61A052B2
+#define MT41K128M16JT125K_EMIF_SDREF            0x00000C30
+#define MT41K128M16JT125K_ZQ_CFG                0x50074BE4
+#define MT41K128M16JT125K_RATIO                 0x80
+#define MT41K128M16JT125K_INVERT_CLKOUT         0x0
+#define MT41K128M16JT125K_RD_DQS                0x38
+#define MT41K128M16JT125K_WR_DQS                0x46
+#define MT41K128M16JT125K_PHY_WR_DATA           0x7D
+#define MT41K128M16JT125K_PHY_FIFO_WE           0x9B
+#define MT41K128M16JT125K_IOCTRL_VALUE          0x18B
+
 /* Micron MT41J64M16JT-125 */
 #define MT41J64MJT125_EMIF_SDCFG		0x61C04A32
 
Signature · 1 line
2.20.1
#1 lore raw

PATCH v3 2/3 env: Don't check CONFIG_ENV_OFFSET_REDUND for SPL build

When booting using an SPL on am335x, if we want to support booting with the boot ROM loader via USB (which uses RNDIS, making bootp and tftp calls) we need to enable gadget eth in the SPL to load the main U-Boot image. To enable CONFIG_SPL_ETH_SUPPORT, we must enable CONFIG_SPL_ENV_SUPPORT as the environment is used by the eth support, but we don't actually need to have environment variables saved in the SPL environment. We do however have environment variables saved in the main U-Boot image and enable CONFIG_ENV_OFFSET_REDUND (we are storing in raw NAND). In such instances, even with the build config enabling both CONFIG_CMD_SAVEENV and CONFIG_CMD_NAND, these options aren't set when building the SPL, but CONFIG_ENV_OFFSET_REDUND still is.

Don't check this configuration option for SPL builds to enable the above configuration.

---

Changes in v3: None
Changes in v2:
- Reword commit message to better describe the issue

 env/nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
env/nand.c +1 -1
index 29eda66fad..d0b95f483d 100644
@@ -26,7 +26,7 @@
 #if defined(CONFIG_CMD_SAVEENV) && defined(CONFIG_CMD_NAND) && \
 		!defined(CONFIG_SPL_BUILD)
 #define CMD_SAVEENV
-#elif defined(CONFIG_ENV_OFFSET_REDUND)
+#elif defined(CONFIG_ENV_OFFSET_REDUND) && !defined(CONFIG_SPL_BUILD)
 #error CONFIG_ENV_OFFSET_REDUND must have CONFIG_CMD_SAVEENV & CONFIG_CMD_NAND
 #endif
 
Signature · 1 line
2.20.1
#2 lore raw

PATCH v3 2/3 env: Don't check CONFIG_ENV_OFFSET_REDUND for SPL build

Quoted 12 lines · Martyn Welch

When booting using an SPL on am335x, if we want to support booting with the boot ROM loader via USB (which uses RNDIS, making bootp and tftp calls) we need to enable gadget eth in the SPL to load the main U-Boot image. To enable CONFIG_SPL_ETH_SUPPORT, we must enable CONFIG_SPL_ENV_SUPPORT as the environment is used by the eth support, but we don't actually need to have environment variables saved in the SPL environment. We do however have environment variables saved in the main U-Boot image and enable CONFIG_ENV_OFFSET_REDUND (we are storing in raw NAND). In such instances, even with the build config enabling both CONFIG_CMD_SAVEENV and CONFIG_CMD_NAND, these options aren't set when building the SPL, but CONFIG_ENV_OFFSET_REDUND still is.

Quoted 5 lines

Don't check this configuration option for SPL builds to enable the above configuration.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190412/194e6d9a/attachment.sig>
#3 lore raw

PATCH v3 3/3 am335x, guardian: Add support for the bosch guardian board

In reply to Martyn Welch

From: Sjoerd Simons <[email protected]>

Add support for the Bosch Guardian board.

CPU  : AM335X-GP rev 2.1
Model: Bosch AM335x Guardian
I2C:   ready
DRAM:  256 MiB
NAND:  512 MiB
MMC:   OMAP SD/MMC: 0

---

Changes in v3:
- Removed unneeded #address-cells and #size-cells properties from dtb
- Correctly order include files

Changes in v2:
- Correct guard #ifdef naming in board config header
- Remove missed cruft from board files

 arch/arm/Kconfig                         |   1 +
 arch/arm/dts/am335x-guardian-u-boot.dtsi |  66 +++
 arch/arm/dts/am335x-guardian.dts         | 509 +++++++++++++++++++++++
 arch/arm/mach-omap2/am33xx/Kconfig       |   7 +
 board/bosch/guardian/Kconfig             |  15 +
 board/bosch/guardian/MAINTAINERS         |   6 +
 board/bosch/guardian/Makefile            |  12 +
 board/bosch/guardian/board.c             | 186 +++++++++
 board/bosch/guardian/board.h             |  17 +
 board/bosch/guardian/mux.c               |  99 +++++
 configs/am335x_guardian_defconfig        |  90 ++++
 include/configs/am335x_guardian.h        | 111 +++++
 12 files changed, 1119 insertions(+)
 create mode 100644 arch/arm/dts/am335x-guardian-u-boot.dtsi
 create mode 100644 arch/arm/dts/am335x-guardian.dts
 create mode 100644 board/bosch/guardian/Kconfig
 create mode 100644 board/bosch/guardian/MAINTAINERS
 create mode 100644 board/bosch/guardian/Makefile
 create mode 100644 board/bosch/guardian/board.c
 create mode 100644 board/bosch/guardian/board.h
 create mode 100644 board/bosch/guardian/mux.c
 create mode 100644 configs/am335x_guardian_defconfig
 create mode 100644 include/configs/am335x_guardian.h
arch/arm/Kconfig +1 -0
index 455f06cfee..d2b3dce2da 100644
@@ -1524,6 +1524,7 @@ source "arch/arm/cpu/armv8/Kconfig"
 source "arch/arm/mach-imx/Kconfig"
 
 source "board/bosch/shc/Kconfig"
+source "board/bosch/guardian/Kconfig"
 source "board/CarMediaLab/flea3/Kconfig"
 source "board/Marvell/aspenite/Kconfig"
 source "board/Marvell/gplugd/Kconfig"
arch/arm/dts/am335x-guardian-u-boot.dtsi new file +66 -0

66 lines not on this page · raw message

arch/arm/dts/am335x-guardian.dts new file +509 -0

509 lines not on this page · raw message

arch/arm/mach-omap2/am33xx/Kconfig +7 -0
index 85ea8946b0..500df1aa11 100644
@@ -87,6 +87,13 @@ config TARGET_AM335X_SHC
 	imply CMD_DM
 	imply CMD_SPL
 
+config TARGET_AM335X_GUARDIAN
+	bool "Support am335x based guardian board from bosch"
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
+	select DM_USB
+
 config TARGET_AM335X_SL50
 	bool "Support am335x_sl50"
 	select BOARD_LATE_INIT
board/bosch/guardian/Kconfig new file +15 -0
new file mode 100644
index 0000000000..1417da61f0
@@ -0,0 +1,15 @@
+if TARGET_AM335X_GUARDIAN
+
+config SYS_BOARD
+	default "guardian"
+
+config SYS_VENDOR
+	default "bosch"
+
+config SYS_SOC
+	default "am33xx"
+
+config SYS_CONFIG_NAME
+	default "am335x_guardian"
+
+endif
board/bosch/guardian/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..8d16ec0202
@@ -0,0 +1,6 @@
+Guardian BOARD
+M:	Sjoerd Simons <[email protected]>
+S:	Maintained
+F:	board/bosch/guardian/
+F:	include/configs/am335x_guardian.h
+F:	configs/am335x_guardian_defconfig
board/bosch/guardian/Makefile new file +12 -0
new file mode 100644
index 0000000000..11625c9dd6
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier:	GPL-2.0+
+#
+# Makefile
+#
+# Copyright (C) 2018 Robert Bosch Power Tools GmbH
+#
+
+ifeq ($(CONFIG_SKIP_LOWLEVEL_INIT),)
+obj-y	:= mux.o
+endif
+
+obj-y	+= board.o
board/bosch/guardian/board.c new file +186 -0

186 lines not on this page · raw message

board/bosch/guardian/board.h new file +17 -0
new file mode 100644
index 0000000000..b301caf47f
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * board.h
+ *
+ * Board header for Bosch Guardian
+ *
+ * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
+ * Copyright (C) 2018 Robert Bosch Power Tools GmbH
+ */
+
+#ifndef _BOARD_H_
+#define _BOARD_H_
+
+void enable_uart0_pin_mux(void);
+void enable_i2c0_pin_mux(void);
+void enable_board_pin_mux(void);
+#endif
board/bosch/guardian/mux.c new file +99 -0

99 lines not on this page · raw message

configs/am335x_guardian_defconfig new file +90 -0

90 lines not on this page · raw message

include/configs/am335x_guardian.h new file +111 -0

111 lines not on this page · raw message

Signature · 1 line
2.20.1
#4 lore raw

PATCH v3 3/3 am335x, guardian: Add support for the bosch guardian board

Quoted 17 lines · Martyn Welch

From: Sjoerd Simons <[email protected]>

Add support for the Bosch Guardian board.

CPU  : AM335X-GP rev 2.1
Model: Bosch AM335x Guardian
I2C:   ready
DRAM:  256 MiB
NAND:  512 MiB
MMC:   OMAP SD/MMC: 0

---

Quoted 8 lines

Changes in v3:
- Removed unneeded #address-cells and #size-cells properties from dtb
- Correctly order include files

Changes in v2:
- Correct guard #ifdef naming in board config header
- Remove missed cruft from board files

--
Felix

#5 lore raw

PATCH v3 3/3 am335x, guardian: Add support for the bosch guardian board

In reply to Martyn Welch
Quoted 11 lines · Martyn Welch

From: Sjoerd Simons <[email protected]>

Add support for the Bosch Guardian board.

CPU  : AM335X-GP rev 2.1
Model: Bosch AM335x Guardian
I2C:   ready
DRAM:  256 MiB
NAND:  512 MiB
MMC:   OMAP SD/MMC: 0
Quoted 4 lines

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190412/bb773bdb/attachment.sig>
#6 lore raw

PATCH v3 1/3 Add support for the MT41K128M16JT125K memory modules

In reply to Martyn Welch
Quoted 11 lines · Martyn Welch

From: Sjoerd Simons <[email protected]>

Add configuration for the MT41K128M16JT125K memory modules as used on the Bosch Guardian device.

Based on a patch by:
Govindaraji Sivanantham <[email protected]>

[checkpatch.pl cleanup by Martyn Welch]

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190412/d1acbb29/attachment.sig>