Skip to contentSkip to conversation

vl: Add missing descriptions to the VGA adapters list

PATCH Applied Philippe Mathieu-Daudé 4 participants 4 messages Apr 12, 2019 – Apr 16, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vl: Add missing descriptions to the VGA adapters list

Some VGA adapters do not contain an helpful description, this can be confusing:

  $ qemu-system-arm -M virt -vga help
  none
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb

Add a description to the missing adapters:

  $ qemu-system-arm -M virt -vga help
  none                 no graphic card
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb                Xen paravirtualized framebuffer

---
Based-on: <[email protected]>

---
 vl.c | 2 ++
 1 file changed, 2 insertions(+)
vl.c +2 -0
index 840c45c00fa..dfeda8bd7fc 100644
@@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
 static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     [VGA_NONE] = {
         .opt_name = "none",
+        .name = "no graphic card",
     },
     [VGA_STD] = {
         .opt_name = "std",
@@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     },
     [VGA_XENFB] = {
         .opt_name = "xenfb",
+        .name = "Xen paravirtualized framebuffer",
     },
 };
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines

-----Original Message-----
From: Philippe Mathieu-Daudé [mailto:[email protected]]
Sent: 12 April 2019 17:37
To: Marc-André Lureau <[email protected]>; [email protected]
Cc: Markus Armbruster <[email protected]>; Anthony Perard <[email protected]>; Paul Durrant <[email protected]>; Stefano Stabellini <[email protected]>; Gerd Hoffmann <[email protected]>; Paolo Bonzini <[email protected]>; Philippe Mathieu-Daudé <[email protected]>
Subject: [PATCH] vl: Add missing descriptions to the VGA adapters list

Some VGA adapters do not contain an helpful description, this can be confusing:

  $ qemu-system-arm -M virt -vga help
  none
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb

Add a description to the missing adapters:

  $ qemu-system-arm -M virt -vga help
  none                 no graphic card
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb                Xen paravirtualized framebuffer
Quoted 3 lines

---
Based-on: <[email protected]>

Quoted 26 lines
---
 vl.c | 2 ++
 1 file changed, 2 insertions(+)
vl.c +2 -1
index 840c45c00fa..dfeda8bd7fc 100644
@@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
 static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     [VGA_NONE] = {
         .opt_name = "none",
+        .name = "no graphic card",
     },
     [VGA_STD] = {
         .opt_name = "std",
@@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     },
     [VGA_XENFB] = {
         .opt_name = "xenfb",
+        .name = "Xen paravirtualized framebuffer",
     },
 };
 
--

2.20.1

Reviewed-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé

Hi

Quoted 20 lines · Philippe Mathieu-Daudé

Some VGA adapters do not contain an helpful description, this can be confusing:

  $ qemu-system-arm -M virt -vga help
  none
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb

Add a description to the missing adapters:

  $ qemu-system-arm -M virt -vga help
  none                 no graphic card
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb                Xen paravirtualized framebuffer
Quoted 3 lines

---
Based-on: <[email protected]>

nice follow up, thanks

Quoted 28 lines
---
 vl.c | 2 ++
 1 file changed, 2 insertions(+)
vl.c +2 -1
index 840c45c00fa..dfeda8bd7fc 100644
@@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
 static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     [VGA_NONE] = {
         .opt_name = "none",
+        .name = "no graphic card",
     },
     [VGA_STD] = {
         .opt_name = "std",
@@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     },
     [VGA_XENFB] = {
         .opt_name = "xenfb",
+        .name = "Xen paravirtualized framebuffer",
     },
 };
 
--

2.20.1

Signature · 1 line
Marc-André Lureau
#3 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 40 lines · Philippe Mathieu-Daudé

Some VGA adapters do not contain an helpful description, this can be confusing:

  $ qemu-system-arm -M virt -vga help
  none
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb

Add a description to the missing adapters:

  $ qemu-system-arm -M virt -vga help
  none                 no graphic card
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb                Xen paravirtualized framebuffer

---
Based-on: <[email protected]>

---
 vl.c | 2 ++
 1 file changed, 2 insertions(+)
vl.c +1 -0
index 840c45c00fa..dfeda8bd7fc 100644
@@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
 static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     [VGA_NONE] = {
         .opt_name = "none",
+        .name = "no graphic card",
     },
     [VGA_STD] = {
         .opt_name = "std",

vl.c static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = { · line 2074

Quoted 7 lines
vl.c +1 -0
@@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     },
     [VGA_XENFB] = {
         .opt_name = "xenfb",
+        .name = "Xen paravirtualized framebuffer",
     },
 };
 

Queued, thanks.

Paolo