ipv6: Remove flowi6_oif compare from __ip6_route_redirect
Subsystems (3)
David Ahern
maintainerPATCH 1/1 ipv6: Remove flowi6_oif compare from __ip6_route_redirect
From: David Ahern <[email protected]>
In the review of 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect"), Martin noted that the flowi6_oif compare is moved to the new helper and should be removed from __ip6_route_redirect. Fix the oversight.
Fixes 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect")
Reported-by Martin Lau <[email protected]>
Signed-off-by David Ahern <[email protected]>
--- net/ipv6/route.c | 2 -- 1 file changed, 2 deletions(-)
net/ipv6/route.c +0 -2
@@ -2471,8 +2471,6 @@ static struct rt6_info *__ip6_route_redirect(struct net *net,continue ;if (rt->fib6_flags &RTF_REJECT )break ; -if (fl6->flowi6_oif != rt->fib6_nh.fib_nh_dev->ifindex) -continue ;if (ip6_redirect_nh_match (rt, &rt->fib6_nh, fl6, &rdfl->gateway, &ret)) goto out;
Signature · 1 line
2.11.0
From: David Ahern <[email protected]>
Date: Fri, 12 Apr 2019 10:31:14 -0700
Quoted 9 lines
From: David Ahern <[email protected]>
In the review of
0b34eb004347("ipv6: Refactor__ip6_route_redirect"), Martin noted that theflowi6_oifcompare is moved to the new helper and should be removed from__ip6_route_redirect. Fix the oversight.Fixes 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect")Reported-by Martin Lau <[email protected]>Signed-off-by David Ahern <[email protected]>
Applied.