Skip to contentSkip to conversation

efi_selftest: expect boot services data for fdt

PATCH New Heinrich Schuchardt 2 participants 2 messages Apr 12, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi_selftest: expect boot services data for fdt

In a previous patch the memory type used for the FDT has been changed to boot services data. We have to adjust the test.

Correct an incorrect comment. The tested services are boot services.

---
 lib/efi_selftest/efi_selftest_memory.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
lib/efi_selftest/efi_selftest_memory.c +3 -3
index d41227b605..5eeb42a9be 100644
@@ -4,7 +4,7 @@
  *
  * Copyright (c) 2018 Heinrich Schuchardt <[email protected]>
  *
- * This unit test checks the following runtime services:
+ * This unit test checks the following boottime services:
  * AllocatePages, FreePages, GetMemoryMap
  *
  * The memory type used for the device tree is checked.
@@ -176,9 +176,9 @@ static int execute(void)
 	/* Check memory reservation for the device tree */
 	if (fdt_addr &&
 	    find_in_memory_map(map_size, memory_map, desc_size, fdt_addr,
-			       EFI_RUNTIME_SERVICES_DATA) != EFI_ST_SUCCESS) {
+			       EFI_BOOT_SERVICES_DATA) != EFI_ST_SUCCESS) {
 		efi_st_error
-			("Device tree not marked as runtime services data\n");
+			("Device tree not marked as boot services data\n");
 		return EFI_ST_FAILURE;
 	}
 	return EFI_ST_SUCCESS;

--
2.20.1

#1 lore raw

PATCH 1/1 efi_selftest: expect boot services data for fdt

Hi Heinrich,

Quoted 36 lines

In a previous patch the memory type used for the FDT has been changed to boot services data. We have to adjust the test.

Correct an incorrect comment. The tested services are boot services.

---
 lib/efi_selftest/efi_selftest_memory.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
lib/efi_selftest/efi_selftest_memory.c +3 -4
index d41227b605..5eeb42a9be 100644
@@ -4,7 +4,7 @@
  *
  * Copyright (c) 2018 Heinrich Schuchardt <[email protected]>
  *
- * This unit test checks the following runtime services:
+ * This unit test checks the following boottime services:
  * AllocatePages, FreePages, GetMemoryMap
  *
  * The memory type used for the device tree is checked.
@@ -176,9 +176,9 @@ static int execute(void)
 	/* Check memory reservation for the device tree */
 	if (fdt_addr &&
 	    find_in_memory_map(map_size, memory_map, desc_size, fdt_addr,
-			       EFI_RUNTIME_SERVICES_DATA) != EFI_ST_SUCCESS) {
+			       EFI_BOOT_SERVICES_DATA) != EFI_ST_SUCCESS) {
 		efi_st_error
-			("Device tree not marked as runtime services data\n");
+			("Device tree not marked as boot services data\n");
 		return EFI_ST_FAILURE;
 	}
 	return EFI_ST_SUCCESS;
--
Quoted 2 lines

2.20.1

I probably should have updated that myself. Thanks for catching this