Skip to contentSkip to conversation

vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()

PATCH Applied Dexuan Cui 3 participants 3 messages Apr 12, 2019 – Apr 13, 2019

Subsystems (2)
lore
Share & tools
lore

Dexuan Cui

author maintainer
#0 lore raw

PATCH 1/1 vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()

With CONFIG_DEBUG_PREEMPT=y, the put_cpu_ptr() triggiers an underflow warning in preempt_count_sub().

Fixes 37cdd991fac8 ("vmbus: put related per-cpu variable together")
Cc Stephen Hemminger <[email protected]>
---
 drivers/hv/hv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/hv/hv.c +0 -1
index 632d25674e7f..45653029ee18 100644
@@ -408,7 +408,6 @@ int hv_synic_cleanup(unsigned int cpu)
 
 		clockevents_unbind_device(hv_cpu->clk_evt, cpu);
 		hv_ce_shutdown(hv_cpu->clk_evt);
-		put_cpu_ptr(hv_cpu);
 	}
 
 	hv_get_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64);
Signature · 1 line
2.19.1
maintainer Applied
#2 lore raw
Quoted 11 lines · Michael Kelley

From: Dexuan Cui <[email protected]> Sent: Friday, April 12, 2019 4:35 PM

Quoted 8 lines

With CONFIG_DEBUG_PREEMPT=y, the put_cpu_ptr() triggiers an underflow warning in preempt_count_sub().

Fixes 37cdd991fac8 ("vmbus: put related per-cpu variable together")
Cc Stephen Hemminger <[email protected]>

Queued for hyperv-fixes, thanks all.

--
Thanks,
Sasha