Skip to contentSkip to conversation

package/most: disable parallel build

PATCH New Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages Apr 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/most: disable parallel build

The hand-written Makefile is not parallel-build safe: the objs directory is created in a separate rule, but the rules that create files in that directory don't depend on it.

Although this relatively simple to fix, upstream clearly doesn't care about parallel builds so it is likely to break again in the future. Since most consists of just a dozen source files, just disable parallel build.

Fixes:
http://autobuild.buildroot.net/results/c7540203a8eadad3f324f0d7e7fe66a526d4a2e9

---
 package/most/most.mk | 1 +
 1 file changed, 1 insertion(+)
package/most/most.mk +1 -0
index d24e67f936..28d82cddf1 100644
@@ -11,6 +11,7 @@ MOST_LICENSE_FILES = COPYING COPYRIGHT
 MOST_DEPENDENCIES = slang
 
 MOST_CONF_OPTS = --with-slang=$(STAGING_DIR)/usr
+MOST_MAKE = $(MAKE1)
 
 define MOST_REMOVE_LOCAL_SLANG_CHECK
 	$(SED) 's/ slangversion / /g' $(@D)/src/Makefile.in
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/most: disable parallel build

Quoted 9 lines · On Sun, 14 Apr 2019 12:00:26 +0200 "Arnout Vandecappelle (Essensium/Mind)"…

The hand-written Makefile is not parallel-build safe: the objs directory is created in a separate rule, but the rules that create files in that directory don't depend on it.

Although this relatively simple to fix, upstream clearly doesn't care about parallel builds so it is likely to break again in the future. Since most consists of just a dozen source files, just disable parallel build.

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/c7540203a8eadad3f324f0d7e7fe66a526d4a2e9

---
 package/most/most.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com