soundwire: code cleanup
v3 cover soundwire: code cleanup
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
Changes since v2:
fixed inversion of devm_kcalloc parameters, detected while rebasing additional patches.
Changes since v1:
added missing newlines in new patch (suggested by Joe Perches)
Pierre-Louis Bossart (5):
soundwire: intel: fix inversion in devm_kcalloc parameters
soundwire: fix style issues
soundwire: bus: remove useless initializations
soundwire: stream: remove useless initialization of local variable
soundwire: add missing newlines in dynamic debug logs
drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 137 ++++++++------- drivers/soundwire/bus.h | 16 +- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 99 +++++------ drivers/soundwire/cadence_master.h | 22 +-- drivers/soundwire/intel.c | 103 ++++++----- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +- drivers/soundwire/mipi_disco.c | 116 +++++++------ drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 267 +++++++++++++++-------------- 12 files changed, 404 insertions(+), 388 deletions(-)
Signature · 1 line
2.17.1
PATCH v3 1/5 soundwire: intel: fix inversion in devm_kcalloc parameters
the number of elements and size are inverted, fix.
This probably only worked because the number of properties is hard-coded to 1.
--- drivers/soundwire/intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soundwire/intel.c +2 -2
@@ -796,8 +796,8 @@ static int intel_prop_read(struct sdw_bus *bus)/* BIOS is not giving some values correctly. So, lets override them */ bus->prop.num_freq =1 ; - bus->prop.freq =devm_kcalloc (bus->dev,sizeof (*bus->prop.freq), - bus->prop.num_freq,GFP_KERNEL ); + bus->prop.freq =devm_kcalloc (bus->dev, bus->prop.num_freq, +sizeof (*bus->prop.freq),GFP_KERNEL );if (!bus->prop.freq)return -ENOMEM ;
Signature · 1 line
2.17.1
Re: [PATCH v3 1/5] soundwire: intel: fix inversion in devm_kcalloc parameters
Quoted 5 lines · Pierre-Louis Bossart
the number of elements and size are inverted, fix.
This probably only worked because the number of properties is hard-coded to 1.
Well, both are mathematically equivalent :)
Takashi
Quoted 25 lines
Fixes 71bb8a1b059e ('soundwire: intel: Add Intel Master driver')Signed-off-by Pierre-Louis Bossart <[email protected]>--- drivers/soundwire/intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/soundwire/intel.c +2
-2@@ -796,8 +796,8 @@ static int intel_prop_read(struct sdw_bus *bus)/* BIOS is not giving some values correctly. So, lets override them */ bus->prop.num_freq =1 ; - bus->prop.freq =devm_kcalloc (bus->dev,sizeof (*bus->prop.freq), - bus->prop.num_freq,GFP_KERNEL ); + bus->prop.freq =devm_kcalloc (bus->dev, bus->prop.num_freq, +sizeof (*bus->prop.freq),GFP_KERNEL );if (!bus->prop.freq)return -ENOMEM ;Signature · 1 line
2.17.1
PATCH v3 2/5 soundwire: fix style issues
In reply to Pierre-Louis BossartVisual inspections confirmed by checkpatch.pl --strict expose a number of style issues, specifically parameter alignment is inconsistent as if different contributors used different styles. Before we restart support for SoundWire with Sound Open Firmware on Intel platforms, let's clean all this.
Fix Kconfig help, spelling, SPDX format, alignment, spurious parentheses, bool comparisons to true/false, macro argument protection.
No new functionality added.
--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++-------------- 12 files changed, 313 insertions(+), 295 deletions(-)
drivers/soundwire/Kconfig +1 -1
@@ -4,7 +4,7 @@ menuconfig SOUNDWIRE bool "SoundWire support" - ---help--- + help SoundWire is a 2-Pin interface with data and clock line ratified by the MIPI Alliance. SoundWire is used for transporting data typically related to audio functions. SoundWire interface is
drivers/soundwire/bus.c +43 -44
305 lines not on this page · raw message
drivers/soundwire/bus.h +8 -8
@@ -1,5 +1,5 @@ -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -// Copyright(c) 2015-17 Intel Corporation. +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ +/* Copyright(c) 2015-17 Intel Corporation. */ #ifndef __SDW_BUS_H#define __SDW_BUS_H
@@ -16,7 +16,7 @@ static inline int sdw_acpi_find_slaves(struct sdw_bus *bus)#endif void sdw_extract_slave_id (struct sdw_bus *bus, -u64 addr,struct sdw_slave_id *id); +u64 addr,struct sdw_slave_id *id);enum {SDW_MSG_FLAG_READ =0 ,
@@ -116,19 +116,19 @@ struct sdw_master_runtime { };struct sdw_dpn_prop *sdw_get_slave_dpn_prop (struct sdw_slave *slave, -enum sdw_data_direction direction, -unsigned int port_num); +enum sdw_data_direction direction, +unsigned int port_num);int sdw_configure_dpn_intr (struct sdw_slave *slave,int port, -bool enable,int mask); +bool enable,int mask);int sdw_transfer (struct sdw_bus *bus,struct sdw_msg *msg);int sdw_transfer_defer (struct sdw_bus *bus,struct sdw_msg *msg, -struct sdw_defer *defer); +struct sdw_defer *defer);#define SDW_READ_INTR_CLEAR_RETRY 10int sdw_fill_msg (struct sdw_msg *msg,struct sdw_slave *slave, -u32 addr,size_t count,u16 dev_num,u8 flags,u8 *buf); +u32 addr,size_t count,u16 dev_num,u8 flags,u8 *buf);/* Read-Modify-Write Slave register */ static inline int
drivers/soundwire/bus_type.c +2 -2
@@ -107,7 +107,7 @@ static int sdw_drv_probe(struct device *dev) slave->prop.clk_stop_timeout =300 ; slave->bus->clk_stop_timeout =max_t (u32, slave->bus->clk_stop_timeout, - slave->prop.clk_stop_timeout); + slave->prop.clk_stop_timeout);return 0 ; }
@@ -148,7 +148,7 @@ int __sdw_register_driver(struct sdw_driver *drv, struct module *owner)if (!drv->probe) {pr_err ("driver %s didn't provide SDW probe routine\n" , - drv->name); + drv->name);return -EINVAL ; }
drivers/soundwire/cadence_master.c +44 -43
279 lines not on this page · raw message
drivers/soundwire/cadence_master.h +11 -11
@@ -1,5 +1,5 @@ -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -// Copyright(c) 2015-17 Intel Corporation. +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ +/* Copyright(c) 2015-17 Intel Corporation. */ #include <sound/soc.h> #ifndef __SDW_CADENCE_H
@@ -160,24 +160,24 @@ irqreturn_t sdw_cdns_thread(int irq, void *dev_id);int sdw_cdns_init (struct sdw_cdns *cdns);int sdw_cdns_pdi_init (struct sdw_cdns *cdns, -struct sdw_cdns_stream_config config); +struct sdw_cdns_stream_config config);int sdw_cdns_enable_interrupt (struct sdw_cdns *cdns);int sdw_cdns_get_stream (struct sdw_cdns *cdns,struct sdw_cdns_streams *stream,u32 ch,u32 dir);int sdw_cdns_alloc_stream (struct sdw_cdns *cdns, -struct sdw_cdns_streams *stream, -struct sdw_cdns_port *port,u32 ch,u32 dir); +struct sdw_cdns_streams *stream, +struct sdw_cdns_port *port,u32 ch,u32 dir);void sdw_cdns_config_stream (struct sdw_cdns *cdns,struct sdw_cdns_port *port, -u32 ch,u32 dir,struct sdw_cdns_pdi *pdi); +u32 ch,u32 dir,struct sdw_cdns_pdi *pdi);void sdw_cdns_shutdown (struct snd_pcm_substream *substream, -struct snd_soc_dai *dai); +struct snd_soc_dai *dai);int sdw_cdns_pcm_set_stream (struct snd_soc_dai *dai, -void *stream,int direction); +void *stream,int direction);int sdw_cdns_pdm_set_stream (struct snd_soc_dai *dai, -void *stream,int direction); +void *stream,int direction);enum sdw_command_response cdns_reset_page_addr (struct sdw_bus *bus,unsigned int dev_num);
@@ -187,7 +187,7 @@ cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg);enum sdw_command_response cdns_xfer_msg_defer (struct sdw_bus *bus, -struct sdw_msg *msg,struct sdw_defer *defer); +struct sdw_msg *msg,struct sdw_defer *defer);enum sdw_command_response cdns_reset_page_addr (struct sdw_bus *bus,unsigned int dev_num);
@@ -195,5 +195,5 @@ cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num);int cdns_bus_conf (struct sdw_bus *bus,struct sdw_bus_params *params);int cdns_set_sdw_stream (struct snd_soc_dai *dai, -void *stream,bool pcm,int direction); +void *stream,bool pcm,int direction);#endif /* __SDW_CADENCE_H */
drivers/soundwire/intel.c +43 -44
214 lines not on this page · raw message
drivers/soundwire/intel.h +2 -2
@@ -1,5 +1,5 @@ -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -// Copyright(c) 2015-17 Intel Corporation. +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ +/* Copyright(c) 2015-17 Intel Corporation. */ #ifndef __SDW_INTEL_LOCAL_H#define __SDW_INTEL_LOCAL_H
drivers/soundwire/intel_init.c +6 -6
@@ -67,7 +67,7 @@ static struct sdw_intel_ctx/* Found controller, find links supported */ count =0 ; ret =fwnode_property_read_u8_array (acpi_fwnode_handle (adev), -"mipi-sdw-master-count" , &count,1 ); +"mipi-sdw-master-count" , &count,1 );/* Don't fail on error, continue and use hw value */ if (ret) {
@@ -85,7 +85,7 @@ static struct sdw_intel_ctx/* Check count is within bounds */ if (count >SDW_MAX_LINKS ) {dev_err (&adev->dev,"Link count %d exceeds max %d\n" , - count,SDW_MAX_LINKS ); + count,SDW_MAX_LINKS );return NULL ; }
@@ -145,7 +145,7 @@ static struct sdw_intel_ctx }static acpi_status sdw_intel_acpi_cb (acpi_handle handle,u32 level, -void *cdata,void **return_value) +void *cdata,void **return_value) {struct sdw_intel_res *res = cdata;struct acpi_device *adev;
@@ -172,9 +172,9 @@ void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res)acpi_status status; status =acpi_walk_namespace (ACPI_TYPE_DEVICE , - parent_handle,1 , - sdw_intel_acpi_cb, -NULL , res,NULL ); + parent_handle,1 , + sdw_intel_acpi_cb, +NULL , res,NULL );if (ACPI_FAILURE (status))return NULL ;
drivers/soundwire/mipi_disco.c +64 -52
308 lines not on this page · raw message
drivers/soundwire/slave.c +5 -5
@@ -14,7 +14,7 @@ static void sdw_slave_release(struct device *dev) }static int sdw_slave_add (struct sdw_bus *bus, -struct sdw_slave_id *id,struct fwnode_handle *fwnode) +struct sdw_slave_id *id,struct fwnode_handle *fwnode) {struct sdw_slave *slave;int ret;
@@ -30,8 +30,8 @@ static int sdw_slave_add(struct sdw_bus *bus,/* name shall be sdw:link:mfg:part:class:unique */ dev_set_name (&slave->dev,"sdw:%x:%x:%x:%x:%x" , - bus->link_id, id->mfg_id, id->part_id, - id->class_id, id->unique_id); + bus->link_id, id->mfg_id, id->part_id, + id->class_id, id->unique_id); slave->dev.release = sdw_slave_release; slave->dev.bus = &sdw_bus_type;
@@ -84,11 +84,11 @@ int sdw_acpi_find_slaves(struct sdw_bus *bus)acpi_status status; status =acpi_evaluate_integer (adev->handle, -METHOD_NAME__ADR ,NULL , &addr); +METHOD_NAME__ADR ,NULL , &addr);if (ACPI_FAILURE (status)) {dev_err (bus->dev,"_ADR resolution failed: %x\n" , - status); + status);return status; }
drivers/soundwire/stream.c +84 -77
444 lines not on this page · raw message
Signature · 1 line
2.17.1
Vinod Koul
maintainerRe: [PATCH v3 2/5] soundwire: fix style issues
Quoted 9 lines · Pierre-Louis Bossart
Visual inspections confirmed by checkpatch.pl --strict expose a number of style issues, specifically parameter alignment is inconsistent as if different contributors used different styles. Before we restart support for SoundWire with Sound Open Firmware on Intel platforms, let's clean all this.
Fix
Kconfighelp, spelling, SPDX format, alignment, spurious parentheses, bool comparisons to true/false, macro argument protection.
Thanks for the cleanup Pierre :)
Quoted 4 lines
No new functionality added.
Signed-off-by Pierre-Louis Bossart <[email protected]>
Quoted 13 lines
--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++--------------
I would prefer this to be a patch per module. It doesnt help to have a single patch for all the files!
It would be great to have cleanup done per logical group, for example typos in a patch, aligns in another etc...
drivers/soundwire/Kconfig line 7
Quoted 12 lines
12 files changed, 313 insertions(+), 295 deletions(-)drivers/soundwire/Kconfig +1
-1@@ -4,7 +4,7 @@ menuconfig SOUNDWIRE bool "SoundWire support" - ---help--- + help
Not sure if this is a style issue, kernel seems to have 2990 instances of this!
drivers/soundwire/Kconfig int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) · line 247
Quoted 8 lines
drivers/soundwire/Kconfig +1
-1if (msg->page) sdw_reset_page(bus, msg->dev_num);@@ -243,7 +244,7 @@ int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) * Caller needs to hold the msg_lock lock while calling this */ int sdw_transfer_defer(struct sdw_bus *bus, struct sdw_msg *msg, - struct sdw_defer *defer) + struct sdw_defer *defer)
this does not seem aligned to me!
drivers/soundwire/Kconfig int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) · line 249
Quoted 3 lines
drivers/soundwire/Kconfig +1
-1int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave, - u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf) + u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf)
this one too
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 461
Quoted 6 lines
drivers/soundwire/Kconfig +1
-1@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave) mutex_unlock(&slave->bus->bus_lock); if (dev_num < 0) { dev_err(slave->bus->dev, "Get dev_num failed: %d", - dev_num); + dev_num);
It might read better if we move the log to second line along with dev_num...
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 463
Quoted 3 lines
drivers/soundwire/Kconfig +1
-1int sdw_configure_dpn_intr(struct sdw_slave *slave, - int port, bool enable, int mask) + int port, bool enable, int mask)
not aligned
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 466
Quoted 4 lines
drivers/soundwire/Kconfig +1
-1void sdw_extract_slave_id(struct sdw_bus *bus, - u64 addr, struct sdw_slave_id *id); + u64 addr, struct sdw_slave_id *id);
Not aligned
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 469
Quoted 4 lines
drivers/soundwire/Kconfig +1
-1enum sdw_command_response cdns_xfer_msg_defer(struct sdw_bus *bus, - struct sdw_msg *msg, struct sdw_defer *defer) + struct sdw_msg *msg, struct sdw_defer *defer)
this one too..
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave)
Quoted 3 lines
drivers/soundwire/Kconfig +1
-1static int cdns_port_params(struct sdw_bus *bus, - struct sdw_port_params *p_params, unsigned int bank) + struct sdw_port_params *p_params, unsigned int bank)
here as well.. (and giving up on rest)
Signature · 1 line
~Vinod
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 17 lines
Quoted 16 lines
Signed-off-by Pierre-Louis Bossart <[email protected]>--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++--------------
Quoted 5 lines
I would prefer this to be a patch per module. It doesnt help to have a single patch for all the files!
It would be great to have cleanup done per logical group, for example typos in a patch, aligns in another etc...
You've got to be kidding. I've never seen people ask for this sort of detail.
Quoted 9 lines
Quoted 9 lines
12 files changed, 313 insertions(+), 295 deletions(-)drivers/soundwire/Kconfig +0
-0@@ -4,7 +4,7 @@
Quoted 7 lines
drivers/soundwire/Kconfig line 7
Quoted 4 lines
drivers/soundwire/Kconfig +1
-1menuconfig SOUNDWIRE bool "SoundWire support" - ---help--- + helpNot sure if this is a style issue, kernel seems to have 2990 instances of this!
this is reported by checkpatch.pl --strict.
Quoted 11 lines
drivers/soundwire/Kconfig int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) · line 247
Quoted 9 lines
drivers/soundwire/Kconfig +1
-1if (msg->page) sdw_reset_page(bus, msg->dev_num);@@ -243,7 +244,7 @@ int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) * Caller needs to hold the msg_lock lock while calling this */ int sdw_transfer_defer(struct sdw_bus *bus, struct sdw_msg *msg, - struct sdw_defer *defer) + struct sdw_defer *defer)this does not seem aligned to me!
It is, I checked. 2 tabs and 7 spaces.
Quoted 6 lines
drivers/soundwire/Kconfig int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) · line 249
Quoted 4 lines
drivers/soundwire/Kconfig +1
-1int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave, - u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf) + u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf)this one too
2 tabs and one space.
Quoted 11 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 461
Quoted 7 lines
drivers/soundwire/Kconfig +1
-1@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave) mutex_unlock(&slave->bus->bus_lock); if (dev_num < 0) { dev_err(slave->bus->dev, "Get dev_num failed: %d", - dev_num); + dev_num);It might read better if we move the log to second line along with
dev_num...
Quoted 5 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 463
Quoted 3 lines
drivers/soundwire/Kconfig +1
-1int sdw_configure_dpn_intr(struct sdw_slave *slave, - int port, bool enable, int mask) + int port, bool enable, int mask)not aligned
it is in the code. It's a diff illusion.
Quoted 7 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 466
Quoted 5 lines
drivers/soundwire/Kconfig +1
-1void sdw_extract_slave_id(struct sdw_bus *bus, - u64 addr, struct sdw_slave_id *id); + u64 addr, struct sdw_slave_id *id);Not aligned
it is in the code. It's a diff illusion.
Quoted 8 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 469
Quoted 5 lines
drivers/soundwire/Kconfig +1
-1enum sdw_command_response cdns_xfer_msg_defer(struct sdw_bus *bus, - struct sdw_msg *msg, struct sdw_defer *defer) + struct sdw_msg *msg, struct sdw_defer *defer)this one too..
Quoted 5 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave)
Quoted 3 lines
drivers/soundwire/Kconfig +1
-1static int cdns_port_params(struct sdw_bus *bus, - struct sdw_port_params *p_params, unsigned int bank) + struct sdw_port_params *p_params, unsigned int bank)here as well.. (and giving up on rest)
Please check for yourself that this is a diff illusion w/ tab space.
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 43 lines · Pierre-Louis Bossart
Quoted 17 lines
Quoted 16 lines
Signed-off-by Pierre-Louis Bossart <[email protected]>--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++--------------Quoted 5 lines
I would prefer this to be a patch per module. It doesnt help to have a single patch for all the files!
It would be great to have cleanup done per logical group, for example typos in a patch, aligns in another etc...
You've got to be kidding. I've never seen people ask for this sort of detail.
Quoted 9 lines
Quoted 9 lines
12 files changed, 313 insertions(+), 295 deletions(-)drivers/soundwire/Kconfig +0
-0@@ -4,7 +4,7 @@Quoted 7 lines
drivers/soundwire/Kconfig line 7
Quoted 4 lines
drivers/soundwire/Kconfig +1
-1menuconfig SOUNDWIRE bool "SoundWire support" - ---help--- + helpNot sure if this is a style issue, kernel seems to have 2990 instances of this!
Quoted 1 line
this is reported by checkpatch.pl --strict.
Please don't run checkpatch on code that's already in the kernel, and especially not with the --strict (a.k.a. --subjective) option enabled.
Don't try to fix what isn't broken.
Thanks,
Johan
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
drivers/soundwire/Kconfig line 7
Quoted 11 lines
drivers/soundwire/Kconfig +1
-1@@ -4,7 +4,7 @@ menuconfig SOUNDWIRE bool "SoundWire support" - ---help--- + helpNot sure if this is a style issue, kernel seems to have 2990 instances of this!
Quoted 6 lines
Quoted 1 line
this is reported by checkpatch.pl --strict.
Please don't run checkpatch on code that's already in the kernel, and especially not with the --strict (a.k.a. --subjective) option enabled.
Don't try to fix what isn't broken.
I would agree in general, but this case is different: the SoundWire code in the upstream kernel is missing parts left and right and isn't fully functional as is. I will soon be posting what's missing, so this cleanup is an opportunity to bring SoundWire to the latest coding standards before adding the missing pieces which will be compliant with --strict. For the record using --strict already exposed 3 major issues in the yet-to-be-released code, so it's not as subjective as you describe it.
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 22 lines · Pierre-Louis Bossart
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
drivers/soundwire/Kconfig line 7
Quoted 11 lines
drivers/soundwire/Kconfig +1
-1@@ -4,7 +4,7 @@ menuconfig SOUNDWIRE bool "SoundWire support" - ---help--- + helpNot sure if this is a style issue, kernel seems to have 2990 instances of this!
Quoted 6 lines
Quoted 1 line
this is reported by checkpatch.pl --strict.
Please don't run checkpatch on code that's already in the kernel, and especially not with the --strict (a.k.a. --subjective) option enabled.
Don't try to fix what isn't broken.
Quoted 7 lines
I would agree in general, but this case is different: the SoundWire code in the upstream kernel is missing parts left and right and isn't fully functional as is. I will soon be posting what's missing, so this cleanup is an opportunity to bring SoundWire to the latest coding standards before adding the missing pieces which will be compliant with --strict. For the record using --strict already exposed 3 major issues in the yet-to-be-released code, so it's not as subjective as you describe it.
It's not just me calling it subjective; --subjective is literally another name for the same switch which enables checks that are specifically *not* part of the coding standard.
By all my means use it on your own patches before you submit them if you agree with all or some of those checks, but I doubt all that open-parenthesis re-alignment is going to expose any major issues. ;)
It does add noise, and makes code forensic and backports harder though.
Johan
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
In reply to Pierre-Louis BossartQuoted 8 lines
Quoted 8 lines
Quoted 5 lines
enum
sdw_command_responsecdns_xfer_msg_defer(structsdw_bus*bus,
- structsdw_msg*msg, structsdw_defer*defer) + structsdw_msg*msg, structsdw_defer*defer)this one too..
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
static int cdns_port_params(struct
sdw_bus*bus,
- structsdw_port_params*p_params, unsigned int bank) + structsdw_port_params*p_params, unsigned int bank)here as well.. (and giving up on rest)
Please check for yourself that this is a diff illusion w/ tab space.
Vinod, can you please double-check, the alignment issues you reported don't exist, see e.g. below what the code looks like after merge.
int sdw_transfer_defer(struct sdw_bus *bus, struct sdw_msg *msg,
struct sdw_defer *defer)
int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave,
u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf)
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Vinod Koul
maintainerRe: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 20 lines · Pierre-Louis Bossart
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
enum
sdw_command_responsecdns_xfer_msg_defer(structsdw_bus*bus,
- structsdw_msg*msg, structsdw_defer*defer) + structsdw_msg*msg, structsdw_defer*defer)this one too..
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
static int cdns_port_params(struct
sdw_bus*bus,
- structsdw_port_params*p_params, unsigned int bank) + structsdw_port_params*p_params, unsigned int bank)here as well.. (and giving up on rest)
Please check for yourself that this is a diff illusion w/ tab space.
Vinod, can you please double-check, the alignment issues you reported don't exist, see e.g. below what the code looks like after merge.
Quoted 5 lines
int sdw_transfer_defer(struct
sdw_bus*bus, structsdw_msg*msg,
structsdw_defer*defer)int sdw_fill_msg(struct
sdw_msg*msg, structsdw_slave*slave,u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf)
Sure, please split up as requested and I shall test apply and check alignment before reporting...
Signature · 1 line
~Vinod
Vinod Koul
maintainerRe: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
In reply to Pierre-Louis BossartQuoted 17 lines · Pierre-Louis Bossart
Quoted 17 lines
Quoted 16 lines
Signed-off-by Pierre-Louis Bossart <[email protected]>--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++--------------
Quoted 8 lines
Quoted 5 lines
I would prefer this to be a patch per module. It doesnt help to have a single patch for all the files!
It would be great to have cleanup done per logical group, for example typos in a patch, aligns in another etc...
You've got to be kidding. I've never seen people ask for this sort of detail.
Nope this is the way it should be. A patch is patch and which should do one thing! Even if it is a cleanup one.
I dislike a patch which touches everything, core, modules, so please split up. As a said in review it takes guesswork to find why a change was done, was it whitespace fix, indentation or not, so please split up based on type of fixes.
Quoted 34 lines
Quoted 4 lines
Quoted 4 lines
12 files changed, 313 insertions(+), 295 deletions(-)Quoted 12 lines
drivers/soundwire/Kconfig line 6
Quoted 9 lines
drivers/soundwire/Kconfig +1
-1@@ -4,7 +4,7 @@ menuconfig SOUNDWIRE bool "SoundWire support" - ---help--- + helpNot sure if this is a style issue, kernel seems to have 2990 instances of this!
this is reported by checkpatch.pl --strict.
Quoted 11 lines
drivers/soundwire/Kconfig int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) · line 247
Quoted 9 lines
drivers/soundwire/Kconfig +1
-1if (msg->page) sdw_reset_page(bus, msg->dev_num);@@ -243,7 +244,7 @@ int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) * Caller needs to hold the msg_lock lock while calling this */ int sdw_transfer_defer(struct sdw_bus *bus, struct sdw_msg *msg, - struct sdw_defer *defer) + struct sdw_defer *defer)this does not seem aligned to me!
It is, I checked. 2 tabs and 7 spaces.
Quoted 1 line
Quoted 18 lines
Quoted 5 lines
drivers/soundwire/Kconfig int sdw_transfer(struct sdw_bus *bus, struct sdw_msg *msg) · line 249
Quoted 3 lines
drivers/soundwire/Kconfig +1
-1int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave, - u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf) + u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf)this one too
2 tabs and one space.
Quoted 10 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 461
Quoted 7 lines
drivers/soundwire/Kconfig +1
-1@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave) mutex_unlock(&slave->bus->bus_lock); if (dev_num < 0) { dev_err(slave->bus->dev, "Get dev_num failed: %d", - dev_num); + dev_num);It might read better if we move the log to second line along with
dev_num...
?
Quoted 32 lines
Quoted 6 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 463
Quoted 4 lines
drivers/soundwire/Kconfig +1
-1int sdw_configure_dpn_intr(struct sdw_slave *slave, - int port, bool enable, int mask) + int port, bool enable, int mask)not aligned
it is in the code. It's a diff illusion.
Quoted 6 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 465
Quoted 4 lines
drivers/soundwire/Kconfig +1
-1void sdw_extract_slave_id(struct sdw_bus *bus, - u64 addr, struct sdw_slave_id *id); + u64 addr, struct sdw_slave_id *id);Not aligned
it is in the code. It's a diff illusion.
Quoted 7 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 468
Quoted 4 lines
drivers/soundwire/Kconfig +1
-1enum sdw_command_response cdns_xfer_msg_defer(struct sdw_bus *bus, - struct sdw_msg *msg, struct sdw_defer *defer) + struct sdw_msg *msg, struct sdw_defer *defer)this one too..
Quoted 5 lines
drivers/soundwire/Kconfig static int sdw_assign_device_num(struct sdw_slave *slave) · line 470
Quoted 3 lines
drivers/soundwire/Kconfig +1
-1static int cdns_port_params(struct sdw_bus *bus, - struct sdw_port_params *p_params, unsigned int bank) + struct sdw_port_params *p_params, unsigned int bank)here as well.. (and giving up on rest)
Please check for yourself that this is a diff illusion w/ tab space.
Signature · 1 line
~Vinod
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 27 lines · Vinod Koul
Quoted 17 lines · Pierre-Louis Bossart
Quoted 17 lines
Quoted 16 lines
Signed-off-by Pierre-Louis Bossart <[email protected]>--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++--------------Quoted 8 lines
Quoted 5 lines
I would prefer this to be a patch per module. It doesnt help to have a single patch for all the files!
It would be great to have cleanup done per logical group, for example typos in a patch, aligns in another etc...
You've got to be kidding. I've never seen people ask for this sort of detail.
Quoted 7 lines
Nope this is the way it should be. A patch is patch and which should do one thing! Even if it is a cleanup one.
I dislike a patch which touches everything, core, modules, so please split up. As a said in review it takes guesswork to find why a change was done, was it whitespace fix, indentation or not, so please split up based on type of fixes.
With all due respect, you are not helping here but rather slowing things down. I've done dozens of cleanups in the ALSA tree and I didn't go in this sort of details. The fact that the series was tagged as Reviewed by Takashi on April 11 and we are still discussing trivial changes tells me the integration model is broken. It's not just me, the patches related to runtime-pm from your own Linaro colleagues posted on March 28 went nowhere either.
Moving forward, I suggest we merge SoundWire-related patches through the sound tree. There will be dependencies in the coming weeks between SOF and SoundWire and it makes no sense to have separate maintainers and make the life of early adopters more complicated than it needs to be. If we have 3-week delays for trivial stuff, I can't imagine what the pace will be when I publish the next 20-odd patches I am still working on, and the code needed for the SoundWire audio device class being standardized as we speak. Things were fine up to now since no one was actually using the code, we are in a different model now.
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 36 lines · Pierre-Louis Bossart
Quoted 27 lines · Vinod Koul
Quoted 17 lines · Pierre-Louis Bossart
Quoted 17 lines
Quoted 16 lines
Signed-off-by Pierre-Louis Bossart <[email protected]>--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++--------------Quoted 8 lines
Quoted 5 lines
I would prefer this to be a patch per module. It doesnt help to have a single patch for all the files!
It would be great to have cleanup done per logical group, for example typos in a patch, aligns in another etc...
You've got to be kidding. I've never seen people ask for this sort of detail.
Quoted 7 lines
Nope this is the way it should be. A patch is patch and which should do one thing! Even if it is a cleanup one.
I dislike a patch which touches everything, core, modules, so please split up. As a said in review it takes guesswork to find why a change was done, was it whitespace fix, indentation or not, so please split up based on type of fixes.
Quoted 7 lines
With all due respect, you are not helping here but rather slowing things down. I've done dozens of cleanups in the ALSA tree and I didn't go in this sort of details. The fact that the series was tagged as Reviewed by Takashi on April 11 and we are still discussing trivial changes tells me the integration model is broken. It's not just me, the patches related to runtime-pm from your own Linaro colleagues posted on March 28 went nowhere either.
My patch-bot would reject a patch that tried to do multiple types of different cleanups on the same file(s). Has done so for _years_, this is not a new thing.
Remember, maintainer/reviewer time is scarce, engineer time is prolific, we optimize for reviewers, not the people writing the patches.
thanks,
greg k-h
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 4 lines
My patch-bot would reject a patch that tried to do multiple types of different cleanups on the same file(s). Has done so for _years_, this is not a new thing.
If there are tools let's use them (all the fixes in this series were reported by tools). Can you share pointers and location of this patch-bot?
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 7 lines · Pierre-Louis Bossart
Quoted 4 lines
My patch-bot would reject a patch that tried to do multiple types of different cleanups on the same file(s). Has done so for _years_, this is not a new thing.
If there are tools let's use them (all the fixes in this series were reported by tools). Can you share pointers and location of this patch-bot?
I talked about my bot a long time ago in one of my presentations, the source isn't around anywhere public, sorry.
But here's the template for what it can spit out, depending on the patch input, feel free to cut/paste from it for your use when reviewing patches.
thanks,
greg k-h
-----------------
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch breaks the build.
- Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool.
- Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/email-clients.txt in order to fix this.
- Your patch was attached, please place it inline so that it can be applied directly from the email message itself.
- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.
- Your patch was sent privately to Greg. Kernel development is done in public, please always cc: a public mailing list with a patch submission. Using the tool, scripts/get_maintainer.pl on the patch will tell you what mailing list to cc.
- Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause.
- Your patch did not apply to any known trees that Greg is in control of. Possibly this is because you made it against Linus's tree, not the linux-next tree, which is where all of the development for the next version of the kernel is at. Please refresh your patch against the linux-next tree, or even better yet, the development tree specified in the MAINTAINERS file for the subsystem you are submitting a patch for, and resend it.
- You sent multiple patches, yet no indication of which ones should be applied in which order. Greg could just guess, but if you are receiving this email, he guessed wrong and the patches didn't apply. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for a description of how to do this so that Greg has a chance to apply these correctly.
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Vfiinod Koul
maintainerRe: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
In reply to Pierre-Louis BossartQuoted 31 lines · Pierre-Louis Bossart
Quoted 30 lines · Vinod Koul
Quoted 17 lines · Pierre-Louis Bossart
Quoted 17 lines
Quoted 16 lines
Signed-off-by Pierre-Louis Bossart <[email protected]>--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++--------------Quoted 8 lines
Quoted 5 lines
I would prefer this to be a patch per module. It doesnt help to have a single patch for all the files!
It would be great to have cleanup done per logical group, for example typos in a patch, aligns in another etc...
You've got to be kidding. I've never seen people ask for this sort of detail.
Nope this is the way it should be. A patch is patch and which should do one thing! Even if it is a cleanup one.
Quoted 8 lines
Quoted 4 lines
I dislike a patch which touches everything, core, modules, so please split up. As a said in review it takes guesswork to find why a change was done, was it whitespace fix, indentation or not, so please split up based on type of fixes.
With all due respect, you are not helping here but rather slowing things down. I've done dozens of cleanups in the ALSA tree and I didn't go in this sort of details.
Thats fine, it is upto people, everyone has different views, mine is different from Takashi's. We all know for example networking has different stable and code style rule. That is how it is and I dont think we would have one rule for all kernel.
All I ask is to be able to review and split up accordingly, I guess that is a fair request
Quoted 3 lines
The fact that the series was tagged as Reviewed by Takashi on April 11 and we are still discussing trivial changes tells me the integration model is broken.
Is it? you got feedback on 15th (that too after my 2 week conf/vacation break) and I got called crazy for that, not helping!!
Quoted 3 lines
It's not just me the patches related to
runtime-pm from your own Linaro colleagues posted on March 28 went nowhere either.
Does it matter it was a Linaro colleague or not, a patch was posted, feedback given (similar to cadence one) we agreed that the fix is not correct and so patch was not applied. I don't think Srini cried over it!
Quoted 9 lines
Moving forward, I suggest we merge SoundWire-related patches through the sound tree. There will be dependencies in the coming weeks between SOF and SoundWire and it makes no sense to have separate maintainers and make the life of early adopters more complicated than it needs to be. If we have 3-week delays for trivial stuff, I can't imagine what the pace will be when I publish the next 20-odd patches I am still working on, and the code needed for the SoundWire audio device class being standardized as we speak. Things were fine up to now since no one was actually using the code, we are in a different model now.
I disagree and wont accept it. I dont think you understand that you are not the most important person in the whole world, the 20 patches series you are cooking would sure be greatest ever, but that is not the point. The kernel has a process, you got a feedback, please fix that and post v2 rather than cribbing, complaining and calling crazy. The energy would have been better spent on fixing the feedback provided.
Dependencies are _always_ there in kernel development and we know how to deal with it. Am sure Takashi, Mark and me can come to reasonable agreement, I wouldn't worry about that!
What we dont do is create new model for your 20 patches.
And I guess I dont have anything more to say on this thread, so I wont bother replying, please feel free to post v2 and I shall review.
Signature · 5 lines
~Vinod _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues
Quoted 83 lines · Vfiinod Koul
Quoted 31 lines · Pierre-Louis Bossart
Quoted 30 lines · Vinod Koul
Quoted 17 lines · Pierre-Louis Bossart
Quoted 17 lines
Quoted 16 lines
Signed-off-by Pierre-Louis Bossart <[email protected]>--- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 87 ++++++++-------- drivers/soundwire/bus.h | 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87 ++++++++-------- drivers/soundwire/cadence_master.h | 22 ++-- drivers/soundwire/intel.c | 87 ++++++++-------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +-- drivers/soundwire/mipi_disco.c | 116 +++++++++++---------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 161 +++++++++++++++--------------Quoted 8 lines
Quoted 5 lines
I would prefer this to be a patch per module. It doesnt help to have a single patch for all the files!
It would be great to have cleanup done per logical group, for example typos in a patch, aligns in another etc...
You've got to be kidding. I've never seen people ask for this sort of detail.
Nope this is the way it should be. A patch is patch and which should do one thing! Even if it is a cleanup one.
Quoted 8 lines
Quoted 4 lines
I dislike a patch which touches everything, core, modules, so please split up. As a said in review it takes guesswork to find why a change was done, was it whitespace fix, indentation or not, so please split up based on type of fixes.
With all due respect, you are not helping here but rather slowing things down. I've done dozens of cleanups in the ALSA tree and I didn't go in this sort of details.
Thats fine, it is upto people, everyone has different views, mine is different from Takashi's. We all know for example networking has different stable and code style rule. That is how it is and I dont think we would have one rule for all kernel.
All I ask is to be able to review and split up accordingly, I guess that is a fair request
Quoted 3 lines
The fact that the series was tagged as Reviewed by Takashi on April 11 and we are still discussing trivial changes tells me the integration model is broken.
Is it? you got feedback on 15th (that too after my 2 week conf/vacation break) and I got called crazy for that, not helping!!
Quoted 3 lines
It's not just me the patches related to
runtime-pm from your own Linaro colleagues posted on March 28 went nowhere either.Does it matter it was a Linaro colleague or not, a patch was posted, feedback given (similar to cadence one) we agreed that the fix is not correct and so patch was not applied. I don't think Srini cried over it!
Quoted 9 lines
Moving forward, I suggest we merge SoundWire-related patches through the sound tree. There will be dependencies in the coming weeks between SOF and SoundWire and it makes no sense to have separate maintainers and make the life of early adopters more complicated than it needs to be. If we have 3-week delays for trivial stuff, I can't imagine what the pace will be when I publish the next 20-odd patches I am still working on, and the code needed for the SoundWire audio device class being standardized as we speak. Things were fine up to now since no one was actually using the code, we are in a different model now.
I disagree and wont accept it. I dont think you understand that you are not the most important person in the whole world, the 20 patches series you are cooking would sure be greatest ever, but that is not the point. The kernel has a process, you got a feedback, please fix that and post v2 rather than cribbing, complaining and calling crazy. The energy would have been better spent on fixing the feedback provided.
Quoted 8 lines
Dependencies are _always_ there in kernel development and we know how to deal with it. Am sure Takashi, Mark and me can come to reasonable agreement, I wouldn't worry about that!
What we dont do is create new model for your 20 patches.
And I guess I dont have anything more to say on this thread, so I wont bother replying, please feel free to post v2 and I shall review.
Friends have disagreements. We remain friends and I will provide a v2.
I still believe it makes no sense to split the integration of SoundWire-related patches in two different trees. The only rationale for it might be that SoundWire is a 'bus' than could be used in other areas. Except that for now and the foreseeable future (2022+) it's only for audio as a replacement of HDaudio, so the pragmatic way of dealing with SoundWire is to merge the code through the audio tree. And given that the code is not in a usable state at the moment, dealing with the audio tree would not have any negative impact on anyone.
PATCH v3 3/5 soundwire: bus: remove useless initializations
In reply to Pierre-Louis BossartNo need for explicit initialization of page and ssp fields, they are already zeroed with a memset.
Detected with cppcheck:
[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is reassigned a value before the old one has been used.
--- drivers/soundwire/bus.c | 2 -- 1 file changed, 2 deletions(-)
drivers/soundwire/bus.c +0 -2
@@ -271,8 +271,6 @@ int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave, msg->dev_num = dev_num; msg->flags = flags; msg->buf = buf; - msg->ssp_sync = false; - msg->page = false;if (addr <SDW_REG_NO_PAGE ) {/* no paging area */ return 0 ;
Signature · 1 line
2.17.1
PATCH v3 4/5 soundwire: stream: remove useless initialization of local variable
In reply to Pierre-Louis Bossartno need to reset return value.
Detected with cppcheck:
[drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a value that is never used.
--- drivers/soundwire/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soundwire/stream.c +1 -1
@@ -329,7 +329,7 @@ static int sdw_enable_disable_master_ports(struct sdw_master_runtime *m_rt,struct sdw_transport_params *t_params = &p_rt->transport_params;struct sdw_bus *bus = m_rt->bus;struct sdw_enable_ch enable_ch; -int ret =0 ; +int ret; enable_ch.port_num = p_rt->num; enable_ch.ch_mask = p_rt->ch_mask;
Signature · 1 line
2.17.1
PATCH v3 5/5 soundwire: add missing newlines in dynamic debug logs
In reply to Pierre-Louis BossartFor some reason the newlines are not used everywhere. Fix as needed.
--- drivers/soundwire/bus.c | 74 +++++++++---------- drivers/soundwire/cadence_master.c | 12 ++-- drivers/soundwire/intel.c | 12 ++-- drivers/soundwire/stream.c | 110 ++++++++++++++--------------- 4 files changed, 104 insertions(+), 104 deletions(-)
drivers/soundwire/bus.c +37 -37
@@ -21,12 +21,12 @@ int sdw_add_bus_master(struct sdw_bus *bus)int ret;if (!bus->dev) { -pr_err ("SoundWire bus has no device" ); +pr_err ("SoundWire bus has no device\n" );return -ENODEV ; }if (!bus->ops) { -dev_err (bus->dev,"SoundWire Bus ops are not set" ); +dev_err (bus->dev,"SoundWire Bus ops are not set\n" );return -EINVAL ; }
@@ -43,7 +43,7 @@ int sdw_add_bus_master(struct sdw_bus *bus)if (bus->ops->read_prop) { ret = bus->ops->read_prop (bus);if (ret <0 ) { -dev_err (bus->dev,"Bus read properties failed:%d" , ret); +dev_err (bus->dev,"Bus read properties failed:%d\n" , ret);return ret; } }
@@ -296,7 +296,7 @@ int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave,return -EINVAL ; }else if (!slave->prop.paging_support) {dev_err (&slave->dev, -"address %x needs paging but no support" , addr); +"address %x needs paging but no support\n" , addr);return -EINVAL ; }
@@ -455,13 +455,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave) dev_num =sdw_get_device_num (slave);mutex_unlock (&slave->bus->bus_lock);if (dev_num <0 ) { -dev_err (slave->bus->dev,"Get dev_num failed: %d" , +dev_err (slave->bus->dev,"Get dev_num failed: %d\n" , dev_num);return dev_num; } }else {dev_info (slave->bus->dev, -"Slave already registered dev_num:%d" , +"Slave already registered dev_num:%d\n" , slave->dev_num);/* Clear the slave->dev_num to transfer message on device 0 */
@@ -472,7 +472,7 @@ static int sdw_assign_device_num(struct sdw_slave *slave) ret =sdw_write (slave,SDW_SCP_DEVNUMBER , dev_num);if (ret <0 ) { -dev_err (&slave->dev,"Program device_num failed: %d" , ret); +dev_err (&slave->dev,"Program device_num failed: %d\n" , ret);return ret; }
@@ -485,7 +485,7 @@ static int sdw_assign_device_num(struct sdw_slave *slave)void sdw_extract_slave_id (struct sdw_bus *bus,u64 addr,struct sdw_slave_id *id) { -dev_dbg (bus->dev,"SDW Slave Addr: %llx" , addr); +dev_dbg (bus->dev,"SDW Slave Addr: %llx\n" , addr);/* * Spec definition
@@ -505,7 +505,7 @@ void sdw_extract_slave_id(struct sdw_bus *bus, id->class_id = addr &GENMASK (7 ,0 );dev_dbg (bus->dev, -"SDW Slave class_id %x, part_id %x, mfg_id %x, unique_id %x, version %x" , +"SDW Slave class_id %x, part_id %x, mfg_id %x, unique_id %x, version %x\n" , id->class_id, id->part_id, id->mfg_id, id->unique_id, id->sdw_version);
@@ -562,7 +562,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) ret =sdw_assign_device_num (slave);if (ret) {dev_err (slave->bus->dev, -"Assign dev_num failed:%d" , +"Assign dev_num failed:%d\n" , ret);return ret; }
@@ -573,7 +573,7 @@ static int sdw_program_device_num(struct sdw_bus *bus)if (!found) {/* TODO: Park this device in Group 13 */ -dev_err (bus->dev,"Slave Entry not found" ); +dev_err (bus->dev,"Slave Entry not found\n" ); } count++;
@@ -618,7 +618,7 @@ int sdw_configure_dpn_intr(struct sdw_slave *slave, ret =sdw_update (slave, addr, (mask |SDW_DPN_INT_PORT_READY ), val);if (ret <0 )dev_err (slave->bus->dev, -"SDW_DPN_INTMASK write failed:%d" , val); +"SDW_DPN_INTMASK write failed:%d\n" , val);return ret; }
@@ -642,7 +642,7 @@ static int sdw_initialize_slave(struct sdw_slave *slave) ret =sdw_update (slave,SDW_SCP_INTMASK1 , val, val);if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_SCP_INTMASK1 write failed:%d" , ret); +"SDW_SCP_INTMASK1 write failed:%d\n" , ret);return ret; }
@@ -657,7 +657,7 @@ static int sdw_initialize_slave(struct sdw_slave *slave) ret =sdw_update (slave,SDW_DP0_INTMASK , val, val);if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_DP0_INTMASK read failed:%d" , ret); +"SDW_DP0_INTMASK read failed:%d\n" , ret);return val; }
@@ -672,14 +672,14 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status) status =sdw_read (slave,SDW_DP0_INT );if (status <0 ) {dev_err (slave->bus->dev, -"SDW_DP0_INT read failed:%d" , status); +"SDW_DP0_INT read failed:%d\n" , status);return status; } do { if (status & SDW_DP0_INT_TEST_FAIL) { - dev_err(&slave->dev, "Test fail for port 0"); + dev_err(&slave->dev, "Test fail for port 0\n"); clear |= SDW_DP0_INT_TEST_FAIL; }
@@ -694,7 +694,7 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status) }if (status &SDW_DP0_INT_BRA_FAILURE ) { -dev_err (&slave->dev,"BRA failed" ); +dev_err (&slave->dev,"BRA failed\n" ); clear |=SDW_DP0_INT_BRA_FAILURE ; }
@@ -710,7 +710,7 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status) ret =sdw_write (slave,SDW_DP0_INT , clear);if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_DP0_INT write failed:%d" , ret); +"SDW_DP0_INT write failed:%d\n" , ret);return ret; }
@@ -718,7 +718,7 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status) status2 =sdw_read (slave,SDW_DP0_INT );if (status2 <0 ) {dev_err (slave->bus->dev, -"SDW_DP0_INT read failed:%d" , status2); +"SDW_DP0_INT read failed:%d\n" , status2);return status2; } status &= status2;
@@ -729,7 +729,7 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status) }while (status !=0 && count <SDW_READ_INTR_CLEAR_RETRY );if (count ==SDW_READ_INTR_CLEAR_RETRY ) -dev_warn (slave->bus->dev,"Reached MAX_RETRY on DP0 read" ); +dev_warn (slave->bus->dev,"Reached MAX_RETRY on DP0 read\n" );return ret; }
@@ -748,7 +748,7 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave, status =sdw_read (slave, addr);if (status <0 ) {dev_err (slave->bus->dev, -"SDW_DPN_INT read failed:%d" , status); +"SDW_DPN_INT read failed:%d\n" , status);return status; }
@@ -756,7 +756,7 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave, do { if (status & SDW_DPN_INT_TEST_FAIL) { - dev_err(&slave->dev, "Test fail for port:%d", port); + dev_err(&slave->dev, "Test fail for port:%d\n", port); clear |= SDW_DPN_INT_TEST_FAIL; }
@@ -781,7 +781,7 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave, ret =sdw_write (slave, addr, clear);if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_DPN_INT write failed:%d" , ret); +"SDW_DPN_INT write failed:%d\n" , ret);return ret; }
@@ -789,7 +789,7 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave, status2 =sdw_read (slave, addr);if (status2 <0 ) {dev_err (slave->bus->dev, -"SDW_DPN_INT read failed:%d" , status2); +"SDW_DPN_INT read failed:%d\n" , status2);return status2; } status &= status2;
@@ -820,14 +820,14 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) buf = ret =sdw_read (slave,SDW_SCP_INT1 );if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_SCP_INT1 read failed:%d" , ret); +"SDW_SCP_INT1 read failed:%d\n" , ret);return ret; } ret =sdw_nread (slave,SDW_SCP_INTSTAT2 ,2 , buf2);if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_SCP_INT2/3 read failed:%d" , ret); +"SDW_SCP_INT2/3 read failed:%d\n" , ret);return ret; }
@@ -837,12 +837,12 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave)* interrupt */ if (buf &SDW_SCP_INT1_PARITY ) { -dev_err (&slave->dev,"Parity error detected" ); +dev_err (&slave->dev,"Parity error detected\n" ); clear |=SDW_SCP_INT1_PARITY ; }if (buf &SDW_SCP_INT1_BUS_CLASH ) { -dev_err (&slave->dev,"Bus clash error detected" ); +dev_err (&slave->dev,"Bus clash error detected\n" ); clear |=SDW_SCP_INT1_BUS_CLASH ; }
@@ -908,7 +908,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) ret =sdw_write (slave,SDW_SCP_INT1 , clear);if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_SCP_INT1 write failed:%d" , ret); +"SDW_SCP_INT1 write failed:%d\n" , ret);return ret; }
@@ -919,14 +919,14 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) _buf = ret =sdw_read (slave,SDW_SCP_INT1 );if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_SCP_INT1 read failed:%d" , ret); +"SDW_SCP_INT1 read failed:%d\n" , ret);return ret; } ret =sdw_nread (slave,SDW_SCP_INTSTAT2 ,2 , _buf2);if (ret <0 ) {dev_err (slave->bus->dev, -"SDW_SCP_INT2/3 read failed:%d" , ret); +"SDW_SCP_INT2/3 read failed:%d\n" , ret);return ret; }
@@ -946,7 +946,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) }while (stat !=0 && count <SDW_READ_INTR_CLEAR_RETRY );if (count ==SDW_READ_INTR_CLEAR_RETRY ) -dev_warn (slave->bus->dev,"Reached MAX_RETRY on alert read" ); +dev_warn (slave->bus->dev,"Reached MAX_RETRY on alert read\n" );return ret; }
@@ -975,7 +975,7 @@ int sdw_handle_slave_status(struct sdw_bus *bus,if (status[0 ] ==SDW_SLAVE_ATTACHED ) { ret =sdw_program_device_num (bus);if (ret) -dev_err (bus->dev,"Slave attach failed: %d" , ret); +dev_err (bus->dev,"Slave attach failed: %d\n" , ret); }/* Continue to check other slave statuses */
@@ -1003,7 +1003,7 @@ int sdw_handle_slave_status(struct sdw_bus *bus, ret =sdw_handle_slave_alerts (slave);if (ret)dev_err (bus->dev, -"Slave %d alert handling failed: %d" , +"Slave %d alert handling failed: %d\n" , i, ret);break ;
@@ -1020,13 +1020,13 @@ int sdw_handle_slave_status(struct sdw_bus *bus, ret =sdw_initialize_slave (slave);if (ret)dev_err (bus->dev, -"Slave %d initialization failed: %d" , +"Slave %d initialization failed: %d\n" , i, ret);break ;default : -dev_err (bus->dev,"Invalid slave %d status:%d" , +dev_err (bus->dev,"Invalid slave %d status:%d\n" , i, status[i]);break ; }
@@ -1034,7 +1034,7 @@ int sdw_handle_slave_status(struct sdw_bus *bus, ret =sdw_update_slave_status (slave, status[i]);if (ret)dev_err (slave->bus->dev, -"Update Slave status failed:%d" , ret); +"Update Slave status failed:%d\n" , ret); }
drivers/soundwire/cadence_master.c +6 -6
@@ -346,10 +346,10 @@ cdns_program_scp_addr(struct sdw_cdns *cdns, struct sdw_msg *msg)for (i =0 ; i <2 ; i++) {if (!(cdns->response_buf[i] &CDNS_MCP_RESP_ACK )) { no_ack =1 ; -dev_err (cdns->dev,"Program SCP Ack not received" ); +dev_err (cdns->dev,"Program SCP Ack not received\n" );if (cdns->response_buf[i] &CDNS_MCP_RESP_NACK ) { nack =1 ; -dev_err (cdns->dev,"Program SCP NACK received" ); +dev_err (cdns->dev,"Program SCP NACK received\n" ); } } }
@@ -357,11 +357,11 @@ cdns_program_scp_addr(struct sdw_cdns *cdns, struct sdw_msg *msg)/* For NACK, NO ack, don't return err if we are in Broadcast mode */ if (nack) {dev_err (cdns->dev, -"SCP_addrpage NACKed for Slave %d" , msg->dev_num); +"SCP_addrpage NACKed for Slave %d\n" , msg->dev_num);return SDW_CMD_FAIL ; }else if (no_ack) {dev_dbg (cdns->dev, -"SCP_addrpage ignored for Slave %d" , msg->dev_num); +"SCP_addrpage ignored for Slave %d\n" , msg->dev_num);return SDW_CMD_IGNORED ; }
@@ -665,7 +665,7 @@ int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns) ret =cdns_clear_bit (cdns,CDNS_MCP_CONFIG_UPDATE ,CDNS_MCP_CONFIG_UPDATE_BIT );if (ret <0 ) -dev_err (cdns->dev,"Config update timedout" ); +dev_err (cdns->dev,"Config update timedout\n" );return ret; }
@@ -853,7 +853,7 @@ int cdns_bus_conf(struct sdw_bus *bus, struct sdw_bus_params *params)int divider;if (!params->curr_dr_freq) { -dev_err (cdns->dev,"NULL curr_dr_freq" ); +dev_err (cdns->dev,"NULL curr_dr_freq\n" );return -EINVAL ; }
drivers/soundwire/intel.c +6 -6
@@ -237,7 +237,7 @@ static int intel_shim_init(struct sdw_intel *sdw) ret =intel_clear_bit (shim,SDW_SHIM_SYNC , sync_reg,SDW_SHIM_SYNC_SYNCCPU );if (ret <0 ) -dev_err (sdw->cdns.dev,"Failed to set sync period: %d" , ret); +dev_err (sdw->cdns.dev,"Failed to set sync period: %d\n" , ret);return ret; }
@@ -455,7 +455,7 @@ static int intel_post_bank_switch(struct sdw_bus *bus) ret =intel_clear_bit (shim,SDW_SHIM_SYNC , sync_reg,SDW_SHIM_SYNC_SYNCGO );if (ret <0 ) -dev_err (sdw->cdns.dev,"Post bank switch failed: %d" , ret); +dev_err (sdw->cdns.dev,"Post bank switch failed: %d\n" , ret);return ret; }
@@ -555,7 +555,7 @@ static int intel_hw_params(struct snd_pcm_substream *substream, }if (!dma->nr_ports) { -dev_err (dai->dev,"ports/resources not available" ); +dev_err (dai->dev,"ports/resources not available\n" );return -EINVAL ; }
@@ -606,7 +606,7 @@ static int intel_hw_params(struct snd_pcm_substream *substream, ret =sdw_stream_add_master (&cdns->bus, &sconfig, pconfig, dma->nr_ports, dma->stream);if (ret) { -dev_err (cdns->dev,"add master to stream failed:%d" , ret); +dev_err (cdns->dev,"add master to stream failed:%d\n" , ret); goto stream_error; }
@@ -634,7 +634,7 @@ intel_hw_free(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) ret =sdw_stream_remove_master (&cdns->bus, dma->stream);if (ret <0 ) -dev_err (dai->dev,"remove master from stream %s failed: %d" , +dev_err (dai->dev,"remove master from stream %s failed: %d\n" , dma->stream->name, ret);intel_port_cleanup (dma);
@@ -883,7 +883,7 @@ static int intel_probe(struct platform_device *pdev)/* Register DAIs */ ret =intel_register_dai (sdw);if (ret) { -dev_err (sdw->cdns.dev,"DAI registration failed: %d" , ret); +dev_err (sdw->cdns.dev,"DAI registration failed: %d\n" , ret);snd_soc_unregister_component (sdw->cdns.dev); goto err_dai; }
drivers/soundwire/stream.c +55 -55
436 lines not on this page · raw message
Signature · 1 line
2.17.1
Quoted 13 lines · Pierre-Louis Bossart
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
Changes since v2:
fixed inversion ofdevm_kcallocparameters, detected while rebasing additional patches.Changes since v1:
added missing newlines in new patch (suggested by Joe Perches)
Quoted 6 lines
Pierre-Louis Bossart (5):
soundwire: intel: fix inversion indevm_kcallocparameters
soundwire: fix style issues
soundwire: bus: remove useless initializations
soundwire: stream: remove useless initialization of local variable
soundwire: add missing newlines in dynamic debug logs
All looked fine, for the series:
thanks,
Takashi
Quoted 4 lines · Pierre-Louis Bossart
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
Applied, 1, 3 and 4 (5 looked good but didnt apply)
Thanks
Quoted 31 lines
Changes since v2:
fixed inversion ofdevm_kcallocparameters, detected while rebasing additional patches.Changes since v1:
added missing newlines in new patch (suggested by Joe Perches)Pierre-Louis Bossart (5):
soundwire: intel: fix inversion indevm_kcallocparameters
soundwire: fix style issues
soundwire: bus: remove useless initializations
soundwire: stream: remove useless initialization of local variable
soundwire: add missing newlines in dynamic debug logsdrivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 137 ++++++++------- drivers/soundwire/bus.h | 16 +- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 99 +++++------ drivers/soundwire/cadence_master.h | 22 +-- drivers/soundwire/intel.c | 103 ++++++----- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +- drivers/soundwire/mipi_disco.c | 116 +++++++------ drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 267 +++++++++++++++-------------- 12 files changed, 404 insertions(+), 388 deletions(-)Signature · 1 line
2.17.1
Signature · 1 line
~Vinod
Quoted 7 lines · Vinod Koul
Quoted 4 lines · Pierre-Louis Bossart
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
Applied, 1, 3 and 4 (5 looked good but didnt apply)
this applies on top of Mark Brown's for-next tree. This should be the reference really for SoundWire work, if we start having another tree with deltas it's really counter productive. I already have dependencies on acpi...
Quoted 4 lines · Pierre-Louis Bossart
Quoted 1 line · Vinod Koul
On 10-04-19, 22:16, Pierre-Louis Bossart wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
Applied, 1, 3 and 4 (5 looked good but didnt apply)
this applies on top of Mark Brown's for-next tree. This should be the reference really for SoundWire work, if we start having another tree with deltas it's really counter productive. I already have dependencies on acpi...
Vinod, can you please double-check why patch 5 didn't work for you. I tried on Mark and Linus' trees and no issues, see below.
$ git reset --hard v5.1-rc5 HEAD is now at dc4060a5dc25 Linux 5.1-rc5
$ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml Applying: soundwire: intel: fix inversion in devm_kcalloc parameters Applying: soundwire: fix style issues Applying: soundwire: bus: remove useless initializations Applying: soundwire: stream: remove useless initialization of local variable Applying: soundwire: add missing newlines in dynamic debug logs
$ git reset --hard broonie/for-next HEAD is now at 84fdefca04a7 Merge branch 'asoc-5.2' into asoc-next
$ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml Applying: soundwire: intel: fix inversion in devm_kcalloc parameters Applying: soundwire: fix style issues Applying: soundwire: bus: remove useless initializations Applying: soundwire: stream: remove useless initialization of local variable Applying: soundwire: add missing newlines in dynamic debug logs