core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
v2019.04-rc3 sandbox U-Boot fails to boot when compiled with
-fsanitize=address and linked against -lasan, reporting [1].
Git bisecting shows that the issue is contributed by v2019.01 commit 1678754f5e2c ("core: ofnode: Fix ofnode_get_addr_index function").
The root cause seems to be the mismatch between sizeof(u64) and sizeof(fdt_size_t) on sandbox. Luckily, thanks to the fact that the size argument of both of_get_address() and fdtdec_get_addr_size_fixed() is optional, we can pass NULL in its place, avoiding the problem.
[1] Backtrace reported by ASAN (gcc 8.1.0):
$> ./u-boot -d arch/sandbox/dts/sandbox.dtb
[..]
=================================================================
==10998==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffcc2331140 at pc 0x0000004eeeb0 bp 0x7ffcc2330f80 sp 0x7ffcc2330f70 WRITE of size 8 at 0x7ffcc2331140 thread T0
#0 0x4eeeaf in of_get_address drivers/core/of_addr.c:154
#1 0x4f7441 in ofnode_get_addr_index drivers/core/ofnode.c:263
#2 0x5b2a78 in sb_eth_ofdata_to_platdata drivers/net/sandbox.c:422
#3 0x4dccd8 in device_probe drivers/core/device.c:407
#4 0x753170 in eth_initialize net/eth-uclass.c:428
#5 0x47d9bf in initr_net common/board_r.c:557
#6 0x6bcfa7 in initcall_run_list lib/initcall.c:30
#7 0x47e1fe in board_init_r common/board_r.c:859
#8 0x4060e5 in main arch/sandbox/cpu/start.c:356
#9 0x7fb8d135482f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#10 0x40a3a8 in _start (/path/to/u-boot/u-boot+0x40a3a8)Address 0x7ffcc2331140 is located in stack of thread T0 at offset 32 in frame
#0 0x4f72b8 in ofnode_get_addr_index drivers/core/ofnode.c:255
This frame has 3 object(s):
[32, 36) 'size' <== Memory access@offset 32 partially overflows this variable
[96, 100) 'flags'
[160, 168) 'node'HINT: this may be a false positive if your program uses some custom stack unwind mechanism or swapcontext
(longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-buffer-overflow drivers/core/of_addr.c:154 in of_get_address Shadow bytes around the buggy address:
0x10001845e1d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x10001845e1e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x10001845e1f0: 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1
0x10001845e200: 04 f2 f2 f2 f2 f2 f2 f2 04 f2 f2 f2 f2 f2 f2 f2
0x10001845e210: 04 f2 f2 f2 f3 f3 f3 f3 00 00 00 00 00 00 00 00
=>0x10001845e220: 00 00 00 00 f1 f1 f1 f1[04]f2 f2 f2 f2 f2 f2 f2
0x10001845e230: 04 f2 f2 f2 f2 f2 f2 f2 00 f2 f2 f2 f3 f3 f3 f3
0x10001845e240: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x10001845e250: 00 00 00 00 f1 f1 f1 f1 00 00 f2 f2 f3 f3 f3 f3
0x10001845e260: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1
0x10001845e270: f1 f1 00 f2 f2 f2 f3 f3 f3 f3 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb
==10998==ABORTING
'To' list:
git log --since=1year drivers/core/ofnode.c | grep "\-by: .*@" | \
sed 's/.*-by: //' | sort | uniq -c | sort -rn
10 Simon Glass <[email protected]>
3 Mario Six <[email protected]>
2 Martin Fuzzey <[email protected]>
2 Marek Vasut <[email protected]>
1 Tom Rini <[email protected]>
1 Masahiro Yamada <[email protected]> 1 Keerthy <[email protected]>
1 Jens Wiklander <[email protected]>
1 Bin Meng <[email protected]>
--- drivers/core/ofnode.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/core/ofnode.c +2 -3
@@ -254,14 +254,13 @@ int ofnode_read_size(ofnode node, const char *propname)fdt_addr_t ofnode_get_addr_index (ofnode node,int index) {int na, ns; -fdt_size_t size;if (ofnode_is_np (node)) {const __be32 *prop_val;uint flags; prop_val =of_get_address (ofnode_to_np (node), index, - (u64 *)&size, &flags); +NULL , &flags);if (!prop_val)return FDT_ADDR_T_NONE ;
@@ -278,7 +277,7 @@ fdt_addr_t ofnode_get_addr_index(ofnode node, int index) ns =ofnode_read_simple_size_cells (ofnode_get_parent (node));return fdtdec_get_addr_size_fixed (gd->fdt_blob,ofnode_to_offset (node),"reg" , - index, na, ns, &size, true); + index, na, ns,NULL , true); }return FDT_ADDR_T_NONE ;
Signature · 1 line
2.21.0
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
Quoted 87 lines · Eugeniu Rosca
v2019.04-rc3 sandbox U-Boot fails to boot when compiled with
-fsanitize=address and linked against -lasan, reporting [1].Git bisecting shows that the issue is contributed by v2019.01 commit
1678754f5e2c("core: ofnode: Fixofnode_get_addr_indexfunction").The root cause seems to be the mismatch between sizeof(u64) and
sizeof(fdt_size_t)on sandbox. Luckily, thanks to the fact that the size argument of bothof_get_address()andfdtdec_get_addr_size_fixed()is optional, we can pass NULL in its place, avoiding the problem.[1] Backtrace reported by ASAN (gcc 8.1.0):
$> ./u-boot -d
arch/sandbox/dts/sandbox.dtb
[..]
=================================================================
==10998==ERROR: AddressSanitizer: stack-buffer-overflow on address0x7ffcc2331140at pc0x0000004eeeb0bp0x7ffcc2330f80sp0x7ffcc2330f70WRITE of size 8 at0x7ffcc2331140thread T0#0 0x4eeeaf in of_get_address drivers/core/of_addr.c:154 #1 0x4f7441 in ofnode_get_addr_index drivers/core/ofnode.c:263 #2 0x5b2a78 in sb_eth_ofdata_to_platdata drivers/net/sandbox.c:422 #3 0x4dccd8 in device_probe drivers/core/device.c:407 #4 0x753170 in eth_initialize net/eth-uclass.c:428 #5 0x47d9bf in initr_net common/board_r.c:557 #6 0x6bcfa7 in initcall_run_list lib/initcall.c:30 #7 0x47e1fe in board_init_r common/board_r.c:859 #8 0x4060e5 in main arch/sandbox/cpu/start.c:356 #9 0x7fb8d135482f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f) #10 0x40a3a8 in _start (/path/to/u-boot/u-boot+0x40a3a8)Address
0x7ffcc2331140is located in stack of thread T0 at offset 32 in frame#0 0x4f72b8 in ofnode_get_addr_index drivers/core/ofnode.c:255This frame has 3 object(s):
[32, 36) 'size' <== Memory access@offset 32 partially overflows this variable [96, 100) 'flags' [160, 168) 'node'HINT: this may be a false positive if your program uses some custom stack unwind mechanism or swapcontext
(longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-buffer-overflowdrivers/core/of_addr.c:154inof_get_addressShadow bytes around the buggy address:
0x10001845e1d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x10001845e1e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x10001845e1f0: 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1
0x10001845e200: 04 f2 f2 f2 f2 f2 f2 f2 04 f2 f2 f2 f2 f2 f2 f2
0x10001845e210: 04 f2 f2 f2 f3 f3 f3 f3 00 00 00 00 00 00 00 00
=>0x10001845e220: 00 00 00 00 f1 f1 f1 f1[04]f2 f2 f2 f2 f2 f2 f2
0x10001845e230: 04 f2 f2 f2 f2 f2 f2 f2 00 f2 f2 f2 f3 f3 f3 f3
0x10001845e240: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x10001845e250: 00 00 00 00 f1 f1 f1 f1 00 00 f2 f2 f3 f3 f3 f3
0x10001845e260: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1
0x10001845e270: f1 f1 00 f2 f2 f2 f3 f3 f3 f3 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb==10998==ABORTING
'To' list:
git log --since=1yeardrivers/core/ofnode.c| grep "\-by: .*@" | \
sed 's/.*-by: //' | sort | uniq -c | sort -rn
10 Simon Glass <[email protected]>
3 Mario Six <[email protected]>
2 Martin Fuzzey <[email protected]>
2 Marek Vasut <[email protected]>
1 Tom Rini <[email protected]>
1 Masahiro Yamada <[email protected]> 1 Keerthy <[email protected]>
1 Jens Wiklander <[email protected]>
1 Bin Meng <[email protected]>
Quoted 5 lines
Fixes 1678754f5e2c ("core: ofnode: Fix ofnode_get_addr_index function")Signed-off-by Eugeniu Rosca <[email protected]>--- drivers/core/ofnode.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
Hello Simon,
On Sun, Mar 10, 2019 at 03:51:47PM -0600, Simon Glass wrote:
[..]
Quoted 1 line
Reviewed-by Simon Glass <[email protected]>
Can this fix go to u-boot-dm or is more review required?
Best regards,
Eugeniu.
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
Hi Eugeniu,
Quoted 9 lines · Eugeniu Rosca
Hello Simon,
On Sun, Mar 10, 2019 at 03:51:47PM -0600, Simon Glass wrote:
[..]Quoted 1 line
Reviewed-by Simon Glass <[email protected]>Can this fix go to u-boot-dm or is more review required?
Yes it looks like it is in my queue.
Regards,
Simon
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
Hi Simon,
CC: Tom, Yamada-san, Jiri, Stephen,
Quoted 10 lines · Simon Glass
Hi Eugeniu,
Quoted 7 lines · Eugeniu Rosca
Hello Simon,
On Sun, Mar 10, 2019 at 03:51:47PM -0600, Simon Glass wrote:
[..]Quoted 1 line
Reviewed-by Simon Glass <[email protected]>
Quoted 7 lines
Quoted 2 lines
Can this fix go to u-boot-dm or is more review required?
Yes it looks like it is in my queue.
Regards,
Simon
First, many thanks for pushing the fix to u-boot-dm.
Second, I would like to (repeatedly [0]) point out a pretty rare corruption of patch metadata, which places the 'Reviewed-by:' (and actually any other "*-by: ") signature on top of the '=====' line if the latter is present in commit description (see [1]).
As Yamada-san pointed out in [0], this is presumably caused by a patchwork bug and after some grepping through the patchwork git history, it looks like the issue is already fixed in patchwork master thanks to Jiri and Stephen via commit [2].
My guess is that the U-Boot patchwork version might not be containing this recent fix, hence still showcasing the wrong behavior?
FWIW, at least below U-Boot commits exhibit the same inconsistency:
u-boot $> for c in $(git log --format=%h --grep "^======="); \
do \
git log --format=%B -1 $c | grep -B 2 "^=======" | \
grep -q "by:.*@" && git --no-pager log --oneline -1 $c; \
done0506620f4f49 sata: sata_mv: Add DM support to enable CONFIG_BLK usage 9bfacf249b10 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address e1904f4530a3 common: avb_verify: Fix division by zero in mmc_byte_io() e91610da7c8a kconfig: re-sync with Linux 4.17-rc4e810565e23cd i.MX6DL: mamoj: Add PFUZE100 supportdda9892171c3 i.MX6DL: mamoj: Add I2C supporta0b0ff0ae643 arm: dra7xx: Fix Linux boot from eMMCf6d245b8c56c arm: am57xx: Fix Linux boot from eMMC67ff9e11f397 wandboard: move environment partition farther from u-boot.img
[0] https://marc.info/?l=u-boot&m=152643616902958&w=2
[1] http://git.denx.de/?p=u-boot.git;a=commitdiff;h=9bfacf249b10
[2] https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
("parser: fix parsing of patches with headings")
Best regards,
Eugeniu.
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
Quoted 55 lines · Eugeniu Rosca
Hi Simon,
CC: Tom, Yamada-san, Jiri, Stephen,Quoted 10 lines · Simon Glass
Hi Eugeniu,
Quoted 7 lines · Eugeniu Rosca
Hello Simon,
On Sun, Mar 10, 2019 at 03:51:47PM -0600, Simon Glass wrote:
[..]Quoted 1 line
Reviewed-by Simon Glass <[email protected]>Quoted 7 lines
Quoted 2 lines
Can this fix go to u-boot-dm or is more review required?
Yes it looks like it is in my queue.
Regards,
SimonFirst, many thanks for pushing the fix to u-boot-dm.
Second, I would like to (repeatedly [0]) point out a pretty rare corruption of patch metadata, which places the 'Reviewed-by:' (and actually any other "*-by: ") signature on top of the '=====' line if the latter is present in commit description (see [1]).
As Yamada-san pointed out in [0], this is presumably caused by a patchwork bug and after some grepping through the patchwork git history, it looks like the issue is already fixed in patchwork master thanks to Jiri and Stephen via commit [2].
My guess is that the U-Boot patchwork version might not be containing this recent fix, hence still showcasing the wrong behavior?
FWIW, at least below U-Boot commits exhibit the same inconsistency:
u-boot $> for c in $(git log --format=%h --grep "^======="); \ do \ git log --format=%B -1 $c | grep -B 2 "^=======" | \ grep -q "by:.*@" && git --no-pager log --oneline -1 $c; \ done
0506620f4f49sata:sata_mv: Add DM support to enableCONFIG_BLKusage9bfacf249b10core: ofnode: Fix ASAN-reported stack-buffer-overflow inof_get_addresse1904f4530a3common:avb_verify: Fix division by zero inmmc_byte_io()e91610da7c8akconfig: re-sync with Linux 4.17-rc4e810565e23cdi.MX6DL: mamoj: Add PFUZE100 supportdda9892171c3i.MX6DL: mamoj: Add I2C supporta0b0ff0ae643arm: dra7xx: Fix Linux boot from eMMCf6d245b8c56carm: am57xx: Fix Linux boot from eMMC67ff9e11f397wandboard: move environment partition farther from u-boot.img
Quoted 4 lines
[0] https://marc.info/?l=u-boot&m=152643616902958&w=2
[1] http://git.denx.de/?p=u-boot.git;a=commitdiff;h=9bfacf249b10
[2] https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
("parser: fix parsing of patches with headings")
Adding in Jeremy since we just use the ozlabs patchwork, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190414/0e8f7f0a/attachment.sig>
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
Hi Jeremy,
Would you kindly feedback if it's possible to include commit
https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
into U-Boot's patchwork to avoid occasional glitches in the description of U-Boot commits?
Quoted 65 lines · Tom Rini
Quoted 55 lines · Eugeniu Rosca
Hi Simon,
CC: Tom, Yamada-san, Jiri, Stephen,Quoted 10 lines · Simon Glass
Hi Eugeniu,
Quoted 7 lines · Eugeniu Rosca
Hello Simon,
On Sun, Mar 10, 2019 at 03:51:47PM -0600, Simon Glass wrote:
[..]Quoted 1 line
Reviewed-by Simon Glass <[email protected]>Quoted 7 lines
Quoted 2 lines
Can this fix go to u-boot-dm or is more review required?
Yes it looks like it is in my queue.
Regards,
SimonFirst, many thanks for pushing the fix to u-boot-dm.
Second, I would like to (repeatedly [0]) point out a pretty rare corruption of patch metadata, which places the 'Reviewed-by:' (and actually any other "*-by: ") signature on top of the '=====' line if the latter is present in commit description (see [1]).
As Yamada-san pointed out in [0], this is presumably caused by a patchwork bug and after some grepping through the patchwork git history, it looks like the issue is already fixed in patchwork master thanks to Jiri and Stephen via commit [2].
My guess is that the U-Boot patchwork version might not be containing this recent fix, hence still showcasing the wrong behavior?
FWIW, at least below U-Boot commits exhibit the same inconsistency:
u-boot $> for c in $(git log --format=%h --grep "^======="); \ do \ git log --format=%B -1 $c | grep -B 2 "^=======" | \ grep -q "by:.*@" && git --no-pager log --oneline -1 $c; \ done
0506620f4f49sata:sata_mv: Add DM support to enableCONFIG_BLKusage9bfacf249b10core: ofnode: Fix ASAN-reported stack-buffer-overflow inof_get_addresse1904f4530a3common:avb_verify: Fix division by zero inmmc_byte_io()e91610da7c8akconfig: re-sync with Linux 4.17-rc4e810565e23cdi.MX6DL: mamoj: Add PFUZE100 supportdda9892171c3i.MX6DL: mamoj: Add I2C supporta0b0ff0ae643arm: dra7xx: Fix Linux boot from eMMCf6d245b8c56carm: am57xx: Fix Linux boot from eMMC67ff9e11f397wandboard: move environment partition farther from u-boot.imgQuoted 4 lines
[0] https://marc.info/?l=u-boot&m=152643616902958&w=2
[1] http://git.denx.de/?p=u-boot.git;a=commitdiff;h=9bfacf249b10
[2] https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
("parser: fix parsing of patches with headings")Adding in Jeremy since we just use the ozlabs patchwork, thanks!
Signature · 1 line
Tom
Signature · 2 lines
Best Regards, Eugeniu.
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
Quoted 6 lines · Eugeniu Rosca
Hi Jeremy,
Would you kindly feedback if it's possible to include commit
https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
into U-Boot's patchwork to avoid occasional glitches in the description of U-Boot commits?
This is included in 2.1.1 [1] which patchwork.ozlabs.org was recently updated to [2], so you should have this fix now. Let me know if I've missed something.
Stephen
[1] https://github.com/getpatchwork/patchwork/commit/8060b9a671
[2] https://lists.ozlabs.org/pipermail/patchwork/2019-April/005746.html
Quoted 76 lines · Tom Rini
Quoted 75 lines · Eugeniu Rosca
Quoted 64 lines
Hi Simon,
CC: Tom, Yamada-san, Jiri, Stephen,Quoted 10 lines · Simon Glass
Hi Eugeniu,
Quoted 6 lines · Eugeniu Rosca
Hello Simon,
On Sun, Mar 10, 2019 at 03:51:47PM -0600, Simon Glass wrote:
[..]Quoted 1 line
Reviewed-by Simon Glass <[email protected]>Quoted 7 lines
Quoted 2 lines
Can this fix go to u-boot-dm or is more review required?
Yes it looks like it is in my queue.
Regards,
SimonFirst, many thanks for pushing the fix to u-boot-dm.
Second, I would like to (repeatedly [0]) point out a pretty rare corruption of patch metadata, which places the 'Reviewed-by:' (and actually any other "*-by: ") signature on top of the '=====' line if the latter is present in commit description (see [1]).
As Yamada-san pointed out in [0], this is presumably caused by a patchwork bug and after some grepping through the patchwork git history, it looks like the issue is already fixed in patchwork master
thanks to Jiri and Stephen via commit [2].My guess is that the U-Boot patchwork version might not be containing
this recent fix, hence still showcasing the wrong behavior?FWIW, at least below U-Boot commits exhibit the same inconsistency:
u-boot $> for c in $(git log --format=%h --grep "^======="); \ do \ git log --format=%B -1 $c | grep -B 2 "^=======" | \ grep -q "by:.*@" && git --no-pager log --oneline -1$c; \
done
0506620f4f49sata:sata_mv: Add DM support to enableCONFIG_BLKusage9bfacf249b10core: ofnode: Fix ASAN-reported stack-buffer- overflow inof_get_addresse1904f4530a3common:avb_verify: Fix division by zero inmmc_byte_io()e91610da7c8akconfig: re-sync with Linux 4.17-rc4e810565e23cdi.MX6DL: mamoj: Add PFUZE100 supportdda9892171c3i.MX6DL: mamoj: Add I2C supporta0b0ff0ae643arm: dra7xx: Fix Linux boot from eMMCf6d245b8c56carm: am57xx: Fix Linux boot from eMMC67ff9e11f397wandboard: move environment partition farther from u-boot.imgQuoted 5 lines
[0] https://marc.info/?l=u-boot&m=152643616902958&w=2
[1] http://git.denx.de/?p=u-boot.git;a=commitdiff;h=9bfacf249b10
[2]
https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
("parser: fix parsing of patches with headings")Adding in Jeremy since we just use the ozlabs patchwork, thanks!
Signature · 1 line
Tom
PATCH 1/1 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
Hi Stephen,
Quoted 11 lines · Stephen Finucane
Quoted 6 lines · Eugeniu Rosca
Hi Jeremy,
Would you kindly feedback if it's possible to include commit
https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
into U-Boot's patchwork to avoid occasional glitches in the description of U-Boot commits?This is included in 2.1.1 [1] which patchwork.ozlabs.org was recently updated to [2], so you should have this fix now. Let me know if I've missed something.
Thanks for the input. I will let you know if there are any Reviewed-by signatures climbing erratically in my next patches :)
Quoted 5 lines
Stephen
[1] https://github.com/getpatchwork/patchwork/commit/8060b9a671
[2] https://lists.ozlabs.org/pipermail/patchwork/2019-April/005746.html
--
Best regards,
Eugeniu.