Skip to contentSkip to conversation

cryptodev: update SRCREV

PATCH In review [email protected] 3 participants 5 messages Apr 15, 2019 – Apr 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cryptodev: update SRCREV

From: Kai Kang <[email protected]>

Update SRCREV of cryptodev which only contains one fix for linux 5.0:

$ git log fd8b15ef1c8398a69a37932ee48c74ab40329a29..f971e0cd4a0ebe59fb2e8e17240399bf6901b09b
commit f971e0cd4a0ebe59fb2e8e17240399bf6901b09b
Author: Derald D. Woods <[email protected]>
Date:   Sun Feb 10 13:22:19 2019 -0600

Fix module loading with Linux v5.0-rc5

This commit fixes this module load error:
[...]
[ 29.112091] cryptodev: loading out-of-tree module taints kernel.
[ 29.128906] cryptodev: Unknown symbol crypto_givcipher_type (err -2)
[ 29.188842] cryptodev: Unknown symbol crypto_givcipher_type (err -2)
modprobe: can't load module cryptodev (extra/cryptodev.ko): unknown symbol in module, or unknown parameter [...]

Upstream Linux support for unused GIVCIPHER, and others, was dropped here:

c79b411eaa72 (crypto: skcipher - remove remnants of internal IV generators)

---
 meta/recipes-kernel/cryptodev/cryptodev.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/cryptodev/cryptodev.inc +1 -1
index 252d39d23a..79ddefd435 100644
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux"
-SRCREV = "fd8b15ef1c8398a69a37932ee48c74ab40329a29"
+SRCREV = "f971e0cd4a0ebe59fb2e8e17240399bf6901b09b"
 
 S = "${WORKDIR}/git"
 
Signature · 1 line
2.20.0
#1 lore raw
Quoted 7 lines · On Sun, Apr 14, 2019 at 11:42:31PM -0400, [email protected] wrote:

From: Kai Kang <[email protected]>

Update SRCREV of cryptodev which only contains one fix for linux 5.0:
...

meta/recipes-kernel/cryptodev/cryptodev.inc LICENSE = "GPLv2" · line 9

Quoted 7 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +1 -1
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux"
-SRCREV = "fd8b15ef1c8398a69a37932ee48c74ab40329a29"
+SRCREV = "f971e0cd4a0ebe59fb2e8e17240399bf6901b09b"
 
 S = "${WORKDIR}/git"

This moves cryptodev from a release to a git snapshot, but no PV is set to show that.

It is a systematic problem caused by the switch to git hashes for releases that random git snapshots look exactly the same as releases without any clean way to see what a commit actually is.

IMHO this needs support for tags, and then checks like (pseudo-code)
if(TAG) (commit(TAG) == SRCREV)
TAG xor (PV contains "+git")

Short-term for the suggested change in cryptodev the "which only contains one fix" is correct, and this is not much different from adding the fix as .patch which also wouldn't change PV.
So no objection from me to applying the suggested patch as-is.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#2 lore raw
In reply to [email protected]
Quoted 11 lines · On 2019/4/15 上午11:42, [email protected] wrote:

From: Kai Kang <[email protected]>

Update SRCREV of cryptodev which only contains one fix for linux 5.0:

$ git log fd8b15ef1c8398a69a37932ee48c74ab40329a29..f971e0cd4a0ebe59fb2e8e17240399bf6901b09b
commit f971e0cd4a0ebe59fb2e8e17240399bf6901b09b
Author: Derald D. Woods <[email protected]>
Date:   Sun Feb 10 13:22:19 2019 -0600

Fix module loading with Linux v5.0-rc5

Quoted 7 lines

This commit fixes this module load error:
[...]
[ 29.112091] cryptodev: loading out-of-tree module taints kernel.
[ 29.128906] cryptodev: Unknown symbol crypto_givcipher_type (err -2)
[ 29.188842] cryptodev: Unknown symbol crypto_givcipher_type (err -2)
modprobe: can't load module cryptodev (extra/cryptodev.ko): unknown symbol in module, or unknown parameter [...]

Without this patch it fails to modprobe module cryptodev. Ping.

Kai

Quoted 25 lines

Upstream Linux support for unused GIVCIPHER, and others, was dropped here:

c79b411eaa72 (crypto: skcipher - remove remnants of internal IV generators)

---
  meta/recipes-kernel/cryptodev/cryptodev.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/cryptodev/cryptodev.inc +1 -1
index 252d39d23a..79ddefd435 100644
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"
  LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
  SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux"
-SRCREV = "fd8b15ef1c8398a69a37932ee48c74ab40329a29"
+SRCREV = "f971e0cd4a0ebe59fb2e8e17240399bf6901b09b"
 
  S = "${WORKDIR}/git"
 
Signature · 1 line
Kai Kang
#3 lore raw

I'd prefer this to be applying the patch, which also makes the fix easier to backport.

Ross

Quoted 62 lines · Kang Kai
Quoted 11 lines · On 2019/4/15 上午11:42, [email protected] wrote:

From: Kai Kang <[email protected]>

Update SRCREV of cryptodev which only contains one fix for linux 5.0:

$ git log fd8b15ef1c8398a69a37932ee48c74ab40329a29..f971e0cd4a0ebe59fb2e8e17240399bf6901b09b
commit f971e0cd4a0ebe59fb2e8e17240399bf6901b09b
Author: Derald D. Woods <[email protected]>
Date:   Sun Feb 10 13:22:19 2019 -0600

Fix module loading with Linux v5.0-rc5

Quoted 7 lines

This commit fixes this module load error:
[...]
[ 29.112091] cryptodev: loading out-of-tree module taints kernel.
[ 29.128906] cryptodev: Unknown symbol crypto_givcipher_type (err -2)
[ 29.188842] cryptodev: Unknown symbol crypto_givcipher_type (err -2)
modprobe: can't load module cryptodev (extra/cryptodev.ko): unknown symbol in module, or unknown parameter [...]

Without this patch it fails to modprobe module cryptodev. Ping.

Kai

Quoted 17 lines

Upstream Linux support for unused GIVCIPHER, and others, was dropped here:

c79b411eaa72 (crypto: skcipher - remove remnants of internal IV generators)

---
  meta/recipes-kernel/cryptodev/cryptodev.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/cryptodev/cryptodev.inc +0 -0
index 252d39d23a..79ddefd435 100644

meta/recipes-kernel/cryptodev/cryptodev.inc LICENSE = "GPLv2" · line 10

Quoted 8 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +1 -1
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"
  LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
  SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux"
-SRCREV = "fd8b15ef1c8398a69a37932ee48c74ab40329a29"
+SRCREV = "f971e0cd4a0ebe59fb2e8e17240399bf6901b09b"
 
  S = "${WORKDIR}/git"
 

--
Kai Kang

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#4 lore raw
Quoted 2 lines · Ross

I'd prefer this to be applying the patch, which also makes the fix easier to backport.

OK. I'll send v2 to apply the the patch.

Regards,
Kai

Quoted 62 lines

Ross

Quoted 58 lines · Kang Kai
Quoted 11 lines · On 2019/4/15 上午11:42, [email protected] wrote:

From: Kai Kang <[email protected]>

Update SRCREV of cryptodev which only contains one fix for linux 5.0:

$ git log fd8b15ef1c8398a69a37932ee48c74ab40329a29..f971e0cd4a0ebe59fb2e8e17240399bf6901b09b
commit f971e0cd4a0ebe59fb2e8e17240399bf6901b09b
Author: Derald D. Woods <[email protected]>
Date:   Sun Feb 10 13:22:19 2019 -0600

Fix module loading with Linux v5.0-rc5

Quoted 7 lines

This commit fixes this module load error:
[...]
[ 29.112091] cryptodev: loading out-of-tree module taints kernel.
[ 29.128906] cryptodev: Unknown symbol crypto_givcipher_type (err -2)
[ 29.188842] cryptodev: Unknown symbol crypto_givcipher_type (err -2)
modprobe: can't load module cryptodev (extra/cryptodev.ko): unknown symbol in module, or unknown parameter [...]

Without this patch it fails to modprobe module cryptodev. Ping.

Kai

Quoted 16 lines

Upstream Linux support for unused GIVCIPHER, and others, was dropped here:

c79b411eaa72 (crypto: skcipher - remove remnants of internal IV generators)

---
   meta/recipes-kernel/cryptodev/cryptodev.inc | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/cryptodev/cryptodev.inc +0 -0
index 252d39d23a..79ddefd435 100644

meta/recipes-kernel/cryptodev/cryptodev.inc LICENSE = "GPLv2" · line 10

Quoted 8 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +1 -1
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"
   LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
   SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux"
-SRCREV = "fd8b15ef1c8398a69a37932ee48c74ab40329a29"
+SRCREV = "f971e0cd4a0ebe59fb2e8e17240399bf6901b09b"
 
   S = "${WORKDIR}/git"
 

--
Kai Kang

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line
Kai Kang