net: fec_mxc: not access reserved register on i.MX8
PATCH 1/1 net: fec_mxc: not access reserved register on i.MX8
We should not access reserved register on i.MX8, otherwise met SERROR
--- drivers/net/fec_mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/fec_mxc.c +1 -1
@@ -604,7 +604,7 @@ static int fec_init(struct eth_device *dev, bd_t *bd)writel (0x00000000 , &fec->eth->gaddr2);/* Do not access reserved register */ -if (!is_mx6ul () && !is_mx6ull () && !is_imx8m ()) { +if (!is_mx6ul () && !is_mx6ull () && !is_imx8 () && !is_imx8m ()) {/* clear MIB RAM */ for (i = mib_ptr; i <= mib_ptr +0xfc ; i +=4 )writel (0 , i);
Signature · 1 line
2.16.4
PATCH 1/1 net: fec_mxc: not access reserved register on i.MX8
Quoted 4 lines · Peng Fan
We should not access reserved register on i.MX8, otherwise met SERROR
Signed-off-by Peng Fan <[email protected]>
PATCH 1/1 net: fec_mxc: not access reserved register on i.MX8
In reply to Peng FanHi Stefano,
I do not see this patch applied to your tree, would you pick it up?
Patchwork: https://patchwork.ozlabs.org/patch/1085432/
Thanks,
Peng.
Quoted 24 lines
Subject: [PATCH] net:
fec_mxc: not access reserved register on i.MX8We should not access reserved register on i.MX8, otherwise met SERROR
Signed-off-by Peng Fan <[email protected]>--- drivers/net/fec_mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/fec_mxc.c index renamed from drivers/net/fec_mxc.c +0
-0
84f010d805..097bbd090f100644drivers/net/fec_mxc.c +1
-2@@ -604,7 +604,7 @@ static int fec_init(struct eth_device *dev, bd_t *bd)writel (0x00000000 , &fec->eth->gaddr2);/* Do not access reserved register */ -if (!is_mx6ul () && !is_mx6ull () && !is_imx8m ()) { +if (!is_mx6ul () && !is_mx6ull () && !is_imx8 () && !is_imx8m ()) {/* clear MIB RAM */ for (i = mib_ptr; i <= mib_ptr +0xfc ; i +=4 )writel (0 , i); --2.16.4
PATCH 1/1 net: fec_mxc: not access reserved register on i.MX8
In reply to Peng FanQuoted 6 lines · On Mon, 15 Apr 2019 05:18:33 +0000 Peng Fan peng.fan at nxp.com wrote:
We should not access reserved register on i.MX8, otherwise met SERROR
Signed-off-by Peng Fan <[email protected]>--- drivers/net/fec_mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-staging/agust at denx.de, thanks!
--
Anatolij
PATCH 1/1 net: fec_mxc: not access reserved register on i.MX8
Hi Anatolji,
Quoted 12 lines · Anatolij Gustschin
Quoted 6 lines · On Mon, 15 Apr 2019 05:18:33 +0000 Peng Fan peng.fan at nxp.com wrote:
We should not access reserved register on i.MX8, otherwise met SERROR
Signed-off-by Peng Fan <[email protected]>--- drivers/net/fec_mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Applied to u-boot-staging/agust at denx.de, thanks!
I have this in u-boot-imx, too, but I do not think it is a problem when we send PR to Tom.
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 net: fec_mxc: not access reserved register on i.MX8
Hi Stefano,
On Mon, 10 Jun 2019 15:02:37 +0200
Stefano Babic sbabic at denx.de wrote:
...
Quoted 2 lines
I have this in u-boot-imx, too, but I do not think it is a problem when we send PR to Tom.
OK, thanks! Yes, it shouldn't be a problem.
--
Anatolij