Skip to contentSkip to conversation

gvfs: fix typo libexec

PATCH In review [email protected] 2 participants 3 messages Apr 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gvfs: fix typo libexec

From: Kai Kang <[email protected]>

I believe ${libexec} is a typo here which should be ${libexecdir}. Otherwise, the execute bit of ${datadir}/polkit-1/rules.d will be set and previous workaround which chmod ${datadir}/polkit-1/rules.d does not work.

Replace tab with spaces at same time.

---
 meta-gnome/recipes-gnome/gvfs/gvfs_1.40.0.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta-gnome/recipes-gnome/gvfs/gvfs_1.40.0.bb +3 -3
index 8fed9e825..35367ae11 100644
@@ -63,14 +63,14 @@ PACKAGECONFIG[cdda] = "-Dcdda=true, -Dcdda=false, libcdio-paranoia"
 
 do_install_append() {
     # Fix up permissions on polkit rules.d to work with rpm4 constraints
-	chmod 700 ${D}/${datadir}/polkit-1/rules.d
-	chown polkitd:root ${D}/${datadir}/polkit-1/rules.d
+    chmod 700 ${D}/${datadir}/polkit-1/rules.d
+    chown polkitd:root ${D}/${datadir}/polkit-1/rules.d
 
     # After rebuilds (not from scracth) it can happen that the executables in
     # libexec ar missing executable permission flag. Not sure but it came up
     # during transition to meson. Looked into build files and logs but could
     # not find suspicious
-    for exe in `find ${D}/${libexec}`; do
+    for exe in `find ${D}/${libexecdir}`; do
        chmod +x $exe
     done
 
Signature · 1 line
2.20.0
#1 lore raw
Quoted 8 lines · On Mon, Apr 15, 2019 at 8:32 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

I believe ${libexec} is a typo here which should be ${libexecdir}. Otherwise, the execute bit of ${datadir}/polkit-1/rules.d will be set and previous workaround which chmod ${datadir}/polkit-1/rules.d does not work.

Thanks - for fixing and I think it explains the other issue: Systemd service adjustment can go now - it was caused by the typo either

Andreas

#2 lore raw
Quoted 5 lines · Andreas Müller
Quoted 3 lines · On Mon, Apr 15, 2019 at 8:32 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Quoted 8 lines
Quoted 5 lines

I believe ${libexec} is a typo here which should be ${libexecdir}. Otherwise, the execute bit of ${datadir}/polkit-1/rules.d will be set and previous workaround which chmod ${datadir}/polkit-1/rules.d does not work.

Thanks - for fixing and I think it explains the other issue: Systemd service adjustment can go now - it was caused by the typo either

Will send a follow-up for systemd user units