toolchain-external/Config.in: Allow to select custom external-toolchain package
RFC 1/1 toolchain-external/Config.in: Allow to select custom external-toolchain package
Add dummy 'Other' external toolchain option which allows to select custom external-toolchain project, e.g. from external project tree.
--- toolchain/toolchain-external/Config.in | 6 ++++++ 1 file changed, 6 insertions(+)
toolchain/toolchain-external/Config.in +6 -0
@@ -47,6 +47,12 @@ source "toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Confi # architecture. source "toolchain/toolchain-external/toolchain-external-custom/Config.in" +config BR2_TOOLCHAIN_EXTERNAL_OTHER + bool "Other" + help + Use this option to use a external toolchain from custom package + (e.g. in external project). + endchoice choice
Signature · 1 line
2.14.1
RFC 1/1 toolchain-external/Config.in: Allow to select custom external-toolchain package
Hi Vadim,
Quoted 13 lines · Vadim Kochan
Add dummy 'Other' external toolchain option which allows to select custom external-toolchain project, e.g. from external project tree.
Signed-off-by Vadim Kochan <[email protected]>--- toolchain/toolchain-external/Config.in | 6 ++++++ 1 file changed, 6 insertions(+)toolchain/toolchain-external/Config.in +0
-0
toolchain/toolchain-external/Config.in source "toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Confi · line 54
Quoted 8 lines
toolchain/toolchain-external/Config.in +5
-0@@ -47,6 +47,12 @@ source "toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Confi # architecture. source "toolchain/toolchain-external/toolchain-external-custom/Config.in" +config BR2_TOOLCHAIN_EXTERNAL_OTHER + bool "Other" + help + Use this option to use a external toolchain from custom package + (e.g. in external project).
So, the idea is to extend the choice with toolchains that come fromBR2_EXTERNAL and that you can't select here, right? And you need something like that because it's a choice, and there's no way to extend the choice in a different Kconfig file.
I think this is a worthwhile idea, so I'd like to work it out a little more...
Adding Yann in Cc since he like that kind of external craziness :-)
If kept like this, then I think you should make it depend on a new (blind)BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLE option, and that an external toolchain package should select that option. This way, the option is only available if your external tree actually makes one available.
Also, it should be documented in docs/manual/customize-outside-br.txt.
However, it's still pretty inconvenient for the user. So perhaps we could
explicitly extend the external infra to generate a .br2-external.toolchain.in that is included from here. This file would be populated based on the file toolchain/Config.in in the external.
Thomas, is that idea over-engineered?
Regards,
Arnout
Quoted 5 lines
toolchain/toolchain-external/Config.in +1
-0+ endchoice choice
RFC 1/1 toolchain-external/Config.in: Allow to select custom external-toolchain package
Hello,
Quoted 19 lines · On Sun, 14 Apr 2019 23:39:38 +0200 Arnout Vandecappelle <[email protected]> wrote:
toolchain/toolchain-external/Config.in source "toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Confi · line 54
Quoted 5 lines
toolchain/toolchain-external/Config.in +5
-0+config BR2_TOOLCHAIN_EXTERNAL_OTHER + bool "Other" + help + Use this option to use a external toolchain from custom package + (e.g. in external project).So, the idea is to extend the choice with toolchains that come from
BR2_EXTERNALand that you can't select here, right? And you need something like that because it's a choice, and there's no way to extend the choice in a differentKconfigfile.I think this is a worthwhile idea, so I'd like to work it out a little more...
Adding Yann in Cc since he like that kind of external craziness :-)If kept like this, then I think you should make it depend on a new (blind)
BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLEoption, and that an external toolchain package should select that option. This way, the option is only available if your external tree actually makes one available.
Quoted 8 lines
Also, it should be documented in
docs/manual/customize-outside-br.txt.However, it's still pretty inconvenient for the user. So perhaps we could
explicitly extend the external infra to generate a .br2-external.toolchain.in that is included from here. This file would be populated based on the file toolchain/Config.in in the external.Thomas, is that idea over-engineered?
It is over-engineered, but there is not much choice if we want to allow implementing external toolchains in BR2_EXTERNAL, which would definitely be useful.
The downside of Vadim's approach is that it limits the BR2_EXTERNAL to implementing only one external toolchain, since it's only adding one entry to the choice. Your approach would be more flexible.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
RFC 1/1 toolchain-external/Config.in: Allow to select custom external-toolchain package
Quoted 23 lines · Thomas Petazzoni
Hello,
Quoted 18 lines · On Sun, 14 Apr 2019 23:39:38 +0200 Arnout Vandecappelle <[email protected]> wrote:
toolchain/toolchain-external/Config.in source "toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Confi · line 54
Quoted 5 lines
toolchain/toolchain-external/Config.in +5
-0+config BR2_TOOLCHAIN_EXTERNAL_OTHER + bool "Other" + help + Use this option to use a external toolchain from custom package + (e.g. in external project).So, the idea is to extend the choice with toolchains that come from
BR2_EXTERNALand that you can't select here, right? And you need something like that because it's a choice, and there's no way to extend the choice in a differentKconfigfile.I think this is a worthwhile idea, so I'd like to work it out a little more...
Adding Yann in Cc since he like that kind of external craziness :-)If kept like this, then I think you should make it depend on a new (blind)
BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLEoption, and that an external toolchain package should select that option. This way, the option is only available if your external tree actually makes one available.
I forgot to mention how this option should be constructed... In the
toolchain-external's Config.in, you would have
config BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLE
bool
And in the br2-external Config.in:
config BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLE
bool
default y
(Kconfig language allows the same symbol to be declared in different places, as long as the definitions are consistent.)
Quoted 9 lines
Quoted 8 lines
Also, it should be documented in
docs/manual/customize-outside-br.txt.However, it's still pretty inconvenient for the user. So perhaps we could
explicitly extend the external infra to generate a .br2-external.toolchain.in that is included from here. This file would be populated based on the file toolchain/Config.in in the external.Thomas, is that idea over-engineered?
Quoted 7 lines
It is over-engineered, but there is not much choice if we want to allow implementing external toolchains in
BR2_EXTERNAL, which would definitely be useful.The downside of Vadim's approach is that it limits the
BR2_EXTERNALto implementing only one external toolchain, since it's only adding one entry to the choice. Your approach would be more flexible.
Well, you *can* still add a second choice in the br2-external. But then having
multiple options from multiple br2-externals becomes difficult...
Regards,
Arnout
RFC 1/1 toolchain-external/Config.in: Allow to select custom external-toolchain package
Arnout, Thomas, All,
On 2019-04-15 10:54 +0200, Arnout Vandecappelle spake thusly:
Quoted 13 lines · Thomas Petazzoni
Quoted 12 lines
On Sun, 14 Apr 2019 23:39:38 +0200
Quoted 11 lines
toolchain/toolchain-external/Config.in source "toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Confi · line 54
Quoted 5 lines
toolchain/toolchain-external/Config.in +5
-0+config BR2_TOOLCHAIN_EXTERNAL_OTHER + bool "Other" + help + Use this option to use a external toolchain from custom package + (e.g. in external project).So, the idea is to extend the choice with toolchains that come from
BR2_EXTERNALand that you can't select here, right? And you need something like that because it's a choice, and there's no way to extend the choice in a differentKconfigfile.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I think this is a worthwhile idea, so I'd like to work it out a little more...
Adding Yann in Cc since he like that kind of external craziness :-)
Aha! It's bneen quite a long time I've thought about doing exactly that, but I always postponed it because, well, 24h in a day...
Quoted 11 lines
Quoted 4 lines
Quoted 4 lines
If kept like this, then I think you should make it depend on a new (blind)
BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLEoption, and that an external toolchain package should select that option. This way, the option is only available if your external tree actually makes one available.I forgot to mention how this option should be constructed... In the
toolchain-external's Config.in, you would haveconfig
BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLE
bool
Quoted 8 lines
And in the br2-external Config.in:
config
BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLE
bool
default y(
Kconfiglanguage allows the same symbol to be declared in different places, as long as the definitions are consistent.)
I was thinking about an alternative, instead, where all the external toolchains are gathered in that choice.
If we go with your solution, then a br2-external may have its own choice, e.g.:
choice
bool "my toolchains"
config BR2_MINE_TC_1
bool "mine-1"
config BR2_MINE_TC_2
bool "mine-2"
endchoiceAnd a second br2-external would have something similar:
choice
bool "your toolchains"
config BR2_YOURS_TC_1
bool "yours-1"
config BR2_YOURS_TC_2
bool "yours-2"
endchoiceSince it is possible to use those two br2-external trees at once, there would obviously be a problem here, with two toolchians being selected...
The proposal from Vadym would not even allow that either, because the choices would have to be both guarded by the same depends on BR2_TOOLCHAIN_EXTERNAL_OTHER, so we'd be back to square one anyway...
The only way to make this workable is to gather all the toolchain symbols under a unique choice.
Quoted 13 lines
Quoted 13 lines
Quoted 8 lines
Also, it should be documented in
docs/manual/customize-outside-br.txt.However, it's still pretty inconvenient for the user. So perhaps we could
explicitly extend the external infra to generate a .br2-external.toolchain.in that is included from here. This file would be populated based on the file toolchain/Config.in in the external.Thomas, is that idea over-engineered?
It is over-engineered, but there is not much choice if we want to allow implementing external toolchains in
BR2_EXTERNAL, which would definitely be useful.
Quoted 6 lines
Quoted 3 lines
The downside of Vadim's approach is that it limits the
BR2_EXTERNALto implementing only one external toolchain, since it's only adding one entry to the choice. Your approach would be more flexible.Well, you *can* still add a second choice in the br2-external. But then having
multiple options from multiple br2-externals becomes difficult...
Exactly.
I don't see any other way than to aggregate all into the same choice...
The reason why I did not yet work or provide this, is because I would also like to have a generic way to doing such a thing.
For example, we have a choice for libjpeg, but it does not allow for a custom implementation to be provided by a br2external tree, with some vendors having an API-compatible libjpeg that is optimised for their SoC for example.
And providing something generic is far from trivial... :-(
However, as a first step, having something ad-hoc for the toolchains would be a net improvement nonetheless...
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC 1/1 toolchain-external/Config.in: Allow to select custom external-toolchain package
Hi All,
Quoted 108 lines · Yann E. MORIN
Arnout, Thomas, All,
On 2019-04-15 10:54 +0200, Arnout Vandecappelle spake thusly:
Quoted 13 lines · Thomas Petazzoni
Quoted 12 lines
On Sun, 14 Apr 2019 23:39:38 +0200
Quoted 11 lines
toolchain/toolchain-external/Config.in source "toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Confi · line 54
Quoted 5 lines
toolchain/toolchain-external/Config.in +5
-0+config BR2_TOOLCHAIN_EXTERNAL_OTHER + bool "Other" + help + Use this option to use a external toolchain from custom package + (e.g. in external project).So, the idea is to extend the choice with toolchains that come from
BR2_EXTERNALand that you can't select here, right? And you need something like that because it's a choice, and there's no way to extend the choice in a differentKconfigfile.Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I think this is a worthwhile idea, so I'd like to work it out a little more...
Adding Yann in Cc since he like that kind of external craziness :-)Aha! It's bneen quite a long time I've thought about doing exactly that, but I always postponed it because, well, 24h in a day...
Quoted 11 lines
Quoted 4 lines
Quoted 4 lines
If kept like this, then I think you should make it depend on a new (blind)
BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLEoption, and that an external toolchain package should select that option. This way, the option is only available if your external tree actually makes one available.I forgot to mention how this option should be constructed... In the
toolchain-external's Config.in, you would haveconfig
BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLE
boolQuoted 8 lines
And in the br2-external Config.in:
config
BR2_TOOLCHAIN_EXTERNAL_OTHER_AVAILABLE
bool
default y(
Kconfiglanguage allows the same symbol to be declared in different places, as long as the definitions are consistent.)I was thinking about an alternative, instead, where all the external toolchains are gathered in that choice.
If we go with your solution, then a br2-external may have its own choice, e.g.:
choice bool "my toolchains" config BR2_MINE_TC_1 bool "mine-1" config BR2_MINE_TC_2 bool "mine-2" endchoiceAnd a second br2-external would have something similar:
choice bool "your toolchains" config BR2_YOURS_TC_1 bool "yours-1" config BR2_YOURS_TC_2 bool "yours-2" endchoiceSince it is possible to use those two br2-external trees at once, there would obviously be a problem here, with two toolchians being selected...
The proposal from Vadym would not even allow that either, because the choices would have to be both guarded by the same depends on
BR2_TOOLCHAIN_EXTERNAL_OTHER, so we'd be back to square one anyway...The only way to make this workable is to gather all the toolchain symbols under a unique choice.
Quoted 13 lines
Quoted 13 lines
Quoted 8 lines
Also, it should be documented in
docs/manual/customize-outside-br.txt.However, it's still pretty inconvenient for the user. So perhaps we could
explicitly extend the external infra to generate a .br2-external.toolchain.in that is included from here. This file would be populated based on the file toolchain/Config.in in the external.Thomas, is that idea over-engineered?
It is over-engineered, but there is not much choice if we want to allow implementing external toolchains in
BR2_EXTERNAL, which would definitely be useful.Quoted 6 lines
Quoted 3 lines
The downside of Vadim's approach is that it limits the
BR2_EXTERNALto implementing only one external toolchain, since it's only adding one entry to the choice. Your approach would be more flexible.Well, you *can* still add a second choice in the br2-external. But then having
multiple options from multiple br2-externals becomes difficult...Exactly.
I don't see any other way than to aggregate all into the same choice...
The reason why I did not yet work or provide this, is because I would also like to have a generic way to doing such a thing.
For example, we have a choice for libjpeg, but it does not allow for a custom implementation to be provided by a br2external tree, with some vendors having an API-compatible libjpeg that is optimised for their SoC for example.
Quoted 5 lines
And providing something generic is far from trivial... :-(
However, as a first step, having something ad-hoc for the toolchains would be a net improvement nonetheless...
So, the solution with aggregation external tree toolchains into .br2-external.in.toolchain and then include it into toolchain/toolchain-external/Config.in looks good, and it is worth to try to implement ?
Regards,
Vadim Kochan
RFC 1/1 toolchain-external/Config.in: Allow to select custom external-toolchain package
Quoted 4 lines · Vadim Kochan
So, the solution with aggregation external tree toolchains into .br2-external.in.toolchain and then include it into toolchain/toolchain-external/Config.in looks good, and it is worth to try to implement ?
We all seem to agree that that is the only way to do it, indeed.
In my earlier mail I said it would be $BR2_EXTERNAL_FOO/toolchain/Config.in
that would get included in there, but it should actually be $BR2_EXTERNAL_FOO/toolchain-external/Config.in
Make sure that you post an RFC pretty early so we can check if we all really
agree on the direction.
Regards,
Arnout