Skip to contentSkip to conversation

infra/pkg-generic: Add rootfs post gen hook

RFC New Vadim Kochan 3 participants 7 messages Apr 15, 2019 VFS

lore
Share & tools
lore
#0 lore raw

RFC 1/1 infra/pkg-generic: Add rootfs post gen hook

Add ability to generate image by custom package, and one of the way to do it - is to add new $(PKG)_ROOTFS_POST_GEN_HOOK which will be called after rootfs image is ready. This allows to have easier alternative to post-image script in form of package, which might be just selected by the user (or this package might be automatically selected already already).

---
 fs/common.mk           | 1 +
 package/pkg-generic.mk | 2 ++
 2 files changed, 3 insertions(+)
fs/common.mk +1 -0
index 4ad51fdd0a..3288406af6 100644
@@ -152,6 +152,7 @@ ifneq ($$(ROOTFS_$(2)_COMPRESS_CMD),)
 	PATH=$$(BR_PATH) $$(ROOTFS_$(2)_COMPRESS_CMD) $$@ > $$@$$(ROOTFS_$(2)_COMPRESS_EXT)
 endif
 	$$(foreach hook,$$(ROOTFS_$(2)_POST_GEN_HOOKS),$$(call $$(hook))$$(sep))
+	$$(foreach hook,$$(ROOTFS_POST_GEN_HOOKS),$$(call $$(hook))$$(sep))
 
 rootfs-$(1)-show-depends:
 	@echo $$(ROOTFS_$(2)_DEPENDENCIES)
package/pkg-generic.mk +2 -0
index a83813e28d..332e3c3cc1 100644
@@ -724,6 +724,7 @@ $(2)_PRE_LEGAL_INFO_HOOKS       ?=
 $(2)_POST_LEGAL_INFO_HOOKS      ?=
 $(2)_TARGET_FINALIZE_HOOKS      ?=
 $(2)_ROOTFS_PRE_CMD_HOOKS       ?=
+$(2)_ROOTFS_POST_GEN_HOOKS      ?=
 
 ifeq ($$($(2)_TYPE),target)
 ifneq ($$(HOST_$(2)_KCONFIG_VAR),)
@@ -1052,6 +1053,7 @@ PACKAGES_USERS += $$($(2)_USERS)$$(sep)
 endif
 TARGET_FINALIZE_HOOKS += $$($(2)_TARGET_FINALIZE_HOOKS)
 ROOTFS_PRE_CMD_HOOKS += $$($(2)_ROOTFS_PRE_CMD_HOOKS)
+ROOTFS_POST_GEN_HOOKS += $$($(2)_ROOTFS_POST_GEN_HOOKS)
 
 ifeq ($$($(2)_SITE_METHOD),svn)
 DL_TOOLS_DEPENDENCIES += svn
Signature · 1 line
2.14.1
#1 lore raw

RFC 1/1 infra/pkg-generic: Add rootfs post gen hook

Hello Vadim,

Quoted 6 lines · On Mon, 15 Apr 2019 03:26:35 +0300 Vadim Kochan <[email protected]> wrote:

Add ability to generate image by custom package, and one of the way to do it - is to add new $(PKG)_ROOTFS_POST_GEN_HOOK which will be called after rootfs image is ready. This allows to have easier alternative to post-image script in form of package, which might be just selected by the user (or this package might be automatically selected already already).

Hum, this description is a bit vague/fuzzy to me. Do you have a specific example that requires this rootfs post gen hook ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

RFC 1/1 infra/pkg-generic: Add rootfs post gen hook

Hi Thomas,

Quoted 12 lines · Thomas Petazzoni

Hello Vadim,

Quoted 6 lines · On Mon, 15 Apr 2019 03:26:35 +0300 Vadim Kochan <[email protected]> wrote:

Add ability to generate image by custom package, and one of the way to do it - is to add new $(PKG)_ROOTFS_POST_GEN_HOOK which will be called after rootfs image is ready. This allows to have easier alternative to post-image script in form of package, which might be just selected by the user (or this package might be automatically selected already already).

Quoted 3 lines

Hum, this description is a bit vague/fuzzy to me. Do you have a specific example that requires this rootfs post gen hook ?

The use case is simple - allow to generate firmware image by custom package instead of post-image script. I did not find some dependencies or other hook to make it installed after rootfs image is ready, so only option I found is to add yet-another-hook which will be called after rootfs image is generated.

Regards,
Vadim Kochan

#3 lore raw

RFC 1/1 infra/pkg-generic: Add rootfs post gen hook

Vadim, All,

On 2019-04-15 10:33 +0300, Vadim Kochan spake thusly:

Quoted 17 lines · Thomas Petazzoni
Quoted 12 lines

Hello Vadim,

Quoted 6 lines · On Mon, 15 Apr 2019 03:26:35 +0300 Vadim Kochan <[email protected]> wrote:

Add ability to generate image by custom package, and one of the way to do it - is to add new $(PKG)_ROOTFS_POST_GEN_HOOK which will be called after rootfs image is ready. This allows to have easier alternative to post-image script in form of package, which might be just selected by the user (or this package might be automatically selected already already).

Quoted 3 lines

Hum, this description is a bit vague/fuzzy to me. Do you have a specific example that requires this rootfs post gen hook ?

Quoted 5 lines

The use case is simple - allow to generate firmware image by custom package instead of post-image script. I did not find some dependencies or other hook to make it installed after rootfs image is ready, so only option I found is to add yet-another-hook which will be called after rootfs image is generated.

If you have a custom tool to generate a custom image, why don't you also provide a custom filesystem implementation of your own in fs/your-fs/ like any other filesystem ?

Note that a filesystem can also be defined in a br2-external tree.

Regards,
Yann E. MORIN.

Signature · 21 lines
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
| +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
|      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
#4 lore raw

RFC 1/1 infra/pkg-generic: Add rootfs post gen hook

Hi Yann,

Quoted 26 lines · yann.morin at orange.com

Vadim, All,

On 2019-04-15 10:33 +0300, Vadim Kochan spake thusly:

Quoted 17 lines · Thomas Petazzoni
Quoted 12 lines

Hello Vadim,

Quoted 6 lines · On Mon, 15 Apr 2019 03:26:35 +0300 Vadim Kochan <[email protected]> wrote:

Add ability to generate image by custom package, and one of the way to do it - is to add new $(PKG)_ROOTFS_POST_GEN_HOOK which will be called after rootfs image is ready. This allows to have easier alternative to post-image script in form of package, which might be just selected by the user (or this package might be automatically selected already already).

Quoted 3 lines

Hum, this description is a bit vague/fuzzy to me. Do you have a specific example that requires this rootfs post gen hook ?

Quoted 5 lines

The use case is simple - allow to generate firmware image by custom package instead of post-image script. I did not find some dependencies or other hook to make it installed after rootfs image is ready, so only option I found is to add yet-another-hook which will be called after rootfs image is generated.

Quoted 6 lines

If you have a custom tool to generate a custom image, why don't you also provide a custom filesystem implementation of your own in fs/your-fs/ like any other filesystem ?

Note that a filesystem can also be defined in a br2-external tree.

Yes, I understand but this is not for fs image generation but for the final firmware image (for flashing, e.g. sdcard image), for example:

https://github.com/vkochan/buildroot-external-rpi/blob/master/package/rpi-image/rpi-image.mk

Regards,
Vadim Kochan

#5 lore raw

RFC 1/1 infra/pkg-generic: Add rootfs post gen hook

Vadym, All,

On 2019-04-15 11:42 +0300, Vadym Kochan spake thusly:

Quoted 31 lines · yann.morin at orange.com
Quoted 30 lines

Vadim, All,

On 2019-04-15 10:33 +0300, Vadim Kochan spake thusly:

Quoted 17 lines · Thomas Petazzoni
Quoted 12 lines

Hello Vadim,

Quoted 6 lines · On Mon, 15 Apr 2019 03:26:35 +0300 Vadim Kochan <[email protected]> wrote:

Add ability to generate image by custom package, and one of the way to do it - is to add new $(PKG)_ROOTFS_POST_GEN_HOOK which will be called after rootfs image is ready. This allows to have easier alternative to post-image script in form of package, which might be just selected by the user (or this package might be automatically selected already already).

Quoted 3 lines

Hum, this description is a bit vague/fuzzy to me. Do you have a specific example that requires this rootfs post gen hook ?

Quoted 5 lines

The use case is simple - allow to generate firmware image by custom package instead of post-image script. I did not find some dependencies or other hook to make it installed after rootfs image is ready, so only option I found is to add yet-another-hook which will be called after rootfs image is generated.

If you have a custom tool to generate a custom image, why don't you also provide a custom filesystem implementation of your own in fs/your-fs/ like any other filesystem ?

Quoted 7 lines
Quoted 2 lines

Note that a filesystem can also be defined in a br2-external tree.

Yes, I understand but this is not for fs image generation but for the final firmware image (for flashing, e.g. sdcard image), for example:

https://github.com/vkochan/buildroot-external-rpi/blob/master/package/rpi-image/rpi-image.mk

I perfectly understand what this is about. But now, say that there are two (or more) packages that must provide a set of tools to run in sequence on the generated filesystem?

For example, the first is an incantation of genimage or some such, and the second one does a signature, and so on?

How would your proposal cover this?

This is exactly what post-image is for: to be able to provide whatever project-specific, board-specific (etc..) tooling to run after filesystems have been generated.

Besides, your rpi-image stuff does not even solve your (non-)problem, because your project-specific defconfig still has to enable that package anyway, so it is not different than having a post-image script listed in the defconfig.

Regards,
Yann E. MORIN.

Signature · 21 lines
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
| +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
|      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
#6 lore raw

RFC 1/1 infra/pkg-generic: Add rootfs post gen hook

Hi Yann,

Quoted 42 lines · yann.morin at orange.com

Vadym, All,

On 2019-04-15 11:42 +0300, Vadym Kochan spake thusly:

Quoted 31 lines · yann.morin at orange.com
Quoted 30 lines

Vadim, All,

On 2019-04-15 10:33 +0300, Vadim Kochan spake thusly:

Quoted 17 lines · Thomas Petazzoni
Quoted 12 lines

Hello Vadim,

Quoted 6 lines · On Mon, 15 Apr 2019 03:26:35 +0300 Vadim Kochan <[email protected]> wrote:

Add ability to generate image by custom package, and one of the way to do it - is to add new $(PKG)_ROOTFS_POST_GEN_HOOK which will be called after rootfs image is ready. This allows to have easier alternative to post-image script in form of package, which might be just selected by the user (or this package might be automatically selected already already).

Quoted 3 lines

Hum, this description is a bit vague/fuzzy to me. Do you have a specific example that requires this rootfs post gen hook ?

Quoted 5 lines

The use case is simple - allow to generate firmware image by custom package instead of post-image script. I did not find some dependencies or other hook to make it installed after rootfs image is ready, so only option I found is to add yet-another-hook which will be called after rootfs image is generated.

If you have a custom tool to generate a custom image, why don't you also provide a custom filesystem implementation of your own in fs/your-fs/ like any other filesystem ?

Quoted 7 lines
Quoted 2 lines

Note that a filesystem can also be defined in a br2-external tree.

Yes, I understand but this is not for fs image generation but for the final firmware image (for flashing, e.g. sdcard image), for example:

https://github.com/vkochan/buildroot-external-rpi/blob/master/package/rpi-image/rpi-image.mk

Quoted 8 lines

I perfectly understand what this is about. But now, say that there are two (or more) packages that must provide a set of tools to run in sequence on the generated filesystem?

For example, the first is an incantation of genimage or some such, and the second one does a signature, and so on?

How would your proposal cover this?

Good point! Actually the package will cover genimage invocation, the rest is still possible to handle in user's post-image (which will be called after $(TARGETS_ROOTFS).

Quoted 10 lines

This is exactly what post-image is for: to be able to provide whatever project-specific, board-specific (etc..) tooling to run after filesystems have been generated.

Besides, your rpi-image stuff does not even solve your (non-)problem, because your project-specific defconfig still has to enable that package anyway, so it is not different than having a post-image script listed in the defconfig.

Well the package is automatically selected by default if RPI's top option is enabled (in ${EXTERNAL}/Config.in, actually it is 'implied', so it can be easy disabled via menuconfig).

Thanks,
Vadim Kochan