perf/report: Report OOM in perf report status line
PATCH 1/1 perf/report: Report OOM in perf report status line
An -ENOMEM error is not reported in the GTK GUI.
Instead this error message pops up on the screen:
[root@m35lp76 perf]# ./perf report -i perf.data.error68-1
Processing events... [974K/3M] Error:failed to process sample 0xf4198 [0x8]: failed to process type: 68
However when I use the same perf.data file with --stdio it works:
[root@m35lp76 perf]# ./perf report -i perf.data.error68-1 --stdio \ | head -12
# Total Lost Samples: 0
#
# Samples: 76K of event 'cycles'
# Event count (approx.): 99056160000
#
# Overhead Command Shared Object Symbol
# ........ ............... ................. .........
#
8.81% find [kernel.kallsyms] [k] ftrace_likely_update
8.74% swapper [kernel.kallsyms] [k] ftrace_likely_update
8.34% sshd [kernel.kallsyms] [k] ftrace_likely_update
2.19% kworker/u512:1- [kernel.kallsyms] [k] ftrace_likely_updateThe sample precentage is a bit low.....
The GUI always fails in the FINISHED_ROUND event (68) and does not indicate the reason why.
When happened is the following. Perf report calls a lot of functions and down deep when a FINISHED_ROUND event is processed, these functions are called:
perf_session__process_event()
+ perf_session__process_user_event()
+ process_finished_round()
+ ordered_events__flush()
+ __ordered_events__flush()
+ do_flush()
+ ordered_events__deliver_event()
+ perf_session__deliver_event()
+ machine__deliver_event()
+ perf_evlist__deliver_event()
+ process_sample_event()
+ hist_entry_iter_add() --> only called in GUI case!!!
+ hist_iter__report__callback()
+ symbol__inc_addr_sample()
Now this functions runs out of memory and returns -ENOMEM. This is reported all the way up until function
perf_session__process_event() returns to its caller, where -ENOMEM is changed to -EINVAL and processing stops:
if ((skip = perf_session__process_event(session, event, head)) < 0) {
pr_err("%#" PRIx64 " [%#x]: failed to process type: %d\n",
head, event->header.size, event->header.type);
err = -EINVAL;
goto out_err;}
This occurred in the FINISHED_ROUND event when it has to process some 10000 entries and ran out of memory.
This patch indicates the root cause and displays it in the status line of ther perf report GUI.
Output before (on GUI status line):0xf4198 [0x8]: failed to process type: 68
Output after:0xf4198 [0x8]: failed to process type: 68 [not enough memory]
--- tools/perf/util/session.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/session.c +3 -3
@@ -1930,10 +1930,10 @@ reader__process_events(struct reader *rd, struct perf_session *session,if (size <sizeof (struct perf_event_header ) || (skip = rd->process (session, event, file_pos)) <0 ) { -pr_err ("%#" PRIx64" [%#x]: failed to process type: %d\n" , +pr_err ("%#" PRIx64" [%#x]: failed to process type: %d [%s]\n" , file_offset + head, event->header.size, - event->header.type); - err = -EINVAL ; + event->header.type,strerror (-skip)); + err = skip; goto out; }
Signature · 1 line
2.16.4
Thomas,
On Mon, Apr 15, 2019 at 11:46:17AM +0200, Thomas Richter wrote:
[...]
Quoted 14 lines
Signed-off-by Thomas Richter <[email protected]>Reviewed-by Jiri Olsa <[email protected]>--- tools/perf/util/session.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)tools/perf/util/session.c +0
-0@@ -1930,10 +1930,10 @@ reader__process_events(struct reader *rd, struct perf_session *session,if (size <sizeof (struct perf_event_header ) || (skip = rd->process (session, event, file_pos)) <0 ) {
tools/perf/util/session.c reader__process_events(struct reader *rd, struct perf_session *session, · line 1939
Quoted 10 lines
tools/perf/util/session.c +3
-3-pr_err ("%#" PRIx64" [%#x]: failed to process type: %d\n" , +pr_err ("%#" PRIx64" [%#x]: failed to process type: %d [%s]\n" , file_offset + head, event->header.size, - event->header.type); - err = -EINVAL ; + event->header.type,strerror (-skip)); + err = skip; goto out; }
Thanks for solving this issue.