util/error: do not free error on error_abort
PATCH v2 1/1 util/error: do not free error on error_abort
It would be nice to have Error object not freed away when debugging a coredump.
Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>
---
v2: don't change error output format
util/error.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
util/error.c +4 -1
@@ -34,7 +34,10 @@ static void error_handle_fatal(Error **errp, Error *err)if (errp == &error_abort) {fprintf (stderr,"Unexpected error in %s() at %s:%d:\n" , err->func, err->src, err->line); -error_report_err (err); +error_report ("%s" ,error_get_pretty (err)); +if (err->hint) { +error_printf_unless_qmp ("%s" , err->hint->str); + }abort (); }if (errp == &error_fatal) {
Signature · 1 line
2.18.0
Quoted 17 lines · Vladimir Sementsov-Ogievskiy
It would be nice to have Error object not freed away when debugging a coredump.
Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>---
v2: don't change error output format
util/error.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)util/error.c +0
-0@@ -34,7 +34,10 @@ static void error_handle_fatal(Error **errp, Error *err)if (errp == &error_abort) {
util/error.c static void error_handle_fatal(Error **errp, Error *err) · line 43
Quoted 10 lines
util/error.c +4
-1fprintf (stderr,"Unexpected error in %s() at %s:%d:\n" , err->func, err->src, err->line); -error_report_err (err); +error_report ("%s" ,error_get_pretty (err)); +if (err->hint) { +error_printf_unless_qmp ("%s" , err->hint->str); + }abort (); }if (errp == &error_fatal) {
We've since found out that the hint should be printed with error_printf(), see "[PATCH] error: Fix error_report_err(), warn_report_err() hint printing". With that:
Reviewed-by Markus Armbruster <[email protected]>
Queued with this change. Thanks!