Skip to contentSkip to conversation

net/virtio: fix dangling pointer on failure

PATCH Applied Aaron Conole 3 participants 3 messages Apr 15, 2019 – Apr 17, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/virtio: fix dangling pointer on failure

When eth_virtio_dev_init() is cleaning up, it does not correctly set the mac_addrs variable to NULL, which will lead to a double free.

Found during unit-test fixes.

Fixes 43d18765c027 ("net/virtio: fix memory leak on failure")
---
 drivers/net/virtio/virtio_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/virtio/virtio_ethdev.c +1 -0
index 2272bb2e5..d25c08f0a 100644
@@ -1862,6 +1862,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
 
 out:
 	rte_free(eth_dev->data->mac_addrs);
+	eth_dev->data->mac_addrs = NULL;
 	return ret;
 }
 
Signature · 1 line
2.19.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Aaron Conole

When eth_virtio_dev_init() is cleaning up, it does not correctly set the mac_addrs variable to NULL, which will lead to a double free.

Found during unit-test fixes.

Quoted 7 lines
Fixes 43d18765c027 ("net/virtio: fix memory leak on failure")
---
 drivers/net/virtio/virtio_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
#2 lore raw
In reply to Aaron Conole
Quoted 5 lines · Aaron Conole

When eth_virtio_dev_init() is cleaning up, it does not correctly set the mac_addrs variable to NULL, which will lead to a double free.

Found during unit-test fixes.

Quoted 7 lines
Fixes 43d18765c027 ("net/virtio: fix memory leak on failure")
---
  drivers/net/virtio/virtio_ethdev.c | 1 +
  1 file changed, 1 insertion(+)

Applied to dpdk-next-virtio/master.

Thanks,
Maxime