Skip to contentSkip to conversation

hwmon: Add support for samples attributes

PATCH In review Guenter Roeck 2 participants 3 messages Apr 15, 2019 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH 1/1 hwmon: Add support for samples attributes

Add support for the new samples attributes to the hwmon core.

Cc Krzysztof Adamski <[email protected]>
Cc Nicolin Chen <[email protected]>
---
 drivers/hwmon/hwmon.c |  5 +++++
 include/linux/hwmon.h | 11 +++++++++++
 2 files changed, 16 insertions(+)
drivers/hwmon/hwmon.c +5 -0
index c22dc1e07911..cd91510a5387 100644
@@ -324,6 +324,11 @@ static const char * const hwmon_chip_attrs[] = {
 	[hwmon_chip_power_reset_history] = "power_reset_history",
 	[hwmon_chip_update_interval] = "update_interval",
 	[hwmon_chip_alarms] = "alarms",
+	[hwmon_chip_samples] = "samples",
+	[hwmon_chip_curr_samples] = "curr_samples",
+	[hwmon_chip_in_samples] = "in_samples",
+	[hwmon_chip_power_samples] = "power_samples",
+	[hwmon_chip_temp_samples] = "temp_samples",
 };
 
 static const char * const hwmon_temp_attr_templates[] = {
include/linux/hwmon.h +11 -0
index 7a8cc06a0d61..7b18a6150a11 100644
@@ -40,6 +40,12 @@ enum hwmon_chip_attributes {
 	hwmon_chip_register_tz,
 	hwmon_chip_update_interval,
 	hwmon_chip_alarms,
+	hwmon_chip_samples,
+	hwmon_chip_curr_samples,
+	hwmon_chip_in_samples,
+	hwmon_chip_power_samples,
+	hwmon_chip_temp_samples,
+
 };
 
 #define HWMON_C_TEMP_RESET_HISTORY	BIT(hwmon_chip_temp_reset_history)
@@ -49,6 +55,11 @@ enum hwmon_chip_attributes {
 #define HWMON_C_REGISTER_TZ		BIT(hwmon_chip_register_tz)
 #define HWMON_C_UPDATE_INTERVAL		BIT(hwmon_chip_update_interval)
 #define HWMON_C_ALARMS			BIT(hwmon_chip_alarms)
+#define HWMON_C_SAMPLES			BIT(hwmon_chip_samples)
+#define HWMON_C_CURR_SAMPLES		BIT(hwmon_chip_curr_samples)
+#define HWMON_C_IN_SAMPLES		BIT(hwmon_chip_in_samples)
+#define HWMON_C_POWER_SAMPLES		BIT(hwmon_chip_power_samples)
+#define HWMON_C_TEMP_SAMPLES		BIT(hwmon_chip_temp_samples)
 
 enum hwmon_temp_attributes {
 	hwmon_temp_input = 0,
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw

Thanks for adding this.

Quoted 4 lines · Guenter Roeck

Add support for the new samples attributes to the hwmon core.

Cc Krzysztof Adamski <[email protected]>
Cc Nicolin Chen <[email protected]>

Will redo my change and test through API later.

Quoted 11 lines
---
 drivers/hwmon/hwmon.c |  5 +++++
 include/linux/hwmon.h | 11 +++++++++++
 2 files changed, 16 insertions(+)
include/linux/hwmon.h +0 -0
index 7a8cc06a0d61..7b18a6150a11 100644

include/linux/hwmon.h enum hwmon_chip_attributes { · line 49

Quoted 10 lines
include/linux/hwmon.h +6 -0
@@ -40,6 +40,12 @@ enum hwmon_chip_attributes {
 	hwmon_chip_register_tz,
 	hwmon_chip_update_interval,
 	hwmon_chip_alarms,
+	hwmon_chip_samples,
+	hwmon_chip_curr_samples,
+	hwmon_chip_in_samples,
+	hwmon_chip_power_samples,
+	hwmon_chip_temp_samples,
+
 };

Why add a blank line at the end?

author maintainer
#2 lore raw
Quoted 27 lines · Nicolin Chen

Thanks for adding this.

Quoted 4 lines · Guenter Roeck

Add support for the new samples attributes to the hwmon core.

Cc Krzysztof Adamski <[email protected]>
Cc Nicolin Chen <[email protected]>

Will redo my change and test through API later.

Quoted 15 lines
---
 drivers/hwmon/hwmon.c |  5 +++++
 include/linux/hwmon.h | 11 +++++++++++
 2 files changed, 16 insertions(+)
include/linux/hwmon.h +1 -0
index 7a8cc06a0d61..7b18a6150a11 100644
@@ -40,6 +40,12 @@ enum hwmon_chip_attributes {
 	hwmon_chip_register_tz,
 	hwmon_chip_update_interval,
 	hwmon_chip_alarms,
+	hwmon_chip_samples,
Quoted 8 lines

include/linux/hwmon.h enum hwmon_chip_attributes { · line 49

Quoted 6 lines
include/linux/hwmon.h +5 -0
+	hwmon_chip_curr_samples,
+	hwmon_chip_in_samples,
+	hwmon_chip_power_samples,
+	hwmon_chip_temp_samples,
+
 };

Why add a blank line at the end?

No idea. I'll drop it. Thanks for having a look!

Guenter