x86: Remove INIT deassert
PATCH v2 1/1 x86: Remove INIT deassert
From: Nadav Amit <[email protected]>
Currently, the INIT deassert is marked as an edge event instead of a level, which is wrong. The deassert is actually not needed, as the arbitration ID should have already been set after boot, and is not affected by further INIT IPIs.
Remove the INIT deassert for these reasons.
--- x86/cstart.S | 1 - x86/cstart64.S | 1 - 2 files changed, 2 deletions(-)
x86/cstart.S +0 -1
@@ -186,7 +186,6 @@ smp_init: rep/movsb mov $APIC_DEFAULT_PHYS_BASE, %eax movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT | APIC_INT_ASSERT), APIC_ICR(%eax) - movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT), APIC_ICR(%eax) movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_STARTUP), APIC_ICR(%eax) call fwcfg_get_nb_cpus 1: pause
x86/cstart64.S +0 -1
@@ -285,7 +285,6 @@ smp_init: rep/movsb mov $APIC_DEFAULT_PHYS_BASE, %eax movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT | APIC_INT_ASSERT), APIC_ICR(%rax) - movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT), APIC_ICR(%rax) movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_STARTUP), APIC_ICR(%rax) call fwcfg_get_nb_cpus 1: pause
Signature · 1 line
2.17.1
Re: [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg
Quoted 7 lines · On Mon, Apr 15, 2019 at 03:14:21PM -0700, [email protected] wrote:
From: Nadav Amit <[email protected]>
Currently, the INIT deassert is marked as an edge event instead of a level, which is wrong. The deassert is actually not needed, as the arbitration ID should have already been set after boot, and is not affected by further INIT IPIs.
Quoted 5 lines
Remove the INIT deassert for these reasons.
Cc Sean Christopherson <[email protected]>Signed-off-by Nadav Amit <[email protected]>---
Re: [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg
Quoted 8 lines · Sean Christopherson
Quoted 6 lines
Currently, the INIT deassert is marked as an edge event instead of a level, which is wrong. The deassert is actually not needed, as the arbitration ID should have already been set after boot, and is not affected by further INIT IPIs.
Remove the INIT deassert for these reasons.
Reviewed-by Sean Christopherson <[email protected]>
Queued, thanks.
Paolo