drm: fix drm_fb_xrgb8888_to_rgb888_dstclip()
Subsystems (2)
PATCH 1/1 drm: fix drm_fb_xrgb8888_to_rgb888_dstclip()
Oops, the __iomem annotation was added to the header file only. Add it to the implementation (and documentation) too.
--- drivers/gpu/drm/drm_format_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_format_helper.c +3 -3
@@ -230,7 +230,7 @@ static void drm_fb_xrgb8888_to_rgb888_line(u8 *dbuf, u32 *sbuf,/** * drm_fb_xrgb8888_to_rgb888_dstclip - Convert XRGB8888 to RGB888 clip buffer -* @dst: RGB565 destination buffer +* @dst: RGB565 destination buffer (iomem) * @dst_pitch: destination buffer pitch * @vaddr: XRGB8888 source buffer * @fb: DRM framebuffer
@@ -241,9 +241,9 @@ static void drm_fb_xrgb8888_to_rgb888_line(u8 *dbuf, u32 *sbuf,* support XRGB8888. * * This function applies clipping on dst, i.e. the destination is a -* full framebuffer but only the clip rect content is copied over. +* full (iomem) framebuffer but only the clip rect content is copied over. */ -void drm_fb_xrgb8888_to_rgb888_dstclip (void *dst,unsigned int dst_pitch, +void drm_fb_xrgb8888_to_rgb888_dstclip (void __iomem *dst,unsigned int dst_pitch,void *vaddr,struct drm_framebuffer *fb,struct drm_rect *clip) {
Signature · 6 lines
2.18.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Den 11.04.2019 06.49, skrev Gerd Hoffmann:
Quoted 6 lines
Oops, the
__iomemannotation was added to the header file only. Add it to the implementation (and documentation) too.Fixes 5c5373b51bec ("drm: switch drm_fb_xrgb8888_to_rgb888_dstclip to accept __iomem dst")Signed-off-by Gerd Hoffmann <[email protected]>---
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 23 lines · Gerd Hoffmann
Oops, the
__iomemannotation was added to the header file only. Add it to the implementation (and documentation) too.Fixes 5c5373b51bec ("drm: switch drm_fb_xrgb8888_to_rgb888_dstclip to accept __iomem dst")Signed-off-by Gerd Hoffmann <[email protected]>--- drivers/gpu/drm/drm_format_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_format_helper.c +1
-1@@ -230,7 +230,7 @@ static void drm_fb_xrgb8888_to_rgb888_line(u8 *dbuf, u32 *sbuf,/** * drm_fb_xrgb8888_to_rgb888_dstclip - Convert XRGB8888 to RGB888 clip buffer -* @dst: RGB565 destination buffer +* @dst: RGB565 destination buffer (iomem) * @dst_pitch: destination buffer pitch * @vaddr: XRGB8888 source buffer * @fb: DRM framebuffer
drivers/gpu/drm/drm_format_helper.c static void drm_fb_xrgb8888_to_rgb888_line(u8 *dbuf, u32 *sbuf, · line 245
Quoted 6 lines
drivers/gpu/drm/drm_format_helper.c +1
-1@@ -241,9 +241,9 @@ static void drm_fb_xrgb8888_to_rgb888_line(u8 *dbuf, u32 *sbuf,* support XRGB8888. * * This function applies clipping on dst, i.e. the destination is a -* full framebuffer but only the clip rect content is copied over. +* full (iomem) framebuffer but only the clip rect content is copied over. */
All this nice kerneldoc isn't pulled into the docs in Documentation/gpu/drm-kms-helper.rst anywhere. Can you pls fix that too?
Thanks, Daniel
Quoted 8 lines
drivers/gpu/drm/drm_format_helper.c +1
-1-void drm_fb_xrgb8888_to_rgb888_dstclip (void *dst,unsigned int dst_pitch, +void drm_fb_xrgb8888_to_rgb888_dstclip (void __iomem *dst,unsigned int dst_pitch,void *vaddr,struct drm_framebuffer *fb,struct drm_rect *clip) {Signature · 1 line
2.18.1
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch