Skip to contentSkip to conversation

ARM: dts: sun4i: protab2: Remove stale pinctrl-names entry

PATCH New Maxime Ripard 1 participant 6 messages Apr 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/6 ARM: dts: sun4i: protab2: Remove stale pinctrl-names entry

Some nodes still have pinctrl-names entry, yet they don't have any pinctrl group anymore. Drop them.

---
 arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts +0 -1
index bcb2fc0c56b1..24a3d23e1952 100644
@@ -197,7 +197,6 @@
 };
 
 &usbphy {
-	pinctrl-names = "default";
 	usb0_id_det-gpios = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
 	usb0_vbus_det-gpios = <&pio 7 5 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>; /* PH5 */
 	usb0_vbus-supply = <&reg_usb0_vbus>;
Signature · 7 lines
2.21.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH 2/6 ARM: dts: sun4i: lime: Fix the USB PHY ID detect GPIO properties

While the USB PHY Device Tree mandates that the name of the ID detect pin should be usb0_id_det-gpios, a significant number of device tree use usb0_id_det-gpio instead.

This was functional because the GPIO framework falls back to the gpio suffix that is legacy, but we should fix this. Commit 2c515b0d05a9 ("ARM: sunxi: Fix the USB PHY ID detect GPIO properties") was supposed to fix this, but one fell through the cracks.

---
 arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts +1 -1
index 7c1f379c3aed..a8e537fd4bd6 100644
@@ -217,7 +217,7 @@
 };
 
 &usbphy {
-	usb0_id_det-gpio   = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
+	usb0_id_det-gpios = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
 	usb0_vbus_det-gpios = <&pio 7 5 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH5 */
 	usb0_vbus-supply   = <&reg_usb0_vbus>;
 	usb1_vbus-supply = <&reg_usb1_vbus>;
Signature · 7 lines
2.21.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH 3/6 ARM: dts: sun6i: i7: Remove useless property

In reply to Maxime Ripard

The I7 DTS uses an spdif-out property with an "okay" value. However, that property isn't documented anywhere, and isn't used anywhere either.

Remove it.

---
 arch/arm/boot/dts/sun6i-a31-i7.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/sun6i-a31-i7.dts +0 -1
index 0832ac5ae3ec..091eb2ac53b3 100644
@@ -157,7 +157,6 @@
 &spdif {
 	pinctrl-names = "default";
 	pinctrl-0 = <&spdif_tx_pin>;
-	spdif-out = "okay";
 	status = "okay";
 };
 
Signature · 7 lines
2.21.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

PATCH 4/6 ARM: dts: sun5i: Reorder pinctrl nodes

In reply to Maxime Ripard

We try to keep the PIO nodes ordered alphabetically, but this doesn't always work out. Let's fix it.

---
 arch/arm/boot/dts/sun5i.dtsi | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)
arch/arm/boot/dts/sun5i.dtsi +13 -13
index cb820bd7974c..510568a19e9d 100644
@@ -506,6 +506,14 @@
 				bias-pull-up;
 			};
 
+			mmc2_4bit_pc_pins: mmc2-4bit-pc-pins {
+				pins = "PC6", "PC7", "PC8", "PC9",
+				       "PC10", "PC11";
+				function = "mmc2";
+				drive-strength = <30>;
+				bias-pull-up;
+			};
+
 			mmc2_8bit_pins: mmc2-8bit-pins {
 				pins = "PC6", "PC7", "PC8", "PC9",
 				       "PC10", "PC11", "PC12", "PC13",
@@ -515,14 +523,6 @@
 				bias-pull-up;
 			};
 
-			mmc2_4bit_pc_pins: mmc2-4bit-pc-pins {
-				pins = "PC6", "PC7", "PC8", "PC9",
-				       "PC10", "PC11";
-				function = "mmc2";
-				drive-strength = <30>;
-				bias-pull-up;
-			};
-
 			nand_pins: nand-pins {
 				pins = "PC0", "PC1", "PC2",
 				       "PC5", "PC8", "PC9", "PC10",
@@ -541,6 +541,11 @@
 				function = "nand0";
 			};
 
+			pwm0_pin: pwm0-pin {
+				pins = "PB2";
+				function = "pwm";
+			};
+
 			spi2_pe_pins: spi2-pe-pins {
 				pins = "PE1", "PE2", "PE3";
 				function = "spi2";
@@ -580,11 +585,6 @@
 				pins = "PG11", "PG12";
 				function = "uart3";
 			};
-
-			pwm0_pin: pwm0-pin {
-				pins = "PB2";
-				function = "pwm";
-			};
 		};
 
 		timer@1c20c00 {
Signature · 7 lines
2.21.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#4 lore raw

PATCH 5/6 ARM: dts: sun8i: mapleboard: Remove cd-inverted

In reply to Maxime Ripard

The cd-inverted property can also be expressed using the GPIO flags. Use the active low GPIO flag to have the same semantic without the confusion.

---
 arch/arm/boot/dts/sun8i-h3-mapleboard-mp130.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/sun8i-h3-mapleboard-mp130.dts +1 -2
index 6d626ec1f747..ff0a7a952e0c 100644
@@ -91,8 +91,7 @@
 &mmc0 {
 	vmmc-supply = <&reg_vcc3v3>;
 	bus-width = <4>;
-	cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
-	cd-inverted;
+	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
 	status = "okay";
 };
 
Signature · 7 lines
2.21.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#5 lore raw

PATCH 6/6 arm64: dts: allwinner: Fix DE2 bus node name

In reply to Maxime Ripard

According to the device tree specification, any bus should have a 'bus' node name.

Since it isn't the case for us on the DE2 bus, fix that.

---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 +-
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +1 -1
index 6f27eb082429..d724026d87d4 100644
@@ -217,7 +217,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		de2@1000000 {
+		bus@1000000 {
 			compatible = "allwinner,sun50i-a64-de2";
 			reg = <0x1000000 0x400000>;
 			allwinner,sram = <&de2_sram 1>;
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -1
index e0dc4a05c1ba..a19b2c3ebf12 100644
@@ -101,7 +101,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		display-engine@1000000 {
+		bus@1000000 {
 			compatible = "allwinner,sun50i-h6-de3",
 				     "allwinner,sun50i-a64-de2";
 			reg = <0x1000000 0x400000>;
Signature · 7 lines
2.21.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel