Skip to contentSkip to conversation

Staging: mt7621-mmc: Use DIV_ROUND_UP in function msdc_set_mclk

PATCH In review Madhumitha Prabakaran 2 participants 2 messages Apr 3, 2019 – Apr 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: mt7621-mmc: Use DIV_ROUND_UP in function msdc_set_mclk

Use DIV_ROUND_UP to make code simple and more understandable.

---
 drivers/staging/mt7621-mmc/sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/mt7621-mmc/sd.c +2 -2
index 4b26ec896a96..b12ed2c988fd 100644
@@ -240,7 +240,7 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
 			div  = 1;         /* mean div = 1/4 */
 			sclk = hclk >> 2; /* sclk = clk / 4 */
 		} else {
-			div  = (hclk + ((hz << 2) - 1)) / (hz << 2);
+			div  = DIV_ROUND_UP(hclk, (hz << 2));
 			sclk = (hclk >> 2) / div;
 		}
 	} else if (hz >= hclk) { /* bug fix */
@@ -253,7 +253,7 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
 			div  = 0;         /* mean div = 1/2 */
 			sclk = hclk >> 1; /* sclk = clk / 2 */
 		} else {
-			div  = (hclk + ((hz << 2) - 1)) / (hz << 2);
+			div  = DIV_ROUND_UP(hclk, (hz << 2));
 			sclk = (hclk >> 2) / div;
 		}
 	}
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 21 lines · Madhumitha Prabakaran

Use DIV_ROUND_UP to make code simple and more understandable.

---
 drivers/staging/mt7621-mmc/sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/mt7621-mmc/sd.c +1 -1
index 4b26ec896a96..b12ed2c988fd 100644
@@ -240,7 +240,7 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
 			div  = 1;         /* mean div = 1/4 */
 			sclk = hclk >> 2; /* sclk = clk / 4 */
 		} else {
-			div  = (hclk + ((hz << 2) - 1)) / (hz << 2);
+			div  = DIV_ROUND_UP(hclk, (hz << 2));
 			sclk = (hclk >> 2) / div;
 		}
 	} else if (hz >= hclk) { /* bug fix */

drivers/staging/mt7621-mmc/sd.c static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz) · line 259

Quoted 8 lines
drivers/staging/mt7621-mmc/sd.c +1 -1
@@ -253,7 +253,7 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
 			div  = 0;         /* mean div = 1/2 */
 			sclk = hclk >> 1; /* sclk = clk / 2 */
 		} else {
-			div  = (hclk + ((hz << 2) - 1)) / (hz << 2);
+			div  = DIV_ROUND_UP(hclk, (hz << 2));
 			sclk = (hclk >> 2) / div;
 		}
 	}

This file is no longer in the kernel tree :(