Skip to contentSkip to conversation

kmemleak: fix unused-function warning

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kmemleak: fix unused-function warning

The only references outside of the #ifdef have been removed, so now we get a warning in non-SMP configurations:

mm/kmemleak.c:1404:13: error: unused function 'scan_large_block' [-Werror,-Wunused-function]

Add a new #ifdef around it.

Fixes 298a32b13208 ("kmemleak: powerpc: skip scanning holes in the .bss section")
---
 mm/kmemleak.c | 2 ++
 1 file changed, 2 insertions(+)
mm/kmemleak.c +2 -0
index 6c318f5ac234..2e435b8142e5 100644
@@ -1401,6 +1401,7 @@ static void scan_block(void *_start, void *_end,
 /*
  * Scan a large memory block in MAX_SCAN_SIZE chunks to reduce the latency.
  */
+#ifdef CONFIG_SMP
 static void scan_large_block(void *start, void *end)
 {
 	void *next;
@@ -1412,6 +1413,7 @@ static void scan_large_block(void *start, void *end)
 		cond_resched();
 	}
 }
+#endif
 
 /*
  * Scan a memory block corresponding to a kmemleak_object. A condition is
Signature · 1 line
2.20.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

The only references outside of the #ifdef have been removed, so now we get a warning in non-SMP configurations:

mm/kmemleak.c:1404:13: error: unused function 'scan_large_block' [-Werror,-Wunused-function]

Add a new #ifdef around it.

Fixes 298a32b13208 ("kmemleak: powerpc: skip scanning holes in the .bss section")