Skip to contentSkip to conversation

cifs: do not attempt cifs operation on smb2+ rename error

PATCH New Frank Sorenson 1 participant 1 message Apr 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: do not attempt cifs operation on smb2+ rename error

A path-based rename returning EBUSY will incorrectly try opening the file with a cifs (NT Create AndX) operation on an smb2+ mount, which causes the server to force a session close.

If the mount is smb2+, skip the fallback.

---
 fs/cifs/inode.c | 4 ++++
 1 file changed, 4 insertions(+)
fs/cifs/inode.c +4 -0
index 53fdb5df0d2e..538fd7d807e4 100644
@@ -1735,6 +1735,10 @@ cifs_do_rename(const unsigned int xid, struct dentry *from_dentry,
 	if (rc == 0 || rc != -EBUSY)
 		goto do_rename_exit;
 
+	/* Don't fall back to using SMB on SMB 2+ mount */
+	if (server->vals->protocol_id != 0)
+		goto do_rename_exit;
+
 	/* open-file renames don't work across directories */
 	if (to_dentry->d_parent != from_dentry->d_parent)
 		goto do_rename_exit;
Signature · 1 line
2.14.4