Skip to contentSkip to conversation

clocksource: timer-probe: change log level to info

PATCH In review Moses Christopher 2 participants 2 messages Apr 16, 2019 Clocksource, clockevent drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clocksource: timer-probe: change log level to info

- In drivers/clocksource/timer-probe.c, the log level for the message stating "no matching timers found" should be informational rather than critical.
- Reference:
- https://e2e.ti.com/support/processors/f/791/t/726024

---
 drivers/clocksource/timer-probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/timer-probe.c +1 -1
index 028075720334..f0dcb41e079f 100644
@@ -50,5 +50,5 @@ void __init timer_probe(void)
 	timers += acpi_probe_device_table(timer);
 
 	if (!timers)
-		pr_crit("%s: no matching timers found\n", __func__);
+		pr_info("%s: no matching timers found\n", __func__);
 }
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Moses Christopher

- In drivers/clocksource/timer-probe.c, the log level for the message stating "no matching timers found" should be informational rather than critical.
- Reference:
- https://e2e.ti.com/support/processors/f/791/t/726024

Thanks for the pointer.

Actually in most of the cases when there are no timers found after this sequence it is because a definition is missing in the DT or the timer was not able to initialize and we end up with a stuck board at boot time.

May be pr_warn would be more appropriate in this case.

However, if this omap board can boot without DT defined timers, does it make sense to run the timer-probe code?

Quoted 17 lines
---
 drivers/clocksource/timer-probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/timer-probe.c +1 -1
index 028075720334..f0dcb41e079f 100644
@@ -50,5 +50,5 @@ void __init timer_probe(void)
 	timers += acpi_probe_device_table(timer);
 
 	if (!timers)
-		pr_crit("%s: no matching timers found\n", __func__);
+		pr_info("%s: no matching timers found\n", __func__);
 }
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog