Skip to contentSkip to conversation

package/madplay: fix build failure due to old autotools macro

PATCH New Giulio Benetti 3 participants 8 messages Apr 16, 2019 – Apr 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/madplay: fix build failure due to old autotools macro

MKINSTALLDIRS is not automatically called by autotools when autoreconfigured.
This leads to have install stage error:
/bin/sh @MKINSTALLDIRS@ /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share /bin/sh: 0: Can't open @MKINSTALLDIRS@
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute every @MKINSTALLDIRS@ occurence in *.in Makefile.

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

---
 ...4-configure-ac-call-AM_MKINSTALLDIRS.patch | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch new file +23 -0
new file mode 100644
index 0000000000..bc6c97efae
@@ -0,0 +1,23 @@
+configure.ac: call AM_MKINSTALLDIRS to substitute @MKINSTALLDIRS@
+
+MKINSTALLDIRS is obsolete and doesn't get automatically called.
+
+Force call AM_MKINSTALLDIRS() macro to substitute every @MKINSTALLDIRS@
+occurence in *.in files.
+
+Signed-off-by: Giulio Benetti <[email protected]>
+
+diff -urpN madplay-0.15.2b.orig/configure.ac madplay-0.15.2b/configure.ac
+--- madplay-0.15.2b.orig/configure.ac	2019-04-16 12:06:03.781018755 +0200
++++ madplay-0.15.2b/configure.ac	2019-04-16 12:07:48.399162610 +0200
+@@ -146,6 +146,10 @@ ALL_LINGUAS="en es fr hr no"
+ AM_GNU_GETTEXT([use-libtool])
+ AM_GNU_GETTEXT_VERSION(0.14.1)
+ 
++dnl Make sure AM_MKINSTALLDIRS gets called
++
++AM_MKINSTALLDIRS()
++
+ dnl Checks for header files.
+ 
+ AC_HEADER_STDC
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/madplay: fix build failure due to old autotools macro

Quoted 26 lines · Giulio Benetti

MKINSTALLDIRS is not automatically called by autotools when autoreconfigured.
This leads to have install stage error:
/bin/sh @MKINSTALLDIRS@ /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share /bin/sh: 0: Can't open @MKINSTALLDIRS@
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute every @MKINSTALLDIRS@ occurence in *.in Makefile.

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

---
 ...4-configure-ac-call-AM_MKINSTALLDIRS.patch | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch
package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch new file +0 -0
new file mode 100644
index 0000000000..bc6c97efae

package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch line 8

Quoted 8 lines
package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch new file +8 -0
@@ -0,0 +1,23 @@
+configure.ac: call AM_MKINSTALLDIRS to substitute @MKINSTALLDIRS@
+
+MKINSTALLDIRS is obsolete and doesn't get automatically called.
+
+Force call AM_MKINSTALLDIRS() macro to substitute every @MKINSTALLDIRS@
+occurence in *.in files.
+
+Signed-off-by: Giulio Benetti <[email protected]>

What is the upstream status of this patch?

package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch line 17

Quoted 9 lines
package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch new file +9 -0
+
+diff -urpN madplay-0.15.2b.orig/configure.ac madplay-0.15.2b/configure.ac
+--- madplay-0.15.2b.orig/configure.ac	2019-04-16 12:06:03.781018755 +0200
++++ madplay-0.15.2b/configure.ac	2019-04-16 12:07:48.399162610 +0200
+@@ -146,6 +146,10 @@ ALL_LINGUAS="en es fr hr no"
+ AM_GNU_GETTEXT([use-libtool])
+ AM_GNU_GETTEXT_VERSION(0.14.1)
+ 
++dnl Make sure AM_MKINSTALLDIRS gets called

That comment just repeats the function call. Better:

dnl Substitute MKINSTALLDIRS

Regards,
Arnout

Quoted 7 lines
package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch new file +6 -0
++
++AM_MKINSTALLDIRS()
++
+ dnl Checks for header files.
+ 
+ AC_HEADER_STDC
#2 lore raw

PATCH 1/1 package/madplay: fix build failure due to old autotools macro

Hello Arnout,

Il 16/04/2019 21:45, Arnout Vandecappelle ha scritto:

Quoted 23 lines · Giulio Benetti
Quoted 20 lines

MKINSTALLDIRS is not automatically called by autotools when autoreconfigured.
This leads to have install stage error:
/bin/sh @MKINSTALLDIRS@ /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share /bin/sh: 0: Can't open @MKINSTALLDIRS@
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute every @MKINSTALLDIRS@ occurence in *.in Makefile.

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

---
  ...4-configure-ac-call-AM_MKINSTALLDIRS.patch | 23 +++++++++++++++++++
  1 file changed, 23 insertions(+)

create mode 100644 package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch

Quoted 16 lines
Quoted 6 lines
package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch new file +0 -0
new file mode 100644
index 0000000000..bc6c97efae

package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch line 8

Quoted 8 lines
package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch new file +8 -0
@@ -0,0 +1,23 @@
+configure.ac: call AM_MKINSTALLDIRS to substitute @MKINSTALLDIRS@
+
+MKINSTALLDIRS is obsolete and doesn't get automatically called.
+
+Force call AM_MKINSTALLDIRS() macro to substitute every @MKINSTALLDIRS@
+occurence in *.in files.
+
+Signed-off-by: Giulio Benetti <[email protected]>

What is the upstream status of this patch?

It seems almost dead the development, latest release is old, 2004:
https://sourceforge.net/projects/mad/files/
there are several patches pending but nothing seems to move on:
https://sourceforge.net/p/mad/patches/

I haven't found any other possible upstream different from sourceforge. Do you know if there's another one?

Or do I send patch anyway on Sourceforge and leave it there?

Quoted 12 lines

package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch line 17

Quoted 9 lines
package/madplay/0004-configure-ac-call-AM_MKINSTALLDIRS.patch new file +9 -0
+
+diff -urpN madplay-0.15.2b.orig/configure.ac madplay-0.15.2b/configure.ac
+--- madplay-0.15.2b.orig/configure.ac	2019-04-16 12:06:03.781018755 +0200
++++ madplay-0.15.2b/configure.ac	2019-04-16 12:07:48.399162610 +0200
+@@ -146,6 +146,10 @@ ALL_LINGUAS="en es fr hr no"
+ AM_GNU_GETTEXT([use-libtool])
+ AM_GNU_GETTEXT_VERSION(0.14.1)
+
++dnl Make sure AM_MKINSTALLDIRS gets called

That comment just repeats the function call. Better:

Quoted 1 line

dnl Substitute MKINSTALLDIRS

Yes, right.

Thank you
Kind regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#3 lore raw

PATCH 1/1 package/madplay: fix build failure due to old autotools macro

In reply to Giulio Benetti
Quoted 8 lines · On Tue, 16 Apr 2019 12:21:25 +0200 Giulio Benetti…

MKINSTALLDIRS is not automatically called by autotools when autoreconfigured.
This leads to have install stage error:
/bin/sh @MKINSTALLDIRS@ /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share /bin/sh: 0: Can't open @MKINSTALLDIRS@
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Quoted 7 lines

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute every @MKINSTALLDIRS@ occurence in *.in Makefile.

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

Why is this package suddenly failing to build ? madplay hasn't been updated recently, so why do we have build failures and not before ?

Isn't the build failure related to the switch from gettext-gnu to gettext-tiny ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/madplay: fix build failure due to old autotools macro

Hello Thomas,

Il 16/04/2019 22:13, Thomas Petazzoni ha scritto:

Quoted 14 lines
Quoted 11 lines · On Tue, 16 Apr 2019 12:21:25 +0200 Giulio Benetti…

MKINSTALLDIRS is not automatically called by autotools when autoreconfigured.
This leads to have install stage error:
/bin/sh @MKINSTALLDIRS@ /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share /bin/sh: 0: Can't open @MKINSTALLDIRS@
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute every @MKINSTALLDIRS@ occurence in *.in Makefile.

Quoted 7 lines
Quoted 4 lines

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

Why is this package suddenly failing to build ? madplay hasn't been updated recently, so why do we have build failures and not before ?

MKINSTALLDIRS is very obsolete, but Autoconf and Automake are the same version since 2017 and 2018, so they're not the problem even if I thought they were.
First failure is dated 14-04-2019.

Quoted 2 lines

Isn't the build failure related to the switch from gettext-gnu to gettext-tiny ?

.config has "gettext-gnu" not "gettext-tiny", so that doesn't seem the problem.
I try to dig deeper.

Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
Quoted 2 lines

Thomas

#5 lore raw

PATCH 1/1 package/madplay: fix build failure due to old autotools macro

Hello Thomas,

Il 16/04/2019 23:47, Giulio Benetti ha scritto:

Quoted 22 lines

Hello Thomas,

Il 16/04/2019 22:13, Thomas Petazzoni ha scritto:

Quoted 19 lines
Quoted 15 lines · On Tue, 16 Apr 2019 12:21:25 +0200 Giulio Benetti…

MKINSTALLDIRS is not automatically called by autotools when autoreconfigured.
This leads to have install stage error:
/bin/sh @MKINSTALLDIRS@ /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share /bin/sh: 0: Can't open @MKINSTALLDIRS@
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute every @MKINSTALLDIRS@ occurence in *.in Makefile.

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

Quoted 7 lines
Quoted 2 lines

Why is this package suddenly failing to build ? madplay hasn't been updated recently, so why do we have build failures and not before ?

MKINSTALLDIRS is very obsolete, but Autoconf and Automake are the same version since 2017 and 2018, so they're not the problem even if I thought they were.
First failure is dated 14-04-2019.

Found, it is due to this patch:
https://git.buildroot.net/buildroot/commit/?id=c05cc5de868cc5af27afdb1451e30fcd1ecb2856

It sets MADPLAY_AUTORECONF = YES in madplay.mk

Then "autoreconf" is called and this is why @MKINSTALLDIRS@ is not substituted correctly, due to obsolescence of MKINSTALLDIRS macro.

I hope I've explained it decently.

Quoted 9 lines
Quoted 2 lines

Isn't the build failure related to the switch from gettext-gnu to gettext-tiny ?

.config has "gettext-gnu" not "gettext-tiny", so that doesn't seem the problem.
I try to dig deeper.

Best regards

Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#6 lore raw

PATCH 1/1 package/madplay: fix build failure due to old autotools macro

Quoted 29 lines · Giulio Benetti

Hello Thomas,

Il 16/04/2019 23:47, Giulio Benetti ha scritto:

Quoted 26 lines

Hello Thomas,

Il 16/04/2019 22:13, Thomas Petazzoni ha scritto:

Quoted 22 lines
Quoted 8 lines · On Tue, 16 Apr 2019 12:21:25 +0200 Giulio Benetti…

MKINSTALLDIRS is not automatically called by autotools when autoreconfigured.
This leads to have install stage error:
/bin/sh @MKINSTALLDIRS@ /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share /bin/sh: 0: Can't open @MKINSTALLDIRS@
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Quoted 8 lines

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute every @MKINSTALLDIRS@ occurence in *.in Makefile.

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

Why is this package suddenly failing to build ? madplay hasn't been updated recently, so why do we have build failures and not before ?

Quoted 7 lines
Quoted 4 lines

MKINSTALLDIRS is very obsolete, but Autoconf and Automake are the same version since 2017 and 2018, so they're not the problem even if I thought they were.
First failure is dated 14-04-2019.

Found, it is due to this patch:
https://git.buildroot.net/buildroot/commit/?id=c05cc5de868cc5af27afdb1451e30fcd1ecb2856

That commit was applied to master on Feb 15. However, the autobuilder errors
started on April 14. (There were also a number of autobuild errors in February, but they were different errors and they were fixed.)

So no, that doesn't explain it.

What does explain it, however, is that NLS was only enabled in the autobuilders
since commit 472e8808d928af9787abd3303fb0b2b4d5916946 which I applied on April 14.

The thing is, all the @MKINSTALLDIRS@ things are under a condition like

if test "$(PACKAGE)" = "gettext-tools"; then

except for one, which is unconditional but is part of the rule

install-data-yes: all

        $(mkinstalldirs) $(DESTDIR)$(datadir)

and this rule only gets triggered by

install-data: install-data- at USE_NLS@

and obviously USE_NLS = yes only if NLS is enabled.

So, that explains why this issue appears only now. Therefore, I've applied to
master (after modifying the comment). I've also reworked the commit log a little.

Regards,
Arnout

Quoted 18 lines

It sets MADPLAY_AUTORECONF = YES in madplay.mk

Then "autoreconf" is called and this is why @MKINSTALLDIRS@ is not substituted correctly, due to obsolescence of MKINSTALLDIRS macro.

I hope I've explained it decently.

Quoted 9 lines
Quoted 2 lines

Isn't the build failure related to the switch from gettext-gnu to gettext-tiny ?

.config has "gettext-gnu" not "gettext-tiny", so that doesn't seem the problem.
I try to dig deeper.

Best regards

Best regards

#7 lore raw

PATCH 1/1 package/madplay: fix build failure due to old autotools macro

Hello Arnout,

Il 17/04/2019 22:04, Arnout Vandecappelle ha scritto:

Quoted 58 lines · Giulio Benetti
Quoted 29 lines

Hello Thomas,

Il 16/04/2019 23:47, Giulio Benetti ha scritto:

Quoted 26 lines

Hello Thomas,

Il 16/04/2019 22:13, Thomas Petazzoni ha scritto:

Quoted 22 lines
Quoted 8 lines · On Tue, 16 Apr 2019 12:21:25 +0200 Giulio Benetti…

MKINSTALLDIRS is not automatically called by autotools when autoreconfigured.
This leads to have install stage error:
/bin/sh @MKINSTALLDIRS@ /home/dawncrow/buildroot-test/scripts/instance-0/output/target/usr/share /bin/sh: 0: Can't open @MKINSTALLDIRS@
because @MKINSTALLDIRS@ doesn't get substituted during autoreconf.

Quoted 8 lines

Add patch that explicitly calls AM_MKINSTALLDIRS macro to substitute every @MKINSTALLDIRS@ occurence in *.in Makefile.

Fixes:
http://autobuild.buildroot.net/results/744/7447c03426556f787f20f7ab2d36f0cacc4af1bd/

Why is this package suddenly failing to build ? madplay hasn't been updated recently, so why do we have build failures and not before ?

Quoted 7 lines
Quoted 4 lines

MKINSTALLDIRS is very obsolete, but Autoconf and Automake are the same version since 2017 and 2018, so they're not the problem even if I thought they were.
First failure is dated 14-04-2019.

Found, it is due to this patch:
https://git.buildroot.net/buildroot/commit/?id=c05cc5de868cc5af27afdb1451e30fcd1ecb2856

That commit was applied to master on Feb 15. However, the autobuilder errors
started on April 14. (There were also a number of autobuild errors in February, but they were different errors and they were fixed.)

So no, that doesn't explain it.

What does explain it, however, is that NLS was only enabled in the autobuilders
since commit 472e8808d928af9787abd3303fb0b2b4d5916946 which I applied on April 14.

The thing is, all the @MKINSTALLDIRS@ things are under a condition like

if test "$(PACKAGE)" = "gettext-tools"; then

except for one, which is unconditional but is part of the rule

install-data-yes: all

         $(mkinstalldirs) $(DESTDIR)$(datadir)
Quoted 8 lines

and this rule only gets triggered by

install-data: install-data- at USE_NLS@

and obviously USE_NLS = yes only if NLS is enabled.

So, that explains why this issue appears only now. Therefore, I've applied to
master (after modifying the comment). I've also reworked the commit log a little.

So as we've discussed in IRC, to summarize:
- AUTORECONF = yes exposed potential build error(install specifically), but autobuilders still didn't call Makefile install-data recipe(where error was)
then:
- you've applied a patch to autobuilders that enabled NLS support, this way Makefile install-data recipe started to get called and then build failed

Thank you for the deep explanation.

Kind regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
Quoted 23 lines

Regards,
Arnout

Quoted 18 lines

It sets MADPLAY_AUTORECONF = YES in madplay.mk

Then "autoreconf" is called and this is why @MKINSTALLDIRS@ is not substituted correctly, due to obsolescence of MKINSTALLDIRS macro.

I hope I've explained it decently.

Quoted 9 lines
Quoted 2 lines

Isn't the build failure related to the switch from gettext-gnu to gettext-tiny ?

.config has "gettext-gnu" not "gettext-tiny", so that doesn't seem the problem.
I try to dig deeper.

Best regards

Best regards