block: make sure that bvec length can't be overflow
PATCH v2 1/1 block: make sure that bvec length can't be overflow
bvec->bv_offset may be bigger than PAGE_SIZE sometimes, such as, when one bio is splitted in the middle of one bvec via bio_split(), and bi_iter.bi_bvec_done is used to build offset of the 1st bvec of remained bio. And the remained bio's bvec may be re-submitted to fs layer via ITER_IBVEC, such as loop and nvme-loop.
So we have to make sure that every bvec's offset is less than PAGE_SIZE from bio_for_each_segment_all() because some drivers(loop, nvme-loop) passes the splitted bvec to fs layer via ITER_BVEC.
This patch fixes this issue reported by Zhang Yi When running nvme/011.
--- include/linux/bvec.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
include/linux/bvec.h +3 -2
@@ -160,8 +160,9 @@ static inline void bvec_advance(const struct bio_vec *bvec, bv->bv_page =nth_page (bv->bv_page,1 ); bv->bv_offset =0 ; }else { - bv->bv_page = bvec->bv_page; - bv->bv_offset = bvec->bv_offset; + bv->bv_page =bvec_nth_page (bvec->bv_page, bvec->bv_offset / +PAGE_SIZE ); + bv->bv_offset = bvec->bv_offset & ~PAGE_MASK ; } bv->bv_len = min_t(unsigned int, PAGE_SIZE - bv->bv_offset, bvec->bv_len - iter_all->done);
Signature · 1 line
2.9.5
Quoted 11 lines · Ming Lei
bvec->bv_offsetmay be bigger thanPAGE_SIZEsometimes, such as, when one bio is splitted in the middle of one bvec viabio_split(), and bi_iter.bi_bvec_done is used to build offset of the 1st bvec of remained bio. And the remained bio's bvec may be re-submitted to fs layer viaITER_IBVEC, such as loop and nvme-loop.So we have to make sure that every bvec's offset is less than
PAGE_SIZEfrombio_for_each_segment_all()because somedrivers(loop, nvme-loop)passes the splitted bvec to fs layer viaITER_BVEC.This patch fixes this issue reported by Zhang Yi When running nvme/011.
Applied, thanks.
Signature · 1 line
Jens Axboe