Skip to contentSkip to conversation

x86: Initialize vmcs_root

PATCH Applied [email protected] 2 participants 2 messages Apr 17, 2019 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: Initialize vmcs_root

From: Nadav Amit <[email protected]>

vmcs_root was not initialized, so vmclear was run on the memory in which the IDT resides. That is not good.

---
 x86/vmx.c | 2 ++
 1 file changed, 2 insertions(+)
x86/vmx.c +2 -0
index f713ada..c0f4749 100644
@@ -1244,6 +1244,8 @@ static void init_vmx(void)
 	vmxon_region = alloc_page();
 	memset(vmxon_region, 0, PAGE_SIZE);
 
+	vmcs_root = alloc_page();
+
 	fix_cr0_set =  rdmsr(MSR_IA32_VMX_CR0_FIXED0);
 	fix_cr0_clr =  rdmsr(MSR_IA32_VMX_CR0_FIXED1);
 	fix_cr4_set =  rdmsr(MSR_IA32_VMX_CR4_FIXED0);
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 16 lines · On 17/04/19 06:10, [email protected] wrote:

From: Nadav Amit <[email protected]>

vmcs_root was not initialized, so vmclear was run on the memory in which the IDT resides. That is not good.

---
 x86/vmx.c | 2 ++
 1 file changed, 2 insertions(+)
x86/vmx.c +0 -0
index f713ada..c0f4749 100644

x86/vmx.c static void init_vmx(void) · line 1251

Quoted 8 lines
x86/vmx.c +2 -0
@@ -1244,6 +1244,8 @@ static void init_vmx(void)
 	vmxon_region = alloc_page();
 	memset(vmxon_region, 0, PAGE_SIZE);
 
+	vmcs_root = alloc_page();
+
 	fix_cr0_set =  rdmsr(MSR_IA32_VMX_CR0_FIXED0);
 	fix_cr0_clr =  rdmsr(MSR_IA32_VMX_CR0_FIXED1);
 	fix_cr4_set =  rdmsr(MSR_IA32_VMX_CR4_FIXED0);

Queued, thanks.

Paolo