Skip to contentSkip to conversation

usb: typec: fusb302: Implement start_toggling for all port-types

PATCH New Heikki Krogerus 1 participant 1 message Apr 17, 2019 USB

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/3 usb: typec: fusb302: Implement start_toggling for all port-types

Quoted 10 lines · Hans de Goede

When in single-role port mode, we must start single-role toggling to get an interrupt when a device / cable gets plugged into the port.

This commit modifies the fusb302 start_toggling implementation to start toggling for all port-types, so that connection-detection works on single-role ports too.

Fixes ea3b4d5523bc("usb: typec: fusb302: Resolve fixed power role ...")
Cc Adam Thomson <[email protected]>

Acked-by Heikki Krogerus <[email protected]>

Quoted 46 lines

---
Changes in v2:

(quoted diff) +0 -2
-Adjust for the tcpm core renaming start_drp_toggling to start_toggling,
 instead of adding a new start_srp_connection_detect callback
---
 drivers/usb/typec/tcpm/fusb302.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
drivers/usb/typec/tcpm/fusb302.c +13 -3
index 6d83891cc895..ba030b03d156 100644
@@ -882,10 +882,20 @@ static int tcpm_start_toggling(struct tcpc_dev *dev,
 {
 	struct fusb302_chip *chip = container_of(dev, struct fusb302_chip,
 						 tcpc_dev);
+	enum toggling_mode mode = TOGGLING_MODE_OFF;
 	int ret = 0;
 
-	if (port_type != TYPEC_PORT_DRP)
-		return -EOPNOTSUPP;
+	switch (port_type) {
+	case TYPEC_PORT_SRC:
+		mode = TOGGLING_MODE_SRC;
+		break;
+	case TYPEC_PORT_SNK:
+		mode = TOGGLING_MODE_SNK;
+		break;
+	case TYPEC_PORT_DRP:
+		mode = TOGGLING_MODE_DRP;
+		break;
+	}
 
 	mutex_lock(&chip->lock);
 	ret = fusb302_set_src_current(chip, cc_src_current[cc]);
@@ -894,7 +904,7 @@ static int tcpm_start_toggling(struct tcpc_dev *dev,
 			    typec_cc_status_name[cc], ret);
 		goto done;
 	}
-	ret = fusb302_set_toggling(chip, TOGGLING_MODE_DRP);
+	ret = fusb302_set_toggling(chip, mode);
 	if (ret < 0) {
 		fusb302_log(chip,
 			    "unable to start drp toggling, ret=%d", ret);
Signature · 1 line
2.21.0

thanks,