Skip to contentSkip to conversation

docs/adding-packages-generic.txt: Add note if package does not use source

RFC New Vadim Kochan 2 participants 3 messages Apr 17, 2019

lore
Share & tools
lore
#0 lore raw

RFC 1/1 docs/adding-packages-generic.txt: Add note if package does not use source

Add some description how to allow to add package which does not need any source code.

---
 docs/manual/adding-packages-generic.txt | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
docs/manual/adding-packages-generic.txt +7 -2
index 7be1754f54..96a57a519a 100644
@@ -223,8 +223,13 @@ not and can not work as people would expect it should:
   which Buildroot will use to download the tarball from
   +LIBFOO_SITE+. If +HOST_LIBFOO_SOURCE+ is not specified, it defaults
   to +LIBFOO_SOURCE+. If none are specified, then the value is assumed
-  to be +libfoo-$(LIBFOO_VERSION).tar.gz+. +
-  Example: +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
+  to be +libfoo-$(LIBFOO_VERSION).tar.gz+.
+  In case when the package does not use any source code (e.g. only performs
+  some target/host altering), then +LIBFOO_SOURCE+ should be specified
+  with empty value. +
+  Examples:
+    +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
+    +LIBFOO_SOURCE =
 
 * +LIBFOO_PATCH+ may contain a space-separated list of patch file
   names, that Buildroot will download and apply to the package source
Signature · 1 line
2.14.1
#1 lore raw

RFC 1/1 docs/adding-packages-generic.txt: Add note if package does not use source

Quoted 15 lines · Vadim Kochan

Add some description how to allow to add package which does not need any source code.

---
 docs/manual/adding-packages-generic.txt | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
docs/manual/adding-packages-generic.txt +0 -0
index 7be1754f54..96a57a519a 100644
@@ -223,8 +223,13 @@ not and can not work as people would expect it should:
   which Buildroot will use to download the tarball from
   +LIBFOO_SITE+. If +HOST_LIBFOO_SOURCE+ is not specified, it defaults

docs/manual/adding-packages-generic.txt not and can not work as people would expect it should: · line 232

Quoted 10 lines
docs/manual/adding-packages-generic.txt +7 -2
   to +LIBFOO_SOURCE+. If none are specified, then the value is assumed
-  to be +libfoo-$(LIBFOO_VERSION).tar.gz+. +
-  Example: +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
+  to be +libfoo-$(LIBFOO_VERSION).tar.gz+.
+  In case when the package does not use any source code (e.g. only performs
+  some target/host altering), then +LIBFOO_SOURCE+ should be specified
+  with empty value. +
+  Examples:
+    +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
+    +LIBFOO_SOURCE =

I'm probably stupid, but when is this needed? E.g. skeleton-init-sysv doesn't
have any code, and it doesn't set _SOURCE to empty...

Regards,
Arnout

Quoted 4 lines
docs/manual/adding-packages-generic.txt +0 -0
 * +LIBFOO_PATCH+ may contain a space-separated list of patch file
   names, that Buildroot will download and apply to the package source
 
#2 lore raw

RFC 1/1 docs/adding-packages-generic.txt: Add note if package does not use source

Hi Arnout, All,

Quoted 32 lines · Arnout Vandecappelle
Quoted 15 lines · Vadim Kochan

Add some description how to allow to add package which does not need any source code.

---
 docs/manual/adding-packages-generic.txt | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
docs/manual/adding-packages-generic.txt +0 -0
index 7be1754f54..96a57a519a 100644
@@ -223,8 +223,13 @@ not and can not work as people would expect it should:
   which Buildroot will use to download the tarball from
   +LIBFOO_SITE+. If +HOST_LIBFOO_SOURCE+ is not specified, it defaults

docs/manual/adding-packages-generic.txt not and can not work as people would expect it should: · line 232

Quoted 10 lines
docs/manual/adding-packages-generic.txt +7 -2
   to +LIBFOO_SOURCE+. If none are specified, then the value is assumed
-  to be +libfoo-$(LIBFOO_VERSION).tar.gz+. +
-  Example: +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
+  to be +libfoo-$(LIBFOO_VERSION).tar.gz+.
+  In case when the package does not use any source code (e.g. only performs
+  some target/host altering), then +LIBFOO_SOURCE+ should be specified
+  with empty value. +
+  Examples:
+    +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
+    +LIBFOO_SOURCE =

I'm probably stupid, but when is this needed? E.g. skeleton-init-sysv doesn't
have any code, and it doesn't set _SOURCE to empty...

Quoted 2 lines

Regards,
Arnout

Ohhh, So now I realize what was wrong ... looks like I got issue when I use _VERSION in my custom package but it failed to "build" w/o _SOURCE because _SOURCE automatically was set including this _VERSION value, and only after I set "*_SOURCE=" then it fixed my problem. OK, this patch is wrong, I will drop it. Thanks for point it!

Regards,
Vadim Kochan

Quoted 5 lines
Quoted 5 lines
docs/manual/adding-packages-generic.txt +0 -0
 * +LIBFOO_PATCH+ may contain a space-separated list of patch file
   names, that Buildroot will download and apply to the package source