Skip to contentSkip to conversation

regulator: stm32-pwr: Fix error checking for of_iomap

PATCH In review Axel Lin 2 participants 2 messages Apr 17, 2019

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: stm32-pwr: Fix error checking for of_iomap

of_iomap returns NULL on error.

---
 drivers/regulator/stm32-pwr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/stm32-pwr.c +2 -2
index 222d593d76a2..dd5c2b383e5b 100644
@@ -140,9 +140,9 @@ static int stm32_pwr_regulator_probe(struct platform_device *pdev)
 	int i, ret = 0;
 
 	base = of_iomap(np, 0);
-	if (IS_ERR(base)) {
+	if (!base) {
 		dev_err(&pdev->dev, "Unable to map IO memory\n");
-		return PTR_ERR(base);
+		return -ENODEV;
 	}
 
 	config.dev = &pdev->dev;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 1 line · Axel Lin

of_iomap returns NULL on error.

Someone already sent a patch for this.