lib/igt_dummyload: libify checks for spin batch activation
PATCH 1/3 lib/igt_dummyload: libify checks for spin batch activation
Instead of opencoding the poll into the spinner, use a helper to check if spinner has started.
--- lib/igt_dummyload.c | 35 +++++++++++++++++++--------------- lib/igt_dummyload.h | 17 ++++++++++++++--- tests/i915/gem_ctx_exec.c | 4 +--- tests/i915/gem_ctx_isolation.c | 4 ++-- tests/i915/gem_eio.c | 4 ++-- tests/i915/gem_exec_latency.c | 22 ++++++++++----------- tests/i915/gem_exec_schedule.c | 5 ++--- tests/i915/gem_sync.c | 28 ++++++++++++--------------- tests/perf_pmu.c | 4 ++-- 9 files changed, 66 insertions(+), 57 deletions(-)
lib/igt_dummyload.c +20 -15
@@ -67,11 +67,13 @@ static pthread_mutex_t list_lock = PTHREAD_MUTEX_INITIALIZER;static void fill_reloc (struct drm_i915_gem_relocation_entry *reloc, -uint32_t gem_handle,uint32_t offset, +uint32_t gem_handle,uint32_t offset,uint32_t delta,uint32_t read_domains,uint32_t write_domains) { + reloc->presumed_offset =-1 ; reloc->target_handle = gem_handle; reloc->offset = offset *sizeof (uint32_t ); + reloc->delta = delta *sizeof (uint32_t ); reloc->read_domains = read_domains; reloc->write_domain = write_domains; }
@@ -131,11 +133,13 @@ emit_recursive_batch(igt_spin_t *spin,/* dummy write to dependency */ obj[SCRATCH ].handle = opts->dependency;fill_reloc (&relocs[obj[BATCH ].relocation_count++], - opts->dependency,1020 , + opts->dependency,1020 ,0 ,I915_GEM_DOMAIN_RENDER ,I915_GEM_DOMAIN_RENDER ); execbuf->buffer_count++; }else if (opts->flags &IGT_SPIN_POLL_RUN ) { +const unsigned int start_idx_offset = +SPIN_POLL_START_IDX *sizeof (uint32_t );unsigned int offset;igt_assert (!opts->dependency);
@@ -149,36 +153,37 @@ emit_recursive_batch(igt_spin_t *spin,if (__gem_set_caching (fd, spin->poll_handle,I915_CACHING_CACHED ) ==0 ) - spin->running =gem_mmap__cpu (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); + spin->poll =gem_mmap__cpu (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE );else - spin->running =gem_mmap__wc (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); -igt_assert_eq (*spin->running,0 ); + spin->poll =gem_mmap__wc (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE ); +igt_assert_eq (spin->poll[SPIN_POLL_START_IDX ],0 ); *batch++ =MI_STORE_DWORD_IMM | (gen <6 ?1 <<22 :0 );if (gen >=8 ) { offset =1 ; - *batch++ =0 ; + *batch++ = start_idx_offset; *batch++ =0 ; }else if (gen >=4 ) { offset =2 ; *batch++ =0 ; - *batch++ =0 ; + *batch++ = start_idx_offset; }else { offset =1 ; batch[-1 ]--; - *batch++ =0 ; + *batch++ = start_idx_offset; } *batch++ =1 ; obj[SCRATCH ].handle = spin->poll_handle;fill_reloc (&relocs[obj[BATCH ].relocation_count++], - spin->poll_handle, offset,0 ,0 ); + spin->poll_handle, offset, +SPIN_POLL_START_IDX ,0 ,0 ); execbuf->buffer_count++; }
@@ -408,8 +413,8 @@ void igt_spin_batch_free(int fd, igt_spin_t *spin)gem_munmap ((void *)((unsigned long )spin->batch & (~4095UL )),BATCH_SIZE ); -if (spin->running) { -gem_munmap (spin->running,4096 ); +if (spin->poll) { +gem_munmap (spin->poll,4096 );gem_close (fd, spin->poll_handle); }
lib/igt_dummyload.h +14 -3
@@ -41,7 +41,8 @@ typedef struct igt_spin {struct drm_i915_gem_exec_object2 obj[2 ];struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle; -bool *running; +uint32_t *poll; +#define SPIN_POLL_START_IDX 0 } igt_spin_t;struct igt_spin_factory {
@@ -70,9 +71,19 @@ void igt_spin_batch_set_timeout(igt_spin_t *spin, int64_t ns);void igt_spin_batch_end (igt_spin_t *spin);void igt_spin_batch_free (int fd,igt_spin_t *spin); -static inline void igt_spin_busywait_until_running (igt_spin_t *spin) +static inline bool igt_spin_has_poll (const igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) +return spin->poll; +} + +static inline bool igt_spin_has_started (igt_spin_t *spin) +{ +return READ_ONCE (spin->poll[SPIN_POLL_START_IDX ]); +} + +static inline void igt_spin_busywait_until_started (igt_spin_t *spin) +{ +while (!igt_spin_has_started (spin)) ; }
tests/i915/gem_ctx_exec.c +1 -3
@@ -181,10 +181,8 @@ static void norecovery(int i915) spin = __igt_spin_batch_new(i915, .ctx = param.ctx_id, .flags =IGT_SPIN_POLL_RUN ); -igt_assert (spin->running); +igt_spin_busywait_until_started (spin); -while (!READ_ONCE (*spin->running)) - ;igt_force_gpu_reset (i915);igt_spin_batch_end (spin);
tests/i915/gem_ctx_isolation.c +2 -2
@@ -704,8 +704,8 @@ static void inject_reset_context(int fd, unsigned int engine) spin =__igt_spin_batch_factory (fd, &opts); -if (spin->running) -igt_spin_busywait_until_running (spin); +if (igt_spin_has_poll (spin)) +igt_spin_busywait_until_started (spin);else usleep (1000 );/* better than nothing */
tests/i915/gem_eio.c +2 -2
@@ -186,8 +186,8 @@ static igt_spin_t * __spin_poll(int fd, uint32_t ctx, unsigned long flags)static void __spin_wait (int fd,igt_spin_t *spin) { -if (spin->running) { -igt_spin_busywait_until_running (spin); +if (igt_spin_has_poll (spin)) { +igt_spin_busywait_until_started (spin); }else {igt_debug ("__spin_wait - usleep mode\n" );usleep (500e3 );/* Better than nothing! */
tests/i915/gem_exec_latency.c +11 -11
@@ -79,29 +79,29 @@ poll_ring(int fd, unsigned ring, const char *name)igt_require (gem_can_store_dword (fd, ring)); spin[0 ] =__igt_spin_batch_factory (fd, &opts); -igt_assert (spin[0 ]->running); +igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; spin[1 ] =__igt_spin_batch_factory (fd, &opts); -igt_assert (spin[1 ]->running); +igt_assert (igt_spin_has_poll (spin[1 ])); +igt_assert (cmd == *spin[1 ]->batch);igt_spin_batch_end (spin[0 ]); -while (!READ_ONCE (*spin[1 ]->running)) - ; +igt_spin_busywait_until_started (spin[1 ]); +igt_assert (!gem_bo_busy (fd, spin[0 ]->handle)); cycles =0 ;while ((elapsed =igt_nsec_elapsed (&tv)) <2ull <<30 ) { -unsigned int idx = cycles++ &1 ; +const unsigned int idx = cycles++ &1 ; *spin[idx]->batch = cmd; - *spin[idx]->running =0 ; + spin[idx]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[idx]->execbuf);igt_spin_batch_end (spin[!idx]); -while (!READ_ONCE (*spin[idx]->running)) - ; +igt_spin_busywait_until_started (spin[idx]); } igt_info("%s completed %ld cycles: %.3f us\n",
@@ -419,7 +419,7 @@ static void __rearm_spin_batch(igt_spin_t *spin)const uint32_t mi_arb_chk =0x5 <<23 ; *spin->batch = mi_arb_chk; - *spin->running =0 ; + spin->poll[SPIN_POLL_START_IDX ] =0 ;__sync_synchronize (); }
@@ -441,7 +441,7 @@ struct rt_pkt {static bool __spin_wait (int fd,igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) { +while (!igt_spin_has_started (spin)) {if (!gem_bo_busy (fd, spin->handle))return false; }
@@ -537,7 +537,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned in passname[pass]);break ; } -igt_spin_busywait_until_running (spin); +igt_spin_busywait_until_started (spin); igt_until_timeout(pass > 0 ? 5 : 2) {struct timespec ts = { };
tests/i915/gem_exec_schedule.c +2 -3
@@ -436,7 +436,7 @@ static void semaphore_codependency(int i915) .ctx = ctx, .engine = engine, .flags = IGT_SPIN_POLL_RUN); -igt_spin_busywait_until_running (task[i].xcs); +igt_spin_busywait_until_started (task[i].xcs);/* Common rcs tasks will be queued in FIFO */ task[i].rcs =
@@ -1361,8 +1361,7 @@ static void measure_semaphore_power(int i915) .engine = signaler, .flags = IGT_SPIN_POLL_RUN);gem_wait (i915, spin->handle, &jiffie);/* waitboost */ -igt_assert (spin->running); -igt_spin_busywait_until_running (spin); +igt_spin_busywait_until_started (spin);gpu_power_read (&power, &s_spin[0 ]);usleep (100 *1000 );
tests/i915/gem_sync.c +12 -16
@@ -225,7 +225,7 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .engine = execbuf.flags, .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST)); -igt_assert (spin->running); +igt_assert (igt_spin_has_poll (spin)); cmd = *spin->batch;gem_execbuf (fd, &execbuf);
@@ -239,10 +239,9 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles =0 ; do { *spin->batch = cmd; - *spin->running = 0; + spin->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin->execbuf); - while (!READ_ONCE(*spin->running)) - ; + igt_spin_busywait_until_started(spin); this = gettime(); igt_spin_batch_end(spin);
@@ -264,10 +263,9 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles =0 ; do { *spin->batch = cmd; - *spin->running = 0; + spin->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin->execbuf); - while (!READ_ONCE(*spin->running)) - ; + igt_spin_busywait_until_started(spin); for (int n = 0; n < wlen; n++) gem_execbuf(fd, &execbuf);
@@ -410,7 +408,7 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .engine = execbuf.flags, .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST)); -igt_assert (spin[0 ]->running); +igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; spin[1] = __igt_spin_batch_new(fd,
@@ -426,18 +424,17 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen)for (int warmup =0 ; warmup <=1 ; warmup++) { *spin[0 ]->batch = cmd; - *spin[0 ]->running =0 ; + spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout/10. ; elapsed =0 ; cycles =0 ; do { - while (!READ_ONCE(*spin[0]->running)) - ; + igt_spin_busywait_until_started(spin[0]); *spin[1]->batch = cmd; - *spin[1]->running = 0; + spin[1]->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
@@ -458,21 +455,20 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles, elapsed*1e6/cycles); *spin[0 ]->batch = cmd; - *spin[0 ]->running =0 ; + spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout; elapsed =0 ; cycles =0 ; do { - while (!READ_ONCE(*spin[0]->running)) - ; + igt_spin_busywait_until_started(spin[0]); for (int n = 0; n < wlen; n++) gem_execbuf(fd, &execbuf); *spin[1]->batch = cmd; - *spin[1]->running = 0; + spin[1]->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
tests/perf_pmu.c +2 -2
@@ -189,10 +189,10 @@ static unsigned long __spin_wait(int fd, igt_spin_t *spin)igt_nsec_elapsed (&start); -if (spin->running) { +if (igt_spin_has_poll (spin)) {unsigned long timeout =0 ; -while (!READ_ONCE (*spin->running)) { +while (!igt_spin_has_started (spin)) {unsigned long t =igt_nsec_elapsed (&start);if ((t - timeout) >250e6 ) {
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 lib/igt_dummyload: Get rid of 'batch' on spinner accessors
There is no guarantee that spinners are and will be implemented using batches. As we have igt_spin_t, manipulate it through igt_spin_* functions consistently and hide the batch nature.
--- lib/drmtest.c | 4 +- lib/igt_core.c | 4 +- lib/igt_dummyload.c | 48 +++++++------- lib/igt_dummyload.h | 20 +++--- lib/igt_gt.c | 10 +-- tests/i915/gem_busy.c | 34 +++++----- tests/i915/gem_ctx_exec.c | 10 +-- tests/i915/gem_ctx_isolation.c | 20 +++--- tests/i915/gem_eio.c | 18 +++--- tests/i915/gem_exec_fence.c | 32 +++++----- tests/i915/gem_exec_latency.c | 38 +++++------ tests/i915/gem_exec_nop.c | 8 +-- tests/i915/gem_exec_reloc.c | 26 ++++---- tests/i915/gem_exec_schedule.c | 92 +++++++++++++-------------- tests/i915/gem_exec_suspend.c | 4 +- tests/i915/gem_fenced_exec_thrash.c | 4 +- tests/i915/gem_mmap.c | 4 +- tests/i915/gem_mmap_gtt.c | 4 +- tests/i915/gem_mmap_wc.c | 4 +- tests/i915/gem_shrink.c | 10 +-- tests/i915/gem_spin_batch.c | 20 +++--- tests/i915/gem_sync.c | 74 +++++++++++----------- tests/i915/gem_wait.c | 12 ++-- tests/i915/i915_pm_rps.c | 26 ++++---- tests/kms_busy.c | 26 ++++---- tests/kms_cursor_legacy.c | 12 ++-- tests/perf_pmu.c | 98 ++++++++++++++--------------- 27 files changed, 331 insertions(+), 331 deletions(-)
lib/drmtest.c +2 -2
@@ -176,7 +176,7 @@ static const char *forced_driver(void)*/ void gem_quiescent_gpu (int fd) { -igt_terminate_spin_batches (); +igt_terminate_spins ();igt_drop_caches_set (fd,DROP_ACTIVE |DROP_RETIRE |DROP_IDLE |DROP_FREED );
@@ -314,7 +314,7 @@ static int at_exit_drm_render_fd = -1;static void __cancel_work_at_exit (int fd) { -igt_terminate_spin_batches ();/* for older kernels */ +igt_terminate_spins ();/* for older kernels */ igt_sysfs_set_parameter (fd,"reset" ,"%x" ,-1u /* any method */ ); igt_drop_caches_set(fd,
lib/igt_core.c +2 -2
@@ -1007,7 +1007,7 @@ static void exit_subtest(const char *result)fprintf (stderr,"Subtest %s: %s (%.3fs)\n" , in_subtest, result,igt_time_elapsed (&subtest_time, &now)); -igt_terminate_spin_batches (); +igt_terminate_spins (); in_subtest =NULL ;siglongjmp (igt_subtest_jmpbuf,1 );
@@ -1915,7 +1915,7 @@ static void call_exit_handlers(int sig) {int i; -igt_terminate_spin_batches (); +igt_terminate_spins ();if (!exit_handler_count) {return ;
lib/igt_dummyload.c +24 -24
128 lines not on this page · raw message
lib/igt_dummyload.h +10 -10
@@ -58,18 +58,18 @@ struct igt_spin_factory {#define IGT_SPIN_NO_PREEMPTION (1 << 3)igt_spin_t * -__igt_spin_batch_factory (int fd,const struct igt_spin_factory *opts); +__igt_spin_factory (int fd,const struct igt_spin_factory *opts);igt_spin_t * -igt_spin_batch_factory (int fd,const struct igt_spin_factory *opts); +igt_spin_factory (int fd,const struct igt_spin_factory *opts); -#define __igt_spin_batch_new (fd, ...) \ - __igt_spin_batch_factory(fd, &((struct igt_spin_factory){__VA_ARGS__})) -#define igt_spin_batch_new (fd, ...) \ - igt_spin_batch_factory(fd, &((struct igt_spin_factory){__VA_ARGS__})) +#define __igt_spin_new (fd, ...) \ + __igt_spin_factory(fd, &((struct igt_spin_factory){__VA_ARGS__})) +#define igt_spin_new (fd, ...) \ + igt_spin_factory(fd, &((struct igt_spin_factory){__VA_ARGS__})) -void igt_spin_batch_set_timeout (igt_spin_t *spin,int64_t ns); -void igt_spin_batch_end (igt_spin_t *spin); -void igt_spin_batch_free (int fd,igt_spin_t *spin); +void igt_spin_set_timeout (igt_spin_t *spin,int64_t ns); +void igt_spin_end (igt_spin_t *spin); +void igt_spin_free (int fd,igt_spin_t *spin);static inline bool igt_spin_has_poll (const igt_spin_t *spin) {
@@ -87,7 +87,7 @@ static inline void igt_spin_busywait_until_started(igt_spin_t *spin) ; } -void igt_terminate_spin_batches (void ); +void igt_terminate_spins (void );enum igt_cork_type {CORK_SYNC_FD =1 ,
lib/igt_gt.c +5 -5
@@ -294,10 +294,10 @@ igt_hang_t igt_hang_ctx(int fd, uint32_t ctx, int ring, unsigned flags)if ((flags &HANG_ALLOW_BAN ) ==0 )context_set_ban (fd, ctx,0 ); - spin = __igt_spin_batch_new(fd, - .ctx = ctx, - .engine = ring, - .flags =IGT_SPIN_NO_PREEMPTION ); + spin = __igt_spin_new(fd, + .ctx = ctx, + .engine = ring, + .flags =IGT_SPIN_NO_PREEMPTION );return (igt_hang_t ){ spin, ctx, ban, flags }; }
@@ -333,7 +333,7 @@ void igt_post_hang_ring(int fd, igt_hang_t arg)return ;gem_sync (fd, arg.spin->handle);/* Wait until it hangs */ -igt_spin_batch_free (fd, arg.spin); +igt_spin_free (fd, arg.spin);context_set_ban (fd, arg.ctx, arg.ban);
tests/i915/gem_busy.c +17 -17
@@ -128,9 +128,9 @@ static void semaphore(int fd, unsigned ring, uint32_t flags)/* Create a long running batch which we can use to hog the GPU */ handle[BUSY ] =gem_create (fd,4096 ); - spin = igt_spin_batch_new(fd, - .engine = ring, - .dependency = handle[BUSY ]); + spin = igt_spin_new(fd, + .engine = ring, + .dependency = handle[BUSY ]);/* Queue a batch after the busy, it should block and remain "busy" */ igt_assert (exec_noop (fd, handle, ring | flags, false));
@@ -159,7 +159,7 @@ static void semaphore(int fd, unsigned ring, uint32_t flags)/* Check that our long batch was long enough */ igt_assert (still_busy (fd, handle[BUSY ])); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);/* And make sure it becomes idle again */ gem_sync (fd, handle[TEST ]);
@@ -379,16 +379,16 @@ static void close_race(int fd)igt_assert (sched_setscheduler (getpid (),SCHED_RR , &rt) ==0 );for (i =0 ; i < nhandles; i++) { - spin[i] = __igt_spin_batch_new(fd, - .engine = engines[rand () % nengine]); + spin[i] = __igt_spin_new(fd, + .engine = engines[rand () % nengine]); handles[i] = spin[i]->handle; } igt_until_timeout(20) {for (i =0 ; i < nhandles; i++) { -igt_spin_batch_free (fd, spin[i]); - spin[i] = __igt_spin_batch_new(fd, - .engine = engines[rand () % nengine]); +igt_spin_free (fd, spin[i]); + spin[i] = __igt_spin_new(fd, + .engine = engines[rand () % nengine]); handles[i] = spin[i]->handle;__sync_synchronize (); }
@@ -398,7 +398,7 @@ static void close_race(int fd)__sync_synchronize ();for (i =0 ; i < nhandles; i++) -igt_spin_batch_free (fd, spin[i]); +igt_spin_free (fd, spin[i]); }igt_waitchildren ();
@@ -430,11 +430,11 @@ static bool has_semaphores(int fd)static bool has_extended_busy_ioctl (int fd) { - igt_spin_t *spin = igt_spin_batch_new(fd, .engine = I915_EXEC_RENDER); + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);uint32_t read, write;__gem_busy (fd, spin->handle, &read, &write); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);return read !=0 ; }
@@ -442,9 +442,9 @@ static bool has_extended_busy_ioctl(int fd)static void basic (int fd,unsigned ring,unsigned flags) {igt_spin_t *spin = - igt_spin_batch_new(fd, - .engine = ring, - .flags =IGT_SPIN_NO_PREEMPTION ); + igt_spin_new(fd, + .engine = ring, + .flags =IGT_SPIN_NO_PREEMPTION );struct timespec tv;int timeout;bool busy;
@@ -453,7 +453,7 @@ static void basic(int fd, unsigned ring, unsigned flags) timeout =120 ;if ((flags &HANG ) ==0 ) { -igt_spin_batch_end (spin); +igt_spin_end (spin); timeout =1 ; }
@@ -470,7 +470,7 @@ static void basic(int fd, unsigned ring, unsigned flags) } } -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin); } igt_main
tests/i915/gem_ctx_exec.c +5 -5
@@ -178,16 +178,16 @@ static void norecovery(int i915)gem_context_get_param (i915, ¶m);igt_assert_eq (param.value, pass); - spin = __igt_spin_batch_new(i915, - .ctx = param.ctx_id, - .flags =IGT_SPIN_POLL_RUN ); + spin = __igt_spin_new(i915, + .ctx = param.ctx_id, + .flags =IGT_SPIN_POLL_RUN );igt_spin_busywait_until_started (spin);igt_force_gpu_reset (i915); -igt_spin_batch_end (spin); +igt_spin_end (spin);igt_assert_eq (__gem_execbuf (i915, &spin->execbuf), expect); -igt_spin_batch_free (i915, spin); +igt_spin_free (i915, spin);gem_context_destroy (i915, param.ctx_id); }
tests/i915/gem_ctx_isolation.c +10 -10
@@ -578,7 +578,7 @@ static void nonpriv(int fd,tmpl_regs (fd, ctx, e, tmpl, values[v]); - spin = igt_spin_batch_new(fd, .ctx = ctx, .engine = engine); + spin = igt_spin_new(fd, .ctx = ctx, .engine = engine);igt_debug ("%s[%d]: Setting all registers to 0x%08x\n" , __func__, v, values[v]);
@@ -592,7 +592,7 @@ static void nonpriv(int fd,*/ restore_regs (fd, ctx, e, flags, regs[0 ]); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);compare_regs (fd, tmpl, regs[1 ],"nonpriv read/writes" );
@@ -631,7 +631,7 @@ static void isolation(int fd, ctx[0 ] =gem_context_create (fd); regs[0 ] =read_regs (fd, ctx[0 ], e, flags); - spin = igt_spin_batch_new(fd, .ctx = ctx[0], .engine = engine); + spin = igt_spin_new(fd, .ctx = ctx[0], .engine = engine);if (flags &DIRTY1 ) { igt_debug("%s[%d]: Setting all registers of ctx 0 to 0x%08x\n",
@@ -663,7 +663,7 @@ static void isolation(int fd, tmp =read_regs (fd, ctx[0 ], e, flags);restore_regs (fd, ctx[0 ], e, flags, regs[0 ]); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);if (!(flags &DIRTY1 ))compare_regs (fd, regs[0 ], tmp,"two reads of the same ctx" );
@@ -702,7 +702,7 @@ static void inject_reset_context(int fd, unsigned int engine)if (gem_can_store_dword (fd, engine)) opts.flags |=IGT_SPIN_POLL_RUN ; - spin =__igt_spin_batch_factory (fd, &opts); + spin =__igt_spin_factory (fd, &opts);if (igt_spin_has_poll (spin))igt_spin_busywait_until_started (spin);
@@ -711,7 +711,7 @@ static void inject_reset_context(int fd, unsigned int engine)igt_force_gpu_reset (fd); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);gem_context_destroy (fd, opts.ctx); }
@@ -738,7 +738,7 @@ static void preservation(int fd,gem_quiescent_gpu (fd); ctx[num_values] =gem_context_create (fd); - spin = igt_spin_batch_new(fd, .ctx = ctx[num_values], .engine = engine); + spin = igt_spin_new(fd, .ctx = ctx[num_values], .engine = engine); regs[num_values][0 ] =read_regs (fd, ctx[num_values], e, flags);for (int v =0 ; v < num_values; v++) { ctx[v] =gem_context_create (fd);
@@ -748,7 +748,7 @@ static void preservation(int fd, }gem_close (fd,read_regs (fd, ctx[num_values], e, flags)); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);if (flags &RESET )inject_reset_context (fd, engine);
@@ -778,11 +778,11 @@ static void preservation(int fd,break ; } - spin = igt_spin_batch_new(fd, .ctx = ctx[num_values], .engine = engine); + spin = igt_spin_new(fd, .ctx = ctx[num_values], .engine = engine);for (int v =0 ; v < num_values; v++) regs[v][1 ] =read_regs (fd, ctx[v], e, flags); regs[num_values][1 ] =read_regs (fd, ctx[num_values], e, flags); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);for (int v =0 ; v < num_values; v++) {char buf[80 ];
tests/i915/gem_eio.c +9 -9
@@ -181,7 +181,7 @@ static igt_spin_t * __spin_poll(int fd, uint32_t ctx, unsigned long flags)if (gem_can_store_dword (fd, opts.engine)) opts.flags |=IGT_SPIN_POLL_RUN ; -return __igt_spin_batch_factory (fd, &opts); +return __igt_spin_factory (fd, &opts); }static void __spin_wait (int fd,igt_spin_t *spin)
@@ -346,7 +346,7 @@ static void __test_banned(int fd)/* Trigger a reset, making sure we are detected as guilty */ hang =spin_sync (fd,0 ,0 );trigger_reset (fd); -igt_spin_batch_free (fd, hang); +igt_spin_free (fd, hang); count++; }
@@ -386,7 +386,7 @@ static void test_wait(int fd, unsigned int flags, unsigned int wait)check_wait (fd, hang->handle, wait,NULL ); -igt_spin_batch_free (fd, hang); +igt_spin_free (fd, hang);igt_require (i915_reset_control (true));
@@ -466,7 +466,7 @@ static void test_inflight(int fd, unsigned int wait)close (fence[n]); } -igt_spin_batch_free (fd, hang); +igt_spin_free (fd, hang);igt_assert (i915_reset_control (true));trigger_reset (fd);
@@ -522,7 +522,7 @@ static void test_inflight_suspend(int fd)close (fence[n]); } -igt_spin_batch_free (fd, hang); +igt_spin_free (fd, hang);igt_assert (i915_reset_control (true));trigger_reset (fd);close (fd);
@@ -600,7 +600,7 @@ static void test_inflight_contexts(int fd, unsigned int wait)close (fence[n]); } -igt_spin_batch_free (fd, hang); +igt_spin_free (fd, hang);gem_close (fd, obj[1 ].handle);igt_assert (i915_reset_control (true));trigger_reset (fd);
@@ -660,7 +660,7 @@ static void test_inflight_external(int fd)igt_assert_eq (sync_fence_status (fence), -EIO );close (fence); -igt_spin_batch_free (fd, hang); +igt_spin_free (fd, hang);igt_assert (i915_reset_control (true));trigger_reset (fd);close (fd);
@@ -709,7 +709,7 @@ static void test_inflight_internal(int fd, unsigned int wait)close (fences[nfence]); } -igt_spin_batch_free (fd, hang); +igt_spin_free (fd, hang);igt_assert (i915_reset_control (true));trigger_reset (fd);close (fd);
@@ -779,7 +779,7 @@ static void reset_stress(int fd,gem_execbuf (fd, &execbuf);gem_sync (fd, obj.handle); -igt_spin_batch_free (fd, hang); +igt_spin_free (fd, hang);gem_context_destroy (fd, ctx); }check_wait_elapsed (fd, &stats);
tests/i915/gem_exec_fence.c +16 -16
@@ -468,7 +468,7 @@ static void test_parallel(int fd, unsigned int master)/* Fill the queue with many requests so that the next one has to * wait before it can be executed by the hardware. */ - spin = igt_spin_batch_new(fd, .engine = master, .dependency = plug); + spin = igt_spin_new(fd, .engine = master, .dependency = plug);resubmit (fd, spin->handle, master,16 );/* Now queue the master request and its secondaries */
@@ -588,7 +588,7 @@ static void test_parallel(int fd, unsigned int master)/* Unblock the master */ igt_cork_unplug (&c);gem_close (fd, plug); -igt_spin_batch_end (spin); +igt_spin_end (spin);/* Wait for all secondaries to complete. If we used a regular fence * then the secondaries would not start until the master was complete.
@@ -651,7 +651,7 @@ static void test_keep_in_fence(int fd, unsigned int engine, unsigned int flags)igt_spin_t *spin;int fence; - spin = igt_spin_batch_new(fd, .engine = engine); + spin = igt_spin_new(fd, .engine = engine);gem_execbuf_wr (fd, &execbuf); fence =upper_32_bits (execbuf.rsvd2);
@@ -698,7 +698,7 @@ static void test_keep_in_fence(int fd, unsigned int engine, unsigned int flags)gem_close (fd, obj.handle);close (fence); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);gem_quiescent_gpu (fd); }
@@ -1070,7 +1070,7 @@ static void test_syncobj_unused_fence(int fd)struct local_gem_exec_fence fence = { .handle =syncobj_create (fd), }; -igt_spin_t *spin =igt_spin_batch_new (fd); +igt_spin_t *spin =igt_spin_new (fd);/* sanity check our syncobj_to_sync_file interface */ igt_assert_eq (__syncobj_to_sync_file (fd,0 ), -ENOENT );
@@ -1095,7 +1095,7 @@ static void test_syncobj_unused_fence(int fd)gem_close (fd, obj.handle);syncobj_destroy (fd, fence.handle); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin); }static void test_syncobj_invalid_wait (int fd)
@@ -1162,7 +1162,7 @@ static void test_syncobj_signal(int fd)struct local_gem_exec_fence fence = { .handle =syncobj_create (fd), }; -igt_spin_t *spin =igt_spin_batch_new (fd); +igt_spin_t *spin =igt_spin_new (fd);/* Check that the syncobj is signaled only when our request/fence is */
@@ -1183,7 +1183,7 @@ static void test_syncobj_signal(int fd)igt_assert (gem_bo_busy (fd, obj.handle));igt_assert (syncobj_busy (fd, fence.handle)); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);gem_sync (fd, obj.handle);igt_assert (!gem_bo_busy (fd, obj.handle));
@@ -1212,7 +1212,7 @@ static void test_syncobj_wait(int fd)gem_quiescent_gpu (fd); - spin =igt_spin_batch_new (fd); + spin =igt_spin_new (fd);memset (&execbuf,0 ,sizeof (execbuf)); execbuf.buffers_ptr =to_user_pointer (&obj);
@@ -1265,7 +1265,7 @@ static void test_syncobj_wait(int fd)for (int i =0 ; i < n; i++)igt_assert (gem_bo_busy (fd, handle[i])); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);for (int i =0 ; i < n; i++) {gem_sync (fd, handle[i]);
@@ -1282,7 +1282,7 @@ static void test_syncobj_export(int fd) .handle = syncobj_create(fd), };int export[2 ]; -igt_spin_t *spin =igt_spin_batch_new (fd); +igt_spin_t *spin =igt_spin_new (fd);/* Check that if we export the syncobj prior to use it picks up * the later fence. This allows a syncobj to establish a channel
@@ -1315,7 +1315,7 @@ static void test_syncobj_export(int fd)syncobj_destroy (fd, import); } -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);gem_sync (fd, obj.handle);igt_assert (!gem_bo_busy (fd, obj.handle));
@@ -1340,7 +1340,7 @@ static void test_syncobj_repeat(int fd)struct drm_i915_gem_execbuffer2 execbuf;struct local_gem_exec_fence *fence;int export; -igt_spin_t *spin =igt_spin_batch_new (fd); +igt_spin_t *spin =igt_spin_new (fd);/* Check that we can wait on the same fence multiple times */ fence =calloc (nfences,sizeof (*fence));
@@ -1378,7 +1378,7 @@ static void test_syncobj_repeat(int fd)igt_assert (syncobj_busy (fd, fence[i].handle));igt_assert (gem_bo_busy (fd, obj.handle)); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);gem_sync (fd, obj.handle);gem_close (fd, obj.handle);
@@ -1395,7 +1395,7 @@ static void test_syncobj_import(int fd)const uint32_t bbe =MI_BATCH_BUFFER_END ;struct drm_i915_gem_exec_object2 obj;struct drm_i915_gem_execbuffer2 execbuf; -igt_spin_t *spin =igt_spin_batch_new (fd); +igt_spin_t *spin =igt_spin_new (fd);uint32_t sync =syncobj_create (fd);int fence;
@@ -1423,7 +1423,7 @@ static void test_syncobj_import(int fd)igt_assert (gem_bo_busy (fd, obj.handle));igt_assert (syncobj_busy (fd, sync)); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);gem_sync (fd, obj.handle);igt_assert (!gem_bo_busy (fd, obj.handle));
tests/i915/gem_exec_latency.c +19 -19
@@ -78,16 +78,16 @@ poll_ring(int fd, unsigned ring, const char *name)gem_require_ring (fd, ring);igt_require (gem_can_store_dword (fd, ring)); - spin[0 ] =__igt_spin_batch_factory (fd, &opts); + spin[0 ] =__igt_spin_factory (fd, &opts);igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; - spin[1 ] =__igt_spin_batch_factory (fd, &opts); + spin[1 ] =__igt_spin_factory (fd, &opts);igt_assert (igt_spin_has_poll (spin[1 ]));igt_assert (cmd == *spin[1 ]->batch); -igt_spin_batch_end (spin[0 ]); +igt_spin_end (spin[0 ]);igt_spin_busywait_until_started (spin[1 ]);igt_assert (!gem_bo_busy (fd, spin[0 ]->handle));
@@ -100,15 +100,15 @@ poll_ring(int fd, unsigned ring, const char *name) spin[idx]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[idx]->execbuf); -igt_spin_batch_end (spin[!idx]); +igt_spin_end (spin[!idx]);igt_spin_busywait_until_started (spin[idx]); }igt_info ("%s completed %ld cycles: %.3f us\n" , name, cycles, elapsed*1e-3 /cycles); -igt_spin_batch_free (fd, spin[1 ]); -igt_spin_batch_free (fd, spin[0 ]); +igt_spin_free (fd, spin[1 ]); +igt_spin_free (fd, spin[0 ]); }#define RCS_TIMESTAMP (0x2000 + 0x358)
@@ -192,7 +192,7 @@ static void latency_on_ring(int fd, }if (flags &LIVE ) - spin = igt_spin_batch_new(fd, .engine = ring); + spin = igt_spin_new(fd, .engine = ring); start = *reg;for (j =0 ; j < repeats; j++) {
@@ -209,7 +209,7 @@ static void latency_on_ring(int fd, end = *reg;igt_assert (reloc.presumed_offset == obj[1 ].offset); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);if (flags &CORK )igt_cork_unplug (&c);
@@ -324,9 +324,9 @@ static void latency_from_ring(int fd, I915_GEM_DOMAIN_GTT);if (flags &PREEMPT ) - spin = __igt_spin_batch_new(fd, - .ctx = ctx[0], - .engine = ring); + spin = __igt_spin_new(fd, + .ctx = ctx[0], + .engine = ring);if (flags &CORK ) { obj[0 ].handle =igt_cork_plug (&c, fd);
@@ -393,7 +393,7 @@ static void latency_from_ring(int fd,gem_set_domain (fd, obj[1 ].handle,I915_GEM_DOMAIN_GTT ,I915_GEM_DOMAIN_GTT ); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin); igt_info("%s-%s delay: %.2fns\n", name, e__->name,
@@ -414,7 +414,7 @@ static void latency_from_ring(int fd, } } -static void __rearm_spin_batch (igt_spin_t *spin) +static void __rearm_spin (igt_spin_t *spin) {const uint32_t mi_arb_chk =0x5 <<23 ;
@@ -424,7 +424,7 @@ static void __rearm_spin_batch(igt_spin_t *spin) }static void -__submit_spin_batch (int fd,igt_spin_t *spin,unsigned int flags) +__submit_spin (int fd,igt_spin_t *spin,unsigned int flags) {struct drm_i915_gem_execbuffer2 eb = spin->execbuf;
@@ -531,7 +531,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned inusleep (250 ); - spin =__igt_spin_batch_factory (fd, &opts); + spin =__igt_spin_factory (fd, &opts);if (!spin) {igt_warn ("Failed to create spinner! (%s)\n" , passname[pass]);
@@ -543,7 +543,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned instruct timespec ts = { };double t; -igt_spin_batch_end (spin); +igt_spin_end (spin);gem_sync (fd, spin->handle);if (flags &RTIDLE )igt_drop_caches_set (fd,DROP_IDLE );
@@ -557,10 +557,10 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned inif (nengine >1 )usleep (10 *nengine); -__rearm_spin_batch (spin); +__rearm_spin (spin);igt_nsec_elapsed (&ts); -__submit_spin_batch (fd, spin, engine); +__submit_spin (fd, spin, engine);if (!__spin_wait (fd, spin)) {igt_warn ("Wait timeout! (%s)\n" , passname[pass]);
@@ -576,7 +576,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned inigt_mean_add (&mean, t); } -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin); igt_info("%8s %10s: mean=%.2fus stddev=%.3fus [%.2fus, %.2fus] (n=%lu)\n", names[child],
tests/i915/gem_exec_nop.c +4 -4
@@ -823,14 +823,14 @@ static void preempt(int fd, uint32_t handle,clock_gettime (CLOCK_MONOTONIC , &start); do { igt_spin_t *spin = - __igt_spin_batch_new(fd, - .ctx = ctx[0], - .engine = ring_id); + __igt_spin_new(fd, + .ctx = ctx[0], + .engine = ring_id); for (int loop = 0; loop < 1024; loop++) gem_execbuf(fd, &execbuf); - igt_spin_batch_free(fd, spin); + igt_spin_free(fd, spin); count += 1024; clock_gettime(CLOCK_MONOTONIC, &now);
tests/i915/gem_exec_reloc.c +13 -13
@@ -388,11 +388,11 @@ static void basic_reloc(int fd, unsigned before, unsigned after, unsigned flags) }if (flags &ACTIVE ) { - spin = igt_spin_batch_new(fd, - .engine = I915_EXEC_DEFAULT, - .dependency = obj.handle); + spin = igt_spin_new(fd, + .engine = I915_EXEC_DEFAULT, + .dependency = obj.handle);if (!(flags &HANG )) -igt_spin_batch_set_timeout (spin,NSEC_PER_SEC /100 ); +igt_spin_set_timeout (spin,NSEC_PER_SEC /100 );igt_assert (gem_bo_busy (fd, obj.handle)); }
@@ -424,7 +424,7 @@ static void basic_reloc(int fd, unsigned before, unsigned after, unsigned flags)igt_assert_eq_u64 (reloc.presumed_offset, offset);igt_assert_eq_u64 (obj.offset, offset); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);/* Simulate relocation */ if (flags &NORELOC ) {
@@ -456,11 +456,11 @@ static void basic_reloc(int fd, unsigned before, unsigned after, unsigned flags) }if (flags &ACTIVE ) { - spin = igt_spin_batch_new(fd, - .engine = I915_EXEC_DEFAULT, - .dependency = obj.handle); + spin = igt_spin_new(fd, + .engine = I915_EXEC_DEFAULT, + .dependency = obj.handle);if (!(flags &HANG )) -igt_spin_batch_set_timeout (spin,NSEC_PER_SEC /100 ); +igt_spin_set_timeout (spin,NSEC_PER_SEC /100 );igt_assert (gem_bo_busy (fd, obj.handle)); }
@@ -492,7 +492,7 @@ static void basic_reloc(int fd, unsigned before, unsigned after, unsigned flags)igt_assert_eq_u64 (reloc.presumed_offset, offset);igt_assert_eq_u64 (obj.offset, offset); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);if (trash)gem_close (fd, trash); }
@@ -585,14 +585,14 @@ static void basic_range(int fd, unsigned flags) execbuf.buffer_count = n +1 ;if (flags &ACTIVE ) { - spin = igt_spin_batch_new(fd, .dependency = obj[n].handle); + spin = igt_spin_new(fd, .dependency = obj[n].handle);if (!(flags &HANG )) -igt_spin_batch_set_timeout (spin,NSEC_PER_SEC /100 ); +igt_spin_set_timeout (spin,NSEC_PER_SEC /100 );igt_assert (gem_bo_busy (fd, obj[n].handle)); }gem_execbuf (fd, &execbuf); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);for (int i =0 ; i < n; i++) {uint64_t offset;
tests/i915/gem_exec_schedule.c +46 -46
226 lines not on this page · raw message
tests/i915/gem_exec_suspend.c +2 -2
@@ -189,7 +189,7 @@ static void run_test(int fd, unsigned engine, unsigned flags) }if (flags &HANG ) - spin = igt_spin_batch_new(fd, .engine = engine); + spin = igt_spin_new(fd, .engine = engine);switch (mode (flags)) {case NOSLEEP :
@@ -216,7 +216,7 @@ static void run_test(int fd, unsigned engine, unsigned flags)break ; } -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);check_bo (fd, obj[0 ].handle);gem_close (fd, obj[0 ].handle);
tests/i915/gem_fenced_exec_thrash.c +2 -2
@@ -132,14 +132,14 @@ static void run_test(int fd, int num_fences, int expected_errno,igt_spin_t *spin =NULL ;if (flags &BUSY_LOAD ) - spin =__igt_spin_batch_new (fd); + spin =__igt_spin_new (fd); igt_while_interruptible(flags & INTERRUPTIBLE) {igt_assert_eq (__gem_execbuf (fd, &execbuf[i]), -expected_errno); } -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);gem_quiescent_gpu (fd); } count++;
tests/i915/gem_mmap.c +2 -2
@@ -122,7 +122,7 @@ test_pf_nonblock(int i915)igt_spin_t *spin;uint32_t *ptr; - spin =igt_spin_batch_new (i915); + spin =igt_spin_new (i915);igt_set_timeout (1 ,"initial pagefaulting did not complete within 1s" );
@@ -132,7 +132,7 @@ test_pf_nonblock(int i915)igt_reset_timeout (); -igt_spin_batch_free (i915, spin); +igt_spin_free (i915, spin); }static int mmap_ioctl (int i915,struct drm_i915_gem_mmap *arg)
tests/i915/gem_mmap_gtt.c +2 -2
@@ -309,7 +309,7 @@ test_pf_nonblock(int i915)igt_require (mmap_gtt_version (i915) >=3 ); - spin =igt_spin_batch_new (i915); + spin =igt_spin_new (i915);igt_set_timeout (1 ,"initial pagefaulting did not complete within 1s" );
@@ -319,7 +319,7 @@ test_pf_nonblock(int i915)igt_reset_timeout (); -igt_spin_batch_free (i915, spin); +igt_spin_free (i915, spin); } static void
tests/i915/gem_mmap_wc.c +2 -2
@@ -448,7 +448,7 @@ test_pf_nonblock(int i915)igt_spin_t *spin;uint32_t *ptr; - spin =igt_spin_batch_new (i915); + spin =igt_spin_new (i915);igt_set_timeout (1 ,"initial pagefaulting did not complete within 1s" );
@@ -458,7 +458,7 @@ test_pf_nonblock(int i915)igt_reset_timeout (); -igt_spin_batch_free (i915, spin); +igt_spin_free (i915, spin); } static void
tests/i915/gem_shrink.c +5 -5
@@ -346,17 +346,17 @@ static void reclaim(unsigned engine, int timeout) }while (!*shared); } - spin = igt_spin_batch_new(fd, .engine = engine); + spin = igt_spin_new(fd, .engine = engine);igt_until_timeout (timeout) { - igt_spin_t *next = __igt_spin_batch_new(fd, .engine = engine); + igt_spin_t *next = __igt_spin_new(fd, .engine = engine); -igt_spin_batch_set_timeout (spin, timeout_100ms); +igt_spin_set_timeout (spin, timeout_100ms);gem_sync (fd, spin->handle); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin); spin = next; } -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin); *shared =1 ;igt_waitchildren ();
tests/i915/gem_spin_batch.c +10 -10
@@ -41,12 +41,12 @@ static void spin(int fd, unsigned int engine, unsigned int timeout_sec)struct timespec itv = { };uint64_t elapsed; - spin = __igt_spin_batch_new(fd, .engine = engine); + spin = __igt_spin_new(fd, .engine = engine);while ((elapsed =igt_nsec_elapsed (&tv)) >>30 < timeout_sec) { - igt_spin_t *next = __igt_spin_batch_new(fd, .engine = engine); + igt_spin_t *next = __igt_spin_new(fd, .engine = engine); -igt_spin_batch_set_timeout (spin, - timeout_100ms -igt_nsec_elapsed (&itv)); +igt_spin_set_timeout (spin, + timeout_100ms -igt_nsec_elapsed (&itv));gem_sync (fd, spin->handle); igt_debug("loop %lu: interval=%fms (target 100ms), elapsed %fms\n", loops,
@@ -54,11 +54,11 @@ static void spin(int fd, unsigned int engine, unsigned int timeout_sec) igt_nsec_elapsed(&tv) * 1e-6);memset (&itv,0 ,sizeof (itv)); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin); spin = next; loops++; } -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);igt_info ("Completed %ld loops in %lld ns, target %ld\n" , loops, (long long )elapsed, (long )(elapsed / timeout_100ms));
@@ -74,7 +74,7 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)const uint32_t ctx0 =gem_context_create (fd);const uint32_t ctx1 = (flags &RESUBMIT_NEW_CTX ) ?gem_context_create (fd) : ctx0; - igt_spin_t *spin = __igt_spin_batch_new(fd, .ctx = ctx0, .engine = engine); + igt_spin_t *spin = __igt_spin_new(fd, .ctx = ctx0, .engine = engine);unsigned int other;struct drm_i915_gem_execbuffer2 eb = {
@@ -96,11 +96,11 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)gem_execbuf (fd, &eb); } -igt_spin_batch_end (spin); +igt_spin_end (spin);gem_sync (fd, spin->obj[1 ].handle); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin);if (ctx1 != ctx0)gem_context_destroy (fd, ctx1);
@@ -110,7 +110,7 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)static void spin_exit_handler (int sig) { -igt_terminate_spin_batches (); +igt_terminate_spins (); }static void spin_on_all_engines (int fd,unsigned int timeout_sec)
tests/i915/gem_sync.c +37 -37
177 lines not on this page · raw message
tests/i915/gem_wait.c +6 -6
@@ -74,9 +74,9 @@ static void basic(int fd, unsigned engine, unsigned flags)IGT_CORK_HANDLE (cork);uint32_t plug = flags & (WRITE |AWAIT ) ?igt_cork_plug (&cork, fd) :0 ; - igt_spin_t *spin = igt_spin_batch_new(fd, - .engine = engine, - .dependency = plug); + igt_spin_t *spin = igt_spin_new(fd, + .engine = engine, + .dependency = plug);struct drm_i915_gem_wait wait = { flags &WRITE ? plug : spin->handle };
@@ -89,7 +89,7 @@ static void basic(int fd, unsigned engine, unsigned flags) timeout =120 ;if ((flags &HANG ) ==0 ) { -igt_spin_batch_set_timeout (spin,NSEC_PER_SEC /2 ); +igt_spin_set_timeout (spin,NSEC_PER_SEC /2 ); timeout =1 ; }
@@ -112,7 +112,7 @@ static void basic(int fd, unsigned engine, unsigned flags)igt_assert_eq (__gem_wait (fd, &wait), -ETIME );if ((flags &HANG ) ==0 ) { -igt_spin_batch_set_timeout (spin,NSEC_PER_SEC /2 ); +igt_spin_set_timeout (spin,NSEC_PER_SEC /2 ); wait.timeout_ns =NSEC_PER_SEC ;/* 1.0s */ igt_assert_eq (__gem_wait (fd, &wait),0 );igt_assert (wait.timeout_ns >=0 );
@@ -129,7 +129,7 @@ static void basic(int fd, unsigned engine, unsigned flags)if (plug)gem_close (fd, plug); -igt_spin_batch_free (fd, spin); +igt_spin_free (fd, spin); } igt_main
tests/i915/i915_pm_rps.c +13 -13
@@ -254,29 +254,29 @@ static void load_helper_run(enum load load)igt_debug ("Applying %s load...\n" , lh.load ?"high" :"low" ); prev_load = lh.load ==HIGH ; - spin[0 ] =__igt_spin_batch_new (drm_fd); + spin[0 ] =__igt_spin_new (drm_fd);if (prev_load) - spin[1 ] =__igt_spin_batch_new (drm_fd); + spin[1 ] =__igt_spin_new (drm_fd); prev_load = !prev_load;/* send the initial signal */ while (!lh.exit) {bool high_load; handle = spin[0 ]->handle; -igt_spin_batch_end (spin[0 ]); +igt_spin_end (spin[0 ]);while (gem_bo_busy (drm_fd, handle))usleep (100 ); -igt_spin_batch_free (drm_fd, spin[0 ]); +igt_spin_free (drm_fd, spin[0 ]);usleep (100 ); high_load = lh.load ==HIGH ;if (!high_load && spin[1 ]) { -igt_spin_batch_free (drm_fd, spin[1 ]); +igt_spin_free (drm_fd, spin[1 ]); spin[1 ] =NULL ; }else { spin[0 ] = spin[1 ]; } - spin[high_load] =__igt_spin_batch_new (drm_fd); + spin[high_load] =__igt_spin_new (drm_fd);if (lh.signal && high_load != prev_load) {write (lh.link, &lh.signal,sizeof (lh.signal));
@@ -286,11 +286,11 @@ static void load_helper_run(enum load load) } handle = spin[0 ]->handle; -igt_spin_batch_end (spin[0 ]); +igt_spin_end (spin[0 ]);if (spin[1 ]) { handle = spin[1 ]->handle; -igt_spin_batch_end (spin[1 ]); +igt_spin_end (spin[1 ]); }/* Wait for completion without boosting */
@@ -305,8 +305,8 @@ static void load_helper_run(enum load load)*/ igt_drop_caches_set (drm_fd,DROP_RETIRE ); -igt_spin_batch_free (drm_fd, spin[1 ]); -igt_spin_batch_free (drm_fd, spin[0 ]); +igt_spin_free (drm_fd, spin[1 ]); +igt_spin_free (drm_fd, spin[0 ]); }close (lh.link);
@@ -549,7 +549,7 @@ static void boost_freq(int fd, int *boost_freqs)int64_t timeout =1 ;igt_spin_t *load; - load =igt_spin_batch_new (fd); + load =igt_spin_new (fd);resubmit_batch (fd, load->handle,16 );/* Waiting will grant us a boost to maximum */
@@ -559,9 +559,9 @@ static void boost_freq(int fd, int *boost_freqs)dump (boost_freqs);/* Avoid downlocking till boost request is pending */ -igt_spin_batch_end (load); +igt_spin_end (load);gem_sync (fd, load->handle); -igt_spin_batch_free (fd, load); +igt_spin_free (fd, load); }static void waitboost (int fd,bool reset)
tests/kms_busy.c +13 -13
@@ -76,9 +76,9 @@ static void flip_to_fb(igt_display_t *dpy, int pipe,const int timeout = modeset ?8500 :100 ;struct drm_event_vblank ev; - igt_spin_t *t = igt_spin_batch_new(dpy->drm_fd, - .engine = ring, - .dependency = fb->gem_handle); + igt_spin_t *t = igt_spin_new(dpy->drm_fd, + .engine = ring, + .dependency = fb->gem_handle);if (modeset) {/*
@@ -115,7 +115,7 @@ static void flip_to_fb(igt_display_t *dpy, int pipe,igt_waitchildren_timeout (5 * timeout,"flip blocked waiting for busy bo\n" ); -igt_spin_batch_end (t); +igt_spin_end (t);igt_assert (read (dpy->drm_fd, &ev,sizeof (ev)) ==sizeof (ev));igt_assert (poll (&pfd,1 ,0 ) ==0 );
@@ -131,7 +131,7 @@ static void flip_to_fb(igt_display_t *dpy, int pipe,igt_display_commit2 (dpy,COMMIT_ATOMIC ); } -igt_spin_batch_free (dpy->drm_fd, t); +igt_spin_free (dpy->drm_fd, t); }static void test_flip (igt_display_t *dpy,unsigned ring,int pipe,bool modeset)
@@ -180,9 +180,9 @@ static void test_flip(igt_display_t *dpy, unsigned ring, int pipe, bool modeset)static void test_atomic_commit_hang (igt_display_t *dpy,igt_plane_t *primary,struct igt_fb *busy_fb,unsigned ring) { - igt_spin_t *t = igt_spin_batch_new(dpy->drm_fd, - .engine = ring, - .dependency = busy_fb->gem_handle); + igt_spin_t *t = igt_spin_new(dpy->drm_fd, + .engine = ring, + .dependency = busy_fb->gem_handle);struct pollfd pfd = { .fd = dpy->drm_fd, .events =POLLIN };unsigned flags =0 ;struct drm_event_vblank ev;
@@ -210,7 +210,7 @@ static void test_atomic_commit_hang(igt_display_t *dpy, igt_plane_t *primary,igt_assert (read (dpy->drm_fd, &ev,sizeof (ev)) ==sizeof (ev)); -igt_spin_batch_end (t); +igt_spin_end (t); } static void test_hang(igt_display_t *dpy, unsigned ring,
@@ -269,9 +269,9 @@ static void test_pageflip_modeset_hang(igt_display_t *dpy,igt_display_commit2 (dpy, dpy->is_atomic ?COMMIT_ATOMIC :COMMIT_LEGACY ); - t = igt_spin_batch_new(dpy->drm_fd, - .engine = ring, - .dependency = fb.gem_handle); + t = igt_spin_new(dpy->drm_fd, + .engine = ring, + .dependency = fb.gem_handle);do_or_die (drmModePageFlip (dpy->drm_fd, dpy->pipes[pipe].crtc_id, fb.fb_id,DRM_MODE_PAGE_FLIP_EVENT , &fb));
@@ -282,7 +282,7 @@ static void test_pageflip_modeset_hang(igt_display_t *dpy,igt_assert (read (dpy->drm_fd, &ev,sizeof (ev)) ==sizeof (ev)); -igt_spin_batch_end (t); +igt_spin_end (t);igt_remove_fb (dpy->drm_fd, &fb); }
tests/kms_cursor_legacy.c +6 -6
@@ -534,8 +534,8 @@ static void basic_flip_cursor(igt_display_t *display, spin =NULL ;if (flags &BASIC_BUSY ) - spin = igt_spin_batch_new(display->drm_fd, - .dependency = fb_info.gem_handle); + spin = igt_spin_new(display->drm_fd, + .dependency = fb_info.gem_handle);/* Start with a synchronous query to align with the vblank */ vblank_start =get_vblank (display->drm_fd, pipe,DRM_VBLANK_NEXTONMISS );
@@ -580,7 +580,7 @@ static void basic_flip_cursor(igt_display_t *display,if (spin) {struct pollfd pfd = { display->drm_fd,POLLIN };igt_assert (poll (&pfd,1 ,0 ) ==0 ); -igt_spin_batch_free (display->drm_fd, spin); +igt_spin_free (display->drm_fd, spin); }if (miss)
@@ -1321,8 +1321,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)for (int i =1 ; i >=0 ; i--) {igt_spin_t *spin; - spin = igt_spin_batch_new(display->drm_fd, - .dependency = fb_info[1 ].gem_handle); + spin = igt_spin_new(display->drm_fd, + .dependency = fb_info[1 ].gem_handle); vblank_start =get_vblank (display->drm_fd, pipe,DRM_VBLANK_NEXTONMISS );
@@ -1333,7 +1333,7 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)igt_pipe_crc_get_current (display->drm_fd, pipe_crc, &test_crc); -igt_spin_batch_free (display->drm_fd, spin); +igt_spin_free (display->drm_fd, spin);igt_set_timeout (1 ,"Stuck page flip" );igt_ignore_warn (read (display->drm_fd, &vbl,sizeof (vbl)));
tests/perf_pmu.c +49 -49
279 lines not on this page · raw message
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH i-g-t 2/3] lib/igt_dummyload: Get rid of 'batch' on spinner accessors
Quoting Mika Kuoppala (2019-04-17 16:28:33)
Quoted 6 lines
There is no guarantee that spinners are and will be implemented using batches. As we have
igt_spin_t, manipulate it through igt_spin_* functions consistently and hide the batch nature.Cc Chris Wilson <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 lib/igt_dummyload: Introduce igt_spin_reset
In reply to Mika KuoppalaLibify resetting a spin for reuse.
--- lib/igt_dummyload.c | 20 ++++++++++++++++++++ lib/igt_dummyload.h | 2 ++ tests/i915/gem_exec_latency.c | 19 ++++--------------- tests/i915/gem_sync.c | 34 ++++++++++++++-------------------- 4 files changed, 40 insertions(+), 35 deletions(-)
lib/igt_dummyload.c +20 -0
@@ -268,6 +268,8 @@ emit_recursive_batch(igt_spin_t *spin, obj[SCRATCH ].flags =EXEC_OBJECT_PINNED ; obj[BATCH ].flags =EXEC_OBJECT_PINNED ; + spin->cmd_spin = *spin->batch; +return fence_fd; }
@@ -374,6 +376,24 @@ void igt_spin_set_timeout(igt_spin_t *spin, int64_t ns) spin->timer = timer; } +/** +* igt_spin_reset: +* @spin: spin state from igt_spin_new() +* +* Reset the state of spin, allowing its reuse. +*/ +void igt_spin_reset (igt_spin_t *spin) +{ +if (!spin) +return ; + +if (igt_spin_has_poll (spin)) + spin->poll[SPIN_POLL_START_IDX ] =0 ; + + *spin->batch = spin->cmd_spin; +__sync_synchronize (); +} +/** * igt_spin_end: * @spin: spin state from igt_spin_new()
lib/igt_dummyload.h +2 -0
@@ -37,6 +37,7 @@ typedef struct igt_spin {timer_t timer;struct igt_list link;uint32_t *batch; +uint32_t cmd_spin;int out_fence;struct drm_i915_gem_exec_object2 obj[2 ];struct drm_i915_gem_execbuffer2 execbuf;
@@ -68,6 +69,7 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts); igt_spin_factory(fd, &((struct igt_spin_factory){__VA_ARGS__}))void igt_spin_set_timeout (igt_spin_t *spin,int64_t ns); +void igt_spin_reset (igt_spin_t *spin);void igt_spin_end (igt_spin_t *spin);void igt_spin_free (int fd,igt_spin_t *spin);
tests/i915/gem_exec_latency.c +4 -15
@@ -73,19 +73,17 @@ poll_ring(int fd, unsigned ring, const char *name)unsigned long cycles;igt_spin_t *spin[2 ];uint64_t elapsed; -uint32_t cmd;gem_require_ring (fd, ring);igt_require (gem_can_store_dword (fd, ring)); spin[0 ] =__igt_spin_factory (fd, &opts);igt_assert (igt_spin_has_poll (spin[0 ])); - cmd = *spin[0 ]->batch; spin[1 ] =__igt_spin_factory (fd, &opts);igt_assert (igt_spin_has_poll (spin[1 ])); -igt_assert (cmd == *spin[1 ]->batch); +igt_assert (*spin[0 ]->batch == *spin[1 ]->batch);igt_spin_end (spin[0 ]);igt_spin_busywait_until_started (spin[1 ]);
@@ -96,8 +94,8 @@ poll_ring(int fd, unsigned ring, const char *name)while ((elapsed =igt_nsec_elapsed (&tv)) <2ull <<30 ) {const unsigned int idx = cycles++ &1 ; - *spin[idx]->batch = cmd; - spin[idx]->poll[SPIN_POLL_START_IDX ] =0 ; +igt_spin_reset (spin[idx]); +gem_execbuf (fd, &spin[idx]->execbuf);igt_spin_end (spin[!idx]);
@@ -414,15 +412,6 @@ static void latency_from_ring(int fd, } } -static void __rearm_spin (igt_spin_t *spin) -{ -const uint32_t mi_arb_chk =0x5 <<23 ; - - *spin->batch = mi_arb_chk; - spin->poll[SPIN_POLL_START_IDX ] =0 ; -__sync_synchronize (); -} -static void __submit_spin (int fd,igt_spin_t *spin,unsigned int flags) {
@@ -557,7 +546,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned inif (nengine >1 )usleep (10 *nengine); -__rearm_spin (spin); +igt_spin_reset (spin);igt_nsec_elapsed (&ts);__submit_spin (fd, spin, engine);
tests/i915/gem_sync.c +14 -20
@@ -209,7 +209,6 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen)struct drm_i915_gem_execbuffer2 execbuf;double end, this, elapsed, now, baseline;unsigned long cycles; -uint32_t cmd;igt_spin_t *spin;memset (&object,0 ,sizeof (object));
@@ -226,7 +225,6 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST));igt_assert (igt_spin_has_poll (spin)); - cmd = *spin->batch;gem_execbuf (fd, &execbuf);
@@ -238,8 +236,8 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) elapsed =0 ; cycles =0 ; do { - *spin->batch = cmd; - spin->poll[SPIN_POLL_START_IDX] = 0; + igt_spin_reset(spin); + gem_execbuf(fd, &spin->execbuf); igt_spin_busywait_until_started(spin);
@@ -262,8 +260,8 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) elapsed =0 ; cycles =0 ; do { - *spin->batch = cmd; - spin->poll[SPIN_POLL_START_IDX] = 0; + igt_spin_reset(spin); + gem_execbuf(fd, &spin->execbuf); igt_spin_busywait_until_started(spin);
@@ -321,17 +319,14 @@ static void active_ring(int fd, unsigned ring, int timeout)double start, end, elapsed;unsigned long cycles;igt_spin_t *spin[2 ]; -uint32_t cmd; spin[0] = __igt_spin_new(fd, .engine = ring, .flags =IGT_SPIN_FAST ); - cmd = *spin[0 ]->batch; spin[1] = __igt_spin_new(fd, .engine = ring, .flags =IGT_SPIN_FAST ); -igt_assert (*spin[1 ]->batch == cmd); start =gettime (); end = start + timeout;
@@ -343,7 +338,8 @@ static void active_ring(int fd, unsigned ring, int timeout)igt_spin_end (s);gem_sync (fd, s->handle); - *s->batch = cmd; +igt_spin_reset (s); +gem_execbuf (fd, &s->execbuf); } cycles +=1024 ;
@@ -393,7 +389,6 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen)double end, this, elapsed, now, baseline;unsigned long cycles;igt_spin_t *spin[2 ]; -uint32_t cmd;memset (&object,0 ,sizeof (object)); object.handle =gem_create (fd,4096 );
@@ -409,7 +404,6 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST));igt_assert (igt_spin_has_poll (spin[0 ])); - cmd = *spin[0 ]->batch; spin[1] = __igt_spin_new(fd, .engine = execbuf.flags,
@@ -423,8 +417,8 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen)gem_sync (fd, object.handle);for (int warmup =0 ; warmup <=1 ; warmup++) { - *spin[0 ]->batch = cmd; - spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ; +igt_spin_reset (spin[0 ]); +gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout/10. ;
@@ -433,8 +427,8 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) do { igt_spin_busywait_until_started(spin[0]); - *spin[1]->batch = cmd; - spin[1]->poll[SPIN_POLL_START_IDX] = 0; + igt_spin_reset(spin[1]); + gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
@@ -454,8 +448,8 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) names[child % num_engines] ?" b" :"B" , cycles, elapsed*1e6/cycles); - *spin[0 ]->batch = cmd; - spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ; +igt_spin_reset (spin[0 ]); +gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout;
@@ -467,8 +461,8 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen)for (int n =0 ; n < wlen; n++)gem_execbuf (fd, &execbuf); - *spin[1 ]->batch = cmd; - spin[1 ]->poll[SPIN_POLL_START_IDX ] =0 ; +igt_spin_reset (spin[1 ]); +gem_execbuf (fd, &spin[1 ]->execbuf); this =gettime ();
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH i-g-t 3/3] lib/igt_dummyload: Introduce igt_spin_reset
Quoting Mika Kuoppala (2019-04-17 16:28:34)
Quoted 4 lines
Libify resetting a spin for reuse.
Cc Chris Wilson <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Mika Kuoppala (2019-04-17 16:28:32)
Quoted 22 lines
Instead of opencoding the poll into the spinner, use a helper to check if spinner has started.
Cc Chris Wilson <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>--- lib/igt_dummyload.c | 35 +++++++++++++++++++--------------- lib/igt_dummyload.h | 17 ++++++++++++++--- tests/i915/gem_ctx_exec.c | 4 +--- tests/i915/gem_ctx_isolation.c | 4 ++-- tests/i915/gem_eio.c | 4 ++-- tests/i915/gem_exec_latency.c | 22 ++++++++++----------- tests/i915/gem_exec_schedule.c | 5 ++--- tests/i915/gem_sync.c | 28 ++++++++++++--------------- tests/perf_pmu.c | 4 ++-- 9 files changed, 66 insertions(+), 57 deletions(-)lib/igt_dummyload.c +0
-0
lib/igt_dummyload.c static pthread_mutex_t list_lock = PTHREAD_MUTEX_INITIALIZER; · line 73
Quoted 8 lines
lib/igt_dummyload.c +2
-1@@ -67,11 +67,13 @@ static pthread_mutex_t list_lock = PTHREAD_MUTEX_INITIALIZER;static void fill_reloc (struct drm_i915_gem_relocation_entry *reloc, -uint32_t gem_handle,uint32_t offset, +uint32_t gem_handle,uint32_t offset,uint32_t delta,uint32_t read_domains,uint32_t write_domains) { + reloc->presumed_offset =-1 ;
This is wrong, we do use the presumed_offset of 0. -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/3 lib/igt_dummyload: libify checks for spin batch activation
Instead of opencoding the poll into the spinner, use a helper to check if spinner has started.
v2: use zero as presumed offset (Chris)
--- lib/igt_dummyload.c | 35 +++++++++++++++++++--------------- lib/igt_dummyload.h | 17 ++++++++++++++--- tests/i915/gem_ctx_exec.c | 4 +--- tests/i915/gem_ctx_isolation.c | 4 ++-- tests/i915/gem_eio.c | 4 ++-- tests/i915/gem_exec_latency.c | 22 ++++++++++----------- tests/i915/gem_exec_schedule.c | 5 ++--- tests/i915/gem_sync.c | 28 ++++++++++++--------------- tests/perf_pmu.c | 4 ++-- 9 files changed, 66 insertions(+), 57 deletions(-)
lib/igt_dummyload.c +20 -15
@@ -67,11 +67,13 @@ static pthread_mutex_t list_lock = PTHREAD_MUTEX_INITIALIZER;static void fill_reloc (struct drm_i915_gem_relocation_entry *reloc, -uint32_t gem_handle,uint32_t offset, +uint32_t gem_handle,uint32_t offset,uint32_t delta,uint32_t read_domains,uint32_t write_domains) { + reloc->presumed_offset =0 ; reloc->target_handle = gem_handle; reloc->offset = offset *sizeof (uint32_t ); + reloc->delta = delta *sizeof (uint32_t ); reloc->read_domains = read_domains; reloc->write_domain = write_domains; }
@@ -131,11 +133,13 @@ emit_recursive_batch(igt_spin_t *spin,/* dummy write to dependency */ obj[SCRATCH ].handle = opts->dependency;fill_reloc (&relocs[obj[BATCH ].relocation_count++], - opts->dependency,1020 , + opts->dependency,1020 ,0 ,I915_GEM_DOMAIN_RENDER ,I915_GEM_DOMAIN_RENDER ); execbuf->buffer_count++; }else if (opts->flags &IGT_SPIN_POLL_RUN ) { +const unsigned int start_idx_offset = +SPIN_POLL_START_IDX *sizeof (uint32_t );unsigned int offset;igt_assert (!opts->dependency);
@@ -149,36 +153,37 @@ emit_recursive_batch(igt_spin_t *spin,if (__gem_set_caching (fd, spin->poll_handle,I915_CACHING_CACHED ) ==0 ) - spin->running =gem_mmap__cpu (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); + spin->poll =gem_mmap__cpu (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE );else - spin->running =gem_mmap__wc (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); -igt_assert_eq (*spin->running,0 ); + spin->poll =gem_mmap__wc (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE ); +igt_assert_eq (spin->poll[SPIN_POLL_START_IDX ],0 ); *batch++ =MI_STORE_DWORD_IMM | (gen <6 ?1 <<22 :0 );if (gen >=8 ) { offset =1 ; - *batch++ =0 ; + *batch++ = start_idx_offset; *batch++ =0 ; }else if (gen >=4 ) { offset =2 ; *batch++ =0 ; - *batch++ =0 ; + *batch++ = start_idx_offset; }else { offset =1 ; batch[-1 ]--; - *batch++ =0 ; + *batch++ = start_idx_offset; } *batch++ =1 ; obj[SCRATCH ].handle = spin->poll_handle;fill_reloc (&relocs[obj[BATCH ].relocation_count++], - spin->poll_handle, offset,0 ,0 ); + spin->poll_handle, offset, +SPIN_POLL_START_IDX ,0 ,0 ); execbuf->buffer_count++; }
@@ -408,8 +413,8 @@ void igt_spin_batch_free(int fd, igt_spin_t *spin)gem_munmap ((void *)((unsigned long )spin->batch & (~4095UL )),BATCH_SIZE ); -if (spin->running) { -gem_munmap (spin->running,4096 ); +if (spin->poll) { +gem_munmap (spin->poll,4096 );gem_close (fd, spin->poll_handle); }
lib/igt_dummyload.h +14 -3
@@ -41,7 +41,8 @@ typedef struct igt_spin {struct drm_i915_gem_exec_object2 obj[2 ];struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle; -bool *running; +uint32_t *poll; +#define SPIN_POLL_START_IDX 0 } igt_spin_t;struct igt_spin_factory {
@@ -70,9 +71,19 @@ void igt_spin_batch_set_timeout(igt_spin_t *spin, int64_t ns);void igt_spin_batch_end (igt_spin_t *spin);void igt_spin_batch_free (int fd,igt_spin_t *spin); -static inline void igt_spin_busywait_until_running (igt_spin_t *spin) +static inline bool igt_spin_has_poll (const igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) +return spin->poll; +} + +static inline bool igt_spin_has_started (igt_spin_t *spin) +{ +return READ_ONCE (spin->poll[SPIN_POLL_START_IDX ]); +} + +static inline void igt_spin_busywait_until_started (igt_spin_t *spin) +{ +while (!igt_spin_has_started (spin)) ; }
tests/i915/gem_ctx_exec.c +1 -3
@@ -181,10 +181,8 @@ static void norecovery(int i915) spin = __igt_spin_batch_new(i915, .ctx = param.ctx_id, .flags =IGT_SPIN_POLL_RUN ); -igt_assert (spin->running); +igt_spin_busywait_until_started (spin); -while (!READ_ONCE (*spin->running)) - ;igt_force_gpu_reset (i915);igt_spin_batch_end (spin);
tests/i915/gem_ctx_isolation.c +2 -2
@@ -704,8 +704,8 @@ static void inject_reset_context(int fd, unsigned int engine) spin =__igt_spin_batch_factory (fd, &opts); -if (spin->running) -igt_spin_busywait_until_running (spin); +if (igt_spin_has_poll (spin)) +igt_spin_busywait_until_started (spin);else usleep (1000 );/* better than nothing */
tests/i915/gem_eio.c +2 -2
@@ -186,8 +186,8 @@ static igt_spin_t * __spin_poll(int fd, uint32_t ctx, unsigned long flags)static void __spin_wait (int fd,igt_spin_t *spin) { -if (spin->running) { -igt_spin_busywait_until_running (spin); +if (igt_spin_has_poll (spin)) { +igt_spin_busywait_until_started (spin); }else {igt_debug ("__spin_wait - usleep mode\n" );usleep (500e3 );/* Better than nothing! */
tests/i915/gem_exec_latency.c +11 -11
@@ -79,29 +79,29 @@ poll_ring(int fd, unsigned ring, const char *name)igt_require (gem_can_store_dword (fd, ring)); spin[0 ] =__igt_spin_batch_factory (fd, &opts); -igt_assert (spin[0 ]->running); +igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; spin[1 ] =__igt_spin_batch_factory (fd, &opts); -igt_assert (spin[1 ]->running); +igt_assert (igt_spin_has_poll (spin[1 ])); +igt_assert (cmd == *spin[1 ]->batch);igt_spin_batch_end (spin[0 ]); -while (!READ_ONCE (*spin[1 ]->running)) - ; +igt_spin_busywait_until_started (spin[1 ]); +igt_assert (!gem_bo_busy (fd, spin[0 ]->handle)); cycles =0 ;while ((elapsed =igt_nsec_elapsed (&tv)) <2ull <<30 ) { -unsigned int idx = cycles++ &1 ; +const unsigned int idx = cycles++ &1 ; *spin[idx]->batch = cmd; - *spin[idx]->running =0 ; + spin[idx]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[idx]->execbuf);igt_spin_batch_end (spin[!idx]); -while (!READ_ONCE (*spin[idx]->running)) - ; +igt_spin_busywait_until_started (spin[idx]); } igt_info("%s completed %ld cycles: %.3f us\n",
@@ -419,7 +419,7 @@ static void __rearm_spin_batch(igt_spin_t *spin)const uint32_t mi_arb_chk =0x5 <<23 ; *spin->batch = mi_arb_chk; - *spin->running =0 ; + spin->poll[SPIN_POLL_START_IDX ] =0 ;__sync_synchronize (); }
@@ -441,7 +441,7 @@ struct rt_pkt {static bool __spin_wait (int fd,igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) { +while (!igt_spin_has_started (spin)) {if (!gem_bo_busy (fd, spin->handle))return false; }
@@ -537,7 +537,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned in passname[pass]);break ; } -igt_spin_busywait_until_running (spin); +igt_spin_busywait_until_started (spin); igt_until_timeout(pass > 0 ? 5 : 2) {struct timespec ts = { };
tests/i915/gem_exec_schedule.c +2 -3
@@ -436,7 +436,7 @@ static void semaphore_codependency(int i915) .ctx = ctx, .engine = engine, .flags = IGT_SPIN_POLL_RUN); -igt_spin_busywait_until_running (task[i].xcs); +igt_spin_busywait_until_started (task[i].xcs);/* Common rcs tasks will be queued in FIFO */ task[i].rcs =
@@ -1361,8 +1361,7 @@ static void measure_semaphore_power(int i915) .engine = signaler, .flags = IGT_SPIN_POLL_RUN);gem_wait (i915, spin->handle, &jiffie);/* waitboost */ -igt_assert (spin->running); -igt_spin_busywait_until_running (spin); +igt_spin_busywait_until_started (spin);gpu_power_read (&power, &s_spin[0 ]);usleep (100 *1000 );
tests/i915/gem_sync.c +12 -16
@@ -225,7 +225,7 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .engine = execbuf.flags, .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST)); -igt_assert (spin->running); +igt_assert (igt_spin_has_poll (spin)); cmd = *spin->batch;gem_execbuf (fd, &execbuf);
@@ -239,10 +239,9 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles =0 ; do { *spin->batch = cmd; - *spin->running = 0; + spin->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin->execbuf); - while (!READ_ONCE(*spin->running)) - ; + igt_spin_busywait_until_started(spin); this = gettime(); igt_spin_batch_end(spin);
@@ -264,10 +263,9 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles =0 ; do { *spin->batch = cmd; - *spin->running = 0; + spin->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin->execbuf); - while (!READ_ONCE(*spin->running)) - ; + igt_spin_busywait_until_started(spin); for (int n = 0; n < wlen; n++) gem_execbuf(fd, &execbuf);
@@ -410,7 +408,7 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .engine = execbuf.flags, .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST)); -igt_assert (spin[0 ]->running); +igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; spin[1] = __igt_spin_batch_new(fd,
@@ -426,18 +424,17 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen)for (int warmup =0 ; warmup <=1 ; warmup++) { *spin[0 ]->batch = cmd; - *spin[0 ]->running =0 ; + spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout/10. ; elapsed =0 ; cycles =0 ; do { - while (!READ_ONCE(*spin[0]->running)) - ; + igt_spin_busywait_until_started(spin[0]); *spin[1]->batch = cmd; - *spin[1]->running = 0; + spin[1]->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
@@ -458,21 +455,20 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles, elapsed*1e6/cycles); *spin[0 ]->batch = cmd; - *spin[0 ]->running =0 ; + spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout; elapsed =0 ; cycles =0 ; do { - while (!READ_ONCE(*spin[0]->running)) - ; + igt_spin_busywait_until_started(spin[0]); for (int n = 0; n < wlen; n++) gem_execbuf(fd, &execbuf); *spin[1]->batch = cmd; - *spin[1]->running = 0; + spin[1]->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
tests/perf_pmu.c +2 -2
@@ -189,10 +189,10 @@ static unsigned long __spin_wait(int fd, igt_spin_t *spin)igt_nsec_elapsed (&start); -if (spin->running) { +if (igt_spin_has_poll (spin)) {unsigned long timeout =0 ; -while (!READ_ONCE (*spin->running)) { +while (!igt_spin_has_started (spin)) {unsigned long t =igt_nsec_elapsed (&start);if ((t - timeout) >250e6 ) {
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Mika Kuoppala (2019-04-17 16:54:56)
Quoted 27 lines
Instead of opencoding the poll into the spinner, use a helper to check if spinner has started.
v2: use zero as presumed offset (Chris)
Cc Chris Wilson <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>--- lib/igt_dummyload.c | 35 +++++++++++++++++++--------------- lib/igt_dummyload.h | 17 ++++++++++++++--- tests/i915/gem_ctx_exec.c | 4 +--- tests/i915/gem_ctx_isolation.c | 4 ++-- tests/i915/gem_eio.c | 4 ++-- tests/i915/gem_exec_latency.c | 22 ++++++++++----------- tests/i915/gem_exec_schedule.c | 5 ++--- tests/i915/gem_sync.c | 28 ++++++++++++--------------- tests/perf_pmu.c | 4 ++-- 9 files changed, 66 insertions(+), 57 deletions(-)lib/igt_dummyload.c +0
-0@@ -67,11 +67,13 @@ static pthread_mutex_t list_lock = PTHREAD_MUTEX_INITIALIZER; static void fill_reloc(struct drm_i915_gem_relocation_entry *reloc,
lib/igt_dummyload.c static pthread_mutex_t list_lock = PTHREAD_MUTEX_INITIALIZER; · line 78
Quoted 10 lines
lib/igt_dummyload.c +3
-1- uint32_t gem_handle, uint32_t offset, + uint32_t gem_handle, uint32_t offset, uint32_t delta, uint32_t read_domains, uint32_t write_domains) { + reloc->presumed_offset = 0; reloc->target_handle = gem_handle; reloc->offset = offset *sizeof (uint32_t ); + reloc->delta = delta *sizeof (uint32_t ); reloc->read_domains = read_domains; reloc->write_domain = write_domains;
If you are going to do this, do it right and
return reloc->presumed_offset + reloc->delta;
and use that to fill the batch.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/3 lib/igt_dummyload: libify checks for spin batch activation
Instead of opencoding the poll into the spinner, use a helper to check if spinner has started.
v2: use zero as presumed offset (Chris)
v3: cleanup the relocs (Chris)
--- lib/igt_dummyload.c | 66 +++++++++++++++++----------------- lib/igt_dummyload.h | 17 +++++++-- tests/i915/gem_ctx_exec.c | 4 +-- tests/i915/gem_ctx_isolation.c | 4 +-- tests/i915/gem_eio.c | 4 +-- tests/i915/gem_exec_latency.c | 22 ++++++------ tests/i915/gem_exec_schedule.c | 5 ++- tests/i915/gem_sync.c | 28 +++++++-------- tests/perf_pmu.c | 4 +-- 9 files changed, 78 insertions(+), 76 deletions(-)
lib/igt_dummyload.c +32 -34
@@ -65,17 +65,6 @@ static const int BATCH_SIZE = 4096;static IGT_LIST (spin_list);static pthread_mutex_t list_lock =PTHREAD_MUTEX_INITIALIZER ; -static void -fill_reloc (struct drm_i915_gem_relocation_entry *reloc, -uint32_t gem_handle,uint32_t offset, -uint32_t read_domains,uint32_t write_domains) -{ - reloc->target_handle = gem_handle; - reloc->offset = offset *sizeof (uint32_t ); - reloc->read_domains = read_domains; - reloc->write_domain = write_domains; -} -static int emit_recursive_batch (igt_spin_t *spin,int fd,const struct igt_spin_factory *opts)
@@ -128,15 +117,20 @@ emit_recursive_batch(igt_spin_t *spin,if (opts->dependency) {igt_assert (!(opts->flags &IGT_SPIN_POLL_RUN )); + r = &relocs[obj[BATCH ].relocation_count++]; +/* dummy write to dependency */ obj[SCRATCH ].handle = opts->dependency; -fill_reloc (&relocs[obj[BATCH ].relocation_count++], - opts->dependency,1020 , -I915_GEM_DOMAIN_RENDER , -I915_GEM_DOMAIN_RENDER ); + r->presumed_offset =0 ; + r->target_handle = obj[SCRATCH ].handle; + r->offset =sizeof (uint32_t ) *1020 ; + r->delta =0 ; + r->read_domains =I915_GEM_DOMAIN_RENDER ; + r->write_domain =I915_GEM_DOMAIN_RENDER ; + execbuf->buffer_count++; }else if (opts->flags &IGT_SPIN_POLL_RUN ) { -unsigned int offset; + r = &relocs[obj[BATCH ].relocation_count++];igt_assert (!opts->dependency);
@@ -146,39 +140,43 @@ emit_recursive_batch(igt_spin_t *spin, } spin->poll_handle =gem_create (fd,4096 ); + obj[SCRATCH ].handle = spin->poll_handle;if (__gem_set_caching (fd, spin->poll_handle,I915_CACHING_CACHED ) ==0 ) - spin->running =gem_mmap__cpu (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); + spin->poll =gem_mmap__cpu (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE );else - spin->running =gem_mmap__wc (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); -igt_assert_eq (*spin->running,0 ); + spin->poll =gem_mmap__wc (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE ); + +igt_assert_eq (spin->poll[SPIN_POLL_START_IDX ],0 ); + + r->presumed_offset =0 ; + r->target_handle = obj[SCRATCH ].handle; + r->offset =sizeof (uint32_t ) *1 ; + r->delta =sizeof (uint32_t ) *SPIN_POLL_START_IDX ; + r->read_domains =I915_GEM_DOMAIN_INSTRUCTION ; + r->write_domain =I915_GEM_DOMAIN_INSTRUCTION ; *batch++ =MI_STORE_DWORD_IMM | (gen <6 ?1 <<22 :0 );if (gen >=8 ) { - offset =1 ; - *batch++ =0 ; + *batch++ = r->delta; *batch++ =0 ; }else if (gen >=4 ) { - offset =2 ; - *batch++ =0 ; *batch++ =0 ; + *batch++ = r->delta; + r->offset +=sizeof (uint32_t ); }else { - offset =1 ; batch[-1 ]--; - *batch++ =0 ; + *batch++ = r->delta; } *batch++ =1 ; - obj[SCRATCH ].handle = spin->poll_handle; -fill_reloc (&relocs[obj[BATCH ].relocation_count++], - spin->poll_handle, offset,0 ,0 ); execbuf->buffer_count++; }
@@ -408,8 +406,8 @@ void igt_spin_batch_free(int fd, igt_spin_t *spin)gem_munmap ((void *)((unsigned long )spin->batch & (~4095UL )),BATCH_SIZE ); -if (spin->running) { -gem_munmap (spin->running,4096 ); +if (spin->poll) { +gem_munmap (spin->poll,4096 );gem_close (fd, spin->poll_handle); }
lib/igt_dummyload.h +14 -3
@@ -41,7 +41,8 @@ typedef struct igt_spin {struct drm_i915_gem_exec_object2 obj[2 ];struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle; -bool *running; +uint32_t *poll; +#define SPIN_POLL_START_IDX 0 } igt_spin_t;struct igt_spin_factory {
@@ -70,9 +71,19 @@ void igt_spin_batch_set_timeout(igt_spin_t *spin, int64_t ns);void igt_spin_batch_end (igt_spin_t *spin);void igt_spin_batch_free (int fd,igt_spin_t *spin); -static inline void igt_spin_busywait_until_running (igt_spin_t *spin) +static inline bool igt_spin_has_poll (const igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) +return spin->poll; +} + +static inline bool igt_spin_has_started (igt_spin_t *spin) +{ +return READ_ONCE (spin->poll[SPIN_POLL_START_IDX ]); +} + +static inline void igt_spin_busywait_until_started (igt_spin_t *spin) +{ +while (!igt_spin_has_started (spin)) ; }
tests/i915/gem_ctx_exec.c +1 -3
@@ -181,10 +181,8 @@ static void norecovery(int i915) spin = __igt_spin_batch_new(i915, .ctx = param.ctx_id, .flags =IGT_SPIN_POLL_RUN ); -igt_assert (spin->running); +igt_spin_busywait_until_started (spin); -while (!READ_ONCE (*spin->running)) - ;igt_force_gpu_reset (i915);igt_spin_batch_end (spin);
tests/i915/gem_ctx_isolation.c +2 -2
@@ -704,8 +704,8 @@ static void inject_reset_context(int fd, unsigned int engine) spin =__igt_spin_batch_factory (fd, &opts); -if (spin->running) -igt_spin_busywait_until_running (spin); +if (igt_spin_has_poll (spin)) +igt_spin_busywait_until_started (spin);else usleep (1000 );/* better than nothing */
tests/i915/gem_eio.c +2 -2
@@ -186,8 +186,8 @@ static igt_spin_t * __spin_poll(int fd, uint32_t ctx, unsigned long flags)static void __spin_wait (int fd,igt_spin_t *spin) { -if (spin->running) { -igt_spin_busywait_until_running (spin); +if (igt_spin_has_poll (spin)) { +igt_spin_busywait_until_started (spin); }else {igt_debug ("__spin_wait - usleep mode\n" );usleep (500e3 );/* Better than nothing! */
tests/i915/gem_exec_latency.c +11 -11
@@ -79,29 +79,29 @@ poll_ring(int fd, unsigned ring, const char *name)igt_require (gem_can_store_dword (fd, ring)); spin[0 ] =__igt_spin_batch_factory (fd, &opts); -igt_assert (spin[0 ]->running); +igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; spin[1 ] =__igt_spin_batch_factory (fd, &opts); -igt_assert (spin[1 ]->running); +igt_assert (igt_spin_has_poll (spin[1 ])); +igt_assert (cmd == *spin[1 ]->batch);igt_spin_batch_end (spin[0 ]); -while (!READ_ONCE (*spin[1 ]->running)) - ; +igt_spin_busywait_until_started (spin[1 ]); +igt_assert (!gem_bo_busy (fd, spin[0 ]->handle)); cycles =0 ;while ((elapsed =igt_nsec_elapsed (&tv)) <2ull <<30 ) { -unsigned int idx = cycles++ &1 ; +const unsigned int idx = cycles++ &1 ; *spin[idx]->batch = cmd; - *spin[idx]->running =0 ; + spin[idx]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[idx]->execbuf);igt_spin_batch_end (spin[!idx]); -while (!READ_ONCE (*spin[idx]->running)) - ; +igt_spin_busywait_until_started (spin[idx]); } igt_info("%s completed %ld cycles: %.3f us\n",
@@ -419,7 +419,7 @@ static void __rearm_spin_batch(igt_spin_t *spin)const uint32_t mi_arb_chk =0x5 <<23 ; *spin->batch = mi_arb_chk; - *spin->running =0 ; + spin->poll[SPIN_POLL_START_IDX ] =0 ;__sync_synchronize (); }
@@ -441,7 +441,7 @@ struct rt_pkt {static bool __spin_wait (int fd,igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) { +while (!igt_spin_has_started (spin)) {if (!gem_bo_busy (fd, spin->handle))return false; }
@@ -537,7 +537,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned in passname[pass]);break ; } -igt_spin_busywait_until_running (spin); +igt_spin_busywait_until_started (spin); igt_until_timeout(pass > 0 ? 5 : 2) {struct timespec ts = { };
tests/i915/gem_exec_schedule.c +2 -3
@@ -436,7 +436,7 @@ static void semaphore_codependency(int i915) .ctx = ctx, .engine = engine, .flags = IGT_SPIN_POLL_RUN); -igt_spin_busywait_until_running (task[i].xcs); +igt_spin_busywait_until_started (task[i].xcs);/* Common rcs tasks will be queued in FIFO */ task[i].rcs =
@@ -1361,8 +1361,7 @@ static void measure_semaphore_power(int i915) .engine = signaler, .flags = IGT_SPIN_POLL_RUN);gem_wait (i915, spin->handle, &jiffie);/* waitboost */ -igt_assert (spin->running); -igt_spin_busywait_until_running (spin); +igt_spin_busywait_until_started (spin);gpu_power_read (&power, &s_spin[0 ]);usleep (100 *1000 );
tests/i915/gem_sync.c +12 -16
@@ -225,7 +225,7 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .engine = execbuf.flags, .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST)); -igt_assert (spin->running); +igt_assert (igt_spin_has_poll (spin)); cmd = *spin->batch;gem_execbuf (fd, &execbuf);
@@ -239,10 +239,9 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles =0 ; do { *spin->batch = cmd; - *spin->running = 0; + spin->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin->execbuf); - while (!READ_ONCE(*spin->running)) - ; + igt_spin_busywait_until_started(spin); this = gettime(); igt_spin_batch_end(spin);
@@ -264,10 +263,9 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles =0 ; do { *spin->batch = cmd; - *spin->running = 0; + spin->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin->execbuf); - while (!READ_ONCE(*spin->running)) - ; + igt_spin_busywait_until_started(spin); for (int n = 0; n < wlen; n++) gem_execbuf(fd, &execbuf);
@@ -410,7 +408,7 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .engine = execbuf.flags, .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST)); -igt_assert (spin[0 ]->running); +igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; spin[1] = __igt_spin_batch_new(fd,
@@ -426,18 +424,17 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen)for (int warmup =0 ; warmup <=1 ; warmup++) { *spin[0 ]->batch = cmd; - *spin[0 ]->running =0 ; + spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout/10. ; elapsed =0 ; cycles =0 ; do { - while (!READ_ONCE(*spin[0]->running)) - ; + igt_spin_busywait_until_started(spin[0]); *spin[1]->batch = cmd; - *spin[1]->running = 0; + spin[1]->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
@@ -458,21 +455,20 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles, elapsed*1e6/cycles); *spin[0 ]->batch = cmd; - *spin[0 ]->running =0 ; + spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout; elapsed =0 ; cycles =0 ; do { - while (!READ_ONCE(*spin[0]->running)) - ; + igt_spin_busywait_until_started(spin[0]); for (int n = 0; n < wlen; n++) gem_execbuf(fd, &execbuf); *spin[1]->batch = cmd; - *spin[1]->running = 0; + spin[1]->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
tests/perf_pmu.c +2 -2
@@ -189,10 +189,10 @@ static unsigned long __spin_wait(int fd, igt_spin_t *spin)igt_nsec_elapsed (&start); -if (spin->running) { +if (igt_spin_has_poll (spin)) {unsigned long timeout =0 ; -while (!READ_ONCE (*spin->running)) { +while (!igt_spin_has_started (spin)) {unsigned long t =igt_nsec_elapsed (&start);if ((t - timeout) >250e6 ) {
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Mika Kuoppala (2019-04-17 17:43:39)
Quoted 15 lines
Instead of opencoding the poll into the spinner, use a helper to check if spinner has started.
v2: use zero as presumed offset (Chris)
v3: cleanup the relocs (Chris)Cc Chris Wilson <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>---
static int
emit_recursive_batch(igt_spin_t *spin,
int fd, const structigt_spin_factory*opts)lib/igt_dummyload.c +0
-0@@ -128,15 +117,20 @@ emit_recursive_batch(igt_spin_t *spin,if (opts->dependency) {igt_assert (!(opts->flags &IGT_SPIN_POLL_RUN ));
lib/igt_dummyload.c emit_recursive_batch(igt_spin_t *spin, · line 124
Quoted 10 lines
lib/igt_dummyload.c +3
-4+ r = &relocs[obj[BATCH ].relocation_count++]; +/* dummy write to dependency */ obj[SCRATCH ].handle = opts->dependency; -fill_reloc (&relocs[obj[BATCH ].relocation_count++], - opts->dependency,1020 , -I915_GEM_DOMAIN_RENDER , -I915_GEM_DOMAIN_RENDER ); + r->presumed_offset =0 ;
fwiw, we could make this r->presumed_offset = 4096 and save the kernel having to patch the batch.
Quoted 31 lines
lib/igt_dummyload.c +11
-7+ r->target_handle = obj[SCRATCH ].handle; + r->offset =sizeof (uint32_t ) *1020 ; + r->delta =0 ; + r->read_domains =I915_GEM_DOMAIN_RENDER ; + r->write_domain =I915_GEM_DOMAIN_RENDER ; + execbuf->buffer_count++; }else if (opts->flags &IGT_SPIN_POLL_RUN ) { -unsigned int offset; + r = &relocs[obj[BATCH ].relocation_count++];igt_assert (!opts->dependency);@@ -146,39 +140,43 @@ emit_recursive_batch(igt_spin_t *spin, } spin->poll_handle =gem_create (fd,4096 ); + obj[SCRATCH ].handle = spin->poll_handle;if (__gem_set_caching (fd, spin->poll_handle,I915_CACHING_CACHED ) ==0 ) - spin->running =gem_mmap__cpu (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); + spin->poll =gem_mmap__cpu (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE );else - spin->running =gem_mmap__wc (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE );
lib/igt_dummyload.c emit_recursive_batch(igt_spin_t *spin, · line 159
Quoted 10 lines
lib/igt_dummyload.c +9
-1-igt_assert_eq (*spin->running,0 ); + spin->poll =gem_mmap__wc (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE ); + +igt_assert_eq (spin->poll[SPIN_POLL_START_IDX ],0 ); + + r->presumed_offset =0 ; + r->target_handle = obj[SCRATCH ].handle; + r->offset =sizeof (uint32_t ) *1 ;
* 1.
May be a bit overkill in the pedantry stakes.
Quoted 48 lines
lib/igt_dummyload.c +9
-11+ r->delta =sizeof (uint32_t ) *SPIN_POLL_START_IDX ; + r->read_domains =I915_GEM_DOMAIN_INSTRUCTION ; + r->write_domain =I915_GEM_DOMAIN_INSTRUCTION ; *batch++ =MI_STORE_DWORD_IMM | (gen <6 ?1 <<22 :0 );if (gen >=8 ) { - offset =1 ; - *batch++ =0 ; + *batch++ = r->delta; *batch++ =0 ; }else if (gen >=4 ) { - offset =2 ; - *batch++ =0 ; *batch++ =0 ; + *batch++ = r->delta; + r->offset +=sizeof (uint32_t ); }else { - offset =1 ; batch[-1 ]--; - *batch++ =0 ; + *batch++ = r->delta; } *batch++ =1 ; - obj[SCRATCH ].handle = spin->poll_handle; -fill_reloc (&relocs[obj[BATCH ].relocation_count++], - spin->poll_handle, offset,0 ,0 ); execbuf->buffer_count++; }@@ -408,8 +406,8 @@ void igt_spin_batch_free(int fd, igt_spin_t *spin)gem_munmap ((void *)((unsigned long )spin->batch & (~4095UL )),BATCH_SIZE ); -if (spin->running) { -gem_munmap (spin->running,4096 ); +if (spin->poll) { +gem_munmap (spin->poll,4096 );gem_close (fd, spin->poll_handle); }lib/igt_dummyload.h +0
-0
lib/igt_dummyload.h typedef struct igt_spin { · line 45
Quoted 6 lines
lib/igt_dummyload.h +2
-1@@ -41,7 +41,8 @@ typedef struct igt_spin {struct drm_i915_gem_exec_object2 obj[2 ];struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle; -bool *running; +uint32_t *poll; +#define SPIN_POLL_START_IDX 0
Planning more than one? Plausible, you could stick the timestamp in there as well, or share the scratch with others.
Just looks very suspicious all by itself :-p
Quoted 13 lines
lib/igt_dummyload.h +3
-2} igt_spin_t;struct igt_spin_factory {@@ -70,9 +71,19 @@ void igt_spin_batch_set_timeout(igt_spin_t *spin, int64_t ns);void igt_spin_batch_end (igt_spin_t *spin);void igt_spin_batch_free (int fd,igt_spin_t *spin); -static inline void igt_spin_busywait_until_running (igt_spin_t *spin) +static inline bool igt_spin_has_poll (const igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) +return spin->poll; +}
lib/igt_dummyload.h void igt_spin_batch_set_timeout(igt_spin_t *spin, int64_t ns); · line 87
Quoted 10 lines
lib/igt_dummyload.h +9
-0+ +static inline bool igt_spin_has_started (igt_spin_t *spin) +{ +return READ_ONCE (spin->poll[SPIN_POLL_START_IDX ]); +} + +static inline void igt_spin_busywait_until_started (igt_spin_t *spin) +{ +while (!igt_spin_has_started (spin)) ;
I keep fearing the gpu hang that leaves this spinning for ever.
while (gem_busy(spin->handle) && !igt_spin_has_started(spin))
;
igt_assert(igt_spin_has_started(spin));
give or take the lack of spin->fd and generalisation of gem_busy. A problem for another day.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/3 lib/igt_dummyload: libify checks for spin batch activation
Instead of opencoding the poll into the spinner, use a helper to check if spinner has started.
v2: use zero as presumed offset (Chris)
v3: cleanup the relocs (Chris)
v4: leave the domains to zero, avoid relocation (Chris)
--- lib/igt_dummyload.c | 65 ++++++++++++++++------------------ lib/igt_dummyload.h | 17 +++++++-- tests/i915/gem_ctx_exec.c | 4 +-- tests/i915/gem_ctx_isolation.c | 4 +-- tests/i915/gem_eio.c | 4 +-- tests/i915/gem_exec_latency.c | 22 ++++++------ tests/i915/gem_exec_schedule.c | 5 ++- tests/i915/gem_sync.c | 28 +++++++-------- tests/perf_pmu.c | 4 +-- 9 files changed, 77 insertions(+), 76 deletions(-)
lib/igt_dummyload.c +31 -34
@@ -65,17 +65,6 @@ static const int BATCH_SIZE = 4096;static IGT_LIST (spin_list);static pthread_mutex_t list_lock =PTHREAD_MUTEX_INITIALIZER ; -static void -fill_reloc (struct drm_i915_gem_relocation_entry *reloc, -uint32_t gem_handle,uint32_t offset, -uint32_t read_domains,uint32_t write_domains) -{ - reloc->target_handle = gem_handle; - reloc->offset = offset *sizeof (uint32_t ); - reloc->read_domains = read_domains; - reloc->write_domain = write_domains; -} -static int emit_recursive_batch (igt_spin_t *spin,int fd,const struct igt_spin_factory *opts)
@@ -128,15 +117,20 @@ emit_recursive_batch(igt_spin_t *spin,if (opts->dependency) {igt_assert (!(opts->flags &IGT_SPIN_POLL_RUN )); + r = &relocs[obj[BATCH ].relocation_count++]; +/* dummy write to dependency */ obj[SCRATCH ].handle = opts->dependency; -fill_reloc (&relocs[obj[BATCH ].relocation_count++], - opts->dependency,1020 , -I915_GEM_DOMAIN_RENDER , -I915_GEM_DOMAIN_RENDER ); + r->presumed_offset =0 ; + r->target_handle = obj[SCRATCH ].handle; + r->offset =sizeof (uint32_t ) *1020 ; + r->delta =0 ; + r->read_domains =I915_GEM_DOMAIN_RENDER ; + r->write_domain =I915_GEM_DOMAIN_RENDER ; + execbuf->buffer_count++; }else if (opts->flags &IGT_SPIN_POLL_RUN ) { -unsigned int offset; + r = &relocs[obj[BATCH ].relocation_count++];igt_assert (!opts->dependency);
@@ -146,39 +140,42 @@ emit_recursive_batch(igt_spin_t *spin, } spin->poll_handle =gem_create (fd,4096 ); + obj[SCRATCH ].handle = spin->poll_handle;if (__gem_set_caching (fd, spin->poll_handle,I915_CACHING_CACHED ) ==0 ) - spin->running =gem_mmap__cpu (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); + spin->poll =gem_mmap__cpu (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE );else - spin->running =gem_mmap__wc (fd, spin->poll_handle, -0 ,4096 , -PROT_READ |PROT_WRITE ); -igt_assert_eq (*spin->running,0 ); + spin->poll =gem_mmap__wc (fd, spin->poll_handle, +0 ,4096 , +PROT_READ |PROT_WRITE ); + +igt_assert_eq (spin->poll[SPIN_POLL_START_IDX ],0 ); + +/* batch is first */ + r->presumed_offset =4096 ; + r->target_handle = obj[SCRATCH ].handle; + r->offset =sizeof (uint32_t ) *1 ; + r->delta =sizeof (uint32_t ) *SPIN_POLL_START_IDX ; *batch++ =MI_STORE_DWORD_IMM | (gen <6 ?1 <<22 :0 );if (gen >=8 ) { - offset =1 ; - *batch++ =0 ; + *batch++ = r->presumed_offset + r->delta; *batch++ =0 ; }else if (gen >=4 ) { - offset =2 ; - *batch++ =0 ; *batch++ =0 ; + *batch++ = r->presumed_offset + r->delta; + r->offset +=sizeof (uint32_t ); }else { - offset =1 ; batch[-1 ]--; - *batch++ =0 ; + *batch++ = r->presumed_offset + r->delta; } *batch++ =1 ; - obj[SCRATCH ].handle = spin->poll_handle; -fill_reloc (&relocs[obj[BATCH ].relocation_count++], - spin->poll_handle, offset,0 ,0 ); execbuf->buffer_count++; }
@@ -408,8 +405,8 @@ void igt_spin_batch_free(int fd, igt_spin_t *spin)gem_munmap ((void *)((unsigned long )spin->batch & (~4095UL )),BATCH_SIZE ); -if (spin->running) { -gem_munmap (spin->running,4096 ); +if (spin->poll) { +gem_munmap (spin->poll,4096 );gem_close (fd, spin->poll_handle); }
lib/igt_dummyload.h +14 -3
@@ -41,7 +41,8 @@ typedef struct igt_spin {struct drm_i915_gem_exec_object2 obj[2 ];struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle; -bool *running; +uint32_t *poll; +#define SPIN_POLL_START_IDX 0 } igt_spin_t;struct igt_spin_factory {
@@ -70,9 +71,19 @@ void igt_spin_batch_set_timeout(igt_spin_t *spin, int64_t ns);void igt_spin_batch_end (igt_spin_t *spin);void igt_spin_batch_free (int fd,igt_spin_t *spin); -static inline void igt_spin_busywait_until_running (igt_spin_t *spin) +static inline bool igt_spin_has_poll (const igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) +return spin->poll; +} + +static inline bool igt_spin_has_started (igt_spin_t *spin) +{ +return READ_ONCE (spin->poll[SPIN_POLL_START_IDX ]); +} + +static inline void igt_spin_busywait_until_started (igt_spin_t *spin) +{ +while (!igt_spin_has_started (spin)) ; }
tests/i915/gem_ctx_exec.c +1 -3
@@ -181,10 +181,8 @@ static void norecovery(int i915) spin = __igt_spin_batch_new(i915, .ctx = param.ctx_id, .flags =IGT_SPIN_POLL_RUN ); -igt_assert (spin->running); +igt_spin_busywait_until_started (spin); -while (!READ_ONCE (*spin->running)) - ;igt_force_gpu_reset (i915);igt_spin_batch_end (spin);
tests/i915/gem_ctx_isolation.c +2 -2
@@ -704,8 +704,8 @@ static void inject_reset_context(int fd, unsigned int engine) spin =__igt_spin_batch_factory (fd, &opts); -if (spin->running) -igt_spin_busywait_until_running (spin); +if (igt_spin_has_poll (spin)) +igt_spin_busywait_until_started (spin);else usleep (1000 );/* better than nothing */
tests/i915/gem_eio.c +2 -2
@@ -186,8 +186,8 @@ static igt_spin_t * __spin_poll(int fd, uint32_t ctx, unsigned long flags)static void __spin_wait (int fd,igt_spin_t *spin) { -if (spin->running) { -igt_spin_busywait_until_running (spin); +if (igt_spin_has_poll (spin)) { +igt_spin_busywait_until_started (spin); }else {igt_debug ("__spin_wait - usleep mode\n" );usleep (500e3 );/* Better than nothing! */
tests/i915/gem_exec_latency.c +11 -11
@@ -79,29 +79,29 @@ poll_ring(int fd, unsigned ring, const char *name)igt_require (gem_can_store_dword (fd, ring)); spin[0 ] =__igt_spin_batch_factory (fd, &opts); -igt_assert (spin[0 ]->running); +igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; spin[1 ] =__igt_spin_batch_factory (fd, &opts); -igt_assert (spin[1 ]->running); +igt_assert (igt_spin_has_poll (spin[1 ])); +igt_assert (cmd == *spin[1 ]->batch);igt_spin_batch_end (spin[0 ]); -while (!READ_ONCE (*spin[1 ]->running)) - ; +igt_spin_busywait_until_started (spin[1 ]); +igt_assert (!gem_bo_busy (fd, spin[0 ]->handle)); cycles =0 ;while ((elapsed =igt_nsec_elapsed (&tv)) <2ull <<30 ) { -unsigned int idx = cycles++ &1 ; +const unsigned int idx = cycles++ &1 ; *spin[idx]->batch = cmd; - *spin[idx]->running =0 ; + spin[idx]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[idx]->execbuf);igt_spin_batch_end (spin[!idx]); -while (!READ_ONCE (*spin[idx]->running)) - ; +igt_spin_busywait_until_started (spin[idx]); } igt_info("%s completed %ld cycles: %.3f us\n",
@@ -419,7 +419,7 @@ static void __rearm_spin_batch(igt_spin_t *spin)const uint32_t mi_arb_chk =0x5 <<23 ; *spin->batch = mi_arb_chk; - *spin->running =0 ; + spin->poll[SPIN_POLL_START_IDX ] =0 ;__sync_synchronize (); }
@@ -441,7 +441,7 @@ struct rt_pkt {static bool __spin_wait (int fd,igt_spin_t *spin) { -while (!READ_ONCE (*spin->running)) { +while (!igt_spin_has_started (spin)) {if (!gem_bo_busy (fd, spin->handle))return false; }
@@ -537,7 +537,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned in passname[pass]);break ; } -igt_spin_busywait_until_running (spin); +igt_spin_busywait_until_started (spin); igt_until_timeout(pass > 0 ? 5 : 2) {struct timespec ts = { };
tests/i915/gem_exec_schedule.c +2 -3
@@ -436,7 +436,7 @@ static void semaphore_codependency(int i915) .ctx = ctx, .engine = engine, .flags = IGT_SPIN_POLL_RUN); -igt_spin_busywait_until_running (task[i].xcs); +igt_spin_busywait_until_started (task[i].xcs);/* Common rcs tasks will be queued in FIFO */ task[i].rcs =
@@ -1361,8 +1361,7 @@ static void measure_semaphore_power(int i915) .engine = signaler, .flags = IGT_SPIN_POLL_RUN);gem_wait (i915, spin->handle, &jiffie);/* waitboost */ -igt_assert (spin->running); -igt_spin_busywait_until_running (spin); +igt_spin_busywait_until_started (spin);gpu_power_read (&power, &s_spin[0 ]);usleep (100 *1000 );
tests/i915/gem_sync.c +12 -16
@@ -225,7 +225,7 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .engine = execbuf.flags, .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST)); -igt_assert (spin->running); +igt_assert (igt_spin_has_poll (spin)); cmd = *spin->batch;gem_execbuf (fd, &execbuf);
@@ -239,10 +239,9 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles =0 ; do { *spin->batch = cmd; - *spin->running = 0; + spin->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin->execbuf); - while (!READ_ONCE(*spin->running)) - ; + igt_spin_busywait_until_started(spin); this = gettime(); igt_spin_batch_end(spin);
@@ -264,10 +263,9 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles =0 ; do { *spin->batch = cmd; - *spin->running = 0; + spin->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin->execbuf); - while (!READ_ONCE(*spin->running)) - ; + igt_spin_busywait_until_started(spin); for (int n = 0; n < wlen; n++) gem_execbuf(fd, &execbuf);
@@ -410,7 +408,7 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) .engine = execbuf.flags, .flags = (IGT_SPIN_POLL_RUN | IGT_SPIN_FAST)); -igt_assert (spin[0 ]->running); +igt_assert (igt_spin_has_poll (spin[0 ])); cmd = *spin[0 ]->batch; spin[1] = __igt_spin_batch_new(fd,
@@ -426,18 +424,17 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen)for (int warmup =0 ; warmup <=1 ; warmup++) { *spin[0 ]->batch = cmd; - *spin[0 ]->running =0 ; + spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout/10. ; elapsed =0 ; cycles =0 ; do { - while (!READ_ONCE(*spin[0]->running)) - ; + igt_spin_busywait_until_started(spin[0]); *spin[1]->batch = cmd; - *spin[1]->running = 0; + spin[1]->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
@@ -458,21 +455,20 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) cycles, elapsed*1e6/cycles); *spin[0 ]->batch = cmd; - *spin[0 ]->running =0 ; + spin[0 ]->poll[SPIN_POLL_START_IDX ] =0 ;gem_execbuf (fd, &spin[0 ]->execbuf); end =gettime () + timeout; elapsed =0 ; cycles =0 ; do { - while (!READ_ONCE(*spin[0]->running)) - ; + igt_spin_busywait_until_started(spin[0]); for (int n = 0; n < wlen; n++) gem_execbuf(fd, &execbuf); *spin[1]->batch = cmd; - *spin[1]->running = 0; + spin[1]->poll[SPIN_POLL_START_IDX] = 0; gem_execbuf(fd, &spin[1]->execbuf); this = gettime();
tests/perf_pmu.c +2 -2
@@ -189,10 +189,10 @@ static unsigned long __spin_wait(int fd, igt_spin_t *spin)igt_nsec_elapsed (&start); -if (spin->running) { +if (igt_spin_has_poll (spin)) {unsigned long timeout =0 ; -while (!READ_ONCE (*spin->running)) { +while (!igt_spin_has_started (spin)) {unsigned long t =igt_nsec_elapsed (&start);if ((t - timeout) >250e6 ) {
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation
URL : https://patchwork.freedesktop.org/series/59655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5948 -> IGTPW_2885
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59655/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2885 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +52
* igt@gem_exec_store@basic-bsd2:
- fi-hsw-4770: NOTRUN -> SKIP [fdo#109271] +41
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]
* igt@kms_addfb_basic@addfb25-y-tiled-small:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +51
* igt@kms_busy@basic-flip-c:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-edid-read:
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] +46
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] +2
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (43 -> 42)
------------------------------
Additional (4): fi-hsw-peppy fi-hsw-4770 fi-byt-n2820 fi-byt-clapper
Missing (5): fi-ilk-m540 fi-byt-squawks fi-ctg-p8600 fi-icl-u3 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4956 -> IGTPW_2885
CI_DRM_5948: cb5afe9301dbef678a0af3bda9ed9f4ee0b3dbf7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2885: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2885/
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2885/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev2)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev2)
URL : https://patchwork.freedesktop.org/series/59655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5948 -> IGTPW_2886
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59655/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_2886 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-kbl-7500u: NOTRUN -> SKIP [fdo#109271] +28
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +52
* igt@gem_exec_store@basic-bsd2:
- fi-hsw-4770: NOTRUN -> SKIP [fdo#109271] +41
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_addfb_basic@addfb25-y-tiled-small:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +51
* igt@kms_busy@basic-flip-c:
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: NOTRUN -> DMESG-WARN [fdo#102505] / [fdo#103558] / [fdo#105079] / [fdo#105602]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] +47
* igt@kms_chamelium@hdmi-edid-read:
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] +46
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] +1
- fi-glk-dsi: PASS -> FAIL [fdo#103191]
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: DMESG-WARN [fdo#103841] -> PASS
[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (43 -> 43)
------------------------------
Additional (5): fi-byt-j1900 fi-hsw-peppy fi-hsw-4770 fi-byt-n2820 fi-byt-clapper
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bwr-2160 fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4956 -> IGTPW_2886
CI_DRM_5948: cb5afe9301dbef678a0af3bda9ed9f4ee0b3dbf7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2886: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2886/
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2886/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev3)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev3)
URL : https://patchwork.freedesktop.org/series/59655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5948 -> IGTPW_2888
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59655/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_2888 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +52
* igt@gem_exec_store@basic-bsd2:
- fi-hsw-4770: NOTRUN -> SKIP [fdo#109271] +41
* igt@gem_exec_suspend@basic-s3:
- fi-apl-guc: PASS -> DMESG-WARN [fdo#108566]
* igt@kms_busy@basic-flip-c:
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] +47
* igt@kms_chamelium@hdmi-edid-read:
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] +46
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: PASS -> FAIL [fdo#103167]
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (43 -> 39)
------------------------------
Additional (4): fi-byt-j1900 fi-hsw-4770 fi-hsw-peppy fi-byt-clapper
Missing (8): fi-ilk-m540 fi-bdw-5557u fi-byt-squawks fi-icl-u2 fi-bwr-2160 fi-skl-6260u fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4956 -> IGTPW_2888
CI_DRM_5948: cb5afe9301dbef678a0af3bda9ed9f4ee0b3dbf7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2888: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2888/
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@audio@hdmi-integrity
+igt@audio@hdmi-integrity-after-hibernate
+igt@audio@hdmi-integrity-after-suspend
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2888/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation
URL : https://patchwork.freedesktop.org/series/59655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5948_full -> IGTPW_2885_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59655/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2885_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-kbl: PASS -> DMESG-WARN [fdo#108566] +4
* igt@gem_exec_params@no-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109283]
* igt@gem_mocs_settings@mocs-rc6-dirty-render:
- shard-iclb: NOTRUN -> SKIP [fdo#110206]
* igt@gem_pwrite@huge-cpu-fbr:
- shard-iclb: NOTRUN -> SKIP [fdo#109290] +1
* igt@gem_stolen@stolen-clear:
- shard-iclb: NOTRUN -> SKIP [fdo#109277]
* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: PASS -> FAIL [fdo#108686]
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-iclb: NOTRUN -> SKIP [fdo#110426] +1
* igt@gen3_render_mixed_blits:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: PASS -> SKIP [fdo#109271]
- shard-snb: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +118
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> SKIP [fdo#109288]
* igt@i915_suspend@debugfs-reader:
- shard-apl: PASS -> DMESG-WARN [fdo#108566] +4
* igt@i915_suspend@forcewake:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#108566] +1
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-f:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-planes-random:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +5
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336] +1
* igt@kms_cursor_crc@cursor-512x512-suspend:
- shard-iclb: NOTRUN -> SKIP [fdo#109279] +1
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +4
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: NOTRUN -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: PASS -> FAIL [fdo#103167] +5
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +19
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +26
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +72
* igt@kms_lease@setcrtc_implicit_plane:
- shard-apl: NOTRUN -> FAIL [fdo#110281]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-e:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +8
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145] +3
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] / [fdo#109278]
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: PASS -> SKIP [fdo#109642]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> SKIP [fdo#109441] +1
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: PASS -> SKIP [fdo#109441] +1
* igt@kms_tv_load_detect@load-detect:
- shard-iclb: NOTRUN -> SKIP [fdo#109309]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +3
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-glk: PASS -> FAIL [fdo#102583]
* igt@prime_nv_api@i915_nv_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +3
* igt@prime_vgem@fence-wait-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +13
* igt@v3d_get_bo_offset@create-get-offsets:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: DMESG-WARN [fdo#108566] -> PASS +3
* igt@gem_eio@in-flight-immediate:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +5
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: FAIL [fdo#103167] -> PASS
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: FAIL [fdo#103166] -> PASS +1
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: SKIP [fdo#109441] -> PASS +1
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
#### Warnings ####
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-apl: INCOMPLETE [fdo#103927] -> SKIP [fdo#109271]
[fdo#102583]: https://bugs.freedesktop.org/show_bug.cgi?id=102583
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109288]: https://bugs.freedesktop.org/show_bug.cgi?id=109288
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#110426]: https://bugs.freedesktop.org/show_bug.cgi?id=110426
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4956 -> IGTPW_2885
* Piglit: piglit_4509 -> None
CI_DRM_5948: cb5afe9301dbef678a0af3bda9ed9f4ee0b3dbf7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2885: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2885/
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2885/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev2)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev2)
URL : https://patchwork.freedesktop.org/series/59655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5948_full -> IGTPW_2886_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59655/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_2886_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: PASS -> DMESG-WARN [fdo#108566] +2
* igt@gem_exec_params@no-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109283]
* igt@gem_mocs_settings@mocs-rc6-dirty-render:
- shard-iclb: NOTRUN -> SKIP [fdo#110206]
* igt@gem_pwrite@huge-cpu-fbr:
- shard-iclb: NOTRUN -> SKIP [fdo#109290] +1
* igt@gem_stolen@stolen-clear:
- shard-iclb: NOTRUN -> SKIP [fdo#109277]
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-iclb: NOTRUN -> SKIP [fdo#110426] +1
* igt@gen3_render_mixed_blits:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +118
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> SKIP [fdo#109288]
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-f:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-planes-random:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +5
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336] +1
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-512x512-suspend:
- shard-iclb: NOTRUN -> SKIP [fdo#109279] +1
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +4
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: PASS -> FAIL [fdo#103167] +7
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
- shard-iclb: NOTRUN -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +19
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +26
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +70
* igt@kms_lease@setcrtc_implicit_plane:
- shard-apl: NOTRUN -> FAIL [fdo#110281]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-e:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +8
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145] +3
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] / [fdo#109278]
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: PASS -> SKIP [fdo#109642]
* igt@kms_psr@no_drrs:
- shard-iclb: PASS -> FAIL [fdo#108341]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> SKIP [fdo#109441] +2
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: PASS -> SKIP [fdo#109441] +2
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_tv_load_detect@load-detect:
- shard-iclb: NOTRUN -> SKIP [fdo#109309]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +3
* igt@perf_pmu@rc6:
- shard-kbl: PASS -> SKIP [fdo#109271]
* igt@prime_nv_api@i915_nv_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +3
* igt@prime_vgem@fence-wait-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +13
* igt@v3d_get_bo_offset@create-get-offsets:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: DMESG-WARN [fdo#108566] -> PASS +3
* igt@gem_eio@in-flight-immediate:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +5
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: SKIP [fdo#109349] -> PASS
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: FAIL [fdo#103166] -> PASS
* igt@kms_psr2_su@page_flip:
- shard-iclb: SKIP [fdo#109642] -> PASS
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: SKIP [fdo#109441] -> PASS
#### Warnings ####
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-apl: INCOMPLETE [fdo#103927] -> SKIP [fdo#109271]
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109288]: https://bugs.freedesktop.org/show_bug.cgi?id=109288
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#110426]: https://bugs.freedesktop.org/show_bug.cgi?id=110426
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4956 -> IGTPW_2886
* Piglit: piglit_4509 -> None
CI_DRM_5948: cb5afe9301dbef678a0af3bda9ed9f4ee0b3dbf7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2886: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2886/
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2886/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev3)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev3)
URL : https://patchwork.freedesktop.org/series/59655/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5948_full -> IGTPW_2888_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2888_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_2888_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59655/revisions/3/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2888_full:
### IGT changes ###
#### Possible regressions ####
* {igt@audio@hdmi-integrity} (NEW):
- shard-kbl: NOTRUN -> FAIL +1
- shard-glk: NOTRUN -> FAIL +1
- shard-snb: NOTRUN -> FAIL +1* {igt@audio@hdmi-integrity-after-suspend} (NEW):
- shard-hsw: NOTRUN -> FAIL +1
- shard-apl: NOTRUN -> FAIL +1
- shard-iclb: NOTRUN -> FAIL * igt@perf_pmu@most-busy-check-all-bcs0:
- shard-hsw: PASS -> FAIL +9
* igt@perf_pmu@most-busy-check-all-vcs0:
- shard-snb: PASS -> FAIL +7
New tests
---------
New tests have been introduced between CI_DRM_5948_full and IGTPW_2888_full:
### New IGT tests (2) ###
* igt@audio@hdmi-integrity:
- Statuses : 5 fail(s) 1 timeout(s)
- Exec time: [0.14, 363.81] s
* igt@audio@hdmi-integrity-after-suspend:
- Statuses : 6 fail(s)
- Exec time: [0.11, 5.11] s
Known issues
------------
Here are the changes found in IGTPW_2888_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* {igt@audio@hdmi-integrity} (NEW):
- shard-iclb: NOTRUN -> TIMEOUT [fdo#109673]
* igt@gem_exec_params@no-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109283]
* igt@gem_mocs_settings@mocs-rc6-dirty-render:
- shard-iclb: NOTRUN -> SKIP [fdo#110206]
* igt@gem_pwrite@huge-cpu-fbr:
- shard-iclb: NOTRUN -> SKIP [fdo#109290] +1
* igt@gem_stolen@stolen-clear:
- shard-iclb: NOTRUN -> SKIP [fdo#109277]
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: PASS -> FAIL [fdo#108686]
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-iclb: NOTRUN -> SKIP [fdo#110426] +1
* igt@gen3_render_mixed_blits:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP [fdo#109271] +1
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@i915_pm_rpm@i2c:
- shard-iclb: PASS -> DMESG-WARN [fdo#109982]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +118
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> SKIP [fdo#109288]
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-f:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-planes-random:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +5
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336] +1
* igt@kms_cursor_crc@cursor-512x512-suspend:
- shard-iclb: NOTRUN -> SKIP [fdo#109279] +1
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#108566]
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +4
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: PASS -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: NOTRUN -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +18
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +26
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +71
* igt@kms_lease@setcrtc_implicit_plane:
- shard-apl: NOTRUN -> FAIL [fdo#110281]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-e:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +8
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: PASS -> DMESG-WARN [fdo#108566] +4
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145] +3
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] / [fdo#109278]
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: PASS -> SKIP [fdo#109642]
* igt@kms_psr@no_drrs:
- shard-iclb: PASS -> FAIL [fdo#108341]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> SKIP [fdo#109441] +2
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: PASS -> SKIP [fdo#109441] +2
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763] +1
* igt@kms_tv_load_detect@load-detect:
- shard-iclb: NOTRUN -> SKIP [fdo#109309]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +3
* igt@prime_nv_api@i915_nv_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +3
* igt@prime_vgem@fence-wait-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +13
* igt@v3d_get_bo_offset@create-get-offsets:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: DMESG-WARN [fdo#108566] -> PASS +3
* igt@gem_eio@in-flight-immediate:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@gem_eio@in-flight-suspend:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +3
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: SKIP [fdo#109349] -> PASS
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: FAIL [fdo#103167] -> PASS
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: FAIL [fdo#103166] -> PASS
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: SKIP [fdo#109441] -> PASS +2
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
#### Warnings ####
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-apl: INCOMPLETE [fdo#103927] -> SKIP [fdo#109271]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109288]: https://bugs.freedesktop.org/show_bug.cgi?id=109288
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
[fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#110426]: https://bugs.freedesktop.org/show_bug.cgi?id=110426
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4956 -> IGTPW_2888
* Piglit: piglit_4509 -> None
CI_DRM_5948: cb5afe9301dbef678a0af3bda9ed9f4ee0b3dbf7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2888: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2888/
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2888/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev4)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev4)
URL : https://patchwork.freedesktop.org/series/59655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5952 -> IGTPW_2891
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59655/revisions/4/mbox/
Known issues
------------
Here are the changes found in IGTPW_2891 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +50
* igt@gem_exec_basic@basic-blt:
- fi-icl-y: PASS -> INCOMPLETE [fdo#107713] / [fdo#110246]
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +52
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_addfb_basic@addfb25-y-tiled-small:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +51
* igt@kms_busy@basic-flip-c:
- fi-skl-6770hq: PASS -> SKIP [fdo#109271] / [fdo#109278] +2
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_chamelium@hdmi-edid-read:
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] +46
* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6770hq: PASS -> SKIP [fdo#109271] +23
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110246]: https://bugs.freedesktop.org/show_bug.cgi?id=110246
Participating hosts (44 -> 41)
------------------------------
Additional (6): fi-hsw-peppy fi-icl-u2 fi-byt-clapper fi-bsw-kefka fi-byt-n2820 fi-icl-dsi
Missing (9): fi-ilk-m540 fi-bxt-dsi fi-bsw-n3050 fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4956 -> IGTPW_2891
CI_DRM_5952: 65305a057be0e155321a0765a3a24115063f3a32 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2891: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2891/
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@audio@hdmi-integrity
+igt@audio@hdmi-integrity-after-hibernate
+igt@audio@hdmi-integrity-after-suspend
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2891/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev4)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin batch activation (rev4)
URL : https://patchwork.freedesktop.org/series/59655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5952_full -> IGTPW_2891_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59655/revisions/4/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2891_full:
### IGT changes ###
#### Possible regressions ####
* {igt@audio@hdmi-integrity} (NEW):
- shard-kbl: NOTRUN -> FAIL
- shard-glk: NOTRUN -> FAIL +1
- shard-iclb: NOTRUN -> FAIL +1* {igt@audio@hdmi-integrity-after-suspend} (NEW):
- shard-hsw: NOTRUN -> FAIL +1
- shard-apl: NOTRUN -> FAIL +1
- shard-snb: NOTRUN -> FAILNew tests
---------
New tests have been introduced between CI_DRM_5952_full and IGTPW_2891_full:
### New IGT tests (2) ###
* igt@audio@hdmi-integrity:
- Statuses : 5 fail(s)
- Exec time: [0.30, 5.19] s
* igt@audio@hdmi-integrity-after-suspend:
- Statuses : 5 fail(s)
- Exec time: [0.16, 4.25] s
Known issues
------------
Here are the changes found in IGTPW_2891_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-apl: PASS -> DMESG-WARN [fdo#108566] +6
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +32
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP [fdo#109271]
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-f:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: PASS -> FAIL [fdo#103167] +7
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_lease@cursor_implicit_plane:
- shard-snb: NOTRUN -> FAIL [fdo#110278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-f:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: PASS -> FAIL [fdo#103166]
* igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: PASS -> SKIP [fdo#109441] +1
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-glk: FAIL [fdo#109661] -> PASS
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: SKIP [fdo#109349] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- shard-snb: SKIP [fdo#109271] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: DMESG-WARN [fdo#103313] -> PASS
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +5
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: FAIL [fdo#103167] -> PASS +5
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: SKIP [fdo#109441] -> PASS +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110278]: https://bugs.freedesktop.org/show_bug.cgi?id=110278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4956 -> IGTPW_2891
* Piglit: piglit_4509 -> None
CI_DRM_5952: 65305a057be0e155321a0765a3a24115063f3a32 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2891: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2891/
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2891/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx