arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node
Subsystems (2)
PATCH v2 1/2 arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node
Add Goodix GT5663 capacitive touch controller node on Amarula A64-Relic board.
The CTP connected to board with,
- SDA, SCK from i2c1
- GPIO-LD0 as AVDD28 supply
- PH4 gpio as interrupt pin
- PH8 gpio as reset pin
- X axis is inverted
- Y axis is inverted
---
Changes for v2:
- drop i2c1, bias-pull-up
.../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +25 -0
@@ -49,6 +49,24 @@ bias-pull-up; }; +&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>; + status = "okay"; + + touchscreen@5d { + compatible = "goodix,gt5663"; + reg = <0x5d>; + AVDD28-supply = <®_ldo_io0>; /* VCC-CTP: GPIO0-LDO */ + interrupt-parent = <&pio>; + interrupts = <7 4 IRQ_TYPE_EDGE_FALLING>; + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* CTP-INT: PH4 */ + reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* CTP-RST: PH8 */ + touchscreen-inverted-x; + touchscreen-inverted-y; + }; +}; + &mmc1 { pinctrl-names = "default"; pinctrl-0 = <&mmc1_pins>;
@@ -212,6 +230,13 @@ regulator-name = "vdd-cpus"; }; +®_ldo_io0 { + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc-ctp"; + status = "okay"; +}; + ®_rtc_ldo { regulator-name = "vcc-rtc"; };
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v2 2/2 arm64: dts: allwinner: a64-oceanic-5205-5inmfd: Enable GT911 CTP
Goodix GT911 CTP is bound with Oceanic 5205 5inMFD board.
The CTP connected to board with,
- SDA, SCK from i2c0
- GPIO-LD0 as AVDD28 supply
- PH4 gpio as interrupt pin
- PH11 gpio as reset pin
- X axis is inverted
- Y axis is inverted
---
Changes for v2:
- drop i2c1, bias-pull-up
.../sun50i-a64-oceanic-5205-5inmfd.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts +25 -0
@@ -37,6 +37,24 @@ status = "okay"; }; +&i2c0 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins>; + status = "okay"; + + touchscreen@5d { + compatible = "goodix,gt911"; + reg = <0x5d>; + AVDD28-supply = <®_ldo_io0>; /* VDD_CTP: GPIO0-LDO */ + interrupt-parent = <&pio>; + interrupts = <7 4 IRQ_TYPE_EDGE_FALLING>; + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* CTP-INT: PH4 */ + reset-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* CTP-RST: PH11 */ + touchscreen-inverted-x; + touchscreen-inverted-y; + }; +}; + &mdio { ext_rgmii_phy: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22";
@@ -52,6 +70,13 @@ regulator-name = "vcc-phy"; }; +®_ldo_io0 { + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vdd-ctp"; + status = "okay"; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pb_pins>;
Signature · 1 line
2.18.0.321.gffc6fa0e3
Re: [PATCH v2 2/2] arm64: dts: allwinner: a64-oceanic-5205-5inmfd: Enable GT911 CTP
Quoted 23 lines · Jagan Teki
Goodix GT911 CTP is bound with Oceanic 5205 5inMFD board.
The CTP connected to board with,
- SDA, SCK from i2c0
- GPIO-LD0 as AVDD28 supply
- PH4 gpio as interrupt pin
- PH11 gpio as reset pin
- X axis is inverted
- Y axis is invertedSigned-off-by Jagan Teki <[email protected]>---
Changes for v2:
- drop i2c1, bias-pull-up.../sun50i-a64-oceanic-5205-5inmfd.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts +0
-0
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts line 42
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts +3
-0@@ -37,6 +37,24 @@ status = "okay"; }; +&i2c0 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins>;
The comments on PATCH 1 apply here as well.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Quoted 24 lines · Jagan Teki
Add Goodix GT5663 capacitive touch controller node on Amarula A64-Relic board.
The CTP connected to board with,
- SDA, SCK from i2c1
- GPIO-LD0 as AVDD28 supply
- PH4 gpio as interrupt pin
- PH8 gpio as reset pin
- X axis is inverted
- Y axis is invertedSigned-off-by Jagan Teki <[email protected]>---
Changes for v2:
- drop i2c1, bias-pull-up.../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +0
-0
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts line 54
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +3
-0@@ -49,6 +49,24 @@ bias-pull-up; }; +&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>;
That's the default already
Quoted 19 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +15
-0+ status = "okay"; + + touchscreen@5d { + compatible = "goodix,gt5663"; + reg = <0x5d>; + AVDD28-supply = <®_ldo_io0>; /* VCC-CTP: GPIO0-LDO */ + interrupt-parent = <&pio>; + interrupts = <7 4 IRQ_TYPE_EDGE_FALLING>; + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* CTP-INT: PH4 */ + reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* CTP-RST: PH8 */ + touchscreen-inverted-x; + touchscreen-inverted-y; + }; +}; + &mmc1 { pinctrl-names = "default"; pinctrl-0 = <&mmc1_pins>;
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts line 235
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +3
-0@@ -212,6 +230,13 @@ regulator-name = "vdd-cpus"; }; +®_ldo_io0 { + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>;
The name of that regulator is AVDD28, which indicates that it would be a 2.8V regulator?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Quoted 29 lines · Maxime Ripard
Quoted 27 lines · Jagan Teki
Add Goodix GT5663 capacitive touch controller node on Amarula A64-Relic board.
The CTP connected to board with,
- SDA, SCK from i2c1
- GPIO-LD0 as AVDD28 supply
- PH4 gpio as interrupt pin
- PH8 gpio as reset pin
- X axis is inverted
- Y axis is invertedSigned-off-by Jagan Teki <[email protected]>---
Changes for v2:
- drop i2c1, bias-pull-up.../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +0
-0@@ -49,6 +49,24 @@ bias-pull-up; };
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts line 54
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +3
-0+&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>;That's the default already
Yes, and i2c1 node in sun50i-a64.dtsi is not attaching pinctrl. So I attached here.
Quoted 30 lines · Jagan Teki
Quoted 29 lines · Maxime Ripard
Quoted 27 lines · Jagan Teki
Add Goodix GT5663 capacitive touch controller node on Amarula A64-Relic board.
The CTP connected to board with,
- SDA, SCK from i2c1
- GPIO-LD0 as AVDD28 supply
- PH4 gpio as interrupt pin
- PH8 gpio as reset pin
- X axis is inverted
- Y axis is invertedSigned-off-by Jagan Teki <[email protected]>---
Changes for v2:
- drop i2c1, bias-pull-up.../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +0
-0@@ -49,6 +49,24 @@ bias-pull-up; };
Quoted 8 lines
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts line 54
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +3
-0+&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>;That's the default already
Yes, and i2c1 node in
sun50i-a64.dtsiis not attaching pinctrl. So I attached here.
If that's the only muxing option, it should then.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com