livepatch: Convert error about unsupported reliable stacktrace into a warning
Petr Mladek
maintainerPATCH 1/1 livepatch: Convert error about unsupported reliable stacktrace into a warning
The commit d0807da78e11d46f ("livepatch: Remove immediate feature") caused that any livepatch was refused when reliable stacktraces were not supported on the given architecture.
The limitation is too strong. User space processes are safely migrated even when entering or leaving the kernel. Kthreads transition would need to get forced. But it is safe when:
+ The livepatch does not change the semantic of the code.
+ Callbacks do not depend on a safely finished transition.
--- kernel/livepatch/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
kernel/livepatch/core.c +2 -3
@@ -1003,11 +1003,10 @@ int klp_enable_patch(struct klp_patch *patch)return -ENODEV ;if (!klp_have_reliable_stack ()) { -pr_err ("This architecture doesn't have support for the livepatch consistency model.\n" ); -return -EOPNOTSUPP ; +pr_warn ("This architecture doesn't have support for the livepatch consistency model.\n" ); +pr_warn ("The livepatch transition may never complete.\n" ); } -mutex_lock (&klp_mutex); ret =klp_init_patch_early (patch);
Signature · 1 line
2.16.4
Quoted 25 lines · Petr Mladek
The commit
d0807da78e11d46f("livepatch: Remove immediate feature") caused that any livepatch was refused when reliable stacktraces were not supported on the given architecture.The limitation is too strong. User space processes are safely migrated even when entering or leaving the kernel. Kthreads transition would need to get forced. But it is safe when:
+ The livepatch does not change the semantic of the code.
+ Callbacks do not depend on a safely finished transition.Suggested-by Josh Poimboeuf <[email protected]>Signed-off-by Petr Mladek <[email protected]>--- kernel/livepatch/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)kernel/livepatch/core.c +0
-0@@ -1003,11 +1003,10 @@ int klp_enable_patch(struct klp_patch *patch)return -ENODEV ;if (!klp_have_reliable_stack ()) {
kernel/livepatch/core.c int klp_enable_patch(struct klp_patch *patch) · line 1012
Quoted 10 lines
kernel/livepatch/core.c +2
-3-pr_err ("This architecture doesn't have support for the livepatch consistency model.\n" ); -return -EOPNOTSUPP ; +pr_warn ("This architecture doesn't have support for the livepatch consistency model.\n" ); +pr_warn ("The livepatch transition may never complete.\n" ); } -mutex_lock (&klp_mutex); ret =klp_init_patch_early (patch);
Thanks Petr. I would also suggest that we remove the WARN_ONCE() from the weak version of save_stack_trace_tsk_reliable(), since we expect it to be used in this case.
Signature · 1 line
Josh
Miroslav Benes
maintainerQuoted 32 lines · Josh Poimboeuf
Quoted 31 lines · Petr Mladek
The commit
d0807da78e11d46f("livepatch: Remove immediate feature") caused that any livepatch was refused when reliable stacktraces were not supported on the given architecture.The limitation is too strong. User space processes are safely migrated even when entering or leaving the kernel. Kthreads transition would need to get forced. But it is safe when:
+ The livepatch does not change the semantic of the code.
+ Callbacks do not depend on a safely finished transition.Suggested-by Josh Poimboeuf <[email protected]>Signed-off-by Petr Mladek <[email protected]>--- kernel/livepatch/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)kernel/livepatch/core.c +2
-2@@ -1003,11 +1003,10 @@ int klp_enable_patch(struct klp_patch *patch)return -ENODEV ;if (!klp_have_reliable_stack ()) { -pr_err ("This architecture doesn't have support for the livepatch consistency model.\n" ); -return -EOPNOTSUPP ; +pr_warn ("This architecture doesn't have support for the livepatch consistency model.\n" ); +pr_warn ("The livepatch transition may never complete.\n" ); }
Quoted 8 lines
kernel/livepatch/core.c int klp_enable_patch(struct klp_patch *patch) · line 1012
Quoted 4 lines
kernel/livepatch/core.c +0
-1-mutex_lock (&klp_mutex); ret =klp_init_patch_early (patch);Thanks Petr. I would also suggest that we remove the
WARN_ONCE()from the weak version ofsave_stack_trace_tsk_reliable(), since we expect it to be used in this case.
Moreover, we have WARN_ON_ONCE(ret == -ENOSYS) in klp_check_stack() where save_stack_trace_tsk_reliable() is called.
Miroslav