Skip to contentSkip to conversation

crypto/virtio: fix return value check

PATCH New Chenbo Xia 1 participant 1 message Apr 19, 2019

Subsystems (3)
lore
Share & tools
lore

Chenbo Xia

author
#0 lore raw

PATCH 1/1 crypto/virtio: fix return value check

Fix unchecked return value issue for rte_pci_read_config.

Coverity issue: 302861

Fixes 25500d4b8076 ("crypto/virtio: support device init")
---
 drivers/crypto/virtio/virtio_pci.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/crypto/virtio/virtio_pci.c +6 -2
index 0c0c64471..8137b3c5a 100644
@@ -397,9 +397,13 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_crypto_hw *hw)
 			hw->common_cfg = get_cfg_addr(dev, &cap);
 			break;
 		case VIRTIO_PCI_CAP_NOTIFY_CFG:
-			rte_pci_read_config(dev, &hw->notify_off_multiplier,
+			ret = rte_pci_read_config(dev, &hw->notify_off_multiplier,
 					4, pos + sizeof(cap));
-			hw->notify_base = get_cfg_addr(dev, &cap);
+			if (ret != 4)
+				VIRTIO_CRYPTO_INIT_LOG_ERR(
+					"failed to read notify_off_multiplier: ret %d", ret);
+			else
+				hw->notify_base = get_cfg_addr(dev, &cap);
 			break;
 		case VIRTIO_PCI_CAP_DEVICE_CFG:
 			hw->dev_cfg = get_cfg_addr(dev, &cap);
Signature · 1 line
2.17.1