Skip to contentSkip to conversation

fuse: document fuse_fsync_in.fsync_flags

PATCH New [email protected] 1 participant 3 messages Apr 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 fuse: document fuse_fsync_in.fsync_flags

From: Alan Somers <[email protected]>

The FUSE_FSYNC_DATASYNC flag was introduced by commit b6aeadeda22a as a magic number. No new values have been added to fsync_flags since.

---
 fs/fuse/file.c            | 2 +-
 include/uapi/linux/fuse.h | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)
fs/fuse/file.c +1 -1
index 06096b60f1df..6d8dd7035912 100644
@@ -462,7 +462,7 @@ int fuse_fsync_common(struct file *file, loff_t start, loff_t end,
 
 	memset(&inarg, 0, sizeof(inarg));
 	inarg.fh = ff->fh;
-	inarg.fsync_flags = datasync ? 1 : 0;
+	inarg.fsync_flags = datasync ? FUSE_FSYNC_FDATASYNC : 0;
 	args.in.h.opcode = opcode;
 	args.in.h.nodeid = get_node_id(inode);
 	args.in.numargs = 1;
include/uapi/linux/fuse.h +7 -0
index 2ac598614a8f..e4ceeb406eb3 100644
@@ -353,6 +353,13 @@ struct fuse_file_lock {
  */
 #define FUSE_POLL_SCHEDULE_NOTIFY (1 << 0)
 
+/**
+ * Fsync flags
+ *
+ * FUSE_FSYNC_FDATASYNC: Sync data only, not metadata
+ */
+#define FUSE_FSYNC_FDATASYNC	(1 << 0)
+
 enum fuse_opcode {
 	FUSE_LOOKUP		= 1,
 	FUSE_FORGET		= 2,  /* no reply */
Signature · 1 line
2.21.0
#1 lore raw

PATCH 2/3 fuse: fix changelog entry for protocol 7.12

From: Alan Somers <[email protected]>

This was a mistake in the comment in commit e0a43ddcc08c.

---
 include/uapi/linux/fuse.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/fuse.h +1 -1
index e4ceeb406eb3..6457036a5960 100644
@@ -54,7 +54,7 @@
  *  - add POLL message and NOTIFY_POLL notification
  *
  * 7.12
- *  - add umask flag to input argument of open, mknod and mkdir
+ *  - add umask flag to input argument of create, mknod and mkdir
  *  - add notification messages for invalidation of inodes and
  *    directory entries
  *
Signature · 1 line
2.21.0
#2 lore raw

PATCH 3/3 fuse: fix changelog entry for protocol 7.9

In reply to [email protected]

From: Alan Somers <[email protected]>

Retroactively add changelog entry for the atime and mtime "now" flags. This was an oversight in commit 17637cbaba592

---
 include/uapi/linux/fuse.h | 1 +
 1 file changed, 1 insertion(+)
include/uapi/linux/fuse.h +1 -0
index 6457036a5960..35f556d1d5d2 100644
@@ -44,6 +44,7 @@
  *  - add lock_owner field to fuse_setattr_in, fuse_read_in and fuse_write_in
  *  - add blksize field to fuse_attr
  *  - add file flags field to fuse_read_in and fuse_write_in
+ *  - Add ATIME_NOW and MTIME_NOW flags to fuse_setattr_in
  *
  * 7.10
  *  - add nonseekable open flag
Signature · 1 line
2.21.0