Skip to contentSkip to conversation

drm/sched: Fix description of drm_sched_stop

PATCH In review Jonathan Neuschäfer 2 participants 2 messages Apr 20, 2019 – Apr 23, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/sched: Fix description of drm_sched_stop

Since commit 222b5f044159 ("drm/sched: Refactor ring mirror list handling."), drm_sched_hw_job_reset is no longer there, so let's adjust the doc comment accordingly.

---
 drivers/gpu/drm/scheduler/sched_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/scheduler/sched_main.c +1 -2
index 19fc601c9eeb..a1bec2779e76 100644
@@ -366,10 +366,9 @@ void drm_sched_increase_karma(struct drm_sched_job *bad)
 EXPORT_SYMBOL(drm_sched_increase_karma);
 
 /**
- * drm_sched_hw_job_reset - stop the scheduler if it contains the bad job
+ * drm_sched_stop - stop the scheduler
  *
  * @sched: scheduler instance
- * @bad: bad scheduler job
  *
  */
 void drm_sched_stop(struct drm_gpu_scheduler *sched)

--
2.20.1

Reviewed-by on v1 1/1
#1 lore raw

Andrey

Quoted 28 lines · Jonathan Neuschäfer

Since commit 222b5f044159 ("drm/sched: Refactor ring mirror list handling."), drm_sched_hw_job_reset is no longer there, so let's adjust the doc comment accordingly.

---
  drivers/gpu/drm/scheduler/sched_main.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/scheduler/sched_main.c +1 -3
index 19fc601c9eeb..a1bec2779e76 100644
@@ -366,10 +366,9 @@ void drm_sched_increase_karma(struct drm_sched_job *bad)
  EXPORT_SYMBOL(drm_sched_increase_karma);
 
  /**
- * drm_sched_hw_job_reset - stop the scheduler if it contains the bad job
+ * drm_sched_stop - stop the scheduler
   *
   * @sched: scheduler instance
- * @bad: bad scheduler job
   *
   */
  void drm_sched_stop(struct drm_gpu_scheduler *sched)
--

2.20.1