Skip to contentSkip to conversation

include/net/tcp.h: whitespace cleanup at tcp_v4_check

PATCH Applied Daniel T. Lee 2 participants 2 messages Apr 20, 2019 – Apr 23, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include/net/tcp.h: whitespace cleanup at tcp_v4_check

This patch makes trivial whitespace fix to the function tcp_v4_check at include/net/tcp.h file.

It has stylistic issue, which is "space required after that ','" and it can be confirmed with ./scripts/checkpatch.pl tool.

    ERROR: space required after that ',' (ctx:VxV)
    #29: FILE: include/net/tcp.h:1317:
    +	        return csum_tcpudp_magic(saddr,daddr,len,IPPROTO_TCP,base);
         	                              ^
---
 include/net/tcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/tcp.h +1 -1
index 68ee02523b87..7cf1181630a3 100644
@@ -1314,7 +1314,7 @@ static inline void tcp_update_wl(struct tcp_sock *tp, u32 seq)
 static inline __sum16 tcp_v4_check(int len, __be32 saddr,
 				   __be32 daddr, __wsum base)
 {
-	return csum_tcpudp_magic(saddr,daddr,len,IPPROTO_TCP,base);
+	return csum_tcpudp_magic(saddr, daddr, len, IPPROTO_TCP, base);
 }
 
 static inline bool tcp_checksum_complete(struct sk_buff *skb)
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw

From: "Daniel T. Lee" <[email protected]>
Date: Sun, 21 Apr 2019 00:50:42 +0900

Quoted 6 lines

This patch makes trivial whitespace fix to the function tcp_v4_check at include/net/tcp.h file.

It has stylistic issue, which is "space required after that ','" and it can be confirmed with ./scripts/checkpatch.pl tool.

Quoted 6 lines
    ERROR: space required after that ',' (ctx:VxV)
    #29: FILE: include/net/tcp.h:1317:
    +	        return csum_tcpudp_magic(saddr,daddr,len,IPPROTO_TCP,base);
         	                              ^

Applied to net-next, thanks Daniel.