Skip to contentSkip to conversation

r8152: sync sa_family with the media type of network device

PATCH Superseded [email protected] 2 participants 4 messages Apr 22, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 r8152: sync sa_family with the media type of network device

From: "Crag.Wang" <[email protected]>

Without this patch the socket address family sporadically gets wrong value ends up the dev_set_mac_address() fails to set the desired MAC address.

---
 drivers/net/usb/r8152.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/usb/r8152.c +2 -0
index 4c63b40d5e00..41fb39ce69c9 100644
@@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
 	struct net_device *dev = tp->netdev;
 	int ret;
 
+	sa->sa_family = dev->type;
+
 	if (tp->version == RTL_VER_01) {
 		ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
 	} else {
author
#2 lore raw
Quoted 6 lines · David Miller

Networking driver patches not sent to [email protected] are very unlikely to be integrated.

Thank you.

Adding [email protected] to this email, sorry about missing the recipient in the first place.

Thanks,
Crag

maintainer
#3 lore raw

From: Crag Wang <[email protected]>
Date: Mon, 22 Apr 2019 11:17:49 +0800

Quoted 10 lines · David Miller
Quoted 6 lines

Networking driver patches not sent to [email protected] are very unlikely to be integrated.

Thank you.

Adding [email protected] to this email, sorry about missing the recipient in the first place.

This does not get the patch queued up in patchwork, nor allow other readers of netdev to see the patch so that it can be properly reviewed.

You must make a new, fresh, posting of your patch.