Some more games: XorCurses, ASCII-Invaders and Frotz
cover Some more games: XorCurses, ASCII-Invaders and Frotz
Hi everybody!
This is my first patch contribution to the buildroot project ... I used buildroot for building most of the images for he QEMU advent calendar 2018 (see https://www.qemu-advent-calendar.org/2018/ ). That would not have been possible without buildroot, so thanks a lot for this great build environment!
Anyway, I've now gone through the package files that I've written for that project, and I think some of them might maybe be interesting for integrating them into the official buildroot tree, too. Please have a look at the following patches, and let me know what you think. (I also got some more package files on my hard disk, but they need some more polishing, so I would like to get some feedback on these three patches first)
Thomas Huth (3):
package/xorcurses: new package
package/ascii-invaders: new package
package/frotz: new package
package/Config.in | 3 ++ package/ascii-invaders/Config.in | 5 ++++ package/ascii-invaders/ascii-invaders.hash | 2 ++ package/ascii-invaders/ascii-invaders.mk | 23 ++++++++++++++++ package/frotz/Config.in | 7 +++++ package/frotz/frotz.hash | 2 ++ package/frotz/frotz.mk | 32 ++++++++++++++++++++++ package/xorcurses/Config.in | 13 +++++++++ package/xorcurses/xorcurses.hash | 2 ++ package/xorcurses/xorcurses.mk | 25 +++++++++++++++++ 10 files changed, 114 insertions(+) create mode 100644 package/ascii-invaders/Config.in create mode 100644 package/ascii-invaders/ascii-invaders.hash create mode 100644 package/ascii-invaders/ascii-invaders.mk create mode 100644 package/frotz/Config.in create mode 100644 package/frotz/frotz.hash create mode 100644 package/frotz/frotz.mk create mode 100644 package/xorcurses/Config.in create mode 100644 package/xorcurses/xorcurses.hash create mode 100644 package/xorcurses/xorcurses.mk
Signature · 1 line
2.17.2
PATCH 1/3 package/xorcurses: new package
From: Thomas Huth <[email protected]>
XorCurses is a remake of the 8-bit game 'Xor' by Astral Software. Your task is to roam around a series of mazes where you have to collect all blue masks before finding the exit. You have two 'shields' (players) and you can use either one at any time and switch between them. While the first level is simply a matter of navigation, the following levels introduce further objects like bombs and teleports, which have to be used right to solve the puzzles.
--- package/Config.in | 1 + package/xorcurses/Config.in | 13 +++++++++++++ package/xorcurses/xorcurses.hash | 2 ++ package/xorcurses/xorcurses.mk | 25 +++++++++++++++++++++++++ 4 files changed, 41 insertions(+) create mode 100644 package/xorcurses/Config.in create mode 100644 package/xorcurses/xorcurses.hash create mode 100644 package/xorcurses/xorcurses.mk
package/Config.in +1 -0
@@ -258,6 +258,7 @@ menu "Games" source "package/stella/Config.in" source "package/supertux/Config.in" source "package/supertuxkart/Config.in" + source "package/xorcurses/Config.in" endmenu menu "Graphic libraries and applications (graphic/text)"
package/xorcurses/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_XORCURSES + bool "xorcurses" + select BR2_PACKAGE_NCURSES + help + XorCurses is a remake of the 8-bit game 'Xor' by Astral Software. + Your task is to roam around a series of mazes where you have to collect + all blue masks before finding the exit. You have two 'shields' (players) + and you can use either one at any time and switch between them. While + the first level is simply a matter of navigation, the following levels + introduce further objects like bombs and teleports, which have to be + used right to solve the puzzles. + Note that the game needs a terminal with colors, i.e. make sure that + the TERM environment variable is set to "linux" ("vt100" won't work).
package/xorcurses/xorcurses.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally calculated +sha512 1782ebf6ae8798b32e0a8e5e20e6d0b44eb619f6e7f015735c6e86205bd545da108c36bff1c9cfc9e9b44dee8f90bacb9df70436991f57f51c2c87e94b3a4725 XorCurses-0.2.2.tar.bz2
package/xorcurses/xorcurses.mk new file +25 -0
@@ -0,0 +1,25 @@ +################################################################################ +# +# XorCurses +# +################################################################################ + +XORCURSES_VERSION = 0.2.2 +XORCURSES_LICENSE = GPL-3.0 +XORCURSES_SOURCE = XorCurses-$(XORCURSES_VERSION).tar.bz2 +XORCURSES_SITE = http://www.jwm-art.net/art/archive +XORCURSES_INSTALL_TARGET = YES +XORCURSES_DEPENDENCIES = ncurses + +define XORCURSES_BUILD_CMDS + $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \ + CFLAGS="-O2 -DDATADIR='\"/usr/share/xorcurses\"' -DVERSION='\"$(XORCURSES_VERSION)\"'" +endef + +define XORCURSES_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/xorcurses $(TARGET_DIR)/usr/bin/ + mkdir -p $(TARGET_DIR)/usr/share/xorcurses/maps + $(INSTALL) -D -m 0755 $(@D)/maps/*.xcm $(TARGET_DIR)/usr/share/xorcurses/maps/ +endef + +$(eval $(generic-package))
Signature · 1 line
2.17.2
PATCH 1/3 package/xorcurses: new package
Hello Thomas,
Thanks for your contribution. Please find some comments below.
Le sam. 23 f?vr. 2019 ? 21:57, Thomas Huth <[email protected]> a ?crit :
Quoted 11 lines
From: Thomas Huth <[email protected]>
XorCurses is a remake of the 8-bit game 'Xor' by Astral Software. Your task is to roam around a series of mazes where you have to collect all blue masks before finding the exit. You have two 'shields' (players) and you can use either one at any time and switch between them. While the first level is simply a matter of navigation, the following levels introduce further objects like bombs and teleports, which have to be used right to solve the puzzles.
Quoted 6 lines
Signed-off-by Thomas Huth <[email protected]>--- package/Config.in | 1 + package/xorcurses/Config.in | 13 +++++++++++++ package/xorcurses/xorcurses.hash | 2 ++ package/xorcurses/xorcurses.mk | 25 +++++++++++++++++++++++++
You also need to create an entry in the DEVELOPERS file for your name and this package.
Quoted 26 lines
4 files changed, 41 insertions(+) create mode 100644 package/xorcurses/Config.in create mode 100644 package/xorcurses/xorcurses.hash create mode 100644 package/xorcurses/xorcurses.mkpackage/Config.in +1
-0@@ -258,6 +258,7 @@ menu "Games" source "package/stella/Config.in" source "package/supertux/Config.in" source "package/supertuxkart/Config.in" + source "package/xorcurses/Config.in" endmenu menu "Graphic libraries and applications (graphic/text)"package/xorcurses/Config.in new file +3
-0@@ -0,0 +1,13 @@ +config BR2_PACKAGE_XORCURSES + bool "xorcurses" + select BR2_PACKAGE_NCURSES
package/xorcurses/Config.in line 13
Quoted 10 lines
package/xorcurses/Config.in new file +10
-0+ help + XorCurses is a remake of the 8-bit game 'Xor' by Astral Software. + Your task is to roam around a series of mazes where you have to collect + all blue masks before finding the exit. You have two 'shields' (players) + and you can use either one at any time and switch between them. While + the first level is simply a matter of navigation, the following levels + introduce further objects like bombs and teleports, which have to be + used right to solve the puzzles. + Note that the game needs a terminal with colors, i.e. make sure that + the TERM environment variable is set to "linux" ("vt100" won't work).
There are some coding style issues in this file. Please run the following command:
./utils/check-package package/xorcurses/*
to fix the warnings.
You also need to mention the upstream URL of this package as part of the help text.
You might not need to have a help text that long. Just the first line should be enough.
package/xorcurses/xorcurses.hash line 2
Quoted 8 lines
package/xorcurses/xorcurses.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha512 1782ebf6ae8798b32e0a8e5e20e6d0b44eb619f6e7f015735c6e86205bd545da108c36bff1c9cfc9e9b44dee8f90bacb9df70436991f57f51c2c87e94b3a4725 XorCurses-0.2.2.tar.bz2
You also need to provide the hash for the license file.
Quoted 7 lines
package/xorcurses/xorcurses.mk new file +1
-0@@ -0,0 +1,25 @@ +################################################################################
package/xorcurses/xorcurses.mk line 11
Quoted 10 lines
package/xorcurses/xorcurses.mk new file +10
-0+# +# XorCurses +# +################################################################################ + +XORCURSES_VERSION = 0.2.2 +XORCURSES_LICENSE = GPL-3.0 +XORCURSES_SOURCE = XorCurses-$(XORCURSES_VERSION).tar.bz2 +XORCURSES_SITE = http://www.jwm-art.net/art/archive +XORCURSES_INSTALL_TARGET = YES
this is the default value, so not needed.
package/xorcurses/xorcurses.mk line 16
Quoted 5 lines
package/xorcurses/xorcurses.mk new file +5
-0+XORCURSES_DEPENDENCIES = ncurses + +define XORCURSES_BUILD_CMDS + $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \ + CFLAGS="-O2 -DDATADIR='\"/usr/share/xorcurses\"' -DVERSION='\"$(XORCURSES_VERSION)\"'"
You mght want to keep the default CFLAGS by doing this CFLAGS="$(TARGET_CFLAGS) -O2 ...."
package/xorcurses/xorcurses.mk line 20
Quoted 4 lines
package/xorcurses/xorcurses.mk new file +4
-0+endef + +define XORCURSES_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/xorcurses $(TARGET_DIR)/usr/bin/
It should be $(INSTALL) -D -m 0755 $(@D)/xorcurses $(TARGET_DIR)/usr/bin/xorcurses
package/xorcurses/xorcurses.mk line 22
Quoted 2 lines
package/xorcurses/xorcurses.mk new file +2
-0+ mkdir -p $(TARGET_DIR)/usr/share/xorcurses/maps + $(INSTALL) -D -m 0755 $(@D)/maps/*.xcm $(TARGET_DIR)/usr/share/xorcurses/maps/
If these are not executable files, it would be better to change their access permission mode.
Quoted 10 lines
package/xorcurses/xorcurses.mk new file +3
-1+endef + +$(eval $(generic-package)) --2.17.2
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
As a rule of thumb, it is recommended to test your package with the test-pkg tool. This will allow you to spot some issues when building in different configurations.
Please look into the buildroot user manual, under the "How to test your package" for more details.
Thanks!
Gilles.
PATCH 1/3 package/xorcurses: new package
Am Sat, 16 Mar 2019 17:57:28 +0100
schrieb Gilles Talis <[email protected]>:
Quoted 3 lines
Hello Thomas,
Thanks for your contribution. Please find some comments below.
Hi Gilles,
thanks a lot for your review! I finally found some spare time to look into this again, but I have some questions below...
Quoted 2 lines
Le sam. 23 f?vr. 2019 ? 21:57, Thomas Huth <[email protected]> a ?crit :
[...]
Quoted 11 lines
Quoted 10 lines
(quoted diff) +0
-0b/package/xorcurses/xorcurses.hash new file mode 100644 index 0000000000..49d3a0c3b9
package/xorcurses/xorcurses.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha5121782ebf6ae8798b32e0a8e5e20e6d0b44eb619f6e7f015735c6e86205bd545da108c36bff1c9cfc9e9b44dee8f90bacb9df70436991f57f51c2c87e94b3a4725 XorCurses-0.2.2.tar.bz2
You also need to provide the hash for the license file.
There does not seem to be a license file in the tarball here, they just mention in the README that the game is licensed under the GPL. I guess I can skip the hash for the license file in this case?
Thomas
PATCH 1/3 package/xorcurses: new package
Hello Thomas,
Le lun. 22 avr. 2019 ? 07:56, Thomas Huth <[email protected]> a ?crit :
Quoted 4 lines
Am Sat, 16 Mar 2019 17:57:28 +0100
schrieb Gilles Talis <[email protected]>:
Quoted 8 lines
Quoted 3 lines
Hello Thomas,
Thanks for your contribution. Please find some comments below.
Hi Gilles,
thanks a lot for your review! I finally found some spare time to look into this again, but I have some questions below...
All apologies for not coming back sooner on your patch.
Quoted 3 lines
There does not seem to be a license file in the tarball here, they just mention in the README that the game is licensed under the GPL. I guess I can skip the hash for the license file in this case?
This is correct. If there's no actual license file, you can skip the hash for it.
thanks
Gilles.
PATCH 2/3 package/ascii-invaders: new package
In reply to Thomas HuthAn ASCII-art game like Space Invaders using ncurses.
--- package/Config.in | 1 + package/ascii-invaders/Config.in | 5 +++++ package/ascii-invaders/ascii-invaders.hash | 2 ++ package/ascii-invaders/ascii-invaders.mk | 23 ++++++++++++++++++++++ 4 files changed, 31 insertions(+) create mode 100644 package/ascii-invaders/Config.in create mode 100644 package/ascii-invaders/ascii-invaders.hash create mode 100644 package/ascii-invaders/ascii-invaders.mk
package/Config.in +1 -0
@@ -239,6 +239,7 @@ comment "Themes" endmenu menu "Games" + source "package/ascii-invaders/Config.in" source "package/chocolate-doom/Config.in" source "package/doom-wad/Config.in" source "package/flare-engine/Config.in"
package/ascii-invaders/Config.in new file +5 -0
@@ -0,0 +1,5 @@ +config BR2_PACKAGE_ASCII_INVADERS + bool "ascii_invaders" + select BR2_PACKAGE_NCURSES + help + An ASCII-art game like Space Invaders using ncurses.
package/ascii-invaders/ascii-invaders.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally calculated +sha512 326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7 v1.0.1.tar.gz
package/ascii-invaders/ascii-invaders.mk new file +23 -0
@@ -0,0 +1,23 @@ +############################################################################## +# +# ASCII-Invaders +# +############################################################################## + +ASCII_INVADERS_VERSION = 1.0.1 +ASCII_INVADERS_SOURCE = v$(ASCII_INVADERS_VERSION).tar.gz +ASCII_INVADERS_SITE = https://github.com/macdice/ascii-invaders/archive +ASCII_INVADERS_INSTALL_TARGET = YES +ASCII_INVADERS_DEPENDENCIES = ncurses +ASCII_INVADERS_LICENSE = GPL-2.0+ +ASCII_INVADERS_LICENSE_FILES = LICENSE + +define ASCII_INVADERS_BUILD_CMDS + (cd $(@D) ; $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)) +endef + +define ASCII_INVADERS_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin +endef + +$(eval $(generic-package))
Signature · 1 line
2.17.2
PATCH 2/3 package/ascii-invaders: new package
Hello Thomas,
Le sam. 23 f?vr. 2019 ? 21:57, Thomas Huth <[email protected]> a ?crit :
Quoted 9 lines
An ASCII-art game like Space Invaders using ncurses.
Signed-off-by Thomas Huth <[email protected]>--- package/Config.in | 1 + package/ascii-invaders/Config.in | 5 +++++ package/ascii-invaders/ascii-invaders.hash | 2 ++ package/ascii-invaders/ascii-invaders.mk | 23 ++++++++++++++++++++++
Please also add an entry in the DEVELOPERS file for this package.
Quoted 23 lines
4 files changed, 31 insertions(+) create mode 100644 package/ascii-invaders/Config.in create mode 100644 package/ascii-invaders/ascii-invaders.hash create mode 100644 package/ascii-invaders/ascii-invaders.mkpackage/Config.in +1
-0@@ -239,6 +239,7 @@ comment "Themes" endmenu menu "Games" + source "package/ascii-invaders/Config.in" source "package/chocolate-doom/Config.in" source "package/doom-wad/Config.in" source "package/flare-engine/Config.in"package/ascii-invaders/Config.in new file +0
-0
package/ascii-invaders/Config.in line 5
Quoted 5 lines
package/ascii-invaders/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_ASCII_INVADERS + bool "ascii_invaders" + select BR2_PACKAGE_NCURSES + help + An ASCII-art game like Space Invaders using ncurses.
Please add the upstream URL as part of the package help text.
package/ascii-invaders/ascii-invaders.hash line 2
Quoted 8 lines
package/ascii-invaders/ascii-invaders.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha512 326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7 v1.0.1.tar.gz
Please add the hash value for the license file.
package/ascii-invaders/ascii-invaders.mk line 1
Quoted 7 lines
package/ascii-invaders/ascii-invaders.mk new file +1
-0@@ -0,0 +1,23 @@ +##############################################################################
This should be 80 hashes
package/ascii-invaders/ascii-invaders.mk line 5
Quoted 4 lines
package/ascii-invaders/ascii-invaders.mk new file +4
-0+# +# ASCII-Invaders +# +##############################################################################
Same here. 80 hashes.
Please run the following command to fix the formatting issues:
./utils/check-package package/ascii-invaders/*
package/ascii-invaders/ascii-invaders.mk line 10
Quoted 5 lines
package/ascii-invaders/ascii-invaders.mk new file +5
-0+ +ASCII_INVADERS_VERSION = 1.0.1 +ASCII_INVADERS_SOURCE = v$(ASCII_INVADERS_VERSION).tar.gz +ASCII_INVADERS_SITE = https://github.com/macdice/ascii-invaders/archive +ASCII_INVADERS_INSTALL_TARGET = YES
Default value, not required.
package/ascii-invaders/ascii-invaders.mk line 16
Quoted 6 lines
package/ascii-invaders/ascii-invaders.mk new file +6
-0+ASCII_INVADERS_DEPENDENCIES = ncurses +ASCII_INVADERS_LICENSE = GPL-2.0+ +ASCII_INVADERS_LICENSE_FILES = LICENSE + +define ASCII_INVADERS_BUILD_CMDS + (cd $(@D) ; $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D))
The cd $(@D) is not needed here.
package/ascii-invaders/ascii-invaders.mk line 20
Quoted 4 lines
package/ascii-invaders/ascii-invaders.mk new file +4
-0+endef + +define ASCII_INVADERS_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin
It should be $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin/ascii_invaders
Quoted 10 lines
package/ascii-invaders/ascii-invaders.mk new file +3
-1+endef + +$(eval $(generic-package)) --2.17.2
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Please refer to the "How to test your package" section of Buildroot user manual to verify that it can build at least in the 6 default build configurations.
thanks!
Gilles.
PATCH 3/3 package/frotz: new package
In reply to Thomas HuthFrotz is an interpreter for old Infocom adventures and other Z-code games.
--- package/Config.in | 1 + package/frotz/Config.in | 7 +++++++ package/frotz/frotz.hash | 2 ++ package/frotz/frotz.mk | 32 ++++++++++++++++++++++++++++++++ 4 files changed, 42 insertions(+) create mode 100644 package/frotz/Config.in create mode 100644 package/frotz/frotz.hash create mode 100644 package/frotz/frotz.mk
package/Config.in +1 -0
@@ -244,6 +244,7 @@ menu "Games" source "package/doom-wad/Config.in" source "package/flare-engine/Config.in" source "package/flare-game/Config.in" + source "package/frotz/Config.in" source "package/gnuchess/Config.in" source "package/lbreakout2/Config.in" source "package/ltris/Config.in"
package/frotz/Config.in new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_FROTZ + bool "frotz" + select BR2_PACKAGE_NCURSES + help + Frotz is an interpreter for old Infocom adventure games and other Z-code + games. Note that frotz can not be run as root. You must add a normal user + to your buildroot configuration to be able to use it.
package/frotz/frotz.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally calculated +sha512 c3aeb1bca227db7b759be880c1fe14e3d46c79eae3f2891d2472ff1e1b17b2153b2e400d537d54dce68011079e230fe8176ebb7547b2ecbc30e44f2b7423c285 frotz-2.44.tar.bz2
package/frotz/frotz.mk new file +32 -0
@@ -0,0 +1,32 @@ +############################################################################## +# +# Frotz - the Z-code interpreter +# +############################################################################## + +FROTZ_VERSION = 2.44 +FROTZ_SOURCE = frotz-$(FROTZ_VERSION).tar.bz2 +FROTZ_SITE = https://gitlab.com/DavidGriffith/frotz/-/archive/$(FROTZ_VERSION) +FROTZ_INSTALL_TARGET = YES +FROTZ_DEPENDENCIES = ncurses +FROTZ_LICENSE = GPL-2.0+ +FROTZ_LICENSE_FILES = COPYING + +define FROTZ_POST_EXTRACT_FIXUP + (cd $(@D); \ + sed -i 's/$ ar rc/ \$$\(AR\) rc/g' $(@D)/Makefile ; \ + sed -i 's/$ ranlib/ \$$\(RANLIB\)/g' $(@D)/Makefile ; \ + sed -i 's/$ strip/ \$$\(STRIP\)/g' $(@D)/Makefile ) +endef +FROTZ_POST_EXTRACT_HOOKS += FROTZ_POST_EXTRACT_FIXUP + +define FROTZ_BUILD_CMDS + $(MAKE) $(TARGET_CONFIGURE_OPTS) PREFIX=/usr CONFIG_DIR=/etc -C $(@D) +endef + +define FROTZ_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/frotz $(TARGET_DIR)/usr/bin + $(INSTALL) -D -m 0644 $(@D)/doc/frotz.6 $(TARGET_DIR)/usr/man/man6 +endef + +$(eval $(generic-package))
Signature · 1 line
2.17.2
PATCH 3/3 package/frotz: new package
Hello Thomas,
Le sam. 23 f?vr. 2019 ? 21:57, Thomas Huth <[email protected]> a ?crit :
Quoted 9 lines
Frotz is an interpreter for old Infocom adventures and other Z-code games.
Signed-off-by Thomas Huth <[email protected]>--- package/Config.in | 1 + package/frotz/Config.in | 7 +++++++ package/frotz/frotz.hash | 2 ++ package/frotz/frotz.mk | 32 ++++++++++++++++++++++++++++++++
Please add an entry to the DEVELOPERS file for this package.
Quoted 23 lines
4 files changed, 42 insertions(+) create mode 100644 package/frotz/Config.in create mode 100644 package/frotz/frotz.hash create mode 100644 package/frotz/frotz.mkpackage/Config.in +1
-0@@ -244,6 +244,7 @@ menu "Games" source "package/doom-wad/Config.in" source "package/flare-engine/Config.in" source "package/flare-game/Config.in" + source "package/frotz/Config.in" source "package/gnuchess/Config.in" source "package/lbreakout2/Config.in" source "package/ltris/Config.in"package/frotz/Config.in new file +0
-0
package/frotz/Config.in line 7
Quoted 7 lines
package/frotz/Config.in new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_FROTZ + bool "frotz" + select BR2_PACKAGE_NCURSES + help + Frotz is an interpreter for old Infocom adventure games and other Z-code + games. Note that frotz can not be run as root. You must add a normal user + to your buildroot configuration to be able to use it.
This file has some formatting issues. Please run the ./utils/check-package to fix them.
You need to add the upstream URL for this package as part of the help text.
package/frotz/frotz.hash line 2
Quoted 8 lines
package/frotz/frotz.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha512 c3aeb1bca227db7b759be880c1fe14e3d46c79eae3f2891d2472ff1e1b17b2153b2e400d537d54dce68011079e230fe8176ebb7547b2ecbc30e44f2b7423c285 frotz-2.44.tar.bz2
Please add hash value for the license file.
package/frotz/frotz.mk line 1
Quoted 7 lines
package/frotz/frotz.mk new file +1
-0@@ -0,0 +1,32 @@ +##############################################################################
It should be 80 hashes
package/frotz/frotz.mk line 3
Quoted 2 lines
package/frotz/frotz.mk new file +2
-0+# +# Frotz - the Z-code interpreter
Just "frotz" is enough
package/frotz/frotz.mk line 5
Quoted 2 lines
package/frotz/frotz.mk new file +2
-0+# +##############################################################################
Should be 80 hashes.
package/frotz/frotz.mk line 10
Quoted 5 lines
package/frotz/frotz.mk new file +5
-0+ +FROTZ_VERSION = 2.44 +FROTZ_SOURCE = frotz-$(FROTZ_VERSION).tar.bz2 +FROTZ_SITE = https://gitlab.com/DavidGriffith/frotz/-/archive/$(FROTZ_VERSION) +FROTZ_INSTALL_TARGET = YES
Default value. Not needed.
package/frotz/frotz.mk line 16
Quoted 6 lines
package/frotz/frotz.mk new file +6
-0+FROTZ_DEPENDENCIES = ncurses +FROTZ_LICENSE = GPL-2.0+ +FROTZ_LICENSE_FILES = COPYING + +define FROTZ_POST_EXTRACT_FIXUP + (cd $(@D); \
This is not needed.
package/frotz/frotz.mk line 28
Quoted 12 lines
package/frotz/frotz.mk new file +12
-0+ sed -i 's/$ ar rc/ \$$\(AR\) rc/g' $(@D)/Makefile ; \ + sed -i 's/$ ranlib/ \$$\(RANLIB\)/g' $(@D)/Makefile ; \ + sed -i 's/$ strip/ \$$\(STRIP\)/g' $(@D)/Makefile ) +endef +FROTZ_POST_EXTRACT_HOOKS += FROTZ_POST_EXTRACT_FIXUP + +define FROTZ_BUILD_CMDS + $(MAKE) $(TARGET_CONFIGURE_OPTS) PREFIX=/usr CONFIG_DIR=/etc -C $(@D) +endef + +define FROTZ_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/frotz $(TARGET_DIR)/usr/bin
it should be $(INSTALL) -D -m 0755 $(@D)/frotz $(TARGET_DIR)/usr/bin/frotz
package/frotz/frotz.mk line 29
Quoted 1 line
package/frotz/frotz.mk new file +1
-0+ $(INSTALL) -D -m 0644 $(@D)/doc/frotz.6 $(TARGET_DIR)/usr/man/man6
We do not install documentation in buildroot to try and keep the final firmware small.
Quoted 10 lines
package/frotz/frotz.mk new file +3
-1+endef + +$(eval $(generic-package)) --2.17.2
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Please verify that your package at least build for the default configurations by referring to the "How to test your package" in the buildroot user manual.
thanks!
Gilles.
cover Some more games: XorCurses, ASCII-Invaders and Frotz
In reply to Thomas HuthQuoted 15 lines · Thomas Huth
Hi everybody!
This is my first patch contribution to the buildroot project ... I used buildroot for building most of the images for he QEMU advent calendar 2018 (see https://www.qemu-advent-calendar.org/2018/ ). That would not have been possible without buildroot, so thanks a lot for this great build environment!Anyway, I've now gone through the package files that I've written for that project, and I think some of them might maybe be interesting for integrating them into the official buildroot tree, too. Please have a look at the following patches, and let me know what you think. (I also got some more package files on my hard disk, but they need some more polishing, so I would like to get some feedback on these three patches first)
Quoted 4 lines
Thomas Huth (3):
package/xorcurses: new package
package/ascii-invaders: new package
package/frotz: new package
*ping*
Any comments? Are the patches not suitable for buildroot? No problem, just let me know and I'll shut up ;-) ... or is it that just nobody has enough spare time for a review?
Cheers,
Thomas
cover Some more games: XorCurses, ASCII-Invaders and Frotz
Hello,
Quoted 3 lines · On Thu, 7 Mar 2019 12:16:20 +0100 Thomas Huth <[email protected]> wrote:
Any comments? Are the patches not suitable for buildroot? No problem, just let me know and I'll shut up ;-) ... or is it that just nobody has enough spare time for a review?
Gilles Talis did a review of your patches on March 16. When you have some time, could you take into account your comments, and send a v2 of this patch series ?
In the mean time, I'll mark the patches as "Changes Requested" in patchwork (our patch tracking tool).
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com