Skip to contentSkip to conversation

staging: most: core: replace strcpy() by strscpy()

PATCH New Gustavo A. R. Silva 1 participant 1 message Apr 22, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: most: core: replace strcpy() by strscpy()

The strcpy() function is being deprecated. Replace it by the safer strscpy() and fix the following Coverity warning:

"You might overrun the 80-character fixed-size string iface->p->name by copying iface->description without checking the length."

Addresses-Coverity-ID: 1444760 ("Copy into fixed size buffer")

Fixes 131ac62253db ("staging: most: core: use device description as name")
---
 drivers/staging/most/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/core.c +1 -1
index 956daf8c3bd2..f0b834300c6e 100644
@@ -1431,7 +1431,7 @@ int most_register_interface(struct most_interface *iface)
 
 	INIT_LIST_HEAD(&iface->p->channel_list);
 	iface->p->dev_id = id;
-	strcpy(iface->p->name, iface->description);
+	strscpy(iface->p->name, iface->description, sizeof(iface->p->name));
 	iface->dev.init_name = iface->p->name;
 	iface->dev.bus = &mc.bus;
 	iface->dev.parent = &mc.dev;
Signature · 1 line
2.21.0