Skip to contentSkip to conversation

spi: Zap lpc32xx_ssp driver-related code

PATCH New Jagan Teki 4 participants 16 messages Apr 19, 2019 – Apr 29, 2019

Subsystems (2)
lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion
- no response for dm converted patch
- driver-model migration expiry

Cc Vladimir Zapolskiy <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 configs/devkit3250_defconfig |   1 -
 configs/work_92105_defconfig |   1 -
 drivers/spi/Kconfig          |   5 --
 drivers/spi/Makefile         |   1 -
 drivers/spi/lpc32xx_ssp.c    | 134 -----------------------------------
 include/configs/devkit3250.h |   5 --
 include/configs/work_92105.h |   5 --
 scripts/config_whitelist.txt |   1 -
 8 files changed, 153 deletions(-)
 delete mode 100644 drivers/spi/lpc32xx_ssp.c
configs/devkit3250_defconfig +0 -1
index b739f27803..8fc7763c3a 100644
@@ -42,7 +42,6 @@ CONFIG_PHY_ADDR_ENABLE=y
 CONFIG_PHY_ADDR=31
 CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
-CONFIG_LPC32XX_SSP=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_OF_LIBFDT=y
configs/work_92105_defconfig +0 -1
index 105e51a400..61863abeb7 100644
@@ -38,4 +38,3 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_ADDR_ENABLE=y
 CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
-CONFIG_LPC32XX_SSP=y
drivers/spi/Kconfig +0 -5
index fb794adae7..7043b5c0f6 100644
@@ -359,11 +359,6 @@ config KIRKWOOD_SPI
 	  Enable support for SPI on various Marvell SoCs, such as
 	  Kirkwood and Armada 375.
 
-config LPC32XX_SSP
-	bool "LPC32XX SPI Driver"
-	help
-	  Enable support for SPI on LPC32xx
-
 config MPC8XXX_SPI
 	bool "MPC8XXX SPI Driver"
 	help
drivers/spi/Makefile +0 -1
index 8be9a4baa2..25add2812d 100644
@@ -32,7 +32,6 @@ obj-$(CONFIG_FSL_ESPI) += fsl_espi.o
 obj-$(CONFIG_FSL_QSPI) += fsl_qspi.o
 obj-$(CONFIG_ICH_SPI) +=  ich.o
 obj-$(CONFIG_KIRKWOOD_SPI) += kirkwood_spi.o
-obj-$(CONFIG_LPC32XX_SSP) += lpc32xx_ssp.o
 obj-$(CONFIG_MESON_SPIFC) += meson_spifc.o
 obj-$(CONFIG_MPC8XX_SPI) += mpc8xx_spi.o
 obj-$(CONFIG_MPC8XXX_SPI) += mpc8xxx_spi.o
drivers/spi/lpc32xx_ssp.c deleted +0 -134

134 lines not on this page · raw message

include/configs/devkit3250.h +0 -5
index 2f8c655b2c..e1f729a854 100644
@@ -58,11 +58,6 @@
  */
 #define CONFIG_LPC32XX_GPIO
 
-/*
- * SSP/SPI
- */
-#define CONFIG_LPC32XX_SSP_TIMEOUT	100000
-
 /*
  * Ethernet
  */
include/configs/work_92105.h +0 -5
index 67b5e9aa11..9d9a53ef09 100644
@@ -109,11 +109,6 @@
 
 #define CONFIG_LPC32XX_GPIO
 
-/*
- * SSP/SPI/DISPLAY
- */
-
-#define CONFIG_LPC32XX_SSP_TIMEOUT 100000
 /*
  * Environment
  */
scripts/config_whitelist.txt +0 -1
index 5092c3fb4c..e394e03726 100644
@@ -1149,7 +1149,6 @@ CONFIG_LPC32XX_NAND_SLC_WDR_CLKS
 CONFIG_LPC32XX_NAND_SLC_WHOLD
 CONFIG_LPC32XX_NAND_SLC_WSETUP
 CONFIG_LPC32XX_NAND_SLC_WWIDTH
-CONFIG_LPC32XX_SSP_TIMEOUT
 CONFIG_LPC_BASE
 CONFIG_LPC_IO_BASE
 CONFIG_LPUART
Signature · 1 line
2.18.0.321.gffc6fa0e3
#1 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 11 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion
- no response for dm converted patch
- driver-model migration expiry

Quoted 3 lines
Cc Vladimir Zapolskiy <[email protected]>
Cc Albert ARIBAUD <[email protected]>

For all of the "drop" patches you sent, can you please re-work them to instead make the relevant option instead depend on BROKEN for now and we'll drop the code after this next release? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190421/d38cb1c6/attachment.sig>
author
#2 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 14 lines · Tom Rini
Quoted 11 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion
- no response for dm converted patch
- driver-model migration expiry

Quoted 7 lines
Quoted 3 lines
Cc Vladimir Zapolskiy <[email protected]>
Cc Albert ARIBAUD <[email protected]>

For all of the "drop" patches you sent, can you please re-work them to instead make the relevant option instead depend on BROKEN for now and we'll drop the code after this next release? Thanks!

This was my initial plan before indicating the warnings on Makefile in previous releases, do we really need this and prolong the migration plan further?

#3 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 19 lines · Jagan Teki
Quoted 18 lines · Tom Rini
Quoted 14 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion
- no response for dm converted patch
- driver-model migration expiry

Cc Vladimir Zapolskiy <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Quoted 7 lines
Quoted 3 lines

For all of the "drop" patches you sent, can you please re-work them to instead make the relevant option instead depend on BROKEN for now and we'll drop the code after this next release? Thanks!

This was my initial plan before indicating the warnings on Makefile in previous releases, do we really need this and prolong the migration plan further?

We absolutely do because as you can see we're still just now having people see this deadline for the first time because we did a bad job communicating about it.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/0fd9e46d/attachment.sig>
#4 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

In reply to Jagan Teki

Hi Jagan, Tom,

Quoted 8 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Quoted 1 line

- no response for dm converted patch

I believe there was no DM conversion patch for this particular driver, could it happen that I've missed it?

Quoted 2 lines

- driver-model migration expiry

Definitely this is a valid reason.

The good news is that I don't have any strong objection against the deletion of the driver.

Why? Recently Quentin Schulz added drivers/spi/pl022_spi.c, and it provides a support of right the same SPI controller, the new driver satisfies DM policy.

Quentin, you may take a look at drivers/spi/lpc32xx_ssp.c before (or after though) its removal for scavenging any goodies.

From my side I'd like to test the new driver on one of my boards, but unfortunately it may take indefinite time, because it will require some tinkering. Nevertheless, if any LPC32xx specific changes will be required, they'll be added to the new Quentin's driver.

--
Best wishes,
Vladimir

#5 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 7 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 4 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Quoted 8 lines
Quoted 4 lines

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Indeed. Since it was only last month or so that I setup a low-traffic list for maintainers / custodians for important issues like this, and lots of previous series have been super bad about Cc'ing the right people, it's not appropriate to say "no one has spoken up" or similar lack of reply arguments. I know there's been previous postings of "delete this (and all of the other SPI drivers, and all of the other boards and deletion posts too)" type series but no, they've often not gone out to the right people.

Quoted 4 lines
Quoted 1 line

- no response for dm converted patch

I believe there was no DM conversion patch for this particular driver, could it happen that I've missed it?

There was, but all of what I said above about Cc applies too:
https://patchwork.ozlabs.org/patch/910751/

Quoted 12 lines
Quoted 2 lines

- driver-model migration expiry

Definitely this is a valid reason.

The good news is that I don't have any strong objection against the deletion of the driver.

Why? Recently Quentin Schulz added drivers/spi/pl022_spi.c, and it provides a support of right the same SPI controller, the new driver satisfies DM policy.

Quoted 7 lines

Quentin, you may take a look at drivers/spi/lpc32xx_ssp.c before (or after though) its removal for scavenging any goodies.

From my side I'd like to test the new driver on one of my boards, but unfortunately it may take indefinite time, because it will require some tinkering. Nevertheless, if any LPC32xx specific changes will be required, they'll be added to the new Quentin's driver.

In the end, that sounds like an overall improvement to the situation, even if I'm not happy with how we're getting there. Sorry about the frustration (everyone) here.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190422/ab1f9ff0/attachment.sig>
#6 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 13 lines · Tom Rini
Quoted 12 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 8 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

Quoted 6 lines
Quoted 3 lines

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Indeed. Since it was only last month or so that I setup a low-traffic list for maintainers / custodians for important issues like this, [..]

Wait, which list are you talking about? Should I be monitoring anything else than this one?

Regards,
Simon

#7 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 20 lines · Simon Goldschmidt
Quoted 17 lines · Tom Rini
Quoted 15 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 8 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Quoted 5 lines
Quoted 2 lines

Indeed. Since it was only last month or so that I setup a low-traffic list for maintainers / custodians for important issues like this, [..]

Wait, which list are you talking about? Should I be monitoring anything else than this one?

Ah, OK, so a new thing for my own mental checklist (which I ought to write down), there's now u-boot-custodians and u-boot-maintainers AT lists.denx.de, which are low volume custodian / maintainers only lists (they are public) to try and help avoid these "Hey, I maintain a board and just now found out I need to convert things for the next release?!?!?" problems, and similar.

Quoted 3 lines

Regards,
Simon

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190428/4d6521bc/attachment.sig>
#8 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 28 lines · Tom Rini
Quoted 20 lines · Simon Goldschmidt
Quoted 17 lines · Tom Rini
Quoted 15 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 8 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Quoted 5 lines
Quoted 2 lines

Indeed. Since it was only last month or so that I setup a low-traffic list for maintainers / custodians for important issues like this, [..]

Wait, which list are you talking about? Should I be monitoring anything else than this one?

Quoted 6 lines

Ah, OK, so a new thing for my own mental checklist (which I ought to write down), there's now u-boot-custodians and u-boot-maintainers AT lists.denx.de, which are low volume custodian / maintainers only lists (they are public) to try and help avoid these "Hey, I maintain a board and just now found out I need to convert things for the next release?!?!?" problems, and similar.

Right, I remember reading about the plan to have such lists here, but I failed to find them by searching the docs in git or searching the web.

And if I fail to find them, it could be me, but just maybe I'm not the only maintainer not finding them ;-)

Regards,
Simon

#9 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 36 lines · Simon Goldschmidt
Quoted 28 lines · Tom Rini
Quoted 20 lines · Simon Goldschmidt
Quoted 17 lines · Tom Rini
Quoted 15 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 8 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Quoted 5 lines
Quoted 2 lines

Indeed. Since it was only last month or so that I setup a low-traffic list for maintainers / custodians for important issues like this, [..]

Wait, which list are you talking about? Should I be monitoring anything else than this one?

Quoted 6 lines

Ah, OK, so a new thing for my own mental checklist (which I ought to write down), there's now u-boot-custodians and u-boot-maintainers AT lists.denx.de, which are low volume custodian / maintainers only lists (they are public) to try and help avoid these "Hey, I maintain a board and just now found out I need to convert things for the next release?!?!?" problems, and similar.

Quoted 5 lines

Right, I remember reading about the plan to have such lists here, but I failed to find them by searching the docs in git or searching the web.

And if I fail to find them, it could be me, but just maybe I'm not the only maintainer not finding them ;-)

I emailed everyone that's listed in MAINTAINERS when the lists opened. I think this in part means there may be a board entry or two missing your email? :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190429/630ffd66/attachment.sig>
#10 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Am 29.04.2019 um 19:57 schrieb Tom Rini:

Quoted 40 lines · Simon Goldschmidt
Quoted 39 lines · Tom Rini
Quoted 28 lines · Simon Goldschmidt
Quoted 20 lines · Tom Rini
Quoted 17 lines · Vladimir Zapolskiy
Quoted 15 lines

Hi Jagan, Tom,

Quoted 8 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Quoted 5 lines
Quoted 2 lines

Indeed. Since it was only last month or so that I setup a low-traffic list for maintainers / custodians for important issues like this, [..]

Wait, which list are you talking about? Should I be monitoring anything else than this one?

Quoted 6 lines

Ah, OK, so a new thing for my own mental checklist (which I ought to write down), there's now u-boot-custodians and u-boot-maintainers AT lists.denx.de, which are low volume custodian / maintainers only lists (they are public) to try and help avoid these "Hey, I maintain a board and just now found out I need to convert things for the next release?!?!?" problems, and similar.

Right, I remember reading about the plan to have such lists here, but I failed to find them by searching the docs in git or searching the web.

Quoted 6 lines
Quoted 2 lines

And if I fail to find them, it could be me, but just maybe I'm not the only maintainer not finding them ;-)

I emailed everyone that's listed in MAINTAINERS when the lists opened. I think this in part means there may be a board entry or two missing your email? :)

No, I'm not a maintainer of officially supported boards. Unfortunately, we're having non-mainlined private boards only. And my entry as socfpga maintainer/co-custodioan has just been aded now ;-)

However, given the many companies out there using embedded Linux nowadays, I expect many such boards exist. Any while I understand we don't want to go into too much trouble of supporting such boards, I do think maintainers of such boards should be made aware of that list, too.

I guess we could note it in the toplevel README file, but finding it on denx.de would certainly help, too.

Regards,
Simon

author
#11 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

In reply to Vladimir Zapolskiy
Quoted 8 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 4 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Quoted 8 lines
Quoted 4 lines

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Here is the number iterations around the ML, this indeed a notification for dm-conversion.
[1] [2][4][5]

Quoted 5 lines
Quoted 2 lines

- no response for dm converted patch

I believe there was no DM conversion patch for this particular driver, could it happen that I've missed it?

[3]

[1] https://patchwork.ozlabs.org/patch/1002858/
[2] https://patchwork.ozlabs.org/patch/1000463/
[3] https://patchwork.ozlabs.org/patch/910751/
[4] https://gitlab.incom.co/CM-Shield/u-boot/commit/c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8?view=parallel
[5] https://lists.denx.de/pipermail/u-boot/2018-March/322135.html

#12 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 28 lines · Jagan Teki
Quoted 8 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 4 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Quoted 8 lines
Quoted 4 lines

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Here is the number iterations around the ML, this indeed a notification for dm-conversion.
[1] [2][4][5]

Quoted 5 lines
Quoted 2 lines

- no response for dm converted patch

I believe there was no DM conversion patch for this particular driver, could it happen that I've missed it?

Quoted 7 lines

[3]

[1] https://patchwork.ozlabs.org/patch/1002858/
[2] https://patchwork.ozlabs.org/patch/1000463/
[3] https://patchwork.ozlabs.org/patch/910751/
[4] https://gitlab.incom.co/CM-Shield/u-boot/commit/c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8?view=parallel
[5] https://lists.denx.de/pipermail/u-boot/2018-March/322135.html

And to be clear and repeat myself, in all of the above cases while it did go to the ML it did not to/cc nearly enough (or in some cases I seem to recall, any) people directly responsible for the platforms in question. I should have caught that and spoken up more at the time, sorry.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/a2ec02c9/attachment.sig>
author
#13 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 38 lines · Tom Rini
Quoted 28 lines · Jagan Teki
Quoted 8 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 4 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Quoted 8 lines
Quoted 4 lines

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Here is the number iterations around the ML, this indeed a notification for dm-conversion.
[1] [2][4][5]

Quoted 5 lines
Quoted 2 lines

- no response for dm converted patch

I believe there was no DM conversion patch for this particular driver, could it happen that I've missed it?

Quoted 7 lines

[3]

[1] https://patchwork.ozlabs.org/patch/1002858/
[2] https://patchwork.ozlabs.org/patch/1000463/
[3] https://patchwork.ozlabs.org/patch/910751/
[4] https://gitlab.incom.co/CM-Shield/u-boot/commit/c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8?view=parallel
[5] https://lists.denx.de/pipermail/u-boot/2018-March/322135.html

Quoted 5 lines

And to be clear and repeat myself, in all of the above cases while it did go to the ML it did not to/cc nearly enough (or in some cases I seem to recall, any) people directly responsible for the platforms in question. I should have caught that and spoken up more at the time, sorry.

Yes, with few driver patches but I mange to add individual board vendor who effected that driver, but indeed it's very critical job to include all since many drivers has lot of care takers. and I wouldn't agree this point is the fact that this kind of Zap patch is 4 or 5th version not the first time that people would have surprised.

Jagan.

#14 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 45 lines · Jagan Teki
Quoted 38 lines · Tom Rini
Quoted 28 lines · Jagan Teki
Quoted 8 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 4 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Quoted 8 lines
Quoted 4 lines

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Here is the number iterations around the ML, this indeed a notification for dm-conversion.
[1] [2][4][5]

Quoted 5 lines
Quoted 2 lines

- no response for dm converted patch

I believe there was no DM conversion patch for this particular driver, could it happen that I've missed it?

Quoted 7 lines

[3]

[1] https://patchwork.ozlabs.org/patch/1002858/
[2] https://patchwork.ozlabs.org/patch/1000463/
[3] https://patchwork.ozlabs.org/patch/910751/
[4] https://gitlab.incom.co/CM-Shield/u-boot/commit/c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8?view=parallel
[5] https://lists.denx.de/pipermail/u-boot/2018-March/322135.html

Quoted 5 lines

And to be clear and repeat myself, in all of the above cases while it did go to the ML it did not to/cc nearly enough (or in some cases I seem to recall, any) people directly responsible for the platforms in question. I should have caught that and spoken up more at the time, sorry.

Quoted 5 lines

Yes, with few driver patches but I mange to add individual board vendor who effected that driver, but indeed it's very critical job to include all since many drivers has lot of care takers. and I wouldn't agree this point is the fact that this kind of Zap patch is 4 or 5th version not the first time that people would have surprised.

The problem is that Vladimir is one of the people that should have seen any of the previous instances, but didn't, and I'm sure this isn't the only instance. So removal of unconverted drivers needs to be slow.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190425/db72f580/attachment.sig>
author
#15 lore raw

PATCH 1/1 spi: Zap lpc32xx_ssp driver-related code

Quoted 53 lines · Tom Rini
Quoted 45 lines · Jagan Teki
Quoted 38 lines · Tom Rini
Quoted 28 lines · Jagan Teki
Quoted 8 lines · Vladimir Zapolskiy

Hi Jagan, Tom,

Quoted 4 lines · Jagan Teki

Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items

Quoted 8 lines
Quoted 4 lines

Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.

Here is the number iterations around the ML, this indeed a notification for dm-conversion.
[1] [2][4][5]

Quoted 5 lines
Quoted 2 lines

- no response for dm converted patch

I believe there was no DM conversion patch for this particular driver, could it happen that I've missed it?

Quoted 7 lines

[3]

[1] https://patchwork.ozlabs.org/patch/1002858/
[2] https://patchwork.ozlabs.org/patch/1000463/
[3] https://patchwork.ozlabs.org/patch/910751/
[4] https://gitlab.incom.co/CM-Shield/u-boot/commit/c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8?view=parallel
[5] https://lists.denx.de/pipermail/u-boot/2018-March/322135.html

Quoted 5 lines

And to be clear and repeat myself, in all of the above cases while it did go to the ML it did not to/cc nearly enough (or in some cases I seem to recall, any) people directly responsible for the platforms in question. I should have caught that and spoken up more at the time, sorry.

Quoted 5 lines

Yes, with few driver patches but I mange to add individual board vendor who effected that driver, but indeed it's very critical job to include all since many drivers has lot of care takers. and I wouldn't agree this point is the fact that this kind of Zap patch is 4 or 5th version not the first time that people would have surprised.

Quoted 3 lines

The problem is that Vladimir is one of the people that should have seen any of the previous instances, but didn't, and I'm sure this isn't the only instance. So removal of unconverted drivers needs to be slow.

Okay, here is my next plan. will move all these zap driver configs to BROKEN and give a warning during build that it would remove in next version if dm conversion not done. my idea is to make build failure with broken configs enablement, but that indeed trigger travis failure.