webkitgtk: fix compile error for arm64
PATCH 1/1 webkitgtk: fix compile error for arm64
From: Kai Kang <[email protected]>
It removes function JSC::AssemblerBuffer::data() for ARM64 in commit
https://trac.webkit.org/changeset/236589/webkit. But it is required by Cortex A53 from https://trac.webkit.org/changeset/175514/webkit and fails to compile for arm64:
| .../tmp/work/aarch64-poky-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100: error: 'class JSC::AssemblerBuffer' has no member named 'data'
| if (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data()) + m_buffer.codeSize() - sizeof(int32_t)) & 0x0a000000) == 0x08000000))
Not set WTF_CPU_ARM64_CORTEXA53 for arm64 to fix the failure.
--- meta/recipes-sato/webkit/webkitgtk_2.24.0.bb | 2 -- 1 file changed, 2 deletions(-)
meta/recipes-sato/webkit/webkitgtk_2.24.0.bb +0 -2
@@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF " EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF " EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF " -EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON" - # JIT not supported on MIPS either EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "
Signature · 1 line
2.20.0
Quoted 11 lines · On 2019/4/23 下午6:12, [email protected] wrote:
From: Kai Kang <[email protected]>
It removes function
JSC::AssemblerBuffer::data()for ARM64 in commit
https://trac.webkit.org/changeset/236589/webkit. But it is required by Cortex A53 from https://trac.webkit.org/changeset/175514/webkit and fails to compile for arm64:|
.../tmp/work/aarch64-poky-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100: error: 'classJSC::AssemblerBuffer' has no member named 'data'
| if (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data()) +m_buffer.codeSize()-sizeof(int32_t)) &0x0a000000) ==0x08000000))Not set
WTF_CPU_ARM64_CORTEXA53for arm64 to fix the failure.
Any comment please? It still fails even apply the patch to update to 2.24.1 for qemuarm64.
Regards,
Kai
Quoted 19 lines
Signed-off-by Kai Kang <[email protected]>--- meta/recipes-sato/webkit/webkitgtk_2.24.0.bb | 2 -- 1 file changed, 2 deletions(-)meta/recipes-sato/webkit/webkitgtk_2.24.0.bb +0
-2@@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF " EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF " EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF " -EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON" - # JIT not supported on MIPS either EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "
Signature · 1 line
Kai Kang