kvm_main: fix some comments
PATCH v2 1/1 kvm_main: fix some comments
is_dirty has been renamed to flush, but the comment for it is outdated. And the description about @flush parameter for kvm_clear_dirty_log_protect() is missing, add it in this patch as well.
Signed-off-by Jiang Biao <[email protected]>
--- virt/kvm/kvm_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
virt/kvm/kvm_main.c +3 -2
@@ -1134,11 +1134,11 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log);#ifdef CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT /** -* kvm_get_dirty_log_protect - get a snapshot of dirty pages, and if any pages +* kvm_get_dirty_log_protect - get a snapshot of dirty pages * and reenable dirty page tracking for the corresponding pages. * @kvm: pointer to kvm instance * @log: slot id and address to which we copy the log -* @is_dirty: flag set if any page is dirty +* @flush: true if TLB flush is needed by caller * * We need to keep it in mind that VCPU threads can write to the bitmap * concurrently. So, to avoid losing track of dirty pages we keep the
@@ -1223,6 +1223,7 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log_protect);* and reenable dirty page tracking for the corresponding pages. * @kvm: pointer to kvm instance * @log: slot id and address from which to fetch the bitmap of dirty pages +* @flush: true if TLB flush is needed by caller */ int kvm_clear_dirty_log_protect (struct kvm *kvm,struct kvm_clear_dirty_log *log,bool *flush)
Signature · 1 line
2.17.2 (Apple Git-113)
Quoted 9 lines · On Tue, 23 Apr 2019 19:40:30 +0800 Jiang Biao <[email protected]> wrote:
is_dirtyhas been renamed to flush, but the comment for it is outdated. And the description about @flush parameter forkvm_clear_dirty_log_protect()is missing, add it in this patch as well.Signed-off-by Jiang Biao <[email protected]>--- virt/kvm/kvm_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by Cornelia Huck <[email protected]>
Quoted 30 lines · Jiang Biao
is_dirtyhas been renamed to flush, but the comment for it is outdated. And the description about @flush parameter forkvm_clear_dirty_log_protect()is missing, add it in this patch as well.Signed-off-by Jiang Biao <[email protected]>--- virt/kvm/kvm_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)virt/kvm/kvm_main.c +2
-2@@ -1134,11 +1134,11 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log);#ifdef CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT /** -* kvm_get_dirty_log_protect - get a snapshot of dirty pages, and if any pages +* kvm_get_dirty_log_protect - get a snapshot of dirty pages * and reenable dirty page tracking for the corresponding pages. * @kvm: pointer to kvm instance * @log: slot id and address to which we copy the log -* @is_dirty: flag set if any page is dirty +* @flush: true if TLB flush is needed by caller * * We need to keep it in mind that VCPU threads can write to the bitmap * concurrently. So, to avoid losing track of dirty pages we keep the
virt/kvm/kvm_main.c EXPORT_SYMBOL_GPL(kvm_get_dirty_log_protect); · line 1229
Quoted 7 lines
virt/kvm/kvm_main.c +1
-0@@ -1223,6 +1223,7 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log_protect);* and reenable dirty page tracking for the corresponding pages. * @kvm: pointer to kvm instance * @log: slot id and address from which to fetch the bitmap of dirty pages +* @flush: true if TLB flush is needed by caller */ int kvm_clear_dirty_log_protect (struct kvm *kvm,struct kvm_clear_dirty_log *log,bool *flush)
Queued, thanks.
Paolo