Skip to contentSkip to conversation

tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete

PATCH In review Jarkko Sakkinen 2 participants 3 messages Apr 23, 2019 – May 2, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete

commit 442601e87a4769a8daba4976ec3afa5222ca211d upstream

Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour.

Fixes a2871c62e186 ("tpm: Add support for Atmel I2C TPMs")

---
backport v4.9.99

 drivers/char/tpm/tpm_i2c_atmel.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/char/tpm/tpm_i2c_atmel.c +9 -1
index 95ce2e9ccdc6..cc4e642d3180 100644
@@ -65,7 +65,15 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len)
 	dev_dbg(&chip->dev,
 		"%s(buf=%*ph len=%0zx) -> sts=%d\n", __func__,
 		(int)min_t(size_t, 64, len), buf, len, status);
-	return status;
+
+	if (status < 0)
+		return status;
+
+	/* The upper layer does not support incomplete sends. */
+	if (status != len)
+		return -E2BIG;
+
+	return 0;
 }
 
 static int i2c_atmel_recv(struct tpm_chip *chip, u8 *buf, size_t count)
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 10 lines · Jarkko Sakkinen

commit 442601e87a4769a8daba4976ec3afa5222ca211d upstream

Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour.

Fixes a2871c62e186 ("tpm: Add support for Atmel I2C TPMs")

Okay, between the upstream version and your backports we have this fix on all branches, thank you!

--
Thanks,
Sasha

#2 lore raw
Quoted 6 lines · Sasha Levin
Quoted 5 lines · Jarkko Sakkinen

commit 442601e87a4769a8daba4976ec3afa5222ca211d upstream

Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour.

Quoted 8 lines
Quoted 5 lines
Fixes a2871c62e186 ("tpm: Add support for Atmel I2C TPMs")

Okay, between the upstream version and your backports we have this fix on all branches, thank you!

Awesome!

/Jarkko