tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete
Subsystems (3)
PATCH 1/1 tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete
commit 442601e87a4769a8daba4976ec3afa5222ca211d upstream
Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour.
---
backport v4.9.99
drivers/char/tpm/tpm_i2c_atmel.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/char/tpm/tpm_i2c_atmel.c +9 -1
@@ -65,7 +65,15 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len)dev_dbg (&chip->dev,"%s(buf=%*ph len=%0zx) -> sts=%d\n" , __func__, (int )min_t (size_t,64 , len), buf, len, status); -return status; + +if (status <0 ) +return status; + +/* The upper layer does not support incomplete sends. */ +if (status != len) +return -E2BIG ; + +return 0 ; }static int i2c_atmel_recv (struct tpm_chip *chip,u8 *buf,size_t count)
Signature · 1 line
2.20.1
Sasha Levin
maintainerQuoted 10 lines · Jarkko Sakkinen
commit
442601e87a4769a8daba4976ec3afa5222ca211dupstreamReturn
-E2BIGwhen the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour.Fixes a2871c62e186 ("tpm: Add support for Atmel I2C TPMs")Signed-off-by Jarkko Sakkinen <[email protected]>Reviewed-by Stefan Berger <[email protected]>Reviewed-by Jerry Snitselaar <[email protected]>
Okay, between the upstream version and your backports we have this fix on all branches, thank you!
--
Thanks,
Sasha
Quoted 6 lines · Sasha Levin
Quoted 5 lines · Jarkko Sakkinen
commit
442601e87a4769a8daba4976ec3afa5222ca211dupstreamReturn
-E2BIGwhen the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour.
Quoted 8 lines
Quoted 5 lines
Fixes a2871c62e186 ("tpm: Add support for Atmel I2C TPMs")Signed-off-by Jarkko Sakkinen <[email protected]>Reviewed-by Stefan Berger <[email protected]>Reviewed-by Jerry Snitselaar <[email protected]>Okay, between the upstream version and your backports we have this fix on all branches, thank you!
Awesome!
/Jarkko