xen/pvh: set xen_domain_type to HVM in xen_pvh_init
Subsystems (3)
PATCH v2 1/2 xen/pvh: set xen_domain_type to HVM in xen_pvh_init
Or else xen_domain() returns false despite xen_pvh being set.
---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: [email protected]
--- arch/x86/xen/enlighten_pvh.c | 1 + 1 file changed, 1 insertion(+)
arch/x86/xen/enlighten_pvh.c +1 -0
@@ -27,6 +27,7 @@ void __init xen_pvh_init(void)u64 pfn; xen_pvh =1 ; + xen_domain_type =XEN_HVM_DOMAIN ; xen_start_flags = pvh_start_info.flags; msr =cpuid_ebx (xen_cpuid_base () +2 );
Signature · 1 line
2.17.2 (Apple Git-113)
PATCH v2 2/2 xen/pvh: correctly setup the PV EFI interface for dom0
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Darren Hart <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Changes since v1:
- Call xen_efi_init from xen_pvh_init, this avoids having to move the prototype of xen_efi_init to a different header.
--- arch/x86/platform/pvh/enlighten.c | 8 ++++---- arch/x86/xen/efi.c | 12 ++++++------ arch/x86/xen/enlighten_pv.c | 2 +- arch/x86/xen/enlighten_pvh.c | 6 +++++- arch/x86/xen/xen-ops.h | 4 ++-- 5 files changed, 18 insertions(+), 14 deletions(-)
arch/x86/platform/pvh/enlighten.c +4 -4
@@ -44,8 +44,6 @@ void __init __weak mem_map_via_hcall(struct boot_params *ptr __maybe_unused)static void __init init_pvh_bootparams (bool xen_guest) { -memset (&pvh_bootparams,0 ,sizeof (pvh_bootparams)); -if ((pvh_start_info.version >0 ) && (pvh_start_info.memmap_entries)) {struct hvm_memmap_table_entry *ep;int i;
@@ -103,7 +101,7 @@ static void __init init_pvh_bootparams(bool xen_guest)* If we are trying to boot a Xen PVH guest, it is expected that the kernel * will have been configured to provide the required override for this routine. */ -void __init __weak xen_pvh_init (void ) +void __init __weak xen_pvh_init (struct boot_params *boot_params) {xen_raw_printk ("Error: Missing xen PVH initialization\n" );BUG ();
@@ -112,7 +110,7 @@ void __init __weak xen_pvh_init(void)static void hypervisor_specific_init (bool xen_guest) {if (xen_guest) -xen_pvh_init (); +xen_pvh_init (&pvh_bootparams); }/*
@@ -131,6 +129,8 @@ void __init xen_prepare_pvh(void)BUG (); } +memset (&pvh_bootparams,0 ,sizeof (pvh_bootparams)); +hypervisor_specific_init (xen_guest);init_pvh_bootparams (xen_guest);
arch/x86/xen/efi.c +6 -6
@@ -158,7 +158,7 @@ static enum efi_secureboot_mode xen_efi_get_secureboot(void)return efi_secureboot_mode_unknown; } -void __init xen_efi_init (void ) +void __init xen_efi_init (struct boot_params *boot_params) {efi_system_table_t *efi_systab_xen;
@@ -167,12 +167,12 @@ void __init xen_efi_init(void)if (efi_systab_xen ==NULL )return ; -strncpy ((char *)&boot_params.efi_info.efi_loader_signature,"Xen" , -sizeof (boot_params.efi_info.efi_loader_signature)); - boot_params.efi_info.efi_systab = (__u32 )__pa (efi_systab_xen); - boot_params.efi_info.efi_systab_hi = (__u32)(__pa (efi_systab_xen) >>32 ); +strncpy ((char *)&boot_params->efi_info.efi_loader_signature,"Xen" , +sizeof (boot_params->efi_info.efi_loader_signature)); + boot_params->efi_info.efi_systab = (__u32 )__pa (efi_systab_xen); + boot_params->efi_info.efi_systab_hi = (__u32)(__pa (efi_systab_xen) >>32 ); - boot_params.secure_boot =xen_efi_get_secureboot (); + boot_params->secure_boot =xen_efi_get_secureboot ();set_bit (EFI_BOOT , &efi.flags);set_bit (EFI_PARAVIRT , &efi.flags);
arch/x86/xen/enlighten_pv.c +1 -1
@@ -1403,7 +1403,7 @@ asmlinkage __visible void __init xen_start_kernel(void)/* We need this for printk timestamps */ xen_setup_runstate_info (0 ); -xen_efi_init (); +xen_efi_init (&boot_params);/* Start the world */ #ifdef CONFIG_X86_32
arch/x86/xen/enlighten_pvh.c +5 -1
@@ -13,6 +13,8 @@#include <xen/interface/memory.h> +#include "xen-ops.h" +/* * PVH variables. *
@@ -21,7 +23,7 @@*/ bool xen_pvh __attribute__((section(".data"))) = 0; -void __init xen_pvh_init (void ) +void __init xen_pvh_init (struct boot_params *boot_params) {u32 msr;u64 pfn;
@@ -33,6 +35,8 @@ void __init xen_pvh_init(void) msr =cpuid_ebx (xen_cpuid_base () +2 ); pfn =__pa (hypercall_page);wrmsr_safe (msr, (u32 )pfn, (u32)(pfn >>32 )); + +xen_efi_init (boot_params); }void __init mem_map_via_hcall (struct boot_params *boot_params_p)
arch/x86/xen/xen-ops.h +2 -2
@@ -122,9 +122,9 @@ static inline void __init xen_init_vga(const struct dom0_vga_console_info *info,void __init xen_init_apic (void );#ifdef CONFIG_XEN_EFI -extern void xen_efi_init (void ); +extern void xen_efi_init (struct boot_params *boot_params);#else -static inline void __init xen_efi_init (void ) +static inline void __init xen_efi_init (struct boot_params *boot_params) { }#endif
Signature · 1 line
2.17.2 (Apple Git-113)
Boris Ostrovsky
reviewerRe: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
Quoted 8 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>
Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Can you try it?
-boris
Re: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
Quoted 7 lines · Boris Ostrovsky
Quoted 6 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Quoted 7 lines
Quoted 2 lines
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Can you try it?
Sure, thanks for the extra testing! I have to admit I haven't tested save/restore with this patch applied, it didn't come to mind it might affect that functionality.
I assume it's save/restore of a PVH domU that's broken (HVM and PV are fine)?
Thanks, Roger.
Boris Ostrovsky
reviewerRe: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
Quoted 13 lines · Roger Pau Monné
Quoted 12 lines · Boris Ostrovsky
Quoted 8 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Quoted 8 lines
Quoted 1 line
Can you try it?
Sure, thanks for the extra testing! I have to admit I haven't tested save/restore with this patch applied, it didn't come to mind it might affect that functionality.
I assume it's save/restore of a PVH domU that's broken (HVM and PV are fine)?
PV is fine, I haven't tried HVM.
-boris
Re: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
Quoted 19 lines · Boris Ostrovsky
Quoted 18 lines · Roger Pau Monné
Quoted 7 lines · Boris Ostrovsky
Quoted 6 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Quoted 6 lines
Quoted 2 lines
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Can you try it?
Sure, thanks for the extra testing! I have to admit I haven't tested save/restore with this patch applied, it didn't come to mind it might affect that functionality.
Quoted 6 lines
Quoted 3 lines
I assume it's save/restore of a PVH domU that's broken (HVM and PV are fine)?
PV is fine, I haven't tried HVM.
I've tested live migration and save/restore of this series on top of 5.1.0-rc5 and seems to work fine for me. On top of which Linux version where you testing, and can you paste the guest config file?
Thanks, Roger.
Re: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
Quoted 20 lines · Roger Pau Monné
Quoted 19 lines · Boris Ostrovsky
Quoted 18 lines · Roger Pau Monné
Quoted 7 lines · Boris Ostrovsky
Quoted 6 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Quoted 6 lines
Quoted 2 lines
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Can you try it?
Sure, thanks for the extra testing! I have to admit I haven't tested save/restore with this patch applied, it didn't come to mind it might affect that functionality.
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
I assume it's save/restore of a PVH domU that's broken (HVM and PV are fine)?
PV is fine, I haven't tried HVM.
I've tested live migration and save/restore of this series on top of 5.1.0-rc5 and seems to work fine for me. On top of which Linux version where you testing, and can you paste the guest config file?
It's not your change.
I was booting with threadirqs boot option and hvc console apparently doesn't like that. It's not 100% reproducible, but I was able to fail save/restore without your patches as well.
I may look at this sometime next week, but in the meantime for both patches
and I will add 4.19+ for stable.
-boris
Re: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
In reply to Roger Pau MonnéQuoted 20 lines · Roger Pau Monné
Quoted 19 lines · Boris Ostrovsky
Quoted 18 lines · Roger Pau Monné
Quoted 7 lines · Boris Ostrovsky
Quoted 6 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Quoted 6 lines
Quoted 2 lines
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Can you try it?
Sure, thanks for the extra testing! I have to admit I haven't tested save/restore with this patch applied, it didn't come to mind it might affect that functionality.
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
I assume it's save/restore of a PVH domU that's broken (HVM and PV are fine)?
PV is fine, I haven't tried HVM.
I've tested live migration and save/restore of this series on top of 5.1.0-rc5 and seems to work fine for me. On top of which Linux version where you testing, and can you paste the guest config file?
It's not your change.
I was booting with threadirqs boot option and hvc console apparently doesn't like that. It's not 100% reproducible, but I was able to fail save/restore without your patches as well.
I may look at this sometime next week, but in the meantime for both patches
and I will add 4.19+ for stable.
-boris
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
In reply to Boris OstrovskyQuoted 19 lines · Boris Ostrovsky
Quoted 18 lines · Roger Pau Monné
Quoted 7 lines · Boris Ostrovsky
Quoted 6 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Quoted 6 lines
Quoted 2 lines
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Can you try it?
Sure, thanks for the extra testing! I have to admit I haven't tested save/restore with this patch applied, it didn't come to mind it might affect that functionality.
Quoted 6 lines
Quoted 3 lines
I assume it's save/restore of a PVH domU that's broken (HVM and PV are fine)?
PV is fine, I haven't tried HVM.
I've tested live migration and save/restore of this series on top of 5.1.0-rc5 and seems to work fine for me. On top of which Linux version where you testing, and can you paste the guest config file?
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Boris Ostrovsky
reviewerRe: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
In reply to Roger Pau MonnéQuoted 13 lines · Roger Pau Monné
Quoted 12 lines · Boris Ostrovsky
Quoted 8 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Quoted 8 lines
Quoted 1 line
Can you try it?
Sure, thanks for the extra testing! I have to admit I haven't tested save/restore with this patch applied, it didn't come to mind it might affect that functionality.
I assume it's save/restore of a PVH domU that's broken (HVM and PV are fine)?
PV is fine, I haven't tried HVM.
-boris
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
In reply to Boris OstrovskyQuoted 7 lines · Boris Ostrovsky
Quoted 6 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Quoted 7 lines
Quoted 2 lines
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Can you try it?
Sure, thanks for the extra testing! I have to admit I haven't tested save/restore with this patch applied, it didn't come to mind it might affect that functionality.
I assume it's save/restore of a PVH domU that's broken (HVM and PV are fine)?
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Boris Ostrovsky
reviewerRe: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0
In reply to Roger Pau MonneQuoted 8 lines · Roger Pau Monne
This involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
Reported-by PGNet Dev <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>
Hmm.. This seems to be breaking save/restore for me (for domU), and I can't see any obvious reasons.
Can you try it?
-boris
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH v2 2/2 xen/pvh: correctly setup the PV EFI interface for dom0
In reply to Roger Pau MonneThis involves initializing the boot params EFI related fields and the efi global variable.
Without this fix a PVH dom0 doesn't detect when booted from EFI, and thus doesn't support accessing any of the EFI related data.
---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Darren Hart <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Changes since v1:
- Call xen_efi_init from xen_pvh_init, this avoids having to move the prototype of xen_efi_init to a different header.
--- arch/x86/platform/pvh/enlighten.c | 8 ++++---- arch/x86/xen/efi.c | 12 ++++++------ arch/x86/xen/enlighten_pv.c | 2 +- arch/x86/xen/enlighten_pvh.c | 6 +++++- arch/x86/xen/xen-ops.h | 4 ++-- 5 files changed, 18 insertions(+), 14 deletions(-)
arch/x86/platform/pvh/enlighten.c +4 -4
@@ -44,8 +44,6 @@ void __init __weak mem_map_via_hcall(struct boot_params *ptr __maybe_unused)static void __init init_pvh_bootparams (bool xen_guest) { -memset (&pvh_bootparams,0 ,sizeof (pvh_bootparams)); -if ((pvh_start_info.version >0 ) && (pvh_start_info.memmap_entries)) {struct hvm_memmap_table_entry *ep;int i;
@@ -103,7 +101,7 @@ static void __init init_pvh_bootparams(bool xen_guest)* If we are trying to boot a Xen PVH guest, it is expected that the kernel * will have been configured to provide the required override for this routine. */ -void __init __weak xen_pvh_init (void ) +void __init __weak xen_pvh_init (struct boot_params *boot_params) {xen_raw_printk ("Error: Missing xen PVH initialization\n" );BUG ();
@@ -112,7 +110,7 @@ void __init __weak xen_pvh_init(void)static void hypervisor_specific_init (bool xen_guest) {if (xen_guest) -xen_pvh_init (); +xen_pvh_init (&pvh_bootparams); }/*
@@ -131,6 +129,8 @@ void __init xen_prepare_pvh(void)BUG (); } +memset (&pvh_bootparams,0 ,sizeof (pvh_bootparams)); +hypervisor_specific_init (xen_guest);init_pvh_bootparams (xen_guest);
arch/x86/xen/efi.c +6 -6
@@ -158,7 +158,7 @@ static enum efi_secureboot_mode xen_efi_get_secureboot(void)return efi_secureboot_mode_unknown; } -void __init xen_efi_init (void ) +void __init xen_efi_init (struct boot_params *boot_params) {efi_system_table_t *efi_systab_xen;
@@ -167,12 +167,12 @@ void __init xen_efi_init(void)if (efi_systab_xen ==NULL )return ; -strncpy ((char *)&boot_params.efi_info.efi_loader_signature,"Xen" , -sizeof (boot_params.efi_info.efi_loader_signature)); - boot_params.efi_info.efi_systab = (__u32 )__pa (efi_systab_xen); - boot_params.efi_info.efi_systab_hi = (__u32)(__pa (efi_systab_xen) >>32 ); +strncpy ((char *)&boot_params->efi_info.efi_loader_signature,"Xen" , +sizeof (boot_params->efi_info.efi_loader_signature)); + boot_params->efi_info.efi_systab = (__u32 )__pa (efi_systab_xen); + boot_params->efi_info.efi_systab_hi = (__u32)(__pa (efi_systab_xen) >>32 ); - boot_params.secure_boot =xen_efi_get_secureboot (); + boot_params->secure_boot =xen_efi_get_secureboot ();set_bit (EFI_BOOT , &efi.flags);set_bit (EFI_PARAVIRT , &efi.flags);
arch/x86/xen/enlighten_pv.c +1 -1
@@ -1403,7 +1403,7 @@ asmlinkage __visible void __init xen_start_kernel(void)/* We need this for printk timestamps */ xen_setup_runstate_info (0 ); -xen_efi_init (); +xen_efi_init (&boot_params);/* Start the world */ #ifdef CONFIG_X86_32
arch/x86/xen/enlighten_pvh.c +5 -1
@@ -13,6 +13,8 @@#include <xen/interface/memory.h> +#include "xen-ops.h" +/* * PVH variables. *
@@ -21,7 +23,7 @@*/ bool xen_pvh __attribute__((section(".data"))) = 0; -void __init xen_pvh_init (void ) +void __init xen_pvh_init (struct boot_params *boot_params) {u32 msr;u64 pfn;
@@ -33,6 +35,8 @@ void __init xen_pvh_init(void) msr =cpuid_ebx (xen_cpuid_base () +2 ); pfn =__pa (hypercall_page);wrmsr_safe (msr, (u32 )pfn, (u32)(pfn >>32 )); + +xen_efi_init (boot_params); }void __init mem_map_via_hcall (struct boot_params *boot_params_p)
arch/x86/xen/xen-ops.h +2 -2
@@ -122,9 +122,9 @@ static inline void __init xen_init_vga(const struct dom0_vga_console_info *info,void __init xen_init_apic (void );#ifdef CONFIG_XEN_EFI -extern void xen_efi_init (void ); +extern void xen_efi_init (struct boot_params *boot_params);#else -static inline void __init xen_efi_init (void ) +static inline void __init xen_efi_init (struct boot_params *boot_params) { }#endif
Signature · 7 lines
2.17.2 (Apple Git-113) _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Boris Ostrovsky
reviewerQuoted 1 line · Roger Pau Monne
Or else
xen_domain()returns false despitexen_pvhbeing set.
Is this new xen_domain() invocation somewhere in EFI initialization that you add in the second patch?
Asking because I am trying to figure out whether this needs to go to stable tree.
-boris
Quoted 15 lines
Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: [email protected]--- arch/x86/xen/enlighten_pvh.c | 1 + 1 file changed, 1 insertion(+)arch/x86/xen/enlighten_pvh.c +0
-0
arch/x86/xen/enlighten_pvh.c void __init xen_pvh_init(void) · line 33
Quoted 7 lines
arch/x86/xen/enlighten_pvh.c +1
-0@@ -27,6 +27,7 @@ void __init xen_pvh_init(void)u64 pfn; xen_pvh =1 ; + xen_domain_type =XEN_HVM_DOMAIN ; xen_start_flags = pvh_start_info.flags; msr =cpuid_ebx (xen_cpuid_base () +2 );
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Boris Ostrovsky
reviewerQuoted 1 line · Roger Pau Monne
Or else
xen_domain()returns false despitexen_pvhbeing set.
Is this new xen_domain() invocation somewhere in EFI initialization that you add in the second patch?
Asking because I am trying to figure out whether this needs to go to stable tree.
-boris
Quoted 22 lines
Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: [email protected]--- arch/x86/xen/enlighten_pvh.c | 1 + 1 file changed, 1 insertion(+)arch/x86/xen/enlighten_pvh.c +1
-0@@ -27,6 +27,7 @@ void __init xen_pvh_init(void)u64 pfn; xen_pvh =1 ; + xen_domain_type =XEN_HVM_DOMAIN ; xen_start_flags = pvh_start_info.flags; msr =cpuid_ebx (xen_cpuid_base () +2 );
Quoted 5 lines · Boris Ostrovsky
Quoted 1 line · Roger Pau Monne
Or else
xen_domain()returns false despitexen_pvhbeing set.Is this new
xen_domain()invocation somewhere in EFI initialization that you add in the second patch?
Yes, there's a xen_initial_domain() call in xen_efi_probe() which would return false without this fix.
Quoted 2 lines
Asking because I am trying to figure out whether this needs to go to stable tree.
I'm not aware of this being an issue without the EFI code that I add in patch 2, xen_domain_type would get set slightly later in the boot process.
I guess both patches should be backported to 4.19 since that's the only LTS release that has PVH dom0 support IIRC, and it would be good to get this fixed.
Thanks, Roger.
Quoted 5 lines · Boris Ostrovsky
Quoted 1 line · Roger Pau Monne
Or else
xen_domain()returns false despitexen_pvhbeing set.Is this new
xen_domain()invocation somewhere in EFI initialization that you add in the second patch?
Yes, there's a xen_initial_domain() call in xen_efi_probe() which would return false without this fix.
Quoted 2 lines
Asking because I am trying to figure out whether this needs to go to stable tree.
I'm not aware of this being an issue without the EFI code that I add in patch 2, xen_domain_type would get set slightly later in the boot process.
I guess both patches should be backported to 4.19 since that's the only LTS release that has PVH dom0 support IIRC, and it would be good to get this fixed.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel