Skip to contentSkip to conversation

package/libglib2: disable compiler warnings

PATCH New Jugurtha BELKALEM 4 participants 5 messages Apr 23, 2019 – May 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libglib2: disable compiler warnings

This flag is not set by default which yields in a compilation error when host-qemu package is enabled. The build fails at libglib2 package because -Werror is activated which stops the compilation process. Adding this flag corrects the issue.

---
 package/libglib2/libglib2.mk | 1 +
 1 file changed, 1 insertion(+)
package/libglib2/libglib2.mk +1 -0
index 63bfec3..5fd0544 100644
@@ -91,6 +91,7 @@ LIBGLIB2_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -marm"
 endif
 
 HOST_LIBGLIB2_CONF_OPTS = \
+	--disable-compile-warnings \
 	--disable-coverage \
 	--disable-dtrace \
 	--disable-fam \
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/libglib2: disable compiler warnings

Hello,

Quoted 5 lines · On Tue, 23 Apr 2019 15:01:05 +0200 Jugurtha BELKALEM…

This flag is not set by default which yields in a compilation error when host-qemu package is enabled. The build fails at libglib2 package because -Werror is activated which stops the compilation process. Adding this flag corrects the issue.

Could you be more specific about the build failure you encounter ? Also, what is the relationship with host-qemu ? host-libglib2 is build as a dependency for tons of things, including libglib2 itself, i.e it is built many times a day in our autobuilders. So what is different in your situation that requires disabling compiler warnings ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libglib2: disable compiler warnings

Hi Thomas,

I'm currently integrating the Qemu test from toolchain builder (
https://github.com/bootlin/toolchains-builder/blob/master/build.sh) into buildroot to check the consistency of the build and get some ensurance that Qemu build process went successful for the various Qemu architectures. This why I have enabled host-qemu. When compiling without using "--disable-compile-warnings"; I got this message :

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

host-libglib2 2.56.4 Patching libtool
host-libglib2 2.56.4 Building

Failed build last output

  CC       libgio_2_0_la-glistmodel.lo
  CC       libgio_2_0_la-gliststore.lo
  CC       libgio_2_0_la-gapplication.lo

....
....
....
cc1: some warnings being treated as errors
Makefile:3927: recipe for target 'libgio_2_0_la-gunixconnection.lo' failed

A complete log errors is available here :
https://gitlab.com/jugurthaB/buildroot/-/jobs/200780681.

After disabling the warnings; most architectures passes the test with success as shown at :
https://gitlab.com/jugurthaB/buildroot/pipelines/57964815

Thank's.

Quoted 17 lines · Thomas Petazzoni

Hello,

Quoted 5 lines · On Tue, 23 Apr 2019 15:01:05 +0200 Jugurtha BELKALEM…

This flag is not set by default which yields in a compilation error when host-qemu package is enabled. The build fails at libglib2 package because -Werror is activated which stops the compilation process. Adding this flag corrects the issue.

Could you be more specific about the build failure you encounter ? Also, what is the relationship with host-qemu ? host-libglib2 is build as a dependency for tons of things, including libglib2 itself, i.e it is built many times a day in our autobuilders. So what is different in your situation that requires disabling compiler warnings ?

Quoted 9 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190423/03eab468/attachment.html>

#3 lore raw

PATCH 1/1 package/libglib2: disable compiler warnings

Hi Jugurtha, Thomas,

Quoted 12 lines · Jugurtha BELKALEM

Hi Thomas,

I'm currently integrating the Qemu test from toolchain builder (
https://github.com/bootlin/toolchains-builder/blob/master/build.sh) into buildroot to check the consistency of the build and get some ensurance that Qemu build process went successful for the various Qemu architectures. This why I have enabled host-qemu. When compiling without using "--disable-compile-warnings"; I got this message :

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

host-libglib2 2.56.4 Patching libtool
host-libglib2 2.56.4 Building

Failed build last output

Quoted 8 lines
  CC       libgio_2_0_la-glistmodel.lo
  CC       libgio_2_0_la-gliststore.lo
  CC       libgio_2_0_la-gapplication.lo

....
....
....
cc1: some warnings being treated as errors
Makefile:3927: recipe for target 'libgio_2_0_la-gunixconnection.lo' failed

This is very similar error which was related to gettext-tiny libintl.h header but issue was fixed already (may be about 1 month ago). Could you please share the defconfig ?

Quoted 5 lines

A complete log errors is available here :
https://gitlab.com/jugurthaB/buildroot/-/jobs/200780681.

Quoted 29 lines

After disabling the warnings; most architectures passes the test with success as shown at :
https://gitlab.com/jugurthaB/buildroot/pipelines/57964815

Thank's.

Quoted 20 lines · Thomas Petazzoni

Hello,

Quoted 5 lines · On Tue, 23 Apr 2019 15:01:05 +0200 Jugurtha BELKALEM…

This flag is not set by default which yields in a compilation error when host-qemu package is enabled. The build fails at libglib2 package because -Werror is activated which stops the compilation process. Adding this flag corrects the issue.

Could you be more specific about the build failure you encounter ? Also, what is the relationship with host-qemu ? host-libglib2 is build as a dependency for tons of things, including libglib2 itself, i.e it is built many times a day in our autobuilders. So what is different in your situation that requires disabling compiler warnings ?

Thanks,

Thomas

[SNIP]

Regards,
Vadim Kochan

#4 lore raw

PATCH 1/1 package/libglib2: disable compiler warnings

Hi Jugurtha,

Quoted 24 lines · Vadym Kochan

Hi Jugurtha, Thomas,

Quoted 12 lines · Jugurtha BELKALEM

Hi Thomas,

I'm currently integrating the Qemu test from toolchain builder (
https://github.com/bootlin/toolchains-builder/blob/master/build.sh) into buildroot to check the consistency of the build and get some ensurance that Qemu build process went successful for the various Qemu architectures. This why I have enabled host-qemu. When compiling without using "--disable-compile-warnings"; I got this message :

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

host-libglib2 2.56.4 Patching libtool
host-libglib2 2.56.4 Building

Failed build last output

Quoted 8 lines
  CC       libgio_2_0_la-glistmodel.lo
  CC       libgio_2_0_la-gliststore.lo
  CC       libgio_2_0_la-gapplication.lo

....
....
....
cc1: some warnings being treated as errors
Makefile:3927: recipe for target 'libgio_2_0_la-gunixconnection.lo' failed

Quoted 3 lines

This is very similar error which was related to gettext-tiny libintl.h header but issue was fixed already (may be about 1 month ago). Could you please share the defconfig ?

Since you didn't come back to this issue, I assumed it was resolved in the end
in some other way, so I've marked the patch as Rejected in patchwork.

If it still is relevant, please repost it with an updated explanation.

Regards,
Arnout