Skip to contentSkip to conversation

crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA

PATCH Superseded Vitaly Chikunov 3 participants 3 messages Apr 23, 2019 – Apr 25, 2019 Crypto API

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA

Fix undefined symbol issue in ecrdsa_generic module when ASN1 or OID_REGISTRY aren't enabled in the config by selecting these options for CRYPTO_ECRDSA.

ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!

---
 crypto/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
Kconfig +2 -0
index 4446833f6eca..3d056e7da65f 100644
@@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
 	select CRYPTO_ECC
 	select CRYPTO_AKCIPHER
 	select CRYPTO_STREEBOG
+	select OID_REGISTRY
+	select ASN1
 	help
 	  Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
 	  RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Vitaly Chikunov

Fix undefined symbol issue in ecrdsa_generic module when ASN1 or OID_REGISTRY aren't enabled in the config by selecting these options for CRYPTO_ECRDSA.

ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!

Thanks.

My tools would prefer to see the diff at one tree level higher:

crypto/Kconfig

Quoted 5 lines
---
 crypto/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
crypto/Kconfig +0 -0
  diff --git a/crypto/Kconfig b/crypto/Kconfig

for any spelling of a and b.

Kconfig

Quoted 3 lines

index 4446833f6eca..3d056e7da65f 100644

Kconfig +0 -0

--- a/crypto/Kconfig
+++ b/crypto/Kconfig

Quoted 10 lines
Kconfig +2 -0
@@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
 	select CRYPTO_ECC
 	select CRYPTO_AKCIPHER
 	select CRYPTO_STREEBOG
+	select OID_REGISTRY
+	select ASN1
 	help
 	  Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
 	  RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
Signature · 1 line
~Randy
maintainer
#2 lore raw
In reply to Vitaly Chikunov
Quoted 7 lines · Vitaly Chikunov

Fix undefined symbol issue in ecrdsa_generic module when ASN1 or OID_REGISTRY aren't enabled in the config by selecting these options for CRYPTO_ECRDSA.

ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!

Quoted 6 lines
---
 crypto/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt