two small nommu cleanups
Subsystems (3)
Hi all,
these two patches avoid writing some boilerplate code for the upcoming RISC-V nommu support, and might also help to clean up existing nommu support in other architectures down the road.
PATCH 1/2 mm: provide a print_vma_addr stub for !CONFIG_MMU
--- include/linux/mm.h | 6 ++++++ 1 file changed, 6 insertions(+)
include/linux/mm.h +6 -0
@@ -2676,7 +2676,13 @@ extern int randomize_va_space;#endif const char *arch_vma_name (struct vm_area_struct *vma); +#ifdef CONFIG_MMU void print_vma_addr (char *prefix,unsigned long rip); +#else +static inline void print_vma_addr (char *prefix,unsigned long rip) +{ +} +#endif void *sparse_buffer_alloc (unsigned long size); struct page *sparse_mem_map_populate(unsigned long pnum, int nid,
Signature · 1 line
2.20.1
PATCH 2/2 mm: stub out all of swapops.h for !CONFIG_MMU
In reply to Christoph HellwigThe whole header file deals with swap entries and PTEs, none of which can exist for nommu builds.
--- include/linux/swapops.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
include/linux/swapops.h +3 -2
@@ -6,6 +6,8 @@#include <linux/bug.h> #include <linux/mm_types.h> +#ifdef CONFIG_MMU +/* * swapcache pages are stored in the swapper_space radix tree. We want to * get good packing density in that tree, so the index should be dense in
@@ -50,13 +52,11 @@ static inline pgoff_t swp_offset(swp_entry_t entry)return entry.val &SWP_OFFSET_MASK ; } -#ifdef CONFIG_MMU /* check whether a pte points to a swap entry */ static inline int is_swap_pte (pte_t pte) {return !pte_none (pte) && !pte_present (pte); } -#endif /* * Convert the arch-dependent pte representation of a swp_entry_t into an
@@ -375,4 +375,5 @@ static inline int non_swap_entry(swp_entry_t entry) }#endif +#endif /* CONFIG_MMU */ #endif /* _LINUX_SWAPOPS_H */
Signature · 1 line
2.20.1
Any comments? It would be nice to get this in for this merge window to make my life simpler with the RISC-V tree next merge window..
Quoted 5 lines · Christoph Hellwig
Hi all,
these two patches avoid writing some boilerplate code for the upcoming RISC-V nommu support, and might also help to clean up existing nommu support in other architectures down the road.
---end quoted text---
Quoted 10 lines · Christoph Hellwig
Any comments? It would be nice to get this in for this merge window to make my life simpler with the RISC-V tree next merge window..
Quoted 5 lines · Christoph Hellwig
Hi all,
these two patches avoid writing some boilerplate code for the upcoming RISC-V nommu support, and might also help to clean up existing nommu support in other architectures down the road.
---end quoted text---
I don't actually see any patches, can you point me to something?